All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irqchip: IMX_INTMUX should not default to y, unconditionally
@ 2021-02-08 14:56 Geert Uytterhoeven
  2021-02-15 14:55 ` [tip: irq/core] irqchip/imx: " tip-bot2 for Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-02-08 14:56 UTC (permalink / raw)
  To: Anson Huang, Shawn Guo, Sascha Hauer, Thomas Gleixner, Marc Zyngier
  Cc: Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team,
	linux-kernel, Geert Uytterhoeven

Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of IMX_INTMUX to ARCH_MXC,
and ask the user in case of compile-testing.

Fixes: 66968d7dfc3f5451 ("irqchip: Add COMPILE_TEST support for IMX_INTMUX")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/irqchip/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index b147f22a78f48450..d7d1a0fab2c1aeb8 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -457,7 +457,8 @@ config IMX_IRQSTEER
 	  Support for the i.MX IRQSTEER interrupt multiplexer/remapper.
 
 config IMX_INTMUX
-	def_bool y if ARCH_MXC || COMPILE_TEST
+	bool "i.MX INTMUX support" if COMPILE_TEST
+	default y if ARCH_MXC
 	select IRQ_DOMAIN
 	help
 	  Support for the i.MX INTMUX interrupt multiplexer.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip: irq/core] irqchip/imx: IMX_INTMUX should not default to y, unconditionally
  2021-02-08 14:56 [PATCH] irqchip: IMX_INTMUX should not default to y, unconditionally Geert Uytterhoeven
@ 2021-02-15 14:55 ` tip-bot2 for Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Geert Uytterhoeven @ 2021-02-15 14:55 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Geert Uytterhoeven, Marc Zyngier, x86, linux-kernel

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     a890caeb2ba40ca183969230e204ab144f258357
Gitweb:        https://git.kernel.org/tip/a890caeb2ba40ca183969230e204ab144f258357
Author:        Geert Uytterhoeven <geert+renesas@glider.be>
AuthorDate:    Mon, 08 Feb 2021 15:56:05 +01:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 14 Feb 2021 12:01:16 

irqchip/imx: IMX_INTMUX should not default to y, unconditionally

Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of IMX_INTMUX to ARCH_MXC,
and ask the user in case of compile-testing.

Fixes: 66968d7dfc3f5451 ("irqchip: Add COMPILE_TEST support for IMX_INTMUX")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210208145605.422943-1-geert+renesas@glider.be
---
 drivers/irqchip/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 030895c..da7b3cf 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -452,7 +452,8 @@ config IMX_IRQSTEER
 	  Support for the i.MX IRQSTEER interrupt multiplexer/remapper.
 
 config IMX_INTMUX
-	def_bool y if ARCH_MXC || COMPILE_TEST
+	bool "i.MX INTMUX support" if COMPILE_TEST
+	default y if ARCH_MXC
 	select IRQ_DOMAIN
 	help
 	  Support for the i.MX INTMUX interrupt multiplexer.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-15 15:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 14:56 [PATCH] irqchip: IMX_INTMUX should not default to y, unconditionally Geert Uytterhoeven
2021-02-15 14:55 ` [tip: irq/core] irqchip/imx: " tip-bot2 for Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.