* [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling
@ 2021-02-18 9:38 Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling Kunal Joshi
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Kunal Joshi @ 2021-02-18 9:38 UTC (permalink / raw)
To: igt-dev; +Cc: mukunda.pramodh.kumar, petri.latvala
We communicate with chamelium through xmlrpc which is
uni-directional, if chamelium wants to signal something
it triggers hpd pulses which we detect and then do
DPMS cycle on-off, tests which changes modes such as
dp-frame-dump requires this, but test which runs through out
on a single mode doesn't, so providing an option to toggle.
Kunal Joshi (3):
lib/igt_chamelium: Added toggle for fsm_handling
Enabled FSM handling for kms_cahmelium and disabled it for
kms_color_chamelium
HAX: BAT RUN,
lib/igt_chamelium.c | 4 ++--
lib/igt_chamelium.h | 2 ++
tests/intel-ci/fast-feedback.testlist | 2 ++
tests/kms_chamelium.c | 2 ++
tests/kms_color_chamelium.c | 2 ++
5 files changed, 10 insertions(+), 2 deletions(-)
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
@ 2021-02-18 9:38 ` Kunal Joshi
2021-02-18 13:26 ` Petri Latvala
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 2/3] Enabled FSM handling for kms_cahmelium and disabled it for kms_color_chamelium Kunal Joshi
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Kunal Joshi @ 2021-02-18 9:38 UTC (permalink / raw)
To: igt-dev; +Cc: mukunda.pramodh.kumar, petri.latvala
Added bool fsm_handling
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_chamelium.c | 4 ++--
lib/igt_chamelium.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index 585fdfa8..0f1bfddc 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -327,7 +327,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
* to handle the chamelium attempting FSM, we have to fork into another
* thread and have that handle hotplugging displays
*/
- if (fsm_port) {
+ if (fsm_port && fsm_handling) {
monitor_args.chamelium = chamelium;
monitor_args.port = fsm_port;
monitor_args.mon = igt_watch_uevents();
@@ -355,7 +355,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
/* i2c error, let's try to retry */
}
- if (fsm_port) {
+ if (fsm_port && fsm_handling) {
pthread_cancel(fsm_thread_id);
pthread_join(fsm_thread_id, NULL);
igt_cleanup_uevents(monitor_args.mon);
diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
index 359f4ab3..5177279d 100644
--- a/lib/igt_chamelium.h
+++ b/lib/igt_chamelium.h
@@ -100,6 +100,8 @@ struct chamelium_edid;
*/
#define CHAMELIUM_MAX_AUDIO_CHANNELS 8
+bool fsm_handling;
+
void chamelium_deinit_rpc_only(struct chamelium *chamelium);
struct chamelium *chamelium_init_rpc_only(void);
struct chamelium *chamelium_init(int drm_fd);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] Enabled FSM handling for kms_cahmelium and disabled it for kms_color_chamelium
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling Kunal Joshi
@ 2021-02-18 9:38 ` Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 3/3] HAX: BAT RUN, Kunal Joshi
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Kunal Joshi @ 2021-02-18 9:38 UTC (permalink / raw)
To: igt-dev; +Cc: mukunda.pramodh.kumar, petri.latvala
Enabled in kms_chamelium which include tests such as dp-frame-dump
which requires fsm handling and disabled it for kms_color_chamelium
which operates on single mode through out.
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/kms_chamelium.c | 2 ++
tests/kms_color_chamelium.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index a9101a82..ab4427b7 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -2699,6 +2699,8 @@ igt_main
*/
igt_display_commit2(&data.display, COMMIT_ATOMIC);
+ fsm_handling =true;
+
/* we need to initalize chamelium after igt_display_require */
data.chamelium = chamelium_init(data.drm_fd);
igt_require(data.chamelium);
diff --git a/tests/kms_color_chamelium.c b/tests/kms_color_chamelium.c
index af2bf994..ebe8db81 100644
--- a/tests/kms_color_chamelium.c
+++ b/tests/kms_color_chamelium.c
@@ -734,6 +734,8 @@ igt_main
igt_display_require(&data.display, data.drm_fd);
igt_require(data.display.is_atomic);
+ fsm_handling = false;
+
/* we need to initalize chamelium after igt_display_require */
data.chamelium = chamelium_init(data.drm_fd);
igt_require(data.chamelium);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] HAX: BAT RUN,
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 2/3] Enabled FSM handling for kms_cahmelium and disabled it for kms_color_chamelium Kunal Joshi
@ 2021-02-18 9:38 ` Kunal Joshi
2021-02-18 10:26 ` [igt-dev] ✓ Fi.CI.BAT: success for Added option to toggle fsm handling Patchwork
2021-02-18 12:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Kunal Joshi @ 2021-02-18 9:38 UTC (permalink / raw)
To: igt-dev; +Cc: mukunda.pramodh.kumar, petri.latvala
Just to run for testing purpose
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index eaa904fa..f8ceecdf 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -90,6 +90,8 @@ igt@kms_busy@basic
igt@kms_chamelium@dp-hpd-fast
igt@kms_chamelium@dp-edid-read
igt@kms_chamelium@dp-crc-fast
+igt@kms_chamelium@dp-frame-dump
+igt@kms_color_chamelium@pipe-A-gamma
igt@kms_chamelium@hdmi-hpd-fast
igt@kms_chamelium@hdmi-edid-read
igt@kms_chamelium@hdmi-crc-fast
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Added option to toggle fsm handling
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
` (2 preceding siblings ...)
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 3/3] HAX: BAT RUN, Kunal Joshi
@ 2021-02-18 10:26 ` Patchwork
2021-02-18 12:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-02-18 10:26 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 12098 bytes --]
== Series Details ==
Series: Added option to toggle fsm handling
URL : https://patchwork.freedesktop.org/series/87180/
State : success
== Summary ==
CI Bug Log - changes from IGT_6006 -> IGTPW_5530
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/index.html
Known issues
------------
Here are the changes found in IGTPW_5530 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@amdgpu/amd_basic@cs-gfx.html
* igt@amdgpu/amd_basic@semaphore:
- fi-icl-y: NOTRUN -> [SKIP][2] ([fdo#109315]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-icl-y/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-hsw-4770: NOTRUN -> [WARN][3] ([i915#2283])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@gem_huc_copy@huc-copy.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#3012])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-7500u: [PASS][8] -> [DMESG-WARN][9] ([i915#2605])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-kbl-7500u/igt@i915_pm_rpm@module-reload.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#109289])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +10 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-frame-dump:
- fi-skl-6700k2: NOTRUN -> [SKIP][12] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-skl-6700k2/igt@kms_chamelium@dp-frame-dump.html
- fi-elk-e7500: NOTRUN -> [SKIP][13] ([fdo#109271]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-elk-e7500/igt@kms_chamelium@dp-frame-dump.html
- fi-cml-s: NOTRUN -> [SKIP][14] ([fdo#109284] / [fdo#111827]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-cml-s/igt@kms_chamelium@dp-frame-dump.html
- fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-kbl-soraka/igt@kms_chamelium@dp-frame-dump.html
- fi-ivb-3770: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-ivb-3770/igt@kms_chamelium@dp-frame-dump.html
- fi-tgl-y: NOTRUN -> [SKIP][17] ([fdo#111827]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-tgl-y/igt@kms_chamelium@dp-frame-dump.html
- fi-kbl-guc: NOTRUN -> [SKIP][18] ([fdo#109271] / [fdo#111827]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-kbl-guc/igt@kms_chamelium@dp-frame-dump.html
- fi-bsw-kefka: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-bsw-kefka/igt@kms_chamelium@dp-frame-dump.html
- fi-kbl-r: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-kbl-r/igt@kms_chamelium@dp-frame-dump.html
- fi-bdw-5557u: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-bdw-5557u/igt@kms_chamelium@dp-frame-dump.html
- fi-cfl-8109u: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-cfl-8109u/igt@kms_chamelium@dp-frame-dump.html
- fi-snb-2520m: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-snb-2520m/igt@kms_chamelium@dp-frame-dump.html
- fi-cml-u2: NOTRUN -> [TIMEOUT][24] ([i915#1417])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-cml-u2/igt@kms_chamelium@dp-frame-dump.html
* igt@kms_color_chamelium@pipe-a-gamma:
- fi-snb-2600: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-snb-2600/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-kbl-x1275: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-kbl-x1275/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-glk-dsi: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-glk-dsi/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-cfl-guc: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-cfl-guc/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-tgl-u2: NOTRUN -> [SKIP][29] ([fdo#109284] / [fdo#111827]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-tgl-u2/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-ilk-650: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-ilk-650/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-bsw-n3050: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-bsw-n3050/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-cfl-8700k: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-cfl-8700k/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-skl-6600u: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-skl-6600u/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-pnv-d510: NOTRUN -> [SKIP][34] ([fdo#109271]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-pnv-d510/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-bsw-nick: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-bsw-nick/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-icl-y: NOTRUN -> [SKIP][36] ([fdo#109284] / [fdo#111827]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-icl-y/igt@kms_color_chamelium@pipe-a-gamma.html
- fi-bxt-dsi: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-bxt-dsi/igt@kms_color_chamelium@pipe-a-gamma.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#533])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#1072]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][40] ([i915#2411] / [i915#402]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [INCOMPLETE][42] ([i915#2782] / [i915#926]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/fi-icl-y/igt@i915_selftest@live@hangcheck.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-icl-y/igt@i915_selftest@live@hangcheck.html
* igt@vgem_basic@mmap:
- fi-tgl-y: [DMESG-WARN][44] ([i915#402]) -> [PASS][45] +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/fi-tgl-y/igt@vgem_basic@mmap.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/fi-tgl-y/igt@vgem_basic@mmap.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1417]: https://gitlab.freedesktop.org/drm/intel/issues/1417
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#3004]: https://gitlab.freedesktop.org/drm/intel/issues/3004
[i915#3005]: https://gitlab.freedesktop.org/drm/intel/issues/3005
[i915#3011]: https://gitlab.freedesktop.org/drm/intel/issues/3011
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3013]: https://gitlab.freedesktop.org/drm/intel/issues/3013
[i915#3014]: https://gitlab.freedesktop.org/drm/intel/issues/3014
[i915#3015]: https://gitlab.freedesktop.org/drm/intel/issues/3015
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926
Participating hosts (42 -> 38)
------------------------------
Additional (2): fi-hsw-4770 fi-hsw-gt1
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6006 -> IGTPW_5530
CI-20190529: 20190529
CI_DRM_9783: 498a1b2bfd0ecf4401c2f653a82e9ae2c80c9145 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5530: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/index.html
IGT_6006: 9c10a476edf03a50008f0cee26c1ec1ebcbf9db8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/index.html
[-- Attachment #1.2: Type: text/html, Size: 16380 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Added option to toggle fsm handling
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
` (3 preceding siblings ...)
2021-02-18 10:26 ` [igt-dev] ✓ Fi.CI.BAT: success for Added option to toggle fsm handling Patchwork
@ 2021-02-18 12:19 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-02-18 12:19 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30253 bytes --]
== Series Details ==
Series: Added option to toggle fsm handling
URL : https://patchwork.freedesktop.org/series/87180/
State : success
== Summary ==
CI Bug Log - changes from IGT_6006_full -> IGTPW_5530_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/index.html
Known issues
------------
Here are the changes found in IGTPW_5530_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][1] -> [SKIP][2] ([i915#658])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb2/igt@feature_discovery@psr2.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb6/igt@feature_discovery@psr2.html
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-snb2/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_ctx_persistence@replace-hostile:
- shard-hsw: NOTRUN -> [SKIP][5] ([fdo#109271]) +39 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw7/igt@gem_ctx_persistence@replace-hostile.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-parallel:
- shard-apl: NOTRUN -> [TIMEOUT][12] ([i915#1729])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl1/igt@gem_exec_reloc@basic-parallel.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-kbl: NOTRUN -> [FAIL][13] ([i915#2389]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl4/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@gem_huc_copy@huc-copy.html
* igt@gem_pread@exhaustion:
- shard-kbl: NOTRUN -> [WARN][15] ([i915#2658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl1/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@process-exit-mmap@gtt:
- shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#1699]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl4/igt@gem_userptr_blits@process-exit-mmap@gtt.html
* igt@gem_userptr_blits@process-exit-mmap@wb:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#1699]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl2/igt@gem_userptr_blits@process-exit-mmap@wb.html
* igt@gem_userptr_blits@readonly-mmap-unsync@wb:
- shard-tglb: NOTRUN -> [SKIP][18] ([i915#1704]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@gem_userptr_blits@readonly-mmap-unsync@wb.html
* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([i915#2912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-tglb3/igt@gem_vm_create@destroy-race.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb3/igt@gem_vm_create@destroy-race.html
* igt@gen3_render_linear_blits:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#109289])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb3/igt@gen3_render_linear_blits.html
* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#112306])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb8/igt@gen9_exec_parse@bb-chained.html
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#112306])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb6/igt@gen9_exec_parse@bb-chained.html
* igt@gen9_exec_parse@bb-large:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#2527])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb6/igt@gen9_exec_parse@bb-large.html
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#2527])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb8/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#1937])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#1937])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_query@query-topology-known-pci-ids:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109303])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb6/igt@i915_query@query-topology-known-pci-ids.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#404])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb8/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#404])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb5/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271]) +244 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111614])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb5/igt@kms_big_fb@x-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][33] ([fdo#111615])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html
* igt@kms_big_joiner@basic:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#2705])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@kms_big_joiner@basic.html
* igt@kms_big_joiner@invalid-modeset:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#2705])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl2/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +24 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +22 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-snb2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_color@pipe-b-legacy-gamma-reset:
- shard-apl: [PASS][38] -> [FAIL][39] ([i915#2964])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl6/igt@kms_color@pipe-b-legacy-gamma-reset.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@kms_color@pipe-b-legacy-gamma-reset.html
* igt@kms_color@pipe-c-ctm-0-75:
- shard-tglb: NOTRUN -> [FAIL][40] ([i915#1149] / [i915#315])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb8/igt@kms_color@pipe-c-ctm-0-75.html
- shard-iclb: NOTRUN -> [FAIL][41] ([i915#1149] / [i915#315])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@kms_color@pipe-c-ctm-0-75.html
* igt@kms_color_chamelium@pipe-a-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +7 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb7/igt@kms_color_chamelium@pipe-a-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +20 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl6/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-hsw: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +4 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw7/igt@kms_color_chamelium@pipe-c-gamma.html
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +10 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk8/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-0-5.html
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +9 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@kms_color_chamelium@pipe-d-ctm-max.html
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][48] ([i915#1319]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl7/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][49] ([i915#1319]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl6/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@srm:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271]) +58 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk1/igt@kms_content_protection@srm.html
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111828]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb7/igt@kms_content_protection@srm.html
* igt@kms_content_protection@type1:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109300] / [fdo#111066]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@kms_content_protection@type1.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][53] ([i915#2105])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl2/igt@kms_content_protection@uevent.html
- shard-apl: NOTRUN -> [FAIL][54] ([i915#2105])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl3/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109278] / [fdo#109279])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-256x85-offscreen:
- shard-hsw: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw2/igt@kms_cursor_crc@pipe-d-cursor-256x85-offscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109279]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb7/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109274] / [fdo#109278]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size.html
* igt@kms_flip@2x-flip-vs-fences:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb4/igt@kms_flip@2x-flip-vs-fences.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][60] -> [FAIL][61] ([i915#2598])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [PASS][62] -> [INCOMPLETE][63] ([i915#2055])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-hsw2/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw8/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2672])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-glk: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2672])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][66] ([fdo#109271]) +358 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2672])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109280]) +12 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#111825]) +25 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#1187])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@kms_hdr@static-toggle-dpms.html
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#1187])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl7/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][74] ([fdo#108145] / [i915#265])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][75] ([fdo#108145] / [i915#265]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][76] ([fdo#108145] / [i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk9/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][77] ([i915#265])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
- shard-kbl: NOTRUN -> [FAIL][78] ([i915#265]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-kbl: NOTRUN -> [DMESG-WARN][79] ([i915#165] / [i915#180] / [i915#78])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl2/igt@kms_plane_lowres@pipe-c-tiling-x.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#112054])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@kms_plane_multiple@atomic-pipe-d-tiling-yf.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#2733])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#2920]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109441])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109441])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
- shard-hsw: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#1072])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw7/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_vblank@pipe-d-ts-continuation-modeset-rpm:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109278]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb4/igt@kms_vblank@pipe-d-ts-continuation-modeset-rpm.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#533]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2437]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl1/igt@kms_writeback@writeback-fb-id.html
- shard-kbl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2437]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl6/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#2437])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb7/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-c-source-rg:
- shard-iclb: NOTRUN -> [SKIP][96] ([i915#2530])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb3/igt@nouveau_crc@pipe-c-source-rg.html
- shard-tglb: NOTRUN -> [SKIP][97] ([i915#2530])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb5/igt@nouveau_crc@pipe-c-source-rg.html
* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271]) +191 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl1/igt@prime_nv_pcopy@test2.html
* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109291]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb7/igt@prime_nv_pcopy@test3_1.html
* igt@prime_nv_pcopy@test_semaphore:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109291]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb3/igt@prime_nv_pcopy@test_semaphore.html
* igt@sysfs_clients@sema-10@vcs0:
- shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#3026]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@sysfs_clients@sema-10@vcs0.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][102] ([i915#2842]) -> [PASS][103] +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-tglb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][104] ([i915#2842]) -> [PASS][105] +3 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][106] ([i915#2842]) -> [PASS][107] +4 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-kbl: [DMESG-WARN][108] ([i915#1610] / [i915#2803]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-kbl2/igt@gem_exec_schedule@u-fairslice@rcs0.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl7/igt@gem_exec_schedule@u-fairslice@rcs0.html
- shard-glk: [DMESG-WARN][110] ([i915#1610] / [i915#2803]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk5/igt@gem_exec_schedule@u-fairslice@rcs0.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk3/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-apl: [DMESG-WARN][112] ([i915#1610]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl1/igt@gem_exec_schedule@u-fairslice@vcs0.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@gem_exec_schedule@u-fairslice@vcs0.html
* igt@kms_color@pipe-c-legacy-gamma-reset:
- shard-glk: [FAIL][114] ([i915#2964]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk5/igt@kms_color@pipe-c-legacy-gamma-reset.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk3/igt@kms_color@pipe-c-legacy-gamma-reset.html
- shard-hsw: [FAIL][116] ([i915#2964]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-hsw7/igt@kms_color@pipe-c-legacy-gamma-reset.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-hsw2/igt@kms_color@pipe-c-legacy-gamma-reset.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-glk: [FAIL][118] ([i915#49]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][120] ([fdo#109441]) -> [PASS][121] +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@sysfs_clients@recycle-many:
- shard-iclb: [FAIL][122] ([i915#3028]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb1/igt@sysfs_clients@recycle-many.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@sysfs_clients@recycle-many.html
- shard-tglb: [FAIL][124] ([i915#3028]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-tglb6/igt@sysfs_clients@recycle-many.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-tglb1/igt@sysfs_clients@recycle-many.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][126] ([i915#2681] / [i915#2684]) -> [WARN][127] ([i915#1804] / [i915#2684])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][128] ([i915#658]) -> [SKIP][129] ([i915#2920]) +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][130] ([i915#2920]) -> [SKIP][131] ([i915#658]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][132], [FAIL][133]) ([i915#2295] / [i915#2426] / [i915#3002]) -> [FAIL][134] ([i915#2295] / [i915#3002])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-kbl7/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-kbl2/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-kbl2/igt@runner@aborted.html
- shard-apl: ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138]) ([i915#1610] / [i915#2295] / [i915#2426] / [i915#2722] / [i915#3002]) -> ([FAIL][139], [FAIL][140], [FAIL][141]) ([i915#2295] / [i915#3002])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl1/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl6/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-apl1/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl8/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl6/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/shard-apl7/igt@runner@aborted.html
- shard-glk: ([FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([i915#2295] / [i915#2426] / [i915#3002] / [k.org#202321]) -> ([FAIL][146], [FAIL][147], [FAIL][148]) ([i915#2295] / [i915#3002] / [k.org#202321])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk3/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6006/shard-glk3/igt@runner@aborted.ht
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5530/index.html
[-- Attachment #1.2: Type: text/html, Size: 33746 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling Kunal Joshi
@ 2021-02-18 13:26 ` Petri Latvala
2021-02-18 14:23 ` Petri Latvala
0 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2021-02-18 13:26 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev, mukunda.pramodh.kumar
On Thu, Feb 18, 2021 at 03:08:57PM +0530, Kunal Joshi wrote:
> Added bool fsm_handling
>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> lib/igt_chamelium.c | 4 ++--
> lib/igt_chamelium.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> index 585fdfa8..0f1bfddc 100644
> --- a/lib/igt_chamelium.c
> +++ b/lib/igt_chamelium.c
> @@ -327,7 +327,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
> * to handle the chamelium attempting FSM, we have to fork into another
> * thread and have that handle hotplugging displays
> */
> - if (fsm_port) {
> + if (fsm_port && fsm_handling) {
> monitor_args.chamelium = chamelium;
> monitor_args.port = fsm_port;
> monitor_args.mon = igt_watch_uevents();
> @@ -355,7 +355,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
> /* i2c error, let's try to retry */
> }
>
> - if (fsm_port) {
> + if (fsm_port && fsm_handling) {
> pthread_cancel(fsm_thread_id);
> pthread_join(fsm_thread_id, NULL);
> igt_cleanup_uevents(monitor_args.mon);
> diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
> index 359f4ab3..5177279d 100644
> --- a/lib/igt_chamelium.h
> +++ b/lib/igt_chamelium.h
> @@ -100,6 +100,8 @@ struct chamelium_edid;
> */
> #define CHAMELIUM_MAX_AUDIO_CHANNELS 8
>
> +bool fsm_handling;
You need to make this 'extern' and define it in
lib/igt_chamelium.c. This will fail to build with a gcc that defaults
to -fno-common (version 10 I think?) instead of -fcommon.
--
Petri Latvala
> +
> void chamelium_deinit_rpc_only(struct chamelium *chamelium);
> struct chamelium *chamelium_init_rpc_only(void);
> struct chamelium *chamelium_init(int drm_fd);
> --
> 2.17.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling
2021-02-18 13:26 ` Petri Latvala
@ 2021-02-18 14:23 ` Petri Latvala
0 siblings, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2021-02-18 14:23 UTC (permalink / raw)
To: Kunal Joshi; +Cc: igt-dev, mukunda.pramodh.kumar
On Thu, Feb 18, 2021 at 03:26:57PM +0200, Petri Latvala wrote:
> On Thu, Feb 18, 2021 at 03:08:57PM +0530, Kunal Joshi wrote:
> > Added bool fsm_handling
> >
> > Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> > ---
> > lib/igt_chamelium.c | 4 ++--
> > lib/igt_chamelium.h | 2 ++
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
> > index 585fdfa8..0f1bfddc 100644
> > --- a/lib/igt_chamelium.c
> > +++ b/lib/igt_chamelium.c
> > @@ -327,7 +327,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
> > * to handle the chamelium attempting FSM, we have to fork into another
> > * thread and have that handle hotplugging displays
> > */
> > - if (fsm_port) {
> > + if (fsm_port && fsm_handling) {
> > monitor_args.chamelium = chamelium;
> > monitor_args.port = fsm_port;
> > monitor_args.mon = igt_watch_uevents();
> > @@ -355,7 +355,7 @@ static xmlrpc_value *__chamelium_rpc_va(struct chamelium *chamelium,
> > /* i2c error, let's try to retry */
> > }
> >
> > - if (fsm_port) {
> > + if (fsm_port && fsm_handling) {
> > pthread_cancel(fsm_thread_id);
> > pthread_join(fsm_thread_id, NULL);
> > igt_cleanup_uevents(monitor_args.mon);
> > diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h
> > index 359f4ab3..5177279d 100644
> > --- a/lib/igt_chamelium.h
> > +++ b/lib/igt_chamelium.h
> > @@ -100,6 +100,8 @@ struct chamelium_edid;
> > */
> > #define CHAMELIUM_MAX_AUDIO_CHANNELS 8
> >
> > +bool fsm_handling;
>
> You need to make this 'extern' and define it in
> lib/igt_chamelium.c. This will fail to build with a gcc that defaults
> to -fno-common (version 10 I think?) instead of -fcommon.
Forgot to mention that it needs to be initialized to true if the tests
are not fiddling with it, right?
Oh and that name is also bad for an externally accessible variable in
the library. igt_chamelium_allow_fsm_handling or something maybe?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-02-18 14:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 9:38 [igt-dev] [PATCH i-g-t 0/3] Added option to toggle fsm handling Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_chamelium: Added toggle for fsm_handling Kunal Joshi
2021-02-18 13:26 ` Petri Latvala
2021-02-18 14:23 ` Petri Latvala
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 2/3] Enabled FSM handling for kms_cahmelium and disabled it for kms_color_chamelium Kunal Joshi
2021-02-18 9:38 ` [igt-dev] [PATCH i-g-t 3/3] HAX: BAT RUN, Kunal Joshi
2021-02-18 10:26 ` [igt-dev] ✓ Fi.CI.BAT: success for Added option to toggle fsm handling Patchwork
2021-02-18 12:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.