* [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
@ 2021-01-18 21:19 ` trix
0 siblings, 0 replies; 5+ messages in thread
From: trix @ 2021-01-18 21:19 UTC (permalink / raw)
To: daniel.lezcano, tglx, shawnguo, s.hauer, kernel, festevam,
linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
When DEBUG is defined this error occurs
drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token
The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.
Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
Signed-off-by: Tom Rix <trix@redhat.com>
---
v1: replace pr_info() with pr_debug()
---
drivers/clocksource/mxs_timer.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index bc96a4cbf26c..e52e12d27d2a 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state)
/* Clear pending interrupt */
timrot_irq_acknowledge();
-
-#ifdef DEBUG
- pr_info("%s: changing mode to %s\n", __func__, state)
-#endif /* DEBUG */
+ pr_debug("%s: changing mode to %s\n", __func__, state);
}
static int mxs_shutdown(struct clock_event_device *evt)
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
@ 2021-01-18 21:19 ` trix
0 siblings, 0 replies; 5+ messages in thread
From: trix @ 2021-01-18 21:19 UTC (permalink / raw)
To: daniel.lezcano, tglx, shawnguo, s.hauer, kernel, festevam,
linux-imx, viresh.kumar
Cc: Tom Rix, linux-kernel, linux-arm-kernel
From: Tom Rix <trix@redhat.com>
When DEBUG is defined this error occurs
drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token
The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.
Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
Signed-off-by: Tom Rix <trix@redhat.com>
---
v1: replace pr_info() with pr_debug()
---
drivers/clocksource/mxs_timer.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index bc96a4cbf26c..e52e12d27d2a 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state)
/* Clear pending interrupt */
timrot_irq_acknowledge();
-
-#ifdef DEBUG
- pr_info("%s: changing mode to %s\n", __func__, state)
-#endif /* DEBUG */
+ pr_debug("%s: changing mode to %s\n", __func__, state);
}
static int mxs_shutdown(struct clock_event_device *evt)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
2021-01-18 21:19 ` trix
@ 2021-01-18 21:29 ` Daniel Lezcano
-1 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2021-01-18 21:29 UTC (permalink / raw)
To: trix, tglx, shawnguo, s.hauer, kernel, festevam, linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel
On 18/01/2021 22:19, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/clocksource/mxs_timer.c:138:1: error:
> expected ‘;’ before ‘}’ token
>
> The preceding statement needs a semicolon.
> Replace pr_info() with pr_debug() and remove the unneeded ifdef.
>
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v1: replace pr_info() with pr_debug()
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined
@ 2021-01-18 21:29 ` Daniel Lezcano
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2021-01-18 21:29 UTC (permalink / raw)
To: trix, tglx, shawnguo, s.hauer, kernel, festevam, linux-imx, viresh.kumar
Cc: linux-kernel, linux-arm-kernel
On 18/01/2021 22:19, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/clocksource/mxs_timer.c:138:1: error:
> expected ‘;’ before ‘}’ token
>
> The preceding statement needs a semicolon.
> Replace pr_info() with pr_debug() and remove the unneeded ifdef.
>
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> v1: replace pr_info() with pr_debug()
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: timers/urgent] clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined
2021-01-18 21:19 ` trix
(?)
(?)
@ 2021-02-22 10:04 ` tip-bot2 for Tom Rix
-1 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Tom Rix @ 2021-02-22 10:04 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Tom Rix, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: 7da390694afbaed8e0f05717a541dfaf1077ba51
Gitweb: https://git.kernel.org/tip/7da390694afbaed8e0f05717a541dfaf1077ba51
Author: Tom Rix <trix@redhat.com>
AuthorDate: Mon, 18 Jan 2021 13:19:55 -08:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jan 2021 22:28:59 +01:00
clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined
When DEBUG is defined this error occurs
drivers/clocksource/mxs_timer.c:138:1: error:
expected ‘;’ before ‘}’ token
The preceding statement needs a semicolon.
Replace pr_info() with pr_debug() and remove the unneeded ifdef.
Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210118211955.763609-1-trix@redhat.com
---
drivers/clocksource/mxs_timer.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
index bc96a4c..e52e12d 100644
--- a/drivers/clocksource/mxs_timer.c
+++ b/drivers/clocksource/mxs_timer.c
@@ -131,10 +131,7 @@ static void mxs_irq_clear(char *state)
/* Clear pending interrupt */
timrot_irq_acknowledge();
-
-#ifdef DEBUG
- pr_info("%s: changing mode to %s\n", __func__, state)
-#endif /* DEBUG */
+ pr_debug("%s: changing mode to %s\n", __func__, state);
}
static int mxs_shutdown(struct clock_event_device *evt)
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-22 10:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 21:19 [PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined trix
2021-01-18 21:19 ` trix
2021-01-18 21:29 ` Daniel Lezcano
2021-01-18 21:29 ` Daniel Lezcano
2021-02-22 10:04 ` [tip: timers/urgent] clocksource/drivers/mxs_timer: Add " tip-bot2 for Tom Rix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.