* [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
@ 2020-11-11 1:45 ` Shuhao Mai
0 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2020-11-11 1:45 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Shuhao Mai, linux-mtd, linux-kernel
Add support for w25q512jv. This is of the same series chip with
w25q256jv, which is already supported, but with size doubled and
different JEDEC ID.
Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index e5dfa786f190..beaa6389e2dc 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
};
/**
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
2020-11-11 1:45 ` Shuhao Mai
@ 2021-01-04 8:58 ` Tudor.Ambarus
-1 siblings, 0 replies; 11+ messages in thread
From: Tudor.Ambarus @ 2021-01-04 8:58 UTC (permalink / raw)
To: shuhao.mai.1990, miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel
Hi, Shuhao,
On 11/11/20 3:45 AM, Shuhao Mai wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add support for w25q512jv. This is of the same series chip with
> w25q256jv, which is already supported, but with size doubled and
> different JEDEC ID.
Where and how was this tested? Please add this info in the commit
message.
>
> Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index e5dfa786f190..beaa6389e2dc 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
We should name it "w25q512jvq" in order to differentiate it to the
"M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
The flash supports BP locking and we can enable it if you can test
the locking with mtd-utils. Not mandatory though.
Cheers,
ta
> + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> };
>
> /**
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
@ 2021-01-04 8:58 ` Tudor.Ambarus
0 siblings, 0 replies; 11+ messages in thread
From: Tudor.Ambarus @ 2021-01-04 8:58 UTC (permalink / raw)
To: shuhao.mai.1990, miquel.raynal, richard, vigneshr; +Cc: linux-mtd, linux-kernel
Hi, Shuhao,
On 11/11/20 3:45 AM, Shuhao Mai wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add support for w25q512jv. This is of the same series chip with
> w25q256jv, which is already supported, but with size doubled and
> different JEDEC ID.
Where and how was this tested? Please add this info in the commit
message.
>
> Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index e5dfa786f190..beaa6389e2dc 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
We should name it "w25q512jvq" in order to differentiate it to the
"M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
The flash supports BP locking and we can enable it if you can test
the locking with mtd-utils. Not mandatory though.
Cheers,
ta
> + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> };
>
> /**
> --
> 2.20.1
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
2021-01-04 8:58 ` Tudor.Ambarus
@ 2021-01-07 11:35 ` Shuhao Mai
-1 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2021-01-07 11:35 UTC (permalink / raw)
To: Tudor.Ambarus; +Cc: miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel
On Mon, Jan 04, 2021 at 08:58:26AM +0000, Tudor.Ambarus@microchip.com wrote:
> Hi, Shuhao,
>
> On 11/11/20 3:45 AM, Shuhao Mai wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Add support for w25q512jv. This is of the same series chip with
> > w25q256jv, which is already supported, but with size doubled and
> > different JEDEC ID.
>
> Where and how was this tested? Please add this info in the commit
> message.
>
Will add it in next version.
> >
> > Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index e5dfa786f190..beaa6389e2dc 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
>
> We should name it "w25q512jvq" in order to differentiate it to the
> "M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
>
> The flash supports BP locking and we can enable it if you can test
> the locking with mtd-utils. Not mandatory though.
>
> Cheers,
> ta
I tried flash lock on my test enviorment, but it doesn't work. I think I'll
only update the flash name in next version, and submit a new patch when I
have answer to it.
Best,
Shuhao
> > + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > };
> >
> > /**
> > --
> > 2.20.1
> >
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] mtd: spi-nor: winbond: Add support for w25q512jv
@ 2021-01-07 11:35 ` Shuhao Mai
0 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2021-01-07 11:35 UTC (permalink / raw)
To: Tudor.Ambarus; +Cc: richard, linux-mtd, vigneshr, linux-kernel, miquel.raynal
On Mon, Jan 04, 2021 at 08:58:26AM +0000, Tudor.Ambarus@microchip.com wrote:
> Hi, Shuhao,
>
> On 11/11/20 3:45 AM, Shuhao Mai wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Add support for w25q512jv. This is of the same series chip with
> > w25q256jv, which is already supported, but with size doubled and
> > different JEDEC ID.
>
> Where and how was this tested? Please add this info in the commit
> message.
>
Will add it in next version.
> >
> > Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index e5dfa786f190..beaa6389e2dc 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
> > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > + { "w25q512jv", INFO(0xef4020, 0, 64 * 1024, 1024,
>
> We should name it "w25q512jvq" in order to differentiate it to the
> "M" version: https://www.winbond.com/resource-files/W25Q512JV%20DTR%20RevD%2006292020%20133.pdf
>
> The flash supports BP locking and we can enable it if you can test
> the locking with mtd-utils. Not mandatory though.
>
> Cheers,
> ta
I tried flash lock on my test enviorment, but it doesn't work. I think I'll
only update the flash name in next version, and submit a new patch when I
have answer to it.
Best,
Shuhao
> > + SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> > };
> >
> > /**
> > --
> > 2.20.1
> >
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq
2020-11-11 1:45 ` Shuhao Mai
(?)
(?)
@ 2021-01-07 12:13 ` Shuhao Mai
-1 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2021-01-07 12:13 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: inux-mtd, linux-kernel, Shuhao Mai
Add support for w25q512jvq. This is of the same series chip with
w25q256jv, which is already supported, but with size doubled and
different JEDEC ID.
Tested on Intel whitley platform with dd from/to the flash for
read/write respectly, and flash_erase for erasing the flash.
Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index e5dfa786f190..b1d307fcdf9c 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
};
/**
--
v2:
- Change the name to w25q512jvq
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq
2020-11-11 1:45 ` Shuhao Mai
@ 2021-02-08 7:53 ` Shuhao Mai
-1 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2021-02-08 7:53 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Cc: Shuhao Mai
Add support for w25q512jvq. This is of the same series chip with
w25q256jv, which is already supported, but with size doubled and
different JEDEC ID.
Tested on Intel whitley platform with dd from/to the flash for
read/write respectly, and flash_erase for erasing the flash.
Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index e5dfa786f190..b1d307fcdf9c 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
};
/**
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq
@ 2021-02-08 7:53 ` Shuhao Mai
0 siblings, 0 replies; 11+ messages in thread
From: Shuhao Mai @ 2021-02-08 7:53 UTC (permalink / raw)
To: Tudor Ambarus, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel
Cc: Shuhao Mai
Add support for w25q512jvq. This is of the same series chip with
w25q256jv, which is already supported, but with size doubled and
different JEDEC ID.
Tested on Intel whitley platform with dd from/to the flash for
read/write respectly, and flash_erase for erasing the flash.
Signed-off-by: Shuhao Mai <shuhao.mai.1990@gmail.com>
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index e5dfa786f190..b1d307fcdf9c 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -97,6 +97,8 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
};
/**
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq
2021-02-08 7:53 ` Shuhao Mai
@ 2021-03-08 5:50 ` Tudor Ambarus
-1 siblings, 0 replies; 11+ messages in thread
From: Tudor Ambarus @ 2021-03-08 5:50 UTC (permalink / raw)
To: linux-mtd, Miquel Raynal, linux-kernel, Richard Weinberger,
Vignesh Raghavendra, Shuhao Mai
Cc: Tudor Ambarus
On Mon, 8 Feb 2021 15:53:03 +0800, Shuhao Mai wrote:
> Add support for w25q512jvq. This is of the same series chip with
> w25q256jv, which is already supported, but with size doubled and
> different JEDEC ID.
>
> Tested on Intel whitley platform with dd from/to the flash for
> read/write respectly, and flash_erase for erasing the flash.
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: winbond: Add support for w25q512jvq
https://git.kernel.org/mtd/c/ff013330fbdb
Best regards,
--
Tudor Ambarus <tudor.ambarus@microchip.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] mtd: spi-nor: winbond: Add support for w25q512jvq
@ 2021-03-08 5:50 ` Tudor Ambarus
0 siblings, 0 replies; 11+ messages in thread
From: Tudor Ambarus @ 2021-03-08 5:50 UTC (permalink / raw)
To: linux-mtd, Miquel Raynal, linux-kernel, Richard Weinberger,
Vignesh Raghavendra, Shuhao Mai
Cc: Tudor Ambarus
On Mon, 8 Feb 2021 15:53:03 +0800, Shuhao Mai wrote:
> Add support for w25q512jvq. This is of the same series chip with
> w25q256jv, which is already supported, but with size doubled and
> different JEDEC ID.
>
> Tested on Intel whitley platform with dd from/to the flash for
> read/write respectly, and flash_erase for erasing the flash.
Applied to spi-nor/next, thanks!
[1/1] mtd: spi-nor: winbond: Add support for w25q512jvq
https://git.kernel.org/mtd/c/ff013330fbdb
Best regards,
--
Tudor Ambarus <tudor.ambarus@microchip.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 11+ messages in thread