* [PATCH] xtensa: fix warning comparing pointer to 0
@ 2021-03-10 7:10 Jiapeng Chong
2021-03-10 7:35 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-10 7:10 UTC (permalink / raw)
To: chris; +Cc: jcmvbkbc, linux-xtensa, linux-kernel, Jiapeng Chong
Fix the following coccicheck warning:
./arch/xtensa/kernel/pci.c:79:17-18: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
arch/xtensa/kernel/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/xtensa/kernel/pci.c b/arch/xtensa/kernel/pci.c
index 3f32e27..62c900e 100644
--- a/arch/xtensa/kernel/pci.c
+++ b/arch/xtensa/kernel/pci.c
@@ -76,7 +76,7 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma)
struct pci_controller *pci_ctrl = (struct pci_controller*) pdev->sysdata;
resource_size_t ioaddr = pci_resource_start(pdev, bar);
- if (pci_ctrl == 0)
+ if (!pci_ctrl)
return -EINVAL; /* should never happen */
/* Convert to an offset within this PCI controller */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xtensa: fix warning comparing pointer to 0
2021-03-10 7:10 [PATCH] xtensa: fix warning comparing pointer to 0 Jiapeng Chong
@ 2021-03-10 7:35 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2021-03-10 7:35 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Chris Zankel, open list:TENSILICA XTENSA PORT (xtensa), LKML
On Tue, Mar 9, 2021 at 11:10 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./arch/xtensa/kernel/pci.c:79:17-18: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> arch/xtensa/kernel/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my xtensa tree.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-10 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 7:10 [PATCH] xtensa: fix warning comparing pointer to 0 Jiapeng Chong
2021-03-10 7:35 ` Max Filippov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.