All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/imx/dcss: Use simple encoder
@ 2021-03-10  9:00 Tian Tao
  0 siblings, 0 replies; only message in thread
From: Tian Tao @ 2021-03-10  9:00 UTC (permalink / raw)
  To: airlied, daniel, shawnguo, s.hauer; +Cc: dri-devel

The driver uses empty implementations for its encoders. Replace
the code with the generic simple encoder.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index b549ce5e..5d7d228 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -12,6 +12,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
+#include <drm/drm_simple_kms_helper.h>
 #include <drm/drm_vblank.h>
 
 #include "dcss-dev.h"
@@ -59,10 +60,6 @@ static void dcss_kms_mode_config_init(struct dcss_kms_dev *kms)
 	config->helper_private = &dcss_mode_config_helpers;
 }
 
-static const struct drm_encoder_funcs dcss_kms_simple_encoder_funcs = {
-	.destroy = drm_encoder_cleanup,
-};
-
 static int dcss_kms_bridge_connector_init(struct dcss_kms_dev *kms)
 {
 	struct drm_device *ddev = &kms->base;
@@ -84,9 +81,8 @@ static int dcss_kms_bridge_connector_init(struct dcss_kms_dev *kms)
 
 	encoder->possible_crtcs = drm_crtc_mask(crtc);
 
-	ret = drm_encoder_init(&kms->base, encoder,
-			       &dcss_kms_simple_encoder_funcs,
-			       DRM_MODE_ENCODER_NONE, NULL);
+	ret = drm_simple_encoder_init(&kms->base, encoder,
+				      DRM_MODE_ENCODER_NONE);
 	if (ret) {
 		dev_err(ddev->dev, "Failed initializing encoder %d.\n", ret);
 		return ret;
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-10  8:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10  9:00 [PATCH] drm/imx/dcss: Use simple encoder Tian Tao

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.