All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF
@ 2021-03-12 11:48 Hans de Goede
  2021-03-12 16:24 ` Pierre-Louis Bossart
  2021-03-12 20:23 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2021-03-12 11:48 UTC (permalink / raw)
  To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
	Mark Brown
  Cc: Hans de Goede, alsa-devel

The Asus T100TAF uses the same jack-detect settings as the T100TA,
this has been confirmed on actual hardware.

Add these settings to the T100TAF quirks to enable jack-detect support
on the T100TAF.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 1f6a636571c2..59d6d47c8d82 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -482,6 +482,9 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TAF"),
 		},
 		.driver_data = (void *)(BYT_RT5640_IN1_MAP |
+					BYT_RT5640_JD_SRC_JD2_IN4N |
+					BYT_RT5640_OVCD_TH_2000UA |
+					BYT_RT5640_OVCD_SF_0P75 |
 					BYT_RT5640_MONO_SPEAKER |
 					BYT_RT5640_DIFF_MIC |
 					BYT_RT5640_SSP0_AIF2 |
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF
  2021-03-12 11:48 [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF Hans de Goede
@ 2021-03-12 16:24 ` Pierre-Louis Bossart
  2021-03-12 20:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2021-03-12 16:24 UTC (permalink / raw)
  To: Hans de Goede, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown
  Cc: alsa-devel



On 3/12/21 5:48 AM, Hans de Goede wrote:
> The Asus T100TAF uses the same jack-detect settings as the T100TA,
> this has been confirmed on actual hardware.
> 
> Add these settings to the T100TAF quirks to enable jack-detect support
> on the T100TAF.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 1f6a636571c2..59d6d47c8d82 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -482,6 +482,9 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TAF"),
>   		},
>   		.driver_data = (void *)(BYT_RT5640_IN1_MAP |
> +					BYT_RT5640_JD_SRC_JD2_IN4N |
> +					BYT_RT5640_OVCD_TH_2000UA |
> +					BYT_RT5640_OVCD_SF_0P75 |
>   					BYT_RT5640_MONO_SPEAKER |
>   					BYT_RT5640_DIFF_MIC |
>   					BYT_RT5640_SSP0_AIF2 |
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF
  2021-03-12 11:48 [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF Hans de Goede
  2021-03-12 16:24 ` Pierre-Louis Bossart
@ 2021-03-12 20:23 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-03-12 20:23 UTC (permalink / raw)
  To: Cezary Rojewski, Liam Girdwood, Hans de Goede,
	Pierre-Louis Bossart, Jie Yang
  Cc: alsa-devel

On Fri, 12 Mar 2021 12:48:50 +0100, Hans de Goede wrote:
> The Asus T100TAF uses the same jack-detect settings as the T100TA,
> this has been confirmed on actual hardware.
> 
> Add these settings to the T100TAF quirks to enable jack-detect support
> on the T100TAF.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF
      commit: b7c7203a1f751348f35fc4bcb157572d303f7573

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-12 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 11:48 [PATCH] ASoC: Intel: bytcr_rt5640: Enable jack-detect support on Asus T100TAF Hans de Goede
2021-03-12 16:24 ` Pierre-Louis Bossart
2021-03-12 20:23 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.