All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Viktorin <iviktorin@fit.vutbr.cz>
To: dev@dpdk.org
Cc: Jan Viktorin <viktorin@cesnet.cz>, Asaf Penso <asafp@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Matan Azrad <matan@nvidia.com>
Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode
Date: Mon, 15 Mar 2021 15:33:58 +0000	[thread overview]
Message-ID: <1615822438-10082-2-git-send-email-iviktorin@fit.vutbr.cz> (raw)
In-Reply-To: <1615822438-10082-1-git-send-email-iviktorin@fit.vutbr.cz>

From: Jan Viktorin <viktorin@cesnet.cz>

The step 4 is a contradiction. It advices to unbind the device from the
mlx5_core which removes the associated system network interface (e.g.
eth0). In the step 5, the same system network interface (e.g. eth0) is
required to exist.

Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
---
 doc/guides/nics/mlx5.rst | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 0a2dc3dee..122d8e0fc 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1370,11 +1370,7 @@ the DPDK application.
 
         echo <num of vfs > /sys/class/net/<net device>/device/sriov_numvfs
 
-4. Unbind the device (can be rebind after the switchdev mode)::
-
-        echo -n "<device pci address>" > /sys/bus/pci/drivers/mlx5_core/unbind
-
-5. Enable switchdev mode::
+4. Enable switchdev mode::
 
         echo switchdev > /sys/class/net/<net device>/compat/devlink/mode
 
-- 
2.30.1


  reply	other threads:[~2021-03-15 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 15:33 [dpdk-dev] [PATCH 1/2] net/mlx5: fix typos Jan Viktorin
2021-03-15 15:33 ` Jan Viktorin [this message]
2021-03-15 15:53   ` [dpdk-dev] [PATCH 2/2] net/mlx5: avoid unbind step to enable switchdev mode Slava Ovsiienko
2021-03-15 16:11     ` Jan Viktorin
2021-03-15 19:31       ` Slava Ovsiienko
2021-03-15 19:48         ` Jan Viktorin
2021-03-15 19:52           ` Slava Ovsiienko
2021-03-15 20:30             ` Jan Viktorin
2021-07-15 14:51   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1615822438-10082-2-git-send-email-iviktorin@fit.vutbr.cz \
    --to=iviktorin@fit.vutbr.cz \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=viktorin@cesnet.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.