From: no-reply@patchew.org
To: eblake@redhat.com
Cc: berrange@redhat.com, thuth@redhat.com,
richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] More qemu_strtosz fixes
Date: Wed, 17 Mar 2021 08:15:47 -0700 (PDT) [thread overview]
Message-ID: <161599414593.29996.8944585512631660040@c9d4d6fbb2f1> (raw)
In-Reply-To: <20210317143325.2165821-1-eblake@redhat.com>
Patchew URL: https://patchew.org/QEMU/20210317143325.2165821-1-eblake@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210317143325.2165821-1-eblake@redhat.com
Subject: [PATCH 0/2] More qemu_strtosz fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
5d1428d..25a7751 master -> master
- [tag update] patchew/20210315230838.2973103-1-f4bug@amsat.org -> patchew/20210315230838.2973103-1-f4bug@amsat.org
- [tag update] patchew/20210315233527.2988483-1-philmd@redhat.com -> patchew/20210315233527.2988483-1-philmd@redhat.com
- [tag update] patchew/20210316220735.2048137-1-richard.henderson@linaro.org -> patchew/20210316220735.2048137-1-richard.henderson@linaro.org
* [new tag] patchew/20210317143325.2165821-1-eblake@redhat.com -> patchew/20210317143325.2165821-1-eblake@redhat.com
Switched to a new branch 'test'
36c9a8f utils: Work around mingw strto*l bug with 0x
81af63e utils: Tighter tests for qemu_strtosz
=== OUTPUT BEGIN ===
1/2 Checking commit 81af63e53841 (utils: Tighter tests for qemu_strtosz)
2/2 Checking commit 36c9a8f42010 (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#141: FILE: util/cutils.c:409:
+ if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&
total: 1 errors, 0 warnings, 169 lines checked
Patch 2/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210317143325.2165821-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2021-03-17 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:33 [PATCH 0/2] More qemu_strtosz fixes Eric Blake
2021-03-17 14:33 ` [PATCH 1/2] utils: Tighter tests for qemu_strtosz Eric Blake
2021-03-17 14:59 ` Thomas Huth
2021-03-17 14:33 ` [PATCH 2/2] utils: Work around mingw strto*l bug with 0x Eric Blake
2021-03-18 5:07 ` Thomas Huth
2021-03-17 15:15 ` no-reply [this message]
2021-03-17 15:28 ` [PATCH 0/2] More qemu_strtosz fixes Eric Blake
2021-03-19 17:58 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161599414593.29996.8944585512631660040@c9d4d6fbb2f1 \
--to=no-reply@patchew.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.