From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, berrange@redhat.com
Subject: Re: [PATCH 2/2] utils: Work around mingw strto*l bug with 0x
Date: Thu, 18 Mar 2021 06:07:40 +0100 [thread overview]
Message-ID: <5457f23c-a94e-bf8b-fa1d-962fa2e429f8@redhat.com> (raw)
In-Reply-To: <20210317143325.2165821-3-eblake@redhat.com>
On 17/03/2021 15.33, Eric Blake wrote:
> Mingw recognizes that "0x" has value 0 without setting errno, but
> fails to advance endptr to the trailing garbage 'x'. This in turn
> showed up in our recent testsuite additions for qemu_strtosz (commit
> 1657ba44b4 utils: Enhance testsuite for do_strtosz()); adjust our
> remaining tests to show that we now work around this windows bug.
>
> This patch intentionally fails check-syntax for use of strtol.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/unit/test-cutils.c | 54 ++++++++++++++++++++++++++++++++++++++++
> util/cutils.c | 29 +++++++++++++++------
> 2 files changed, 75 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-03-18 5:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:33 [PATCH 0/2] More qemu_strtosz fixes Eric Blake
2021-03-17 14:33 ` [PATCH 1/2] utils: Tighter tests for qemu_strtosz Eric Blake
2021-03-17 14:59 ` Thomas Huth
2021-03-17 14:33 ` [PATCH 2/2] utils: Work around mingw strto*l bug with 0x Eric Blake
2021-03-18 5:07 ` Thomas Huth [this message]
2021-03-17 15:15 ` [PATCH 0/2] More qemu_strtosz fixes no-reply
2021-03-17 15:28 ` Eric Blake
2021-03-19 17:58 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5457f23c-a94e-bf8b-fa1d-962fa2e429f8@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.