* [PATCH 01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level() Lee Jones
` (30 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, James E.J. Bottomley,
Martin K. Petersen, MPT-FusionLinux.pdl, MPT-FusionLinux.pdl,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/mpt3sas/mpt3sas_config.c:1795: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg0(). Prototype was for _config_set_driver_trigger_pg0() instead
drivers/scsi/mpt3sas/mpt3sas_config.c:1929: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg1(). Prototype was for _config_set_driver_trigger_pg1() instead
drivers/scsi/mpt3sas/mpt3sas_config.c:2080: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg2(). Prototype was for _config_set_driver_trigger_pg2() instead
drivers/scsi/mpt3sas/mpt3sas_config.c:2240: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg3(). Prototype was for _config_set_driver_trigger_pg3() instead
drivers/scsi/mpt3sas/mpt3sas_config.c:2397: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg4(). Prototype was for _config_set_driver_trigger_pg4() instead
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: MPT-FusionLinux.pdl@avagotech.com
Cc: MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/mpt3sas/mpt3sas_config.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c
index 8238843523b53..55cd329089246 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_config.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_config.c
@@ -1781,7 +1781,7 @@ mpt3sas_config_get_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc,
}
/**
- * mpt3sas_config_set_driver_trigger_pg0 - write driver trigger page 0
+ * _config_set_driver_trigger_pg0 - write driver trigger page 0
* @ioc: per adapter object
* @mpi_reply: reply mf payload returned from firmware
* @config_page: contents of the config page
@@ -1915,7 +1915,7 @@ mpt3sas_config_get_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc,
}
/**
- * mpt3sas_config_set_driver_trigger_pg1 - write driver trigger page 1
+ * _config_set_driver_trigger_pg1 - write driver trigger page 1
* @ioc: per adapter object
* @mpi_reply: reply mf payload returned from firmware
* @config_page: contents of the config page
@@ -2066,7 +2066,7 @@ mpt3sas_config_get_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc,
}
/**
- * mpt3sas_config_set_driver_trigger_pg2 - write driver trigger page 2
+ * _config_set_driver_trigger_pg2 - write driver trigger page 2
* @ioc: per adapter object
* @mpi_reply: reply mf payload returned from firmware
* @config_page: contents of the config page
@@ -2226,7 +2226,7 @@ mpt3sas_config_get_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc,
}
/**
- * mpt3sas_config_set_driver_trigger_pg3 - write driver trigger page 3
+ * _config_set_driver_trigger_pg3 - write driver trigger page 3
* @ioc: per adapter object
* @mpi_reply: reply mf payload returned from firmware
* @config_page: contents of the config page
@@ -2383,7 +2383,7 @@ mpt3sas_config_get_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc,
}
/**
- * mpt3sas_config_set_driver_trigger_pg4 - write driver trigger page 4
+ * _config_set_driver_trigger_pg4 - write driver trigger page 4
* @ioc: per adapter object
* @mpi_reply: reply mf payload returned from firmware
* @config_page: contents of the config page
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
2021-03-12 9:47 ` [PATCH 01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours Lee Jones
` (29 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Santosh Yaraganavi, Vinayak Holikatti,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/ufs/ufshcd.c:7142: warning: expecting prototype for ufshcd_calc_icc_level(). Prototype was for ufshcd_find_max_sup_active_icc_level() instead
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Santosh Yaraganavi <santosh.sy@samsung.com>
Cc: Vinayak Holikatti <h.vinayak@samsung.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/ufs/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b65c2899aae41..ffbea9f51dfef 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7146,7 +7146,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan, char *buff)
}
/**
- * ufshcd_calc_icc_level - calculate the max ICC level
+ * ufshcd_find_max_sup_active_icc_level - calculate the max ICC level
* In case regulators are not initialized we'll return 0
* @hba: per-adapter instance
* @desc_buf: power descriptor buffer to extract ICC levels from.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
2021-03-12 9:47 ` [PATCH 01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot Lee Jones
2021-03-12 9:47 ` [PATCH 02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions Lee Jones
` (28 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_scsi.c:746: warning: expecting prototype for lpfc_release_scsi_buf(). Prototype was for lpfc_release_scsi_buf_s3() instead
drivers/scsi/lpfc/lpfc_scsi.c:979: warning: expecting prototype for App checking is required for(). Prototype was for BG_ERR_CHECK() instead
drivers/scsi/lpfc/lpfc_scsi.c:3701: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf'
drivers/scsi/lpfc/lpfc_scsi.c:3701: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf'
drivers/scsi/lpfc/lpfc_scsi.c:3717: warning: Function parameter or member 'fcpi_parm' not described in 'lpfc_send_scsi_error_event'
drivers/scsi/lpfc/lpfc_scsi.c:3717: warning: Excess function parameter 'rsp_iocb' description in 'lpfc_send_scsi_error_event'
drivers/scsi/lpfc/lpfc_scsi.c:3837: warning: Function parameter or member 'fcpi_parm' not described in 'lpfc_handle_fcp_err'
drivers/scsi/lpfc/lpfc_scsi.c:3837: warning: expecting prototype for lpfc_handler_fcp_err(). Prototype was for lpfc_handle_fcp_err() instead
drivers/scsi/lpfc/lpfc_scsi.c:4021: warning: Function parameter or member 'wcqe' not described in 'lpfc_fcp_io_cmd_wqe_cmpl'
drivers/scsi/lpfc/lpfc_scsi.c:4021: warning: Excess function parameter 'pwqeOut' description in 'lpfc_fcp_io_cmd_wqe_cmpl'
drivers/scsi/lpfc/lpfc_scsi.c:4621: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf_s3'
drivers/scsi/lpfc/lpfc_scsi.c:4621: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf_s3'
drivers/scsi/lpfc/lpfc_scsi.c:4698: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf_s4'
drivers/scsi/lpfc/lpfc_scsi.c:4698: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf_s4'
drivers/scsi/lpfc/lpfc_scsi.c:4954: warning: expecting prototype for lpfc_taskmgmt_def_cmpl(). Prototype was for lpfc_tskmgmt_def_cmpl() instead
drivers/scsi/lpfc/lpfc_scsi.c:5094: warning: expecting prototype for lpfc_poll_rearm_time(). Prototype was for lpfc_poll_rearm_timer() instead
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_scsi.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index f0caf923f38c2..85f6a066de5a8 100644
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -736,7 +736,7 @@ lpfc_get_scsi_buf(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp,
}
/**
- * lpfc_release_scsi_buf - Return a scsi buffer back to hba scsi buf list
+ * lpfc_release_scsi_buf_s3 - Return a scsi buffer back to hba scsi buf list
* @phba: The Hba for which this call is being executed.
* @psb: The scsi buffer which is being released.
*
@@ -974,10 +974,10 @@ lpfc_scsi_prep_dma_buf_s3(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
#define BG_ERR_TGT 0x2
/* Return BG_ERR_SWAP if swapping CSUM<-->CRC is required for error injection */
#define BG_ERR_SWAP 0x10
-/**
+/*
* Return BG_ERR_CHECK if disabling Guard/Ref/App checking is required for
* error injection
- **/
+ */
#define BG_ERR_CHECK 0x20
/**
@@ -3699,7 +3699,7 @@ lpfc_bg_scsi_prep_dma_buf(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd)
/**
* lpfc_scsi_prep_cmnd_buf - Wrapper function for IOCB/WQE mapping of scsi
* buffer
- * @phba: The Hba for which this call is being executed.
+ * @vport: Pointer to vport object.
* @lpfc_cmd: The scsi buffer which is going to be mapped.
* @tmo: Timeout value for IO
*
@@ -3721,7 +3721,7 @@ lpfc_scsi_prep_cmnd_buf(struct lpfc_vport *vport, struct lpfc_io_buf *lpfc_cmd,
* @phba: Pointer to hba context object.
* @vport: Pointer to vport object.
* @lpfc_cmd: Pointer to lpfc scsi command which reported the error.
- * @rsp_iocb: Pointer to response iocb object which reported error.
+ * @fcpi_parm: FCP Initiator parameter.
*
* This function posts an event when there is a SCSI command reporting
* error from the scsi device.
@@ -3836,10 +3836,10 @@ lpfc_scsi_unprep_dma_buf(struct lpfc_hba *phba, struct lpfc_io_buf *psb)
}
/**
- * lpfc_handler_fcp_err - FCP response handler
+ * lpfc_handle_fcp_err - FCP response handler
* @vport: The virtual port for which this call is being executed.
* @lpfc_cmd: Pointer to lpfc_io_buf data structure.
- * @rsp_iocb: The response IOCB which contains FCP error.
+ * @fcpi_parm: FCP Initiator parameter.
*
* This routine is called to process response IOCB with status field
* IOSTAT_FCP_RSP_ERROR. This routine sets result field of scsi command
@@ -4023,7 +4023,7 @@ lpfc_handle_fcp_err(struct lpfc_vport *vport, struct lpfc_io_buf *lpfc_cmd,
* lpfc_fcp_io_cmd_wqe_cmpl - Complete a FCP IO
* @phba: The hba for which this call is being executed.
* @pwqeIn: The command WQE for the scsi cmnd.
- * @pwqeOut: The response WQE for the scsi cmnd.
+ * @wcqe: Pointer to driver response CQE object.
*
* This routine assigns scsi command result by looking into response WQE
* status field appropriately. This routine handles QUEUE FULL condition as
@@ -4619,7 +4619,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
/**
* lpfc_scsi_prep_cmnd_buf_s3 - SLI-3 IOCB init for the IO
- * @phba: Pointer to vport object for which I/O is executed
+ * @vport: Pointer to vport object.
* @lpfc_cmd: The scsi buffer which is going to be prep'ed.
* @tmo: timeout value for the IO
*
@@ -4696,7 +4696,7 @@ static int lpfc_scsi_prep_cmnd_buf_s3(struct lpfc_vport *vport,
/**
* lpfc_scsi_prep_cmnd_buf_s4 - SLI-4 WQE init for the IO
- * @phba: Pointer to vport object for which I/O is executed
+ * @vport: Pointer to vport object.
* @lpfc_cmd: The scsi buffer which is going to be prep'ed.
* @tmo: timeout value for the IO
*
@@ -4953,7 +4953,7 @@ lpfc_scsi_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp)
}
/**
- * lpfc_taskmgmt_def_cmpl - IOCB completion routine for task management command
+ * lpfc_tskmgmt_def_cmpl - IOCB completion routine for task management command
* @phba: The Hba for which this call is being executed.
* @cmdiocbq: Pointer to lpfc_iocbq data structure.
* @rspiocbq: Pointer to lpfc_iocbq data structure.
@@ -5098,7 +5098,7 @@ lpfc_info(struct Scsi_Host *host)
}
/**
- * lpfc_poll_rearm_time - Routine to modify fcp_poll timer of hba
+ * lpfc_poll_rearm_timer - Routine to modify fcp_poll timer of hba
* @phba: The Hba for which this call is being executed.
*
* This routine modifies fcp_poll_timer field of @phba by cfg_poll_tmo.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (2 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() Lee Jones
` (27 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_attr.c:880: warning: expecting prototype for lpfc_state_show(). Prototype was for lpfc_link_state_show() instead
drivers/scsi/lpfc/lpfc_attr.c:3834: warning: expecting prototype for lpfc_tgt_queue_depth_store(). Prototype was for lpfc_tgt_queue_depth_set() instead
drivers/scsi/lpfc/lpfc_attr.c:4027: warning: expecting prototype for lpfc_topology_set(). Prototype was for lpfc_topology_store() instead
drivers/scsi/lpfc/lpfc_attr.c:4481: warning: expecting prototype for lpfc_link_speed_set(). Prototype was for lpfc_link_speed_store() instead
drivers/scsi/lpfc/lpfc_attr.c:4879: warning: expecting prototype for lpfc_request_firmware_store(). Prototype was for lpfc_request_firmware_upgrade_store() instead
drivers/scsi/lpfc/lpfc_attr.c:5235: warning: expecting prototype for lpfc_state_show(). Prototype was for lpfc_fcp_cpu_map_show() instead
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_attr.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 98594d6bc26b9..8b4c42016865f 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -864,7 +864,7 @@ lpfc_option_rom_version_show(struct device *dev, struct device_attribute *attr,
}
/**
- * lpfc_state_show - Return the link state of the port
+ * lpfc_link_state_show - Return the link state of the port
* @dev: class converted to a Scsi_host structure.
* @attr: device attribute, not used.
* @buf: on return contains text describing the state of the link.
@@ -3819,7 +3819,7 @@ lpfc_vport_param_init(tgt_queue_depth, LPFC_MAX_TGT_QDEPTH,
LPFC_MIN_TGT_QDEPTH, LPFC_MAX_TGT_QDEPTH);
/**
- * lpfc_tgt_queue_depth_store: Sets an attribute value.
+ * lpfc_tgt_queue_depth_set: Sets an attribute value.
* @vport: lpfc vport structure pointer.
* @val: integer attribute value.
*
@@ -4004,7 +4004,7 @@ LPFC_ATTR(topology, 0, 0, 6,
"Select Fibre Channel topology");
/**
- * lpfc_topology_set - Set the adapters topology field
+ * lpfc_topology_store - Set the adapters topology field
* @dev: class device that is converted into a scsi_host.
* @attr:device attribute, not used.
* @buf: buffer for passing information.
@@ -4457,7 +4457,7 @@ static struct bin_attribute sysfs_drvr_stat_data_attr = {
# Value range is [0,16]. Default value is 0.
*/
/**
- * lpfc_link_speed_set - Set the adapters link speed
+ * lpfc_link_speed_store - Set the adapters link speed
* @dev: Pointer to class device.
* @attr: Unused.
* @buf: Data buffer.
@@ -4858,7 +4858,7 @@ lpfc_param_show(sriov_nr_virtfn)
static DEVICE_ATTR_RW(lpfc_sriov_nr_virtfn);
/**
- * lpfc_request_firmware_store - Request for Linux generic firmware upgrade
+ * lpfc_request_firmware_upgrade_store - Request for Linux generic firmware upgrade
*
* @dev: class device that is converted into a Scsi_host.
* @attr: device attribute, not used.
@@ -5222,7 +5222,7 @@ lpfc_cq_max_proc_limit_init(struct lpfc_hba *phba, int val)
static DEVICE_ATTR_RW(lpfc_cq_max_proc_limit);
/**
- * lpfc_state_show - Display current driver CPU affinity
+ * lpfc_fcp_cpu_map_show - Display current driver CPU affinity
* @dev: class converted to a Scsi_host structure.
* @attr: device attribute, not used.
* @buf: on return contains text describing the state of the link.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (3 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params Lee Jones
` (26 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_rport.c:1500: warning: expecting prototype for fc_rport_els_adisc_resp(). Prototype was for fc_rport_adisc_resp() instead
Cc: Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/libfc/fc_rport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 56003208d2e7c..cd0fb8ca2425d 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -1486,7 +1486,7 @@ static void fc_rport_enter_logo(struct fc_rport_priv *rdata)
}
/**
- * fc_rport_els_adisc_resp() - Handler for Address Discovery (ADISC) responses
+ * fc_rport_adisc_resp() - Handler for Address Discovery (ADISC) responses
* @sp: The sequence the ADISC response was on
* @fp: The ADISC response frame
* @rdata_arg: The remote port that sent the ADISC response
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (4 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() Lee Jones
` (25 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, James E.J. Bottomley,
Martin K. Petersen, MPT-FusionLinux.pdl, MPT-FusionLinux.pdl,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/mpt3sas/mpt3sas_transport.c:71: warning: Function parameter or member 'phy' not described in '_transport_get_port_id_by_sas_phy'
drivers/scsi/mpt3sas/mpt3sas_transport.c:354: warning: Function parameter or member 'port_id' not described in '_transport_expander_report_manufacture'
drivers/scsi/mpt3sas/mpt3sas_transport.c:354: warning: expecting prototype for transport_expander_report_manufacture(). Prototype was for _transport_expander_report_manufacture() instead
drivers/scsi/mpt3sas/mpt3sas_transport.c:684: warning: Function parameter or member 'hba_port' not described in 'mpt3sas_transport_port_add'
drivers/scsi/mpt3sas/mpt3sas_transport.c:684: warning: Excess function parameter 'port' description in 'mpt3sas_transport_port_add'
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: MPT-FusionLinux.pdl@avagotech.com
Cc: MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
index 6f47082247551..0681daee6c149 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
@@ -62,7 +62,7 @@
/**
* _transport_get_port_id_by_sas_phy - get zone's port id that Phy belong to
- * @phy - sas_phy object
+ * @phy: sas_phy object
*
* Return Port number
*/
@@ -339,10 +339,11 @@ struct rep_manu_reply {
};
/**
- * transport_expander_report_manufacture - obtain SMP report_manufacture
+ * _transport_expander_report_manufacture - obtain SMP report_manufacture
* @ioc: per adapter object
* @sas_address: expander sas address
* @edev: the sas_expander_device object
+ * @port_id: Port ID number
*
* Fills in the sas_expander_device object when SMP port is created.
*
@@ -671,7 +672,7 @@ _transport_sanity_check(struct MPT3SAS_ADAPTER *ioc, struct _sas_node *sas_node,
* @ioc: per adapter object
* @handle: handle of attached device
* @sas_address: sas address of parent expander or sas host
- * @port: hba port entry
+ * @hba_port: hba port entry
* Context: This function will acquire ioc->sas_node_lock.
*
* Adding new port object to the sas_node->sas_port_list.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (5 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions Lee Jones
` (24 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_fcp.c:2255: warning: expecting prototype for fc_fcp_destory(). Prototype was for fc_fcp_destroy() instead
Cc: Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/libfc/fc_fcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index b43b5f62ee3e3..509eacd7893d7 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -2248,7 +2248,7 @@ int fc_slave_alloc(struct scsi_device *sdev)
EXPORT_SYMBOL(fc_slave_alloc);
/**
- * fc_fcp_destory() - Tear down the FCP layer for a given local port
+ * fc_fcp_destroy() - Tear down the FCP layer for a given local port
* @lport: The local port that no longer needs the FCP layer
*/
void fc_fcp_destroy(struct fc_lport *lport)
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (6 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues Lee Jones
` (23 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_mr.c:525: warning: expecting prototype for qlafx00_warm_reset(). Prototype was for qlafx00_soc_cpu_reset() instead
drivers/scsi/qla2xxx/qla_mr.c:2869: warning: expecting prototype for qlafx00x_mbx_completion(). Prototype was for qlafx00_mbx_completion() instead
Cc: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/qla2xxx/qla_mr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c
index ca73066853255..d488ae95e149a 100644
--- a/drivers/scsi/qla2xxx/qla_mr.c
+++ b/drivers/scsi/qla2xxx/qla_mr.c
@@ -516,7 +516,7 @@ qlafx00_pci_config(scsi_qla_host_t *vha)
}
/**
- * qlafx00_warm_reset() - Perform warm reset of iSA(CPUs being reset on SOC).
+ * qlafx00_soc_cpu_reset() - Perform warm reset of iSA(CPUs being reset on SOC).
* @vha: HA context
*
*/
@@ -2860,7 +2860,7 @@ qlafx00_async_event(scsi_qla_host_t *vha)
}
/**
- * qlafx00x_mbx_completion() - Process mailbox command completions.
+ * qlafx00_mbx_completion() - Process mailbox command completions.
* @vha: SCSI driver HA context
* @mb0: value to be written into mailbox register 0
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (7 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp() Lee Jones
` (22 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Sathya Prakash, Sreekanth Reddy,
Suganath Prabu Subramani, James E.J. Bottomley,
Martin K. Petersen, MPT-FusionLinux.pdl, MPT-FusionLinux.pdl,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/mpt3sas/mpt3sas_ctl.c:463: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_pre_reset_handler() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:495: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_clear_outstanding_ioctls() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:512: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_reset_done_handler() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:2771: warning: expecting prototype for _ ctl_ioctl_compat(). Prototype was for _ctl_ioctl_compat() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:2789: warning: expecting prototype for _ ctl_mpt2_ioctl_compat(). Prototype was for _ctl_mpt2_ioctl_compat() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:3061: warning: expecting prototype for sas_address_show(). Prototype was for host_sas_address_show() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:3682: warning: expecting prototype for diag_trigger_scsi_show(). Prototype was for diag_trigger_mpi_show() instead
drivers/scsi/mpt3sas/mpt3sas_ctl.c:3941: warning: expecting prototype for sas_ncq_io_prio_show(). Prototype was for sas_ncq_prio_enable_show() instead
Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: MPT-FusionLinux.pdl@avagotech.com
Cc: MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/mpt3sas/mpt3sas_ctl.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
index 44f9a05db94e1..8717412b80794 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
@@ -454,7 +454,7 @@ _ctl_verify_adapter(int ioc_number, struct MPT3SAS_ADAPTER **iocpp,
}
/**
- * mpt3sas_ctl_reset_handler - reset callback handler (for ctl)
+ * mpt3sas_ctl_pre_reset_handler - reset callback handler (for ctl)
* @ioc: per adapter object
*
* The handler for doing any required cleanup or initialization.
@@ -486,7 +486,7 @@ void mpt3sas_ctl_pre_reset_handler(struct MPT3SAS_ADAPTER *ioc)
}
/**
- * mpt3sas_ctl_reset_handler - clears outstanding ioctl cmd.
+ * mpt3sas_ctl_clear_outstanding_ioctls - clears outstanding ioctl cmd.
* @ioc: per adapter object
*
* The handler for doing any required cleanup or initialization.
@@ -503,7 +503,7 @@ void mpt3sas_ctl_clear_outstanding_ioctls(struct MPT3SAS_ADAPTER *ioc)
}
/**
- * mpt3sas_ctl_reset_handler - reset callback handler (for ctl)
+ * mpt3sas_ctl_reset_done_handler - reset callback handler (for ctl)
* @ioc: per adapter object
*
* The handler for doing any required cleanup or initialization.
@@ -2759,7 +2759,7 @@ _ctl_mpt2_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
}
#ifdef CONFIG_COMPAT
/**
- *_ ctl_ioctl_compat - main ioctl entry point (compat)
+ * _ctl_ioctl_compat - main ioctl entry point (compat)
* @file: ?
* @cmd: ?
* @arg: ?
@@ -2777,7 +2777,7 @@ _ctl_ioctl_compat(struct file *file, unsigned cmd, unsigned long arg)
}
/**
- *_ ctl_mpt2_ioctl_compat - main ioctl entry point (compat)
+ * _ctl_mpt2_ioctl_compat - main ioctl entry point (compat)
* @file: ?
* @cmd: ?
* @arg: ?
@@ -3045,7 +3045,7 @@ fw_queue_depth_show(struct device *cdev, struct device_attribute *attr,
static DEVICE_ATTR_RO(fw_queue_depth);
/**
- * sas_address_show - sas address
+ * host_sas_address_show - sas address
* @cdev: pointer to embedded class device
* @attr: ?
* @buf: the buffer returned
@@ -3669,7 +3669,7 @@ static DEVICE_ATTR_RW(diag_trigger_scsi);
/**
- * diag_trigger_scsi_show - show the diag_trigger_mpi attribute
+ * diag_trigger_mpi_show - show the diag_trigger_mpi attribute
* @cdev: pointer to embedded class device
* @attr: ?
* @buf: the buffer returned
@@ -3928,7 +3928,7 @@ sas_device_handle_show(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR_RO(sas_device_handle);
/**
- * sas_ncq_io_prio_show - send prioritized io commands to device
+ * sas_ncq_prio_enable_show - send prioritized io commands to device
* @dev: pointer to embedded device
* @attr: ?
* @buf: the buffer returned
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (8 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions Lee Jones
` (21 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_nx2.c:2038: warning: expecting prototype for qla4_8xxx_check_temp(). Prototype was for qla8044_check_temp() instead
Cc: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
index 68a16c95dcb77..7c413f93d53ee 100644
--- a/drivers/scsi/qla2xxx/qla_nx2.c
+++ b/drivers/scsi/qla2xxx/qla_nx2.c
@@ -2028,7 +2028,7 @@ qla8044_device_state_handler(struct scsi_qla_host *vha)
}
/**
- * qla4_8xxx_check_temp - Check the ISP82XX temperature.
+ * qla8044_check_temp - Check the ISP82XX temperature.
* @vha: adapter block pointer.
*
* Note: The caller should not hold the idc lock.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (9 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data() Lee Jones
` (20 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, Vladislav Bolkhovitin,
Nathaniel Clark, Nicholas A. Bellinger, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla2xxx/qla_target.c:6476: warning: expecting prototype for qla_tgt_lport_register(). Prototype was for qlt_lport_register() instead
drivers/scsi/qla2xxx/qla_target.c:6546: warning: expecting prototype for qla_tgt_lport_deregister(). Prototype was for qlt_lport_deregister() instead
Cc: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Vladislav Bolkhovitin <vst@vlnb.net>
Cc: Nathaniel Clark <nate@misrule.us>
Cc: "Nicholas A. Bellinger" <nab@kernel.org>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/qla2xxx/qla_target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index c48daf52725d9..67c6a2710360a 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -6462,7 +6462,7 @@ static void qlt_lport_dump(struct scsi_qla_host *vha, u64 wwpn,
}
/**
- * qla_tgt_lport_register - register lport with external module
+ * qlt_lport_register - register lport with external module
*
* @target_lport_ptr: pointer for tcm_qla2xxx specific lport data
* @phys_wwpn: physical port WWPN
@@ -6538,7 +6538,7 @@ int qlt_lport_register(void *target_lport_ptr, u64 phys_wwpn,
EXPORT_SYMBOL(qlt_lport_register);
/**
- * qla_tgt_lport_deregister - Degister lport
+ * qlt_lport_deregister - Degister lport
*
* @vha: Registered scsi_qla_host pointer
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (10 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions Lee Jones
` (19 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_debugfs.c:405: warning: expecting prototype for lpfc_debugfs_common_xri_data(). Prototype was for lpfc_debugfs_commonxripools_data() instead
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index ec5328f7f1d41..c23a535ac89ac 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -381,7 +381,7 @@ lpfc_debugfs_hbqinfo_data(struct lpfc_hba *phba, char *buf, int size)
static int lpfc_debugfs_last_xripool;
/**
- * lpfc_debugfs_common_xri_data - Dump Hardware Queue info to a buffer
+ * lpfc_debugfs_commonxripools_data - Dump Hardware Queue info to a buffer
* @phba: The HBA to gather host buffer info from.
* @buf: The buffer to dump log into.
* @size: The maximum amount of data to process.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (11 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap Lee Jones
` (18 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_bsg.c:3591: warning: expecting prototype for lpfc_bsg_mbox_ext_cleanup(). Prototype was for lpfc_bsg_mbox_ext_session_reset() instead
drivers/scsi/lpfc/lpfc_bsg.c:3885: warning: expecting prototype for lpfc_bsg_sli_cfg_mse_read_cmd_ext(). Prototype was for lpfc_bsg_sli_cfg_read_cmd_ext() instead
drivers/scsi/lpfc/lpfc_bsg.c:4371: warning: expecting prototype for lpfc_bsg_mbox_ext_abort_req(). Prototype was for lpfc_bsg_mbox_ext_abort() instead
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_bsg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index b974d39d233b8..503540cf20414 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -3580,7 +3580,7 @@ static int lpfc_bsg_check_cmd_access(struct lpfc_hba *phba,
}
/**
- * lpfc_bsg_mbox_ext_cleanup - clean up context of multi-buffer mbox session
+ * lpfc_bsg_mbox_ext_session_reset - clean up context of multi-buffer mbox session
* @phba: Pointer to HBA context object.
*
* This is routine clean up and reset BSG handling of multi-buffer mbox
@@ -3869,7 +3869,7 @@ lpfc_bsg_sli_cfg_dma_desc_setup(struct lpfc_hba *phba, enum nemb_type nemb_tp,
}
/**
- * lpfc_bsg_sli_cfg_mse_read_cmd_ext - sli_config non-embedded mailbox cmd read
+ * lpfc_bsg_sli_cfg_read_cmd_ext - sli_config non-embedded mailbox cmd read
* @phba: Pointer to HBA context object.
* @job: Pointer to the job object.
* @nemb_tp: Enumerate of non-embedded mailbox command type.
@@ -4360,7 +4360,7 @@ lpfc_bsg_handle_sli_cfg_mbox(struct lpfc_hba *phba, struct bsg_job *job,
}
/**
- * lpfc_bsg_mbox_ext_abort_req - request to abort mbox command with ext buffers
+ * lpfc_bsg_mbox_ext_abort - request to abort mbox command with ext buffers
* @phba: Pointer to HBA context object.
*
* This routine is for requesting to abort a pass-through mailbox command with
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (12 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue Lee Jones
` (17 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Anil Gurumurthy, Sudarsana Kalluru,
James E.J. Bottomley, Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/bfa/bfa_fcs_lport.c: In function ‘bfa_fcs_lport_fdmi_build_rhba_pyld’:
drivers/scsi/bfa/bfa_fcs_lport.c:2152:1: warning: the frame size of 1200 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/bfa/bfa_fcs_lport.c | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index 49a14157f123c..b12afcc4b1894 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -1408,7 +1408,7 @@ static void bfa_fcs_lport_fdmi_rpa_response(void *fcsarg,
u32 resid_len,
struct fchs_s *rsp_fchs);
static void bfa_fcs_lport_fdmi_timeout(void *arg);
-static u16 bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi,
+static int bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi,
u8 *pyld);
static u16 bfa_fcs_lport_fdmi_build_rprt_pyld(struct bfa_fcs_lport_fdmi_s *fdmi,
u8 *pyld);
@@ -1887,6 +1887,8 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced)
bfa_fcs_lport_fdmi_build_rhba_pyld(fdmi,
(u8 *) ((struct ct_hdr_s *) pyld
+ 1));
+ if (attr_len < 0)
+ return;
bfa_fcxp_send(fcxp, NULL, port->fabric->vf_id, port->lp_tag, BFA_FALSE,
FC_CLASS_3, (len + attr_len), &fchs,
@@ -1896,17 +1898,20 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced)
bfa_sm_send_event(fdmi, FDMISM_EVENT_RHBA_SENT);
}
-static u16
+static int
bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld)
{
struct bfa_fcs_lport_s *port = fdmi->ms->port;
- struct bfa_fcs_fdmi_hba_attr_s hba_attr;
- struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr = &hba_attr;
+ struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr;
struct fdmi_rhba_s *rhba = (struct fdmi_rhba_s *) pyld;
struct fdmi_attr_s *attr;
+ int len;
u8 *curr_ptr;
- u16 len, count;
- u16 templen;
+ u16 templen, count;
+
+ fcs_hba_attr = kzalloc(sizeof(*fcs_hba_attr), GFP_KERNEL);
+ if (!fcs_hba_attr)
+ return -ENOMEM;
/*
* get hba attributes
@@ -2148,6 +2153,9 @@ bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld)
len += ((sizeof(attr->type) + sizeof(attr->len)) * count);
rhba->hba_attr_blk.attr_count = cpu_to_be32(count);
+
+ kfree(fcs_hba_attr);
+
return len;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (13 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers Lee Jones
` (16 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/lpfc/lpfc_nvme.c:2021: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_create_localport'
Cc: James Smart <james.smart@broadcom.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/lpfc/lpfc_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index 5fe4e93fe984e..4d78eadb65c0a 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -2002,7 +2002,7 @@ lpfc_release_nvme_buf(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_ncmd)
/**
* lpfc_nvme_create_localport - Create/Bind an nvme localport instance.
- * @vport - the lpfc_vport instance requesting a localport.
+ * @vport: the lpfc_vport instance requesting a localport.
*
* This routine is invoked to create an nvme localport instance to bind
* to the nvme_fc_transport. It is called once during driver load
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (14 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() Lee Jones
` (15 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, Stanley Chu, Jan Kotas, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/ufs/cdns-pltfrm.c:109: warning: expecting prototype for Sets HCLKDIV register value based on the core_clk(). Prototype was for cdns_ufs_set_hclkdiv() instead
drivers/scsi/ufs/cdns-pltfrm.c:144: warning: wrong kernel-doc identifier on line:
drivers/scsi/ufs/cdns-pltfrm.c:160: warning: wrong kernel-doc identifier on line:
drivers/scsi/ufs/cdns-pltfrm.c:176: warning: wrong kernel-doc identifier on line:
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Avri Altman <avri.altman@wdc.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>
Cc: Jan Kotas <jank@cadence.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/ufs/cdns-pltfrm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
index 149391faa19c1..13d92043e13b0 100644
--- a/drivers/scsi/ufs/cdns-pltfrm.c
+++ b/drivers/scsi/ufs/cdns-pltfrm.c
@@ -100,6 +100,7 @@ static void cdns_ufs_set_l4_attr(struct ufs_hba *hba)
}
/**
+ * cdns_ufs_set_hclkdiv()
* Sets HCLKDIV register value based on the core_clk
* @hba: host controller instance
*
@@ -141,6 +142,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba)
}
/**
+ * cdns_ufs_hce_enable_notify()
* Called before and after HCE enable bit is set.
* @hba: host controller instance
* @status: notify stage (pre, post change)
@@ -157,6 +159,7 @@ static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
}
/**
+ * cdns_ufs_hibern8_notify()
* Called around hibern8 enter/exit.
* @hba: host controller instance
* @cmd: UIC Command
@@ -173,6 +176,7 @@ static void cdns_ufs_hibern8_notify(struct ufs_hba *hba, enum uic_cmd_dme cmd,
}
/**
+ * cdns_ufs_link_startup_notify()
* Called before and after Link startup is carried out.
* @hba: host controller instance
* @status: notify stage (pre, post change)
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (15 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() Lee Jones
` (14 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Karen Xie, James E.J. Bottomley,
Martin K. Petersen, Dimitris Michailidis, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:1189: warning: expecting prototype for cxgb3i_setup_conn_digest(). Prototype was for ddp_setup_conn_digest() instead
Cc: Karen Xie <kxie@chelsio.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Dimitris Michailidis <dm@chelsio.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index 37d99357120fa..203f938fca7e5 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1177,7 +1177,7 @@ static int ddp_setup_conn_pgidx(struct cxgbi_sock *csk,
}
/**
- * cxgb3i_setup_conn_digest - setup conn. digest setting
+ * ddp_setup_conn_digest - setup conn. digest setting
* @csk: cxgb tcp socket
* @tid: connection id
* @hcrc: header digest enabled
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (16 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() Lee Jones
` (13 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Bradley Grove, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/esas2r/esas2r_log.c: In function ‘esas2r_log_master’:
drivers/scsi/esas2r/esas2r_log.c:155:3: warning: function ‘esas2r_log_master’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Cc: Bradley Grove <linuxdrivers@attotech.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/esas2r/esas2r_log.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c
index b545798e400c4..d6c87a0bae098 100644
--- a/drivers/scsi/esas2r/esas2r_log.c
+++ b/drivers/scsi/esas2r/esas2r_log.c
@@ -101,6 +101,11 @@ static const char *translate_esas2r_event_level_to_kernel(const long level)
}
}
+#pragma GCC diagnostic push
+#ifndef __clang__
+#pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
+#endif
+
/*
* the master logging function. this function will format the message as
* outlined by the formatting string, the input device information and the
@@ -170,6 +175,8 @@ static int esas2r_log_master(const long level,
return 0;
}
+#pragma GCC diagnostic pop
+
/*
* formats and logs a message to the system log.
*
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan()
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (17 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 20/30] scsi: be2iscsi: be_main: Provide missing function name in header Lee Jones
` (12 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Subbu Seetharaman, Ketan Mukadam, Jitendra Bhivare,
James E.J. Bottomley, Martin K. Petersen, linux-drivers,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/be2iscsi/be_iscsi.c:312: warning: expecting prototype for beiscsi_set_vlan_tag(). Prototype was for beiscsi_iface_config_vlan() instead
Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-drivers@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
index a13c203ef7a9a..0e935c49b57bd 100644
--- a/drivers/scsi/be2iscsi/be_iscsi.c
+++ b/drivers/scsi/be2iscsi/be_iscsi.c
@@ -295,7 +295,7 @@ void beiscsi_iface_destroy_default(struct beiscsi_hba *phba)
}
/**
- * beiscsi_set_vlan_tag()- Set the VLAN TAG
+ * beiscsi_iface_config_vlan()- Set the VLAN TAG
* @shost: Scsi Host for the driver instance
* @iface_param: Interface paramters
*
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 20/30] scsi: be2iscsi: be_main: Provide missing function name in header
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (18 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s " Lee Jones
` (11 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Subbu Seetharaman, Ketan Mukadam, Jitendra Bhivare,
James E.J. Bottomley, Martin K. Petersen, linux-drivers,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/be2iscsi/be_main.c:4934: warning: expecting prototype for Boot flag info for iscsi(). Prototype was for BEISCSI_SYSFS_ISCSI_BOOT_FLAGS() instead
Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-drivers@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/be2iscsi/be_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 90fcddb76f46f..ab32ca535078d 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -4927,6 +4927,7 @@ void beiscsi_start_boot_work(struct beiscsi_hba *phba, unsigned int s_handle)
}
/**
+ * beiscsi_show_boot_tgt_info()
* Boot flag info for iscsi-utilities
* Bit 0 Block valid flag
* Bit 1 Firmware booting selected
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (19 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 20/30] scsi: be2iscsi: be_main: Provide missing function name in header Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description Lee Jones
` (10 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Subbu Seetharaman, Ketan Mukadam, Jitendra Bhivare,
James E.J. Bottomley, Martin K. Petersen, linux-drivers,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/be2iscsi/be_mgmt.c:1270: warning: expecting prototype for beiscsi_phys_port(). Prototype was for beiscsi_phys_port_disp() instead
Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>
Cc: Ketan Mukadam <ketan.mukadam@broadcom.com>
Cc: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-drivers@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/be2iscsi/be_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 0d4928567265d..462717bbb5b7e 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -1256,7 +1256,7 @@ beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr,
}
/**
- * beiscsi_phys_port()- Display Physical Port Identifier
+ * beiscsi_phys_port_disp()- Display Physical Port Identifier
* @dev: ptr to device not used.
* @attr: device attribute, not used.
* @buf: contains formatted text port identifier
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (20 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s " Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 23/30] scsi: initio: Remove unused variable 'prev' Lee Jones
` (9 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Nilesh Javali, Manish Rangankar,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Anil Veerabhadrappa, Eddie Wai,
QLogic-Storage-Upstream, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/bnx2i/bnx2i_sysfs.c:118: warning: expecting prototype for bnx2i_get_link_state(). Prototype was for bnx2i_set_ccell_info() instead
Cc: Nilesh Javali <njavali@marvell.com>
Cc: Manish Rangankar <mrangankar@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
Cc: Eddie Wai <eddie.wai@broadcom.com>
Cc: QLogic-Storage-Upstream@qlogic.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/bnx2i/bnx2i_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_sysfs.c b/drivers/scsi/bnx2i/bnx2i_sysfs.c
index 3dc790089f0fc..bea00073cb7cd 100644
--- a/drivers/scsi/bnx2i/bnx2i_sysfs.c
+++ b/drivers/scsi/bnx2i/bnx2i_sysfs.c
@@ -104,7 +104,7 @@ static ssize_t bnx2i_show_ccell_info(struct device *dev,
/**
- * bnx2i_get_link_state - set command cell (HQ) size
+ * bnx2i_set_ccell_info - set command cell (HQ) size
* @dev: device pointer
* @attr: device attribute (unused)
* @buf: buffer to return current SQ size parameter
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 23/30] scsi: initio: Remove unused variable 'prev'
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (21 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 16:27 ` Christoph Hellwig
2021-03-12 9:47 ` [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys' Lee Jones
` (8 subsequent siblings)
31 siblings, 1 reply; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James E.J. Bottomley, Martin K. Petersen,
Bas Vermeulen, Christoph Hellwig, Brian Macy, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/initio.c: In function ‘initio_find_busy_scb’:
drivers/scsi/initio.c:869:30: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Brian Macy <bmacy@sunshinecomputing.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/initio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 814acc57069dc..926a7045c2e5c 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -866,17 +866,16 @@ static void initio_unlink_busy_scb(struct initio_host * host, struct scsi_ctrl_b
struct scsi_ctrl_blk *initio_find_busy_scb(struct initio_host * host, u16 tarlun)
{
- struct scsi_ctrl_blk *tmp, *prev;
+ struct scsi_ctrl_blk *tmp;
u16 scbp_tarlun;
- prev = tmp = host->first_busy;
+ tmp = host->first_busy;
while (tmp != NULL) {
scbp_tarlun = (tmp->lun << 8) | (tmp->target);
if (scbp_tarlun == tarlun) { /* Unlink this SCB */
break;
}
- prev = tmp;
tmp = tmp->next;
}
#if DEBUG_QUEUE
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys'
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (22 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 23/30] scsi: initio: Remove unused variable 'prev' Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 16:37 ` Christoph Hellwig
2021-03-12 9:47 ` [PATCH 25/30] scsi: dc395x: Fix incorrect naming in function headers Lee Jones
` (7 subsequent siblings)
31 siblings, 1 reply; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James E.J. Bottomley, Martin K. Petersen,
Doug Ledford, Christoph Hellwig, Alan Cox, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/a100u2w.c: In function ‘inia100_probe_one’:
drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not used [-Wunused-but-set-variable]
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/a100u2w.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index 66c514310f3c5..c99224a128f82 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a100u2w.c
@@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
int error = -ENODEV;
u32 sz;
unsigned long biosaddr;
- char *bios_phys;
if (pci_enable_device(pdev))
goto out;
@@ -1141,7 +1140,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
biosaddr = host->BIOScfg;
biosaddr = (biosaddr << 4);
- bios_phys = phys_to_virt(biosaddr);
if (init_orchid(host)) { /* Initialize orchid chip */
printk("inia100: initial orchid fail!!\n");
goto out_free_escb_array;
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys'
2021-03-12 9:47 ` [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys' Lee Jones
@ 2021-03-12 16:37 ` Christoph Hellwig
0 siblings, 0 replies; 39+ messages in thread
From: Christoph Hellwig @ 2021-03-12 16:37 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, James E.J. Bottomley, Martin K. Petersen,
Doug Ledford, Christoph Hellwig, Alan Cox, linux-scsi
On Fri, Mar 12, 2021 at 09:47:32AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PATCH 25/30] scsi: dc395x: Fix incorrect naming in function headers
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (23 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys' Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header Lee Jones
` (6 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Oliver Neukum, Ali Akcaagac, Jamie Lenehan,
James E.J. Bottomley, Martin K. Petersen, C.L. Huang, Erich Chen,
Kurt Garloff, dc395x, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/dc395x.c:980: warning: expecting prototype for dc395x_queue_command(). Prototype was for dc395x_queue_command_lck() instead
drivers/scsi/dc395x.c:4263: warning: expecting prototype for adapter_init_host(). Prototype was for adapter_init_scsi_host() instead
drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'acb' not described in 'adapter_init'
drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'io_port_len' not described in 'adapter_init'
drivers/scsi/dc395x.c:4353: warning: expecting prototype for init_adapter(). Prototype was for adapter_init() instead
Cc: Oliver Neukum <oliver@neukum.org>
Cc: Ali Akcaagac <aliakc@web.de>
Cc: Jamie Lenehan <lenehan@twibble.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "C.L. Huang" <ching@tekram.com.tw>
Cc: Erich Chen <erich@tekram.com.tw>
Cc: Kurt Garloff <garloff@suse.de>
Cc: dc395x@twibble.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/dc395x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 3ea345c124673..e28f8931e23f8 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -958,7 +958,7 @@ static void build_srb(struct scsi_cmnd *cmd, struct DeviceCtlBlk *dcb,
/**
- * dc395x_queue_command - queue scsi command passed from the mid
+ * dc395x_queue_command_lck - queue scsi command passed from the mid
* layer, invoke 'done' on completion
*
* @cmd: pointer to scsi command object
@@ -4248,7 +4248,7 @@ static void adapter_init_params(struct AdapterCtlBlk *acb)
/**
- * adapter_init_host - Initialize the scsi host instance based on
+ * adapter_init_scsi_host - Initialize the scsi host instance based on
* values that we have already stored in the adapter instance. There's
* some mention that a lot of these are deprecated, so we won't use
* them (we'll use the ones in the adapter instance) but we'll fill
@@ -4336,7 +4336,7 @@ static void adapter_init_chip(struct AdapterCtlBlk *acb)
/**
- * init_adapter - Grab the resource for the card, setup the adapter
+ * adapter_init - Grab the resource for the card, setup the adapter
* information, set the card into a known state, create the various
* tables etc etc. This basically gets all adapter information all up
* to date, initialised and gets the chip in sync with it.
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (24 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 25/30] scsi: dc395x: Fix incorrect naming in function headers Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 27/30] scsi: myrs: Remove a couple of unused 'status' variables Lee Jones
` (5 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, James E.J. Bottomley, Martin K. Petersen,
Marcelo Tosatti, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/atp870u.c:623: warning: expecting prototype for atp870u_queuecommand(). Prototype was for atp870u_queuecommand_lck() instead
drivers/scsi/atp870u.c:724: warning: Function parameter or member 'dev' not described in 'send_s870'
drivers/scsi/atp870u.c:724: warning: Function parameter or member 'c' not described in 'send_s870'
drivers/scsi/atp870u.c:724: warning: Excess function parameter 'host' description in 'send_s870'
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/atp870u.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
index da6ca2b153d85..9d179cd15bb84 100644
--- a/drivers/scsi/atp870u.c
+++ b/drivers/scsi/atp870u.c
@@ -612,7 +612,7 @@ static irqreturn_t atp870u_intr_handle(int irq, void *dev_id)
return IRQ_HANDLED;
}
/**
- * atp870u_queuecommand - Queue SCSI command
+ * atp870u_queuecommand_lck - Queue SCSI command
* @req_p: request block
* @done: completion function
*
@@ -711,16 +711,15 @@ static int atp870u_queuecommand_lck(struct scsi_cmnd *req_p,
static DEF_SCSI_QCMD(atp870u_queuecommand)
-/**
+/*
* send_s870 - send a command to the controller
- * @host: host
*
* On entry there is work queued to be done. We move some of that work to the
* controller itself.
*
* Caller holds the host lock.
*/
-static void send_s870(struct atp_unit *dev,unsigned char c)
+static void send_s870(struct atp_unit *dev, unsigned char c)
{
struct scsi_cmnd *workreq = NULL;
unsigned int i;//,k;
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 27/30] scsi: myrs: Remove a couple of unused 'status' variables
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (25 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 16:40 ` Christoph Hellwig
2021-03-12 9:47 ` [PATCH 28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev' Lee Jones
` (4 subsequent siblings)
31 siblings, 1 reply; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, Linux GmbH, Leonard N. Zubkoff, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/myrs.c: In function ‘consistency_check_show’:
drivers/scsi/myrs.c:1193:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
drivers/scsi/myrs.c: In function ‘myrs_get_resync’:
drivers/scsi/myrs.c:1984:5: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
Cc: Hannes Reinecke <hare@kernel.org>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linux GmbH <hare@suse.com>
Cc: "Leonard N. Zubkoff" <lnz@dandelion.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/myrs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c
index 4adf9ded296aa..48e399f057d5c 100644
--- a/drivers/scsi/myrs.c
+++ b/drivers/scsi/myrs.c
@@ -1190,7 +1190,6 @@ static ssize_t consistency_check_show(struct device *dev,
struct myrs_hba *cs = shost_priv(sdev->host);
struct myrs_ldev_info *ldev_info;
unsigned short ldev_num;
- unsigned char status;
if (sdev->channel < cs->ctlr_info->physchan_present)
return snprintf(buf, 32, "physical device - not checking\n");
@@ -1199,7 +1198,7 @@ static ssize_t consistency_check_show(struct device *dev,
if (!ldev_info)
return -ENXIO;
ldev_num = ldev_info->ldev_num;
- status = myrs_get_ldev_info(cs, ldev_num, ldev_info);
+ myrs_get_ldev_info(cs, ldev_num, ldev_info);
if (ldev_info->cc_active)
return snprintf(buf, 32, "checking block %zu of %zu\n",
(size_t)ldev_info->cc_lba,
@@ -1981,14 +1980,13 @@ myrs_get_resync(struct device *dev)
struct myrs_hba *cs = shost_priv(sdev->host);
struct myrs_ldev_info *ldev_info = sdev->hostdata;
u64 percent_complete = 0;
- u8 status;
if (sdev->channel < cs->ctlr_info->physchan_present || !ldev_info)
return;
if (ldev_info->rbld_active) {
unsigned short ldev_num = ldev_info->ldev_num;
- status = myrs_get_ldev_info(cs, ldev_num, ldev_info);
+ myrs_get_ldev_info(cs, ldev_num, ldev_info);
percent_complete = ldev_info->rbld_lba * 100;
do_div(percent_complete, ldev_info->cfg_devsize);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev'
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (26 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 27/30] scsi: myrs: Remove a couple of unused 'status' variables Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 29/30] scsi: 3w-9xxx: Remove a few set but unused variables Lee Jones
` (3 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Adam Radford, James E.J. Bottomley,
Martin K. Petersen, Joel Jacobson, de Melo, Andre Hedrick,
linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/3w-xxxx.c: In function ‘tw_empty_response_que’:
drivers/scsi/3w-xxxx.c:463:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable]
drivers/scsi/3w-xxxx.c: In function ‘tw_scsi_biosparam’:
drivers/scsi/3w-xxxx.c:1345:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable]
Cc: Adam Radford <aradford@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Joel Jacobson <linux@3ware.com>
Cc: de Melo <acme@conectiva.com.br>
Cc: Andre Hedrick <andre@suse.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/3w-xxxx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
index d90b9fca4aea2..a7292883b72bc 100644
--- a/drivers/scsi/3w-xxxx.c
+++ b/drivers/scsi/3w-xxxx.c
@@ -460,12 +460,12 @@ static int tw_check_errors(TW_Device_Extension *tw_dev)
/* This function will empty the response que */
static void tw_empty_response_que(TW_Device_Extension *tw_dev)
{
- u32 status_reg_value, response_que_value;
+ u32 status_reg_value;
status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev));
while ((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) {
- response_que_value = inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
+ inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev));
}
} /* End tw_empty_response_que() */
@@ -1342,10 +1342,8 @@ static int tw_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev
sector_t capacity, int geom[])
{
int heads, sectors, cylinders;
- TW_Device_Extension *tw_dev;
dprintk(KERN_NOTICE "3w-xxxx: tw_scsi_biosparam()\n");
- tw_dev = (TW_Device_Extension *)sdev->host->hostdata;
heads = 64;
sectors = 32;
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 29/30] scsi: 3w-9xxx: Remove a few set but unused variables
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (27 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev' Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-12 9:47 ` [PATCH 30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' Lee Jones
` (2 subsequent siblings)
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Adam Radford, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/3w-9xxx.c: In function ‘twa_empty_response_queue’:
drivers/scsi/3w-9xxx.c:942:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable]
drivers/scsi/3w-9xxx.c: In function ‘twa_scsi_biosparam’:
drivers/scsi/3w-9xxx.c:1701:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable]
drivers/scsi/3w-9xxx.c: In function ‘twa_scsiop_execute_scsi’:
drivers/scsi/3w-9xxx.c:1812:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable]
Cc: Adam Radford <aradford@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/3w-9xxx.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
index b96e82de4237d..47028f5e57abd 100644
--- a/drivers/scsi/3w-9xxx.c
+++ b/drivers/scsi/3w-9xxx.c
@@ -939,13 +939,13 @@ static int twa_decode_bits(TW_Device_Extension *tw_dev, u32 status_reg_value)
/* This function will empty the response queue */
static int twa_empty_response_queue(TW_Device_Extension *tw_dev)
{
- u32 status_reg_value, response_que_value;
+ u32 status_reg_value;
int count = 0, retval = 1;
status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev));
while (((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) && (count < TW_MAX_RESPONSE_DRAIN)) {
- response_que_value = readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
+ readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev));
count++;
}
@@ -1698,9 +1698,6 @@ static int twa_reset_sequence(TW_Device_Extension *tw_dev, int soft_reset)
static int twa_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[])
{
int heads, sectors, cylinders;
- TW_Device_Extension *tw_dev;
-
- tw_dev = (TW_Device_Extension *)sdev->host->hostdata;
if (capacity >= 0x200000) {
heads = 255;
@@ -1809,14 +1806,11 @@ static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id,
u32 num_sectors = 0x0;
int i, sg_count;
struct scsi_cmnd *srb = NULL;
- struct scatterlist *sglist = NULL, *sg;
+ struct scatterlist *sg;
int retval = 1;
- if (tw_dev->srb[request_id]) {
+ if (tw_dev->srb[request_id])
srb = tw_dev->srb[request_id];
- if (scsi_sglist(srb))
- sglist = scsi_sglist(srb);
- }
/* Initialize command packet */
full_command_packet = tw_dev->command_packet_virt[request_id];
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (28 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 29/30] scsi: 3w-9xxx: Remove a few set but unused variables Lee Jones
@ 2021-03-12 9:47 ` Lee Jones
2021-03-16 2:29 ` [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Martin K. Petersen
2021-03-19 3:46 ` Martin K. Petersen
31 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-12 9:47 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Adam Radford, James E.J. Bottomley,
Martin K. Petersen, linux-scsi
Fixes the following W=1 kernel build warning(s):
drivers/scsi/3w-sas.c: In function ‘twl_scsiop_execute_scsi’:
drivers/scsi/3w-sas.c:298:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable]
drivers/scsi/3w-sas.c: In function ‘twl_scsi_biosparam’:
drivers/scsi/3w-sas.c:1411:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable]
Cc: Adam Radford <aradford@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/scsi/3w-sas.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
index 3db0e42e9aa75..383f6f204c24b 100644
--- a/drivers/scsi/3w-sas.c
+++ b/drivers/scsi/3w-sas.c
@@ -295,14 +295,11 @@ static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id,
TW_Command_Apache *command_packet;
int i, sg_count;
struct scsi_cmnd *srb = NULL;
- struct scatterlist *sglist = NULL, *sg;
+ struct scatterlist *sg;
int retval = 1;
- if (tw_dev->srb[request_id]) {
+ if (tw_dev->srb[request_id])
srb = tw_dev->srb[request_id];
- if (scsi_sglist(srb))
- sglist = scsi_sglist(srb);
- }
/* Initialize command packet */
full_command_packet = tw_dev->command_packet_virt[request_id];
@@ -1408,9 +1405,6 @@ static int twl_reset_device_extension(TW_Device_Extension *tw_dev, int ioctl_res
static int twl_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[])
{
int heads, sectors;
- TW_Device_Extension *tw_dev;
-
- tw_dev = (TW_Device_Extension *)sdev->host->hostdata;
if (capacity >= 0x200000) {
heads = 255;
--
2.27.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (29 preceding siblings ...)
2021-03-12 9:47 ` [PATCH 30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' Lee Jones
@ 2021-03-16 2:29 ` Martin K. Petersen
2021-03-16 7:17 ` Lee Jones
2021-03-19 3:46 ` Martin K. Petersen
31 siblings, 1 reply; 39+ messages in thread
From: Martin K. Petersen @ 2021-03-16 2:29 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Adam Radford, Alan Cox, Ali Akcaagac, Alim Akhtar,
Andre Hedrick, Anil Gurumurthy, Anil Veerabhadrappa, Avri Altman,
Bas Vermeulen, Bradley Grove, Brian Macy, Christoph Hellwig,
C.L. Huang, dc395x, de Melo, Dick Kennedy, Dimitris Michailidis,
Doug Ledford, Eddie Wai, Erich Chen, GR-QLogic-Storage-Upstream,
Hannes Reinecke, Hannes Reinecke, James E.J. Bottomley,
James Smart, Jamie Lenehan, Jan Kotas, Jitendra Bhivare,
Joel Jacobson, Karen Xie, Ketan Mukadam, Kurt Garloff,
Leonard N. Zubkoff, linux-drivers, Linux GmbH, linux-scsi,
Manish Rangankar, Marcelo Tosatti, Martin K. Petersen,
MPT-FusionLinux.pdl, MPT-FusionLinux.pdl, Nathaniel Clark,
Nicholas A. Bellinger, Nilesh Javali, Oliver Neukum,
QLogic-Storage-Upstream, Santosh Yaraganavi, Sathya Prakash,
Sreekanth Reddy, Stanley Chu, Subbu Seetharaman,
Sudarsana Kalluru, Suganath Prabu Subramani, Vinayak Holikatti,
Vladislav Bolkhovitin
Lee,
> This set is part of a larger effort attempting to clean-up W=1 kernel
> builds, which are currently overwhelmingly riddled with niggly little
> warnings.
Applied to 5.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
2021-03-16 2:29 ` [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Martin K. Petersen
@ 2021-03-16 7:17 ` Lee Jones
2021-03-17 1:38 ` Martin K. Petersen
0 siblings, 1 reply; 39+ messages in thread
From: Lee Jones @ 2021-03-16 7:17 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-kernel, Adam Radford, Alan Cox, Ali Akcaagac, Alim Akhtar,
Andre Hedrick, Anil Gurumurthy, Anil Veerabhadrappa, Avri Altman,
Bas Vermeulen, Bradley Grove, Brian Macy, Christoph Hellwig,
C.L. Huang, dc395x, de Melo, Dick Kennedy, Dimitris Michailidis,
Doug Ledford, Eddie Wai, Erich Chen, GR-QLogic-Storage-Upstream,
Hannes Reinecke, Hannes Reinecke, James E.J. Bottomley,
James Smart, Jamie Lenehan, Jan Kotas, Jitendra Bhivare,
Joel Jacobson, Karen Xie, Ketan Mukadam, Kurt Garloff,
Leonard N. Zubkoff, linux-drivers, Linux GmbH, linux-scsi,
Manish Rangankar, Marcelo Tosatti, MPT-FusionLinux.pdl,
MPT-FusionLinux.pdl, Nathaniel Clark, Nicholas A. Bellinger,
Nilesh Javali, Oliver Neukum, QLogic-Storage-Upstream,
Santosh Yaraganavi, Sathya Prakash, Sreekanth Reddy, Stanley Chu,
Subbu Seetharaman, Sudarsana Kalluru, Suganath Prabu Subramani,
Vinayak Holikatti, Vladislav Bolkhovitin
On Mon, 15 Mar 2021, Martin K. Petersen wrote:
>
> Lee,
>
> > This set is part of a larger effort attempting to clean-up W=1 kernel
> > builds, which are currently overwhelmingly riddled with niggly little
> > warnings.
>
> Applied to 5.13/scsi-staging, thanks!
Superstar! Thanks Martin.
Just FYI, there are more 44 more patches left until clean.
Would you like them in 1 or 2 sets?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
2021-03-16 7:17 ` Lee Jones
@ 2021-03-17 1:38 ` Martin K. Petersen
2021-03-17 8:13 ` Lee Jones
0 siblings, 1 reply; 39+ messages in thread
From: Martin K. Petersen @ 2021-03-17 1:38 UTC (permalink / raw)
To: Lee Jones
Cc: Martin K. Petersen, linux-kernel, Adam Radford, Alan Cox,
Ali Akcaagac, Alim Akhtar, Andre Hedrick, Anil Gurumurthy,
Anil Veerabhadrappa, Avri Altman, Bas Vermeulen, Bradley Grove,
Brian Macy, Christoph Hellwig, C.L. Huang, dc395x, de Melo,
Dick Kennedy, Dimitris Michailidis, Doug Ledford, Eddie Wai,
Erich Chen, GR-QLogic-Storage-Upstream, Hannes Reinecke,
Hannes Reinecke, James E.J. Bottomley, James Smart,
Jamie Lenehan, Jan Kotas, Jitendra Bhivare, Joel Jacobson,
Karen Xie, Ketan Mukadam, Kurt Garloff, Leonard N. Zubkoff,
linux-drivers, Linux GmbH, linux-scsi, Manish Rangankar,
Marcelo Tosatti, MPT-FusionLinux.pdl, MPT-FusionLinux.pdl,
Nathaniel Clark, Nicholas A. Bellinger, Nilesh Javali,
Oliver Neukum, QLogic-Storage-Upstream, Santosh Yaraganavi,
Sathya Prakash, Sreekanth Reddy, Stanley Chu, Subbu Seetharaman,
Sudarsana Kalluru, Suganath Prabu Subramani, Vinayak Holikatti,
Vladislav Bolkhovitin
Lee,
> Would you like them in 1 or 2 sets?
As long as they are trivial, one set is fine.
What does help is to split by complexity. In your two previous series I
would have preferred the mpt3sas and bfa patches that actually change
code to be posted separately. Just to make sure they don't get lost in a
sea of trivial changes.
IOW, if the patches contain substantial functional changes I'd prefer
them to be separate from all the kernel-doc, function prototype,
etc. fixes.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
2021-03-17 1:38 ` Martin K. Petersen
@ 2021-03-17 8:13 ` Lee Jones
0 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2021-03-17 8:13 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-kernel, Adam Radford, Alan Cox, Ali Akcaagac, Alim Akhtar,
Andre Hedrick, Anil Gurumurthy, Anil Veerabhadrappa, Avri Altman,
Bas Vermeulen, Bradley Grove, Brian Macy, Christoph Hellwig,
C.L. Huang, dc395x, de Melo, Dick Kennedy, Dimitris Michailidis,
Doug Ledford, Eddie Wai, Erich Chen, GR-QLogic-Storage-Upstream,
Hannes Reinecke, Hannes Reinecke, James E.J. Bottomley,
James Smart, Jamie Lenehan, Jan Kotas, Jitendra Bhivare,
Joel Jacobson, Karen Xie, Ketan Mukadam, Kurt Garloff,
Leonard N. Zubkoff, linux-drivers, Linux GmbH, linux-scsi,
Manish Rangankar, Marcelo Tosatti, MPT-FusionLinux.pdl,
MPT-FusionLinux.pdl, Nathaniel Clark, Nicholas A. Bellinger,
Nilesh Javali, Oliver Neukum, QLogic-Storage-Upstream,
Santosh Yaraganavi, Sathya Prakash, Sreekanth Reddy, Stanley Chu,
Subbu Seetharaman, Sudarsana Kalluru, Suganath Prabu Subramani,
Vinayak Holikatti, Vladislav Bolkhovitin
On Tue, 16 Mar 2021, Martin K. Petersen wrote:
>
> Lee,
>
> > Would you like them in 1 or 2 sets?
>
> As long as they are trivial, one set is fine.
>
> What does help is to split by complexity. In your two previous series I
> would have preferred the mpt3sas and bfa patches that actually change
> code to be posted separately. Just to make sure they don't get lost in a
> sea of trivial changes.
>
> IOW, if the patches contain substantial functional changes I'd prefer
> them to be separate from all the kernel-doc, function prototype,
> etc. fixes.
At the moment, my process involves a script which opens each file and
works it's way through the reported issues.
I'll take a look through the remaining patches and try to pull out any
that are more complex.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI
2021-03-12 9:47 [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Lee Jones
` (30 preceding siblings ...)
2021-03-16 2:29 ` [PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI Martin K. Petersen
@ 2021-03-19 3:46 ` Martin K. Petersen
31 siblings, 0 replies; 39+ messages in thread
From: Martin K. Petersen @ 2021-03-19 3:46 UTC (permalink / raw)
To: Lee Jones
Cc: Martin K . Petersen, Erich Chen, Linux GmbH, Oliver Neukum,
Joel Jacobson, de Melo, Avri Altman, Andre Hedrick,
Christoph Hellwig, Leonard N. Zubkoff, James E.J. Bottomley,
QLogic-Storage-Upstream, Santosh Yaraganavi, Dick Kennedy,
Sreekanth Reddy, Jamie Lenehan, Brian Macy, Hannes Reinecke,
Nathaniel Clark, Jan Kotas, Bas Vermeulen, Adam Radford,
MPT-FusionLinux.pdl, GR-QLogic-Storage-Upstream, C.L. Huang,
dc395x, Suganath Prabu Subramani, Ketan Mukadam, Hannes Reinecke,
Vladislav Bolkhovitin, Alan Cox, Anil Veerabhadrappa,
Sathya Prakash, Kurt Garloff, Nilesh Javali, Ali Akcaagac,
Vinayak Holikatti, linux-scsi, Bradley Grove, Karen Xie,
Marcelo Tosatti, Eddie Wai, Doug Ledford, Dimitris Michailidis,
Stanley Chu, Nicholas A. Bellinger, linux-drivers,
MPT-FusionLinux.pdl, Subbu Seetharaman, linux-kernel,
Jitendra Bhivare, James Smart, Sudarsana Kalluru,
Manish Rangankar, Alim Akhtar, Anil Gurumurthy
On Fri, 12 Mar 2021 09:47:08 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (30):
> scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot
> scsi: ufs: ufshcd: Fix incorrectly named
> ufshcd_find_max_sup_active_icc_level()
> scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours
> scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions
> scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()
> scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented
> functions/params
> scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()
> scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions
> scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues
> scsi: qla2xxx: qla_nx2: Fix incorrectly named function
> qla8044_check_temp()
> scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions
> scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function
> lpfc_debugfs_commonxripools_data()
> scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions
> scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the
> heap
> scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue
> scsi: ufs: cdns-pltfrm: Supply function names for headers
> scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()
> scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for
> esas2r_log_master()
> scsi: be2iscsi: be_iscsi: Fix incorrect naming of
> beiscsi_iface_config_vlan()
> scsi: be2iscsi: be_main: Provide missing function name in header
> scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header
> scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in
> description
> scsi: initio: Remove unused variable 'prev'
> scsi: a100u2w: Remove unused variable 'bios_phys'
> scsi: dc395x: Fix incorrect naming in function headers
> scsi: atp870u: Fix naming and demote incorrect and non-conformant
> kernel-doc header
> scsi: myrs: Remove a couple of unused 'status' variables
> scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and
> 'tw_dev'
> scsi: 3w-9xxx: Remove a few set but unused variables
> scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'
>
> [...]
Applied to 5.13/scsi-queue, thanks!
[01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot
https://git.kernel.org/mkp/scsi/c/cf9e575e62a4
[02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level()
https://git.kernel.org/mkp/scsi/c/11eea9b3fd4d
[03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours
https://git.kernel.org/mkp/scsi/c/0bb87e01d815
[04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions
https://git.kernel.org/mkp/scsi/c/a3dbf5145d01
[05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()
https://git.kernel.org/mkp/scsi/c/0dbea7c18873
[06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params
https://git.kernel.org/mkp/scsi/c/54cb88dc3083
[07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()
https://git.kernel.org/mkp/scsi/c/775b4d65a6fb
[08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions
https://git.kernel.org/mkp/scsi/c/381095668d51
[09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues
https://git.kernel.org/mkp/scsi/c/782a1ab33f71
[10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp()
https://git.kernel.org/mkp/scsi/c/a736e4490442
[11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions
https://git.kernel.org/mkp/scsi/c/dc49ab48a77c
[12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data()
https://git.kernel.org/mkp/scsi/c/2c6400b78243
[13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions
https://git.kernel.org/mkp/scsi/c/3145d2d69e16
[14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap
https://git.kernel.org/mkp/scsi/c/a7a11b6cfec2
[15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue
https://git.kernel.org/mkp/scsi/c/f6b35a75042b
[16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers
https://git.kernel.org/mkp/scsi/c/d5db88b0ce89
[17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()
https://git.kernel.org/mkp/scsi/c/181883786427
[18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master()
https://git.kernel.org/mkp/scsi/c/1c666a3e0a54
[19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan()
https://git.kernel.org/mkp/scsi/c/1b8a7ee9308e
[20/30] scsi: be2iscsi: be_main: Provide missing function name in header
https://git.kernel.org/mkp/scsi/c/a905a1dce8bf
[21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header
https://git.kernel.org/mkp/scsi/c/ab4bab7a977d
[22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description
https://git.kernel.org/mkp/scsi/c/0a386beb7ebd
[23/30] scsi: initio: Remove unused variable 'prev'
https://git.kernel.org/mkp/scsi/c/78e40ac8b696
[24/30] scsi: a100u2w: Remove unused variable 'bios_phys'
https://git.kernel.org/mkp/scsi/c/fb5b29b2ad3f
[25/30] scsi: dc395x: Fix incorrect naming in function headers
https://git.kernel.org/mkp/scsi/c/167b7e6bfbf5
[26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header
https://git.kernel.org/mkp/scsi/c/6b71f60ca205
[27/30] scsi: myrs: Remove a couple of unused 'status' variables
https://git.kernel.org/mkp/scsi/c/3cb0cfb557cd
[28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev'
https://git.kernel.org/mkp/scsi/c/6c31cb74a1ce
[29/30] scsi: 3w-9xxx: Remove a few set but unused variables
https://git.kernel.org/mkp/scsi/c/ea7fb5344ad0
[30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'
https://git.kernel.org/mkp/scsi/c/475bff65c431
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 39+ messages in thread