* [PATCH net-next] net: make xps_needed and xps_rxqs_needed static
@ 2021-03-22 11:30 Vladimir Oltean
2021-03-22 20:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2021-03-22 11:30 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, netdev; +Cc: Vladimir Oltean, Amritha Nambiar
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Since their introduction in commit 04157469b7b8 ("net: Use static_key
for XPS maps"), xps_needed and xps_rxqs_needed were never used outside
net/core/dev.c, so I don't really understand why they were exported as
symbols in the first place.
This is needed in order to silence a "make W=1" warning about these
static keys not being declared as static variables, but not having a
previous declaration in a header file nonetheless.
Cc: Amritha Nambiar <amritha.nambiar@intel.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
net/core/dev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index be941ed754ac..ffab3928eeeb 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2451,10 +2451,8 @@ int netdev_txq_to_tc(struct net_device *dev, unsigned int txq)
EXPORT_SYMBOL(netdev_txq_to_tc);
#ifdef CONFIG_XPS
-struct static_key xps_needed __read_mostly;
-EXPORT_SYMBOL(xps_needed);
-struct static_key xps_rxqs_needed __read_mostly;
-EXPORT_SYMBOL(xps_rxqs_needed);
+static struct static_key xps_needed __read_mostly;
+static struct static_key xps_rxqs_needed __read_mostly;
static DEFINE_MUTEX(xps_map_mutex);
#define xmap_dereference(P) \
rcu_dereference_protected((P), lockdep_is_held(&xps_map_mutex))
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: make xps_needed and xps_rxqs_needed static
2021-03-22 11:30 [PATCH net-next] net: make xps_needed and xps_rxqs_needed static Vladimir Oltean
@ 2021-03-22 20:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-22 20:30 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: davem, kuba, netdev, vladimir.oltean, amritha.nambiar
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 22 Mar 2021 13:30:19 +0200 you wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Since their introduction in commit 04157469b7b8 ("net: Use static_key
> for XPS maps"), xps_needed and xps_rxqs_needed were never used outside
> net/core/dev.c, so I don't really understand why they were exported as
> symbols in the first place.
>
> [...]
Here is the summary with links:
- [net-next] net: make xps_needed and xps_rxqs_needed static
https://git.kernel.org/netdev/net-next/c/5da9ace3405f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-22 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 11:30 [PATCH net-next] net: make xps_needed and xps_rxqs_needed static Vladimir Oltean
2021-03-22 20:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.