All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
@ 2021-03-23  9:34 ` Yang Li
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-03-23  9:34 UTC (permalink / raw)
  To: tomba; +Cc: airlied, daniel, dri-devel, linux-kernel, Yang Li

fixed the following coccicheck:
./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---

Change in v2:
-Modify the fourth parameter, not the first

 drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index b31d750..5f1722b 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
 	irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
 
 	err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
-				   IRQF_TRIGGER_RISING, "TE", dsi);
+				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+				   "TE", dsi);
 	if (err) {
 		dev_err(dsi->dev, "request irq failed with %d\n", err);
 		gpiod_put(dsi->te_gpio);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
@ 2021-03-23  9:34 ` Yang Li
  0 siblings, 0 replies; 6+ messages in thread
From: Yang Li @ 2021-03-23  9:34 UTC (permalink / raw)
  To: tomba; +Cc: airlied, Yang Li, dri-devel, linux-kernel

fixed the following coccicheck:
./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---

Change in v2:
-Modify the fourth parameter, not the first

 drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index b31d750..5f1722b 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
 	irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
 
 	err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
-				   IRQF_TRIGGER_RISING, "TE", dsi);
+				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+				   "TE", dsi);
 	if (err) {
 		dev_err(dsi->dev, "request irq failed with %d\n", err);
 		gpiod_put(dsi->te_gpio);
-- 
1.8.3.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
  2021-03-23  9:34 ` Yang Li
@ 2021-03-23 11:15   ` Sebastian Reichel
  -1 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2021-03-23 11:15 UTC (permalink / raw)
  To: Yang Li; +Cc: tomba, airlied, dri-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

Hi,

On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Also maybe add this, so that it is properly backported. OTOH old code did
not have IRQF_ONESHOT either.

Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

-- Sebastian

> Change in v2:
> -Modify the fourth parameter, not the first
> 
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index b31d750..5f1722b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
>  	irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
>  
>  	err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
> -				   IRQF_TRIGGER_RISING, "TE", dsi);
> +				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +				   "TE", dsi);
>  	if (err) {
>  		dev_err(dsi->dev, "request irq failed with %d\n", err);
>  		gpiod_put(dsi->te_gpio);
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
@ 2021-03-23 11:15   ` Sebastian Reichel
  0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2021-03-23 11:15 UTC (permalink / raw)
  To: Yang Li; +Cc: airlied, dri-devel, tomba, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1615 bytes --]

Hi,

On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Also maybe add this, so that it is properly backported. OTOH old code did
not have IRQF_ONESHOT either.

Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

-- Sebastian

> Change in v2:
> -Modify the fourth parameter, not the first
> 
>  drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index b31d750..5f1722b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi,
>  	irq_set_status_flags(te_irq, IRQ_NOAUTOEN);
>  
>  	err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler,
> -				   IRQF_TRIGGER_RISING, "TE", dsi);
> +				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +				   "TE", dsi);
>  	if (err) {
>  		dev_err(dsi->dev, "request irq failed with %d\n", err);
>  		gpiod_put(dsi->te_gpio);
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
  2021-03-23 11:15   ` Sebastian Reichel
@ 2021-03-26  7:24     ` Tomi Valkeinen
  -1 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2021-03-26  7:24 UTC (permalink / raw)
  To: Sebastian Reichel, Yang Li; +Cc: airlied, dri-devel, linux-kernel

On 23/03/2021 13:15, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
>> fixed the following coccicheck:
>> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
>> no primary handler requested without IRQF_ONESHOT
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> Also maybe add this, so that it is properly backported. OTOH old code did
> not have IRQF_ONESHOT either.
> 
> Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

Thanks, I have applied this.

  Tomi

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT
@ 2021-03-26  7:24     ` Tomi Valkeinen
  0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2021-03-26  7:24 UTC (permalink / raw)
  To: Sebastian Reichel, Yang Li; +Cc: airlied, linux-kernel, dri-devel

On 23/03/2021 13:15, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Mar 23, 2021 at 05:34:53PM +0800, Yang Li wrote:
>> fixed the following coccicheck:
>> ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with
>> no primary handler requested without IRQF_ONESHOT
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> Also maybe add this, so that it is properly backported. OTOH old code did
> not have IRQF_ONESHOT either.
> 
> Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core")

Thanks, I have applied this.

  Tomi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-26  7:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23  9:34 [PATCH v2] drm/omap: dsi: Add missing IRQF_ONESHOT Yang Li
2021-03-23  9:34 ` Yang Li
2021-03-23 11:15 ` Sebastian Reichel
2021-03-23 11:15   ` Sebastian Reichel
2021-03-26  7:24   ` Tomi Valkeinen
2021-03-26  7:24     ` Tomi Valkeinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.