* [PATCH] genirq: Add missing IRQF_ONESHOT
@ 2021-03-23 9:38 Yang Li
2021-03-25 13:52 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-03-23 9:38 UTC (permalink / raw)
To: tglx; +Cc: linux-kernel, Yang Li
fixed the following coccicheck:
./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 21ea370..a309fd3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2191,7 +2191,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,
if (irq_settings_is_nested_thread(desc)) {
ret = request_threaded_irq(irq, NULL, handler,
- flags, name, dev_id);
+ flags | IRQF_ONESHOT, name, dev_id);
return !ret ? IRQC_IS_NESTED : ret;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] genirq: Add missing IRQF_ONESHOT
2021-03-23 9:38 [PATCH] genirq: Add missing IRQF_ONESHOT Yang Li
@ 2021-03-25 13:52 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2021-03-25 13:52 UTC (permalink / raw)
To: Yang Li; +Cc: linux-kernel, Yang Li
On Tue, Mar 23 2021 at 17:38, Yang Li wrote:
> fixed the following coccicheck:
> ./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
This fixes nothing because it's for a nested thread and not relevant to
that check at all.
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 9:38 [PATCH] genirq: Add missing IRQF_ONESHOT Yang Li
2021-03-25 13:52 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.