From: Rob Herring <robh@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
netdev@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy compatible string
Date: Thu, 25 Mar 2021 10:56:01 -0600 [thread overview]
Message-ID: <1616691361.069761.1321894.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210325124225.2760-2-linux.amoon@gmail.com>
On Thu, 25 Mar 2021 12:42:20 +0000, Anand Moon wrote:
> Fix the parsing of check of pattern ethernet-phy-ieee802.3 used
> by the device tree to initialize the mdio phy.
>
> As per the of_mdio below 2 are valid compatible string
> "ethernet-phy-ieee802.3-c22"
> "ethernet-phy-ieee802.3-c45"
>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.example.dt.yaml: ethernet-phy@0: compatible: 'oneOf' conditional failed, one must be fixed:
['ethernet-phy-id0141.0e90', 'ethernet-phy-ieee802.3-c45'] is too long
Additional items are not allowed ('ethernet-phy-ieee802.3-c45' was unexpected)
'ethernet-phy-ieee802.3-c22' was expected
'ethernet-phy-ieee802.3-c45' was expected
'ethernet-phy-id0141.0e90' does not match '^ethernet-phy-ieee[0-9]{3}\\.[0-9][-][a-f0-9]{4}$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.yaml
See https://patchwork.ozlabs.org/patch/1458341
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
netdev@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy compatible string
Date: Thu, 25 Mar 2021 10:56:01 -0600 [thread overview]
Message-ID: <1616691361.069761.1321894.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210325124225.2760-2-linux.amoon@gmail.com>
On Thu, 25 Mar 2021 12:42:20 +0000, Anand Moon wrote:
> Fix the parsing of check of pattern ethernet-phy-ieee802.3 used
> by the device tree to initialize the mdio phy.
>
> As per the of_mdio below 2 are valid compatible string
> "ethernet-phy-ieee802.3-c22"
> "ethernet-phy-ieee802.3-c45"
>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.example.dt.yaml: ethernet-phy@0: compatible: 'oneOf' conditional failed, one must be fixed:
['ethernet-phy-id0141.0e90', 'ethernet-phy-ieee802.3-c45'] is too long
Additional items are not allowed ('ethernet-phy-ieee802.3-c45' was unexpected)
'ethernet-phy-ieee802.3-c22' was expected
'ethernet-phy-ieee802.3-c45' was expected
'ethernet-phy-id0141.0e90' does not match '^ethernet-phy-ieee[0-9]{3}\\.[0-9][-][a-f0-9]{4}$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.yaml
See https://patchwork.ozlabs.org/patch/1458341
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
netdev@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy compatible string
Date: Thu, 25 Mar 2021 10:56:01 -0600 [thread overview]
Message-ID: <1616691361.069761.1321894.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210325124225.2760-2-linux.amoon@gmail.com>
On Thu, 25 Mar 2021 12:42:20 +0000, Anand Moon wrote:
> Fix the parsing of check of pattern ethernet-phy-ieee802.3 used
> by the device tree to initialize the mdio phy.
>
> As per the of_mdio below 2 are valid compatible string
> "ethernet-phy-ieee802.3-c22"
> "ethernet-phy-ieee802.3-c45"
>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.example.dt.yaml: ethernet-phy@0: compatible: 'oneOf' conditional failed, one must be fixed:
['ethernet-phy-id0141.0e90', 'ethernet-phy-ieee802.3-c45'] is too long
Additional items are not allowed ('ethernet-phy-ieee802.3-c45' was unexpected)
'ethernet-phy-ieee802.3-c22' was expected
'ethernet-phy-ieee802.3-c45' was expected
'ethernet-phy-id0141.0e90' does not match '^ethernet-phy-ieee[0-9]{3}\\.[0-9][-][a-f0-9]{4}$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ethernet-phy.yaml
See https://patchwork.ozlabs.org/patch/1458341
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-03-25 16:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 12:42 [PATCHv1 0/6] Amlogic Soc - Add missing ethernet mdio compatible string Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` [PATCHv1 1/6] dt-bindings: net: ethernet-phy: Fix the parsing of ethernet-phy " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:57 ` Andrew Lunn
2021-03-25 12:57 ` Andrew Lunn
2021-03-25 12:57 ` Andrew Lunn
2021-03-25 13:33 ` Anand Moon
2021-03-25 13:33 ` Anand Moon
2021-03-25 13:33 ` Anand Moon
2021-03-25 13:42 ` Heiner Kallweit
2021-03-25 13:42 ` Heiner Kallweit
2021-03-25 13:42 ` Heiner Kallweit
2021-03-25 16:56 ` Rob Herring [this message]
2021-03-25 16:56 ` Rob Herring
2021-03-25 16:56 ` Rob Herring
2021-03-25 17:37 ` Anand Moon
2021-03-25 17:37 ` Anand Moon
2021-03-25 17:37 ` Anand Moon
2021-03-25 12:42 ` [PATCHv1 2/6] arm: dts: meson: Add missing ethernet phy mdio " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:59 ` Andrew Lunn
2021-03-25 12:59 ` Andrew Lunn
2021-03-25 12:59 ` Andrew Lunn
2021-03-25 12:42 ` [PATCHv1 3/6] arm64: dts: meson-gxbb: Add missing ethernet phy mimo " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` [PATCHv1 4/6] arm64: dts: meson-gxl: Add missing ethernet phy mdio " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` [PATCHv1 5/6] arm64: dts: meson-g12: " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` [PATCHv1 6/6] arm64: dts: meson-glx: Fix the " Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 12:42 ` Anand Moon
2021-03-25 13:02 ` [PATCHv1 0/6] Amlogic Soc - Add missing ethernet " Andrew Lunn
2021-03-25 13:02 ` Andrew Lunn
2021-03-25 13:02 ` Andrew Lunn
2021-03-25 13:19 ` Heiner Kallweit
2021-03-25 13:19 ` Heiner Kallweit
2021-03-25 13:19 ` Heiner Kallweit
2021-03-25 15:40 ` Anand Moon
2021-03-25 15:40 ` Anand Moon
2021-03-25 15:40 ` Anand Moon
2021-03-25 15:55 ` Heiner Kallweit
2021-03-25 15:55 ` Heiner Kallweit
2021-03-25 15:55 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616691361.069761.1321894.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.