All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
@ 2021-03-27  9:56 ` Huang Guobin
  0 siblings, 0 replies; 6+ messages in thread
From: Huang Guobin @ 2021-03-27  9:56 UTC (permalink / raw)
  To: huangguobin4, Felix Fietkau, Lorenzo Bianconi, Kalle Valo,
	Jakub Kicinski, Matthias Brugger, Markus Elfring,
	David S. Miller
  Cc: linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/wireless/mediatek/mt76/mt7615/soc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
index 9aa5183c7a56..be9a69fe1b38 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
@@ -40,10 +40,8 @@ static int mt7622_wmac_probe(struct platform_device *pdev)
 		return irq;
 
 	mem_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(mem_base)) {
-		dev_err(&pdev->dev, "Failed to get memory resource\n");
+	if (IS_ERR(mem_base))
 		return PTR_ERR(mem_base);
-	}
 
 	return mt7615_mmio_probe(&pdev->dev, mem_base, irq, mt7615e_reg_map);
 }


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
@ 2021-03-27  9:56 ` Huang Guobin
  0 siblings, 0 replies; 6+ messages in thread
From: Huang Guobin @ 2021-03-27  9:56 UTC (permalink / raw)
  To: huangguobin4, Felix Fietkau, Lorenzo Bianconi, Kalle Valo,
	Jakub Kicinski, Matthias Brugger, Markus Elfring,
	David S. Miller
  Cc: linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/wireless/mediatek/mt76/mt7615/soc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
index 9aa5183c7a56..be9a69fe1b38 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
@@ -40,10 +40,8 @@ static int mt7622_wmac_probe(struct platform_device *pdev)
 		return irq;
 
 	mem_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(mem_base)) {
-		dev_err(&pdev->dev, "Failed to get memory resource\n");
+	if (IS_ERR(mem_base))
 		return PTR_ERR(mem_base);
-	}
 
 	return mt7615_mmio_probe(&pdev->dev, mem_base, irq, mt7615e_reg_map);
 }


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
@ 2021-03-27  9:56 ` Huang Guobin
  0 siblings, 0 replies; 6+ messages in thread
From: Huang Guobin @ 2021-03-27  9:56 UTC (permalink / raw)
  To: huangguobin4, Felix Fietkau, Lorenzo Bianconi, Kalle Valo,
	Jakub Kicinski, Matthias Brugger, Markus Elfring,
	David S. Miller
  Cc: linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/wireless/mediatek/mt76/mt7615/soc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
index 9aa5183c7a56..be9a69fe1b38 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/soc.c
@@ -40,10 +40,8 @@ static int mt7622_wmac_probe(struct platform_device *pdev)
 		return irq;
 
 	mem_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(mem_base)) {
-		dev_err(&pdev->dev, "Failed to get memory resource\n");
+	if (IS_ERR(mem_base))
 		return PTR_ERR(mem_base);
-	}
 
 	return mt7615_mmio_probe(&pdev->dev, mem_base, irq, mt7615e_reg_map);
 }


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
  2021-03-27  9:56 ` Huang Guobin
  (?)
@ 2021-03-29  1:10   ` patchwork-bot+netdevbpf
  -1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29  1:10 UTC (permalink / raw)
  To: Huang Guobin
  Cc: nbd, lorenzo.bianconi83, kvalo, kuba, matthias.bgg, elfring,
	davem, linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 17:56:18 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
    https://git.kernel.org/netdev/net-next/c/8e99ca3fdb31

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
@ 2021-03-29  1:10   ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29  1:10 UTC (permalink / raw)
  To: Huang Guobin
  Cc: nbd, lorenzo.bianconi83, kvalo, kuba, matthias.bgg, elfring,
	davem, linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 17:56:18 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
    https://git.kernel.org/netdev/net-next/c/8e99ca3fdb31

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
@ 2021-03-29  1:10   ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29  1:10 UTC (permalink / raw)
  To: Huang Guobin
  Cc: nbd, lorenzo.bianconi83, kvalo, kuba, matthias.bgg, elfring,
	davem, linux-wireless, netdev, linux-arm-kernel, linux-mediatek,
	kernel-janitors

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 17:56:18 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()
    https://git.kernel.org/netdev/net-next/c/8e99ca3fdb31

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-29 17:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27  9:56 [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe() Huang Guobin
2021-03-27  9:56 ` Huang Guobin
2021-03-27  9:56 ` Huang Guobin
2021-03-29  1:10 ` patchwork-bot+netdevbpf
2021-03-29  1:10   ` patchwork-bot+netdevbpf
2021-03-29  1:10   ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.