All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported
@ 2021-03-30 15:06 ` Tvrtko Ursulin
  0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2021-03-30 15:06 UTC (permalink / raw)
  To: Intel-gfx; +Cc: Eero T Tamminen, dri-devel, Tvrtko Ursulin

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

We use GT parked status to estimate RC6 while not in use, however if RC6
is not supported to start with that does not work very well and produces a
false 100% RC6 readout.

Fix by not advancing the estimated RC6 counter when feature is not
supported.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 1fe699e30113 ("drm/i915/pmu: Fix sleep under atomic in RC6 readout")
Reported-by: Eero T Tamminen <eero.t.tamminen@intel.com>
---
 drivers/gpu/drm/i915/i915_pmu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 41651ac255fa..02fe0d22c470 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -191,7 +191,10 @@ static u64 get_rc6(struct intel_gt *gt)
 		 * on top of the last known real value, as the approximated RC6
 		 * counter value.
 		 */
-		val = ktime_since_raw(pmu->sleep_last);
+		if (gt->rc6.supported)
+			val = ktime_since_raw(pmu->sleep_last);
+		else
+			val = 0;
 		val += pmu->sample[__I915_SAMPLE_RC6].cur;
 	}
 
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2021-04-09 11:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 15:06 [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported Tvrtko Ursulin
2021-03-30 15:06 ` [Intel-gfx] " Tvrtko Ursulin
2021-03-30 16:01 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-03-30 16:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-30 17:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-01  9:25 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2021-04-01  9:25   ` Rodrigo Vivi
2021-04-06 11:19 ` Andi Shyti
2021-04-06 11:19   ` Andi Shyti
2021-04-09 11:46   ` Tvrtko Ursulin
2021-04-09 11:46     ` Tvrtko Ursulin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.