* [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
@ 2021-04-01 17:05 Gwan-gyeong Mun
2021-04-01 20:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Gwan-gyeong Mun @ 2021-04-01 17:05 UTC (permalink / raw)
To: intel-gfx
As per b.spec 49274, the IO buffer Wake lines and Fast Wake lines can be
calculated based on the following formula.
IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds)
Fast wake lines = ROUNDUP(PSR2 aux transaction time / total line time in microseconds)
For both fields limit the minimum to 7 lines and maximum to 12 lines
PSR2 IO wake time = 50us, PSR2 aux transaction time = 32us.
It calculates IO buffer Wake and Fast Wake based on b.spec 49274 and
programs it.
v2: Address Jose's review comment.
- Do not overwrite the values.
- Move calulating and validating of io_buffer_wake/fast_wake to
intel_psr2_config_valid() from intel_psr_compute_config()
- Add macros for hardcoded values.
- Simplify and reuse the validating the io_buffer_wake/fast_wake.
v3: Rebased
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
.../drm/i915/display/intel_display_types.h | 2 +
drivers/gpu/drm/i915/display/intel_psr.c | 65 +++++++++++++++----
drivers/gpu/drm/i915/i915_reg.h | 8 +++
3 files changed, 63 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index e2e707c4dff5..79df8da9b89e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1496,6 +1496,8 @@ struct intel_psr {
u16 su_x_granularity;
bool dc3co_enabled;
u32 dc3co_exit_delay;
+ u32 io_buffer_wake;
+ u32 fast_wake;
struct delayed_work dc3co_work;
struct drm_dp_vsc_sdp vsc;
};
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 54ad5c378355..a1fff724fb67 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -531,19 +531,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
val |= intel_psr2_get_tp_time(intel_dp);
if (DISPLAY_VER(dev_priv) >= 12) {
- /*
- * TODO: 7 lines of IO_BUFFER_WAKE and FAST_WAKE are default
- * values from BSpec. In order to setting an optimal power
- * consumption, lower than 4k resoluition mode needs to decrese
- * IO_BUFFER_WAKE and FAST_WAKE. And higher than 4K resolution
- * mode needs to increase IO_BUFFER_WAKE and FAST_WAKE.
- */
- val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_2;
- val |= TGL_EDP_PSR2_IO_BUFFER_WAKE(7);
- val |= TGL_EDP_PSR2_FAST_WAKE(7);
+ if (intel_dp->psr.io_buffer_wake < 9 || intel_dp->psr.fast_wake < 9)
+ val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_2;
+ else
+ val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_3;
+ val |= TGL_EDP_PSR2_IO_BUFFER_WAKE(intel_dp->psr.io_buffer_wake);
+ val |= TGL_EDP_PSR2_FAST_WAKE(intel_dp->psr.fast_wake);
} else if (DISPLAY_VER(dev_priv) >= 9) {
- val |= EDP_PSR2_IO_BUFFER_WAKE(7);
- val |= EDP_PSR2_FAST_WAKE(7);
+ val |= EDP_PSR2_IO_BUFFER_WAKE(intel_dp->psr.io_buffer_wake);
+ val |= EDP_PSR2_FAST_WAKE(intel_dp->psr.fast_wake);
}
if (intel_dp->psr.psr2_sel_fetch_enabled) {
@@ -724,7 +720,9 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
int crtc_hdisplay = crtc_state->hw.adjusted_mode.crtc_hdisplay;
int crtc_vdisplay = crtc_state->hw.adjusted_mode.crtc_vdisplay;
+ u32 io_buffer_wake, io_buffer_wake_max, io_buffer_wake_min;
int psr_max_h = 0, psr_max_v = 0, max_bpp = 0;
+ u32 fast_wake, fast_wake_max, fast_wake_min;
if (!intel_dp->psr.sink_psr2_support)
return false;
@@ -768,14 +766,26 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
psr_max_h = 5120;
psr_max_v = 3200;
max_bpp = 30;
+ io_buffer_wake_max = TGL_EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
+ io_buffer_wake_min = TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
+ fast_wake_max = TGL_EDP_PSR2_FAST_WAKE_MAX_LINES;
+ fast_wake_min = TGL_EDP_PSR2_FAST_WAKE_MIN_LINES;
} else if (DISPLAY_VER(dev_priv) >= 10) {
psr_max_h = 4096;
psr_max_v = 2304;
max_bpp = 24;
+ io_buffer_wake_max = EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
+ io_buffer_wake_min = EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
+ fast_wake_max = EDP_PSR2_FAST_WAKE_MAX_LINES;
+ fast_wake_min = EDP_PSR2_FAST_WAKE_MIN_LINES;
} else if (IS_DISPLAY_VER(dev_priv, 9)) {
psr_max_h = 3640;
psr_max_v = 2304;
max_bpp = 24;
+ io_buffer_wake_max = EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
+ io_buffer_wake_min = EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
+ fast_wake_max = EDP_PSR2_FAST_WAKE_MAX_LINES;
+ fast_wake_min = EDP_PSR2_FAST_WAKE_MIN_LINES;
}
if (crtc_state->pipe_bpp > max_bpp) {
@@ -785,6 +795,37 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
return false;
}
+ /*
+ * B.Spec 49274
+ * IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds)
+ * Fast wake lines = ROUNDUP(PSR2 aux transaction time / total line time in microseconds)
+ * For both fields limit the minimum to 7 lines and maximum to 12 lines
+ * PSR2 IO wake time = 50us, PSR2 aux transaction time = 32us.
+ */
+ io_buffer_wake = intel_usecs_to_scanlines(&crtc_state->uapi.adjusted_mode,
+ EDP_PSR2_IO_WAKE_TIME);
+ fast_wake = intel_usecs_to_scanlines(&crtc_state->uapi.adjusted_mode,
+ EDP_PSR2_AUX_TRANSACTION_TIME);
+
+ if (io_buffer_wake < io_buffer_wake_min || io_buffer_wake > io_buffer_wake_max) {
+ drm_dbg_kms(&dev_priv->drm,
+ "PSR condition failed: Invalid PSR2 IO Buffer Wake lines (%d)\n",
+ io_buffer_wake);
+ return false;
+ }
+
+ if (fast_wake < fast_wake_min || fast_wake > fast_wake_max) {
+ drm_dbg_kms(&dev_priv->drm,
+ "PSR condition failed: Invalid PSR2 FAST Wake lines (%d)\n",
+ fast_wake);
+ return false;
+ }
+
+ intel_dp->psr.io_buffer_wake =
+ io_buffer_wake < EDP_PSR2_IO_BUFFER_WAKE_DEFAULT ? EDP_PSR2_IO_BUFFER_WAKE_DEFAULT : io_buffer_wake;
+ intel_dp->psr.fast_wake =
+ fast_wake < EDP_PSR2_FAST_WAKE_DEFAULT ? EDP_PSR2_FAST_WAKE_DEFAULT : fast_wake;
+
/*
* HW sends SU blocks of size four scan lines, which means the starting
* X coordinate and Y granularity requirements will always be met. We
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index cbf7a60afe54..0fc121720364 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4568,14 +4568,22 @@ enum {
#define EDP_MAX_SU_DISABLE_TIME(t) ((t) << 20)
#define EDP_MAX_SU_DISABLE_TIME_MASK (0x1f << 20)
#define EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES 8
+#define EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES 5
+#define EDP_PSR2_IO_BUFFER_WAKE_DEFAULT 7
#define EDP_PSR2_IO_BUFFER_WAKE(lines) ((EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES - (lines)) << 13)
#define EDP_PSR2_IO_BUFFER_WAKE_MASK (3 << 13)
+#define EDP_PSR2_IO_WAKE_TIME 50
+#define TGL_EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES 12
#define TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES 5
#define TGL_EDP_PSR2_IO_BUFFER_WAKE(lines) (((lines) - TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES) << 13)
#define TGL_EDP_PSR2_IO_BUFFER_WAKE_MASK (7 << 13)
#define EDP_PSR2_FAST_WAKE_MAX_LINES 8
+#define EDP_PSR2_FAST_WAKE_MIN_LINES 5
+#define EDP_PSR2_FAST_WAKE_DEFAULT 7
#define EDP_PSR2_FAST_WAKE(lines) ((EDP_PSR2_FAST_WAKE_MAX_LINES - (lines)) << 11)
#define EDP_PSR2_FAST_WAKE_MASK (3 << 11)
+#define EDP_PSR2_AUX_TRANSACTION_TIME 32
+#define TGL_EDP_PSR2_FAST_WAKE_MAX_LINES 12
#define TGL_EDP_PSR2_FAST_WAKE_MIN_LINES 5
#define TGL_EDP_PSR2_FAST_WAKE(lines) (((lines) - TGL_EDP_PSR2_FAST_WAKE_MIN_LINES) << 10)
#define TGL_EDP_PSR2_FAST_WAKE_MASK (7 << 10)
--
2.30.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
@ 2021-04-01 20:45 ` Patchwork
2021-04-01 20:50 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-04-01 20:45 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
URL : https://patchwork.freedesktop.org/series/88673/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
35268f22aac5 drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds)
-:147: WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#147: FILE: drivers/gpu/drm/i915/display/intel_psr.c:822:
+ io_buffer_wake < EDP_PSR2_IO_BUFFER_WAKE_DEFAULT ? EDP_PSR2_IO_BUFFER_WAKE_DEFAULT : io_buffer_wake;
total: 0 errors, 2 warnings, 0 checks, 129 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
2021-04-01 20:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2021-04-01 20:50 ` Patchwork
2021-04-01 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-04-01 20:50 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
URL : https://patchwork.freedesktop.org/series/88673/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
2021-04-01 20:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-04-01 20:50 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
@ 2021-04-01 21:13 ` Patchwork
2021-04-02 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-13 20:06 ` [Intel-gfx] [PATCH] " Souza, Jose
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-04-01 21:13 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5247 bytes --]
== Series Details ==
Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
URL : https://patchwork.freedesktop.org/series/88673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9925 -> Patchwork_19890
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/index.html
Known issues
------------
Here are the changes found in Patchwork_19890 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][3] ([i915#2283])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][6] -> [INCOMPLETE][7] ([i915#2782] / [i915#2940])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#2411] / [i915#402])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-tgl-y/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-tgl-y/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@runner@aborted:
- fi-bsw-nick: NOTRUN -> [FAIL][11] ([i915#1436])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-bsw-nick/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [DMESG-WARN][12] ([i915#402]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-tgl-y/igt@gem_flink_basic@double-flink.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-tgl-y/igt@gem_flink_basic@double-flink.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][14] ([i915#2782]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [DMESG-WARN][16] ([i915#2868]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (47 -> 42)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9925 -> Patchwork_19890
CI-20190529: 20190529
CI_DRM_9925: 44fed14ddf3ab2d108508846f385377082948d76 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6056: 84e6a7e19ccc7fafc46f372e756cad9d4aa093f7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19890: 35268f22aac5bbddacc462e2f62235a6edae2164 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
35268f22aac5 drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/index.html
[-- Attachment #1.2: Type: text/html, Size: 6449 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
` (2 preceding siblings ...)
2021-04-01 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-04-02 3:10 ` Patchwork
2021-04-13 20:06 ` [Intel-gfx] [PATCH] " Souza, Jose
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-04-02 3:10 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30295 bytes --]
== Series Details ==
Series: drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
URL : https://patchwork.freedesktop.org/series/88673/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9925_full -> Patchwork_19890_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19890_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19890_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19890_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_linear_blits@interruptible:
- shard-kbl: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl3/igt@gem_linear_blits@interruptible.html
#### Warnings ####
* igt@runner@aborted:
- shard-kbl: ([FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6], [FAIL][7], [FAIL][8], [FAIL][9]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#92]) -> ([FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14], [FAIL][15], [FAIL][16]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl6/igt@runner@aborted.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@runner@aborted.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl7/igt@runner@aborted.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@runner@aborted.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@runner@aborted.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl7/igt@runner@aborted.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@runner@aborted.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl7/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl7/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl3/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_19890_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][17] ([i915#3002])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl7/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@clone:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-snb7/igt@gem_ctx_persistence@clone.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2842]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl4/igt@gem_exec_fair@basic-none@vcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][21] -> [FAIL][22] ([i915#2842]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][25] ([i915#2842])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][26] -> [FAIL][27] ([i915#2842])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb4/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-many-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][28] ([i915#2389]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl6/igt@gem_exec_reloc@basic-many-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-kbl: NOTRUN -> [FAIL][29] ([i915#2389]) +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_fenced_exec_thrash@2-spare-fences:
- shard-glk: [PASS][30] -> [INCOMPLETE][31] ([i915#2055])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk7/igt@gem_fenced_exec_thrash@2-spare-fences.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk8/igt@gem_fenced_exec_thrash@2-spare-fences.html
* igt@gem_softpin@noreloc-s3:
- shard-kbl: NOTRUN -> [DMESG-WARN][32] ([i915#180]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3323])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][34] ([i915#3002])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@mmap-offset-invalidate-active@wb:
- shard-snb: NOTRUN -> [SKIP][35] ([fdo#109271]) +344 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-snb6/igt@gem_userptr_blits@mmap-offset-invalidate-active@wb.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][36] ([i915#2724])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-snb7/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][37] ([i915#3296])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl6/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [PASS][38] -> [SKIP][39] ([i915#1904])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][40] ([i915#454])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][41] -> [DMESG-WARN][42] ([i915#180])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-apl8/igt@i915_suspend@forcewake.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl6/igt@i915_suspend@forcewake.html
* igt@kms_big_joiner@basic:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl6/igt@kms_big_joiner@basic.html
* igt@kms_big_joiner@invalid-modeset:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2705])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +20 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@hdmi-audio-edid:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk8/igt@kms_chamelium@hdmi-audio-edid.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl6/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +15 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-snb5/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][50] ([i915#1319])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_content_protection@atomic-dpms.html
* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#52] / [i915#54])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-blt-ytiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: NOTRUN -> [INCOMPLETE][53] ([i915#180])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][54] -> [FAIL][55] ([i915#79])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) +4 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2672])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271]) +17 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271]) +69 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271]) +187 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][62] -> [FAIL][63] ([i915#1188])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][65] ([i915#265])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-tglb: [PASS][68] -> [SKIP][69] ([i915#2920]) +19 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb8/igt@kms_psr2_sf@cursor-plane-update-sf.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb7/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) +6 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-skl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl1/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html
* igt@kms_psr2_su@page_flip:
- shard-tglb: [PASS][74] -> [SKIP][75] ([i915#1911])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb3/igt@kms_psr2_su@page_flip.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb6/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][76] -> [SKIP][77] ([fdo#109441]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: [PASS][78] -> [FAIL][79] ([i915#132]) +19 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][80] -> [FAIL][81] ([i915#132])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-a-query-busy-hang:
- shard-kbl: [PASS][82] -> [DMESG-WARN][83] ([i915#1982])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl3/igt@kms_vblank@pipe-a-query-busy-hang.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_vblank@pipe-a-query-busy-hang.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-skl: [PASS][84] -> [INCOMPLETE][85] ([i915#198])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl10/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][86] ([i915#180])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][88] -> [FAIL][89] ([i915#1722])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl9/igt@perf@polling-small-buf.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl9/igt@perf@polling-small-buf.html
* igt@prime_nv_pcopy@test1_macro:
- shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271]) +15 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk8/igt@prime_nv_pcopy@test1_macro.html
* igt@sysfs_clients@pidname:
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl1/igt@sysfs_clients@pidname.html
* igt@sysfs_clients@sema-25:
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl6/igt@sysfs_clients@sema-25.html
* igt@sysfs_clients@split-25:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2994])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][94] ([i915#2410]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb5/igt@gem_ctx_persistence@many-contexts.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_ctx_shared@create-shared-gtt:
- shard-glk: [INCOMPLETE][96] -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk8/igt@gem_ctx_shared@create-shared-gtt.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk8/igt@gem_ctx_shared@create-shared-gtt.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][98] ([i915#3063]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb2/igt@gem_eio@in-flight-contexts-10ms.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb3/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-skl: [TIMEOUT][100] ([i915#3063]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl7/igt@gem_eio@in-flight-contexts-immediate.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl10/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][102] ([i915#2369] / [i915#3063]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb2/igt@gem_eio@unwedge-stress.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][104] ([i915#2842]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][106] ([fdo#109271]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][108] ([i915#2842]) -> [PASS][109] +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-normal-all:
- shard-glk: [DMESG-WARN][110] ([i915#118] / [i915#95]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk4/igt@gem_exec_whisper@basic-normal-all.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk7/igt@gem_exec_whisper@basic-normal-all.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][112] ([i915#2190]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb5/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-iclb: [FAIL][114] ([i915#307]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb1/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb4/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][116] ([i915#72]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-tglb: [FAIL][118] ([i915#2346]) -> [PASS][119] +3 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][120] ([i915#155] / [i915#180] / [i915#636]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-tglb: [FAIL][122] ([i915#2122]) -> [PASS][123] +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb1/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb8/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [FAIL][124] ([i915#79]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][126] ([i915#180]) -> [PASS][127] +4 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][128] ([i915#180]) -> [PASS][129] +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][130] ([i915#2122]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][132] ([i915#180] / [i915#533]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][134] ([fdo#108145] / [i915#265]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@perf@blocking:
- shard-skl: [FAIL][136] ([i915#1542]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-skl7/igt@perf@blocking.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-skl2/igt@perf@blocking.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [SKIP][138] ([fdo#109271]) -> [FAIL][139] ([i915#2842]) +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][140] ([i915#2681] / [i915#2684]) -> [WARN][141] ([i915#1804] / [i915#2684])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_su@frontbuffer:
- shard-tglb: [FAIL][142] ([i915#2596]) -> [SKIP][143] ([i915#1911])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-tglb5/igt@kms_psr2_su@frontbuffer.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-tglb5/igt@kms_psr2_su@frontbuffer.html
- shard-iclb: [SKIP][144] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [SKIP][145] ([i915#1911])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][146] ([fdo#109441]) -> [FAIL][147] ([i915#132]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@runner@aborted:
- shard-apl: ([FAIL][148], [FAIL][149], [FAIL][150]) ([i915#1610] / [i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155]) ([i915#180] / [i915#1814] / [i915#3002])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-apl8/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-apl7/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9925/shard-apl8/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl1/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl6/igt@runner@aborted.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/shard-apl8/igt@runner@aborted.html
[155]: https://intel
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19890/index.html
[-- Attachment #1.2: Type: text/html, Size: 33811 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
` (3 preceding siblings ...)
2021-04-02 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2021-04-13 20:06 ` Souza, Jose
4 siblings, 0 replies; 6+ messages in thread
From: Souza, Jose @ 2021-04-13 20:06 UTC (permalink / raw)
To: Mun, Gwan-gyeong, intel-gfx
On Thu, 2021-04-01 at 20:05 +0300, Gwan-gyeong Mun wrote:
> As per b.spec 49274, the IO buffer Wake lines and Fast Wake lines can be
> calculated based on the following formula.
>
> IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds)
> Fast wake lines = ROUNDUP(PSR2 aux transaction time / total line time in microseconds)
> For both fields limit the minimum to 7 lines and maximum to 12 lines
> PSR2 IO wake time = 50us, PSR2 aux transaction time = 32us.
>
> It calculates IO buffer Wake and Fast Wake based on b.spec 49274 and
> programs it.
>
> v2: Address Jose's review comment.
> - Do not overwrite the values.
> - Move calulating and validating of io_buffer_wake/fast_wake to
> intel_psr2_config_valid() from intel_psr_compute_config()
> - Add macros for hardcoded values.
> - Simplify and reuse the validating the io_buffer_wake/fast_wake.
>
> v3: Rebased
>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Lee Shawn C <shawn.c.lee@intel.com>
> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> ---
> .../drm/i915/display/intel_display_types.h | 2 +
> drivers/gpu/drm/i915/display/intel_psr.c | 65 +++++++++++++++----
> drivers/gpu/drm/i915/i915_reg.h | 8 +++
> 3 files changed, 63 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index e2e707c4dff5..79df8da9b89e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1496,6 +1496,8 @@ struct intel_psr {
> u16 su_x_granularity;
> bool dc3co_enabled;
> u32 dc3co_exit_delay;
> + u32 io_buffer_wake;
> + u32 fast_wake;
> struct delayed_work dc3co_work;
> struct drm_dp_vsc_sdp vsc;
> };
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 54ad5c378355..a1fff724fb67 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -531,19 +531,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
> val |= intel_psr2_get_tp_time(intel_dp);
>
>
>
>
>
>
>
>
> if (DISPLAY_VER(dev_priv) >= 12) {
> - /*
> - * TODO: 7 lines of IO_BUFFER_WAKE and FAST_WAKE are default
> - * values from BSpec. In order to setting an optimal power
> - * consumption, lower than 4k resoluition mode needs to decrese
> - * IO_BUFFER_WAKE and FAST_WAKE. And higher than 4K resolution
> - * mode needs to increase IO_BUFFER_WAKE and FAST_WAKE.
> - */
> - val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_2;
> - val |= TGL_EDP_PSR2_IO_BUFFER_WAKE(7);
> - val |= TGL_EDP_PSR2_FAST_WAKE(7);
> + if (intel_dp->psr.io_buffer_wake < 9 || intel_dp->psr.fast_wake < 9)
> + val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_2;
> + else
> + val |= TGL_EDP_PSR2_BLOCK_COUNT_NUM_3;
> + val |= TGL_EDP_PSR2_IO_BUFFER_WAKE(intel_dp->psr.io_buffer_wake);
> + val |= TGL_EDP_PSR2_FAST_WAKE(intel_dp->psr.fast_wake);
> } else if (DISPLAY_VER(dev_priv) >= 9) {
> - val |= EDP_PSR2_IO_BUFFER_WAKE(7);
> - val |= EDP_PSR2_FAST_WAKE(7);
> + val |= EDP_PSR2_IO_BUFFER_WAKE(intel_dp->psr.io_buffer_wake);
> + val |= EDP_PSR2_FAST_WAKE(intel_dp->psr.fast_wake);
> }
>
>
>
>
>
>
>
>
> if (intel_dp->psr.psr2_sel_fetch_enabled) {
> @@ -724,7 +720,9 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
> struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> int crtc_hdisplay = crtc_state->hw.adjusted_mode.crtc_hdisplay;
> int crtc_vdisplay = crtc_state->hw.adjusted_mode.crtc_vdisplay;
> + u32 io_buffer_wake, io_buffer_wake_max, io_buffer_wake_min;
> int psr_max_h = 0, psr_max_v = 0, max_bpp = 0;
> + u32 fast_wake, fast_wake_max, fast_wake_min;
>
>
>
>
>
>
>
>
> if (!intel_dp->psr.sink_psr2_support)
> return false;
> @@ -768,14 +766,26 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
> psr_max_h = 5120;
> psr_max_v = 3200;
> max_bpp = 30;
> + io_buffer_wake_max = TGL_EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
> + io_buffer_wake_min = TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
> + fast_wake_max = TGL_EDP_PSR2_FAST_WAKE_MAX_LINES;
> + fast_wake_min = TGL_EDP_PSR2_FAST_WAKE_MIN_LINES;
> } else if (DISPLAY_VER(dev_priv) >= 10) {
> psr_max_h = 4096;
> psr_max_v = 2304;
> max_bpp = 24;
> + io_buffer_wake_max = EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
> + io_buffer_wake_min = EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
> + fast_wake_max = EDP_PSR2_FAST_WAKE_MAX_LINES;
> + fast_wake_min = EDP_PSR2_FAST_WAKE_MIN_LINES;
> } else if (IS_DISPLAY_VER(dev_priv, 9)) {
> psr_max_h = 3640;
> psr_max_v = 2304;
> max_bpp = 24;
> + io_buffer_wake_max = EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES;
> + io_buffer_wake_min = EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES;
> + fast_wake_max = EDP_PSR2_FAST_WAKE_MAX_LINES;
> + fast_wake_min = EDP_PSR2_FAST_WAKE_MIN_LINES;
> }
>
>
>
>
>
>
>
>
> if (crtc_state->pipe_bpp > max_bpp) {
> @@ -785,6 +795,37 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
> return false;
> }
>
>
>
>
>
>
>
>
> + /*
> + * B.Spec 49274
> + * IO buffer wake lines = ROUNDUP(PSR2 IO wake time / total line time in microseconds)
> + * Fast wake lines = ROUNDUP(PSR2 aux transaction time / total line time in microseconds)
> + * For both fields limit the minimum to 7 lines and maximum to 12 lines
> + * PSR2 IO wake time = 50us, PSR2 aux transaction time = 32us.
> + */
> + io_buffer_wake = intel_usecs_to_scanlines(&crtc_state->uapi.adjusted_mode,
> + EDP_PSR2_IO_WAKE_TIME);
> + fast_wake = intel_usecs_to_scanlines(&crtc_state->uapi.adjusted_mode,
> + EDP_PSR2_AUX_TRANSACTION_TIME);
> +
> + if (io_buffer_wake < io_buffer_wake_min || io_buffer_wake > io_buffer_wake_max) {
> + drm_dbg_kms(&dev_priv->drm,
> + "PSR condition failed: Invalid PSR2 IO Buffer Wake lines (%d)\n",
> + io_buffer_wake);
> + return false;
> + }
> +
> + if (fast_wake < fast_wake_min || fast_wake > fast_wake_max) {
> + drm_dbg_kms(&dev_priv->drm,
> + "PSR condition failed: Invalid PSR2 FAST Wake lines (%d)\n",
> + fast_wake);
> + return false;
> + }
> +
> + intel_dp->psr.io_buffer_wake =
> + io_buffer_wake < EDP_PSR2_IO_BUFFER_WAKE_DEFAULT ? EDP_PSR2_IO_BUFFER_WAKE_DEFAULT : io_buffer_wake;
> + intel_dp->psr.fast_wake =
> + fast_wake < EDP_PSR2_FAST_WAKE_DEFAULT ? EDP_PSR2_FAST_WAKE_DEFAULT : fast_wake;
> +
> /*
> * HW sends SU blocks of size four scan lines, which means the starting
> * X coordinate and Y granularity requirements will always be met. We
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index cbf7a60afe54..0fc121720364 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4568,14 +4568,22 @@ enum {
> #define EDP_MAX_SU_DISABLE_TIME(t) ((t) << 20)
> #define EDP_MAX_SU_DISABLE_TIME_MASK (0x1f << 20)
> #define EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES 8
> +#define EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES 5
> +#define EDP_PSR2_IO_BUFFER_WAKE_DEFAULT 7
> #define EDP_PSR2_IO_BUFFER_WAKE(lines) ((EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES - (lines)) << 13)
> #define EDP_PSR2_IO_BUFFER_WAKE_MASK (3 << 13)
> +#define EDP_PSR2_IO_WAKE_TIME 50
gen12+ page says that this is 42us, so I guess we will need different values for gen12+ and older.
With that fixed:
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> +#define TGL_EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES 12
> #define TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES 5
> #define TGL_EDP_PSR2_IO_BUFFER_WAKE(lines) (((lines) - TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES) << 13)
> #define TGL_EDP_PSR2_IO_BUFFER_WAKE_MASK (7 << 13)
> #define EDP_PSR2_FAST_WAKE_MAX_LINES 8
> +#define EDP_PSR2_FAST_WAKE_MIN_LINES 5
> +#define EDP_PSR2_FAST_WAKE_DEFAULT 7
> #define EDP_PSR2_FAST_WAKE(lines) ((EDP_PSR2_FAST_WAKE_MAX_LINES - (lines)) << 11)
> #define EDP_PSR2_FAST_WAKE_MASK (3 << 11)
> +#define EDP_PSR2_AUX_TRANSACTION_TIME 32
> +#define TGL_EDP_PSR2_FAST_WAKE_MAX_LINES 12
> #define TGL_EDP_PSR2_FAST_WAKE_MIN_LINES 5
> #define TGL_EDP_PSR2_FAST_WAKE(lines) (((lines) - TGL_EDP_PSR2_FAST_WAKE_MIN_LINES) << 10)
> #define TGL_EDP_PSR2_FAST_WAKE_MASK (7 << 10)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-13 20:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01 17:05 [Intel-gfx] [PATCH] drm/i915/display/psr: Configure and Program IO buffer Wake and Fast Wake Gwan-gyeong Mun
2021-04-01 20:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-04-01 20:50 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-04-01 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-02 3:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-13 20:06 ` [Intel-gfx] [PATCH] " Souza, Jose
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.