* [PATCH 0/2] Fix for a bug and a kernel-doc warning in Xilinx DWC3
@ 2021-04-08 17:54 ` Manish Narani
0 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
This patch series resolves a kernel-doc warning and a clk freeing bug
that was causing a crash.
This patch series is on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/dwc3?id=84770f028fabab4cb66188d583ed12652f30576b
Manish Narani (2):
usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver
usb: dwc3: xilinx: Remove the extra freeing of clocks
drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--
2.1.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] Fix for a bug and a kernel-doc warning in Xilinx DWC3
@ 2021-04-08 17:54 ` Manish Narani
0 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
This patch series resolves a kernel-doc warning and a clk freeing bug
that was causing a crash.
This patch series is on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/dwc3?id=84770f028fabab4cb66188d583ed12652f30576b
Manish Narani (2):
usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver
usb: dwc3: xilinx: Remove the extra freeing of clocks
drivers/usb/dwc3/dwc3-xilinx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--
2.1.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver
2021-04-08 17:54 ` Manish Narani
@ 2021-04-08 17:54 ` Manish Narani
-1 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
The kernel-doc run gave a warning for Xilinx DWC3 driver:
drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for
dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead
Basically it was due to an extra '*' in line:2. This patch fixes the same.
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index a59e149..f42f4cb 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* dwc3-xilinx.c - Xilinx DWC3 controller specific glue driver
*
* Authors: Manish Narani <manish.narani@xilinx.com>
--
2.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver
@ 2021-04-08 17:54 ` Manish Narani
0 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
The kernel-doc run gave a warning for Xilinx DWC3 driver:
drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for
dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead
Basically it was due to an extra '*' in line:2. This patch fixes the same.
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index a59e149..f42f4cb 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* dwc3-xilinx.c - Xilinx DWC3 controller specific glue driver
*
* Authors: Manish Narani <manish.narani@xilinx.com>
--
2.1.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks
2021-04-08 17:54 ` Manish Narani
@ 2021-04-08 17:54 ` Manish Narani
-1 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.
Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index f42f4cb..9cc3ad7 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
return ret;
}
@@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
of_platform_depopulate(dev);
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0;
pm_runtime_disable(dev);
--
2.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks
@ 2021-04-08 17:54 ` Manish Narani
0 siblings, 0 replies; 6+ messages in thread
From: Manish Narani @ 2021-04-08 17:54 UTC (permalink / raw)
To: gregkh, michal.simek, balbi
Cc: git, linux-usb, linux-arm-kernel, linux-kernel, Manish Narani
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.
Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index f42f4cb..9cc3ad7 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
return ret;
}
@@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
of_platform_depopulate(dev);
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0;
pm_runtime_disable(dev);
--
2.1.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-08 17:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 17:54 [PATCH 0/2] Fix for a bug and a kernel-doc warning in Xilinx DWC3 Manish Narani
2021-04-08 17:54 ` Manish Narani
2021-04-08 17:54 ` [PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver Manish Narani
2021-04-08 17:54 ` Manish Narani
2021-04-08 17:54 ` [PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks Manish Narani
2021-04-08 17:54 ` Manish Narani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.