* [PATCH] drm/radeon/cik: remove set but not used variables
@ 2021-04-13 3:26 ` Tian Tao
0 siblings, 0 replies; 4+ messages in thread
From: Tian Tao @ 2021-04-13 3:26 UTC (permalink / raw)
To: airlied, daniel, sumit.semwal; +Cc: Tian Tao, dri-devel, amd-gfx
The value of pipe_id and queue_id are not used under certain
circumstances, so just delete.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/radeon/cik.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
index 8b7a4f7..42a8afa 100644
--- a/drivers/gpu/drm/radeon/cik.c
+++ b/drivers/gpu/drm/radeon/cik.c
@@ -7948,8 +7948,6 @@ int cik_irq_process(struct radeon_device *rdev)
DRM_ERROR("Illegal register access in command stream\n");
/* XXX check the bitfield order! */
me_id = (ring_id & 0x60) >> 5;
- pipe_id = (ring_id & 0x18) >> 3;
- queue_id = (ring_id & 0x7) >> 0;
switch (me_id) {
case 0:
/* This results in a full GPU reset, but all we need to do is soft
@@ -7971,8 +7969,6 @@ int cik_irq_process(struct radeon_device *rdev)
DRM_ERROR("Illegal instruction in command stream\n");
/* XXX check the bitfield order! */
me_id = (ring_id & 0x60) >> 5;
- pipe_id = (ring_id & 0x18) >> 3;
- queue_id = (ring_id & 0x7) >> 0;
switch (me_id) {
case 0:
/* This results in a full GPU reset, but all we need to do is soft
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/radeon/cik: remove set but not used variables
@ 2021-04-13 3:26 ` Tian Tao
0 siblings, 0 replies; 4+ messages in thread
From: Tian Tao @ 2021-04-13 3:26 UTC (permalink / raw)
To: airlied, daniel, sumit.semwal; +Cc: Tian Tao, dri-devel, amd-gfx
The value of pipe_id and queue_id are not used under certain
circumstances, so just delete.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/radeon/cik.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
index 8b7a4f7..42a8afa 100644
--- a/drivers/gpu/drm/radeon/cik.c
+++ b/drivers/gpu/drm/radeon/cik.c
@@ -7948,8 +7948,6 @@ int cik_irq_process(struct radeon_device *rdev)
DRM_ERROR("Illegal register access in command stream\n");
/* XXX check the bitfield order! */
me_id = (ring_id & 0x60) >> 5;
- pipe_id = (ring_id & 0x18) >> 3;
- queue_id = (ring_id & 0x7) >> 0;
switch (me_id) {
case 0:
/* This results in a full GPU reset, but all we need to do is soft
@@ -7971,8 +7969,6 @@ int cik_irq_process(struct radeon_device *rdev)
DRM_ERROR("Illegal instruction in command stream\n");
/* XXX check the bitfield order! */
me_id = (ring_id & 0x60) >> 5;
- pipe_id = (ring_id & 0x18) >> 3;
- queue_id = (ring_id & 0x7) >> 0;
switch (me_id) {
case 0:
/* This results in a full GPU reset, but all we need to do is soft
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon/cik: remove set but not used variables
2021-04-13 3:26 ` Tian Tao
@ 2021-04-15 16:20 ` Alex Deucher
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-04-15 16:20 UTC (permalink / raw)
To: Tian Tao; +Cc: Dave Airlie, Maling list - DRI developers, amd-gfx list
On Mon, Apr 12, 2021 at 11:26 PM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> The value of pipe_id and queue_id are not used under certain
> circumstances, so just delete.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/radeon/cik.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 8b7a4f7..42a8afa 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -7948,8 +7948,6 @@ int cik_irq_process(struct radeon_device *rdev)
> DRM_ERROR("Illegal register access in command stream\n");
> /* XXX check the bitfield order! */
> me_id = (ring_id & 0x60) >> 5;
> - pipe_id = (ring_id & 0x18) >> 3;
> - queue_id = (ring_id & 0x7) >> 0;
> switch (me_id) {
> case 0:
> /* This results in a full GPU reset, but all we need to do is soft
> @@ -7971,8 +7969,6 @@ int cik_irq_process(struct radeon_device *rdev)
> DRM_ERROR("Illegal instruction in command stream\n");
> /* XXX check the bitfield order! */
> me_id = (ring_id & 0x60) >> 5;
> - pipe_id = (ring_id & 0x18) >> 3;
> - queue_id = (ring_id & 0x7) >> 0;
> switch (me_id) {
> case 0:
> /* This results in a full GPU reset, but all we need to do is soft
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/radeon/cik: remove set but not used variables
@ 2021-04-15 16:20 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-04-15 16:20 UTC (permalink / raw)
To: Tian Tao
Cc: Dave Airlie, Maling list - DRI developers, amd-gfx list,
Sumit Semwal, Daniel Vetter
On Mon, Apr 12, 2021 at 11:26 PM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> The value of pipe_id and queue_id are not used under certain
> circumstances, so just delete.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/radeon/cik.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 8b7a4f7..42a8afa 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -7948,8 +7948,6 @@ int cik_irq_process(struct radeon_device *rdev)
> DRM_ERROR("Illegal register access in command stream\n");
> /* XXX check the bitfield order! */
> me_id = (ring_id & 0x60) >> 5;
> - pipe_id = (ring_id & 0x18) >> 3;
> - queue_id = (ring_id & 0x7) >> 0;
> switch (me_id) {
> case 0:
> /* This results in a full GPU reset, but all we need to do is soft
> @@ -7971,8 +7969,6 @@ int cik_irq_process(struct radeon_device *rdev)
> DRM_ERROR("Illegal instruction in command stream\n");
> /* XXX check the bitfield order! */
> me_id = (ring_id & 0x60) >> 5;
> - pipe_id = (ring_id & 0x18) >> 3;
> - queue_id = (ring_id & 0x7) >> 0;
> switch (me_id) {
> case 0:
> /* This results in a full GPU reset, but all we need to do is soft
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-15 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 3:26 [PATCH] drm/radeon/cik: remove set but not used variables Tian Tao
2021-04-13 3:26 ` Tian Tao
2021-04-15 16:20 ` Alex Deucher
2021-04-15 16:20 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.