* [PATCH] media: solo6x10: remove useless function
@ 2021-04-13 7:23 Jiapeng Chong
2021-04-13 10:02 ` Ismael Luceno
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-13 7:23 UTC (permalink / raw)
To: maintainers
Cc: anton, andrey_utkin, ismael, mchehab, linux-media, linux-kernel,
Jiapeng Chong
Fix the following clang warning:
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused
function 'vop_interlaced' [-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
index 0abcad4..8c4fae7 100644
--- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
+++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
@@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip,
}
/* Extract values from VOP header - VE_STATUSxx */
-static inline int vop_interlaced(const vop_header *vh)
-{
- return (__le32_to_cpu((*vh)[0]) >> 30) & 1;
-}
-
static inline u8 vop_channel(const vop_header *vh)
{
return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: solo6x10: remove useless function
2021-04-13 7:23 [PATCH] media: solo6x10: remove useless function Jiapeng Chong
@ 2021-04-13 10:02 ` Ismael Luceno
0 siblings, 0 replies; 2+ messages in thread
From: Ismael Luceno @ 2021-04-13 10:02 UTC (permalink / raw)
To: Jiapeng Chong
Cc: maintainers, anton, andrey_utkin, mchehab, linux-media, linux-kernel
NACK; before removing any of these functions the fields should be
documented somewhere else, so that no information is lost.
On 13/Apr/2021 15:23, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c:394:19: warning: unused
> function 'vop_interlaced' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> index 0abcad4..8c4fae7 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
> @@ -391,11 +391,6 @@ static int solo_send_desc(struct solo_enc_dev *solo_enc, int skip,
> }
>
> /* Extract values from VOP header - VE_STATUSxx */
> -static inline int vop_interlaced(const vop_header *vh)
> -{
> - return (__le32_to_cpu((*vh)[0]) >> 30) & 1;
> -}
> -
> static inline u8 vop_channel(const vop_header *vh)
> {
> return (__le32_to_cpu((*vh)[0]) >> 24) & 0x1F;
> --
> 1.8.3.1
>
--
Ismael Luceno
http://iodev.co.uk/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 7:23 [PATCH] media: solo6x10: remove useless function Jiapeng Chong
2021-04-13 10:02 ` Ismael Luceno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.