* [PATCH] drm/amdgpu: remove set but not used variables
@ 2021-04-13 8:03 ` Tian Tao
0 siblings, 0 replies; 2+ messages in thread
From: Tian Tao @ 2021-04-13 8:03 UTC (permalink / raw)
To: airlied, daniel; +Cc: Tian Tao, dri-devel, amd-gfx
The value of ret set but will rewriten, so just delete.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 1fb2a91..f303ad6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1815,10 +1815,8 @@ int amdgpu_ras_recovery_init(struct amdgpu_device *adev)
return 0;
*data = kmalloc(sizeof(**data), GFP_KERNEL | __GFP_ZERO);
- if (!*data) {
- ret = -ENOMEM;
- goto out;
- }
+ if (!*data)
+ return -ENOMEM;
mutex_init(&con->recovery_lock);
INIT_WORK(&con->recovery_work, amdgpu_ras_do_recovery);
@@ -1848,7 +1846,7 @@ int amdgpu_ras_recovery_init(struct amdgpu_device *adev)
kfree((*data)->bps);
kfree(*data);
con->eh_data = NULL;
-out:
+
dev_warn(adev->dev, "Failed to initialize ras recovery!\n");
/*
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/amdgpu: remove set but not used variables
@ 2021-04-13 8:03 ` Tian Tao
0 siblings, 0 replies; 2+ messages in thread
From: Tian Tao @ 2021-04-13 8:03 UTC (permalink / raw)
To: airlied, daniel; +Cc: Tian Tao, dri-devel, amd-gfx
The value of ret set but will rewriten, so just delete.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 1fb2a91..f303ad6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1815,10 +1815,8 @@ int amdgpu_ras_recovery_init(struct amdgpu_device *adev)
return 0;
*data = kmalloc(sizeof(**data), GFP_KERNEL | __GFP_ZERO);
- if (!*data) {
- ret = -ENOMEM;
- goto out;
- }
+ if (!*data)
+ return -ENOMEM;
mutex_init(&con->recovery_lock);
INIT_WORK(&con->recovery_work, amdgpu_ras_do_recovery);
@@ -1848,7 +1846,7 @@ int amdgpu_ras_recovery_init(struct amdgpu_device *adev)
kfree((*data)->bps);
kfree(*data);
con->eh_data = NULL;
-out:
+
dev_warn(adev->dev, "Failed to initialize ras recovery!\n");
/*
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 8:03 [PATCH] drm/amdgpu: remove set but not used variables Tian Tao
2021-04-13 8:03 ` Tian Tao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.