* [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe()
@ 2021-04-08 10:01 Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ruiqi Gong @ 2021-04-08 10:01 UTC (permalink / raw)
To: gongruiqi1, Talel Shenhar, Zhang Rui, Daniel Lezcano
Cc: Wang Weiyang, linux-pm, kernel-janitors, linux-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
---
drivers/thermal/thermal_mmio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
index d0bdf1ea3331..ded1dd0d4ef7 100644
--- a/drivers/thermal/thermal_mmio.c
+++ b/drivers/thermal/thermal_mmio.c
@@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
- if (IS_ERR(sensor->mmio_base)) {
- dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
- PTR_ERR(sensor->mmio_base));
+ if (IS_ERR(sensor->mmio_base))
return PTR_ERR(sensor->mmio_base);
- }
sensor_init_func = device_get_match_data(&pdev->dev);
if (sensor_init_func) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe()
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
@ 2021-04-08 10:01 ` Shenhar, Talel
2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/thermal_mmio: Remove " thermal-bot for Ruiqi Gong
2021-04-20 7:20 ` thermal-bot for Ruiqi Gong
2 siblings, 0 replies; 4+ messages in thread
From: Shenhar, Talel @ 2021-04-08 10:01 UTC (permalink / raw)
To: Ruiqi Gong, Zhang Rui, Daniel Lezcano
Cc: Wang Weiyang, linux-pm, kernel-janitors, linux-kernel,
Ronen Krupnik, talelshenhar, talel
On 4/8/2021 1:01 PM, Ruiqi Gong wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
> ---
> drivers/thermal/thermal_mmio.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index d0bdf1ea3331..ded1dd0d4ef7 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
>
> resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
> - if (IS_ERR(sensor->mmio_base)) {
> - dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
> - PTR_ERR(sensor->mmio_base));
> + if (IS_ERR(sensor->mmio_base))
> return PTR_ERR(sensor->mmio_base);
> - }
>
> sensor_init_func = device_get_match_data(&pdev->dev);
> if (sensor_init_func) {
Acked-by: Talel Shenhar <talel@amazon.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [thermal: thermal/next] thermal/drivers/thermal_mmio: Remove redundant dev_err call in thermal_mmio_probe()
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
@ 2021-04-15 12:03 ` thermal-bot for Ruiqi Gong
2021-04-20 7:20 ` thermal-bot for Ruiqi Gong
2 siblings, 0 replies; 4+ messages in thread
From: thermal-bot for Ruiqi Gong @ 2021-04-15 12:03 UTC (permalink / raw)
To: linux-pm
Cc: Hulk Robot, Ruiqi Gong, Talel Shenhar, Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: c8671d70b29d72d590678eee59d5891eee8d9d2e
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//c8671d70b29d72d590678eee59d5891eee8d9d2e
Author: Ruiqi Gong <gongruiqi1@huawei.com>
AuthorDate: Thu, 08 Apr 2021 06:01:44 -04:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 15 Apr 2021 13:21:43 +02:00
thermal/drivers/thermal_mmio: Remove redundant dev_err call in thermal_mmio_probe()
There is a error message within devm_ioremap_resource already, so
remove the dev_err call to avoid redundant error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
Acked-by: Talel Shenhar <talel@amazon.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210408100144.7494-1-gongruiqi1@huawei.com
---
drivers/thermal/thermal_mmio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
index d0bdf1e..ded1dd0 100644
--- a/drivers/thermal/thermal_mmio.c
+++ b/drivers/thermal/thermal_mmio.c
@@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
- if (IS_ERR(sensor->mmio_base)) {
- dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
- PTR_ERR(sensor->mmio_base));
+ if (IS_ERR(sensor->mmio_base))
return PTR_ERR(sensor->mmio_base);
- }
sensor_init_func = device_get_match_data(&pdev->dev);
if (sensor_init_func) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* [thermal: thermal/next] thermal/drivers/thermal_mmio: Remove redundant dev_err call in thermal_mmio_probe()
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/thermal_mmio: Remove " thermal-bot for Ruiqi Gong
@ 2021-04-20 7:20 ` thermal-bot for Ruiqi Gong
2 siblings, 0 replies; 4+ messages in thread
From: thermal-bot for Ruiqi Gong @ 2021-04-20 7:20 UTC (permalink / raw)
To: linux-pm
Cc: Hulk Robot, Ruiqi Gong, Talel Shenhar, Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 8cd7ab2a1a393f37f2e2f4b3ff595d98c245b854
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//8cd7ab2a1a393f37f2e2f4b3ff595d98c245b854
Author: Ruiqi Gong <gongruiqi1@huawei.com>
AuthorDate: Thu, 08 Apr 2021 06:01:44 -04:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 20 Apr 2021 08:58:47 +02:00
thermal/drivers/thermal_mmio: Remove redundant dev_err call in thermal_mmio_probe()
There is a error message within devm_ioremap_resource already, so
remove the dev_err call to avoid redundant error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
Acked-by: Talel Shenhar <talel@amazon.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210408100144.7494-1-gongruiqi1@huawei.com
---
drivers/thermal/thermal_mmio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
index d0bdf1e..ded1dd0 100644
--- a/drivers/thermal/thermal_mmio.c
+++ b/drivers/thermal/thermal_mmio.c
@@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
- if (IS_ERR(sensor->mmio_base)) {
- dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
- PTR_ERR(sensor->mmio_base));
+ if (IS_ERR(sensor->mmio_base))
return PTR_ERR(sensor->mmio_base);
- }
sensor_init_func = device_get_match_data(&pdev->dev);
if (sensor_init_func) {
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-20 7:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/thermal_mmio: Remove " thermal-bot for Ruiqi Gong
2021-04-20 7:20 ` thermal-bot for Ruiqi Gong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.