* [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
@ 2021-04-20 19:12 Rodrigo Vivi
2021-04-20 19:38 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (7 more replies)
0 siblings, 8 replies; 13+ messages in thread
From: Rodrigo Vivi @ 2021-04-20 19:12 UTC (permalink / raw)
To: intel-gfx
Although this abstraction removes the convenience of grepping
for the file name, it:
- makes addition easier.
- makes it easier to tweak global path when experiments are needed.
- get in sync with guc/huc, without getting overly abstracted.
- allows future junction with CSR_VERSION for simplicity.
- Enforces dmc file will never change this standard.
Cc: Fei Yang <fei.yang@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/display/intel_csr.c | 20 ++++++++++----------
drivers/gpu/drm/i915/display/intel_csr.h | 6 ++++++
2 files changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
index 26a3c6787e9e..ad68bcc611c4 100644
--- a/drivers/gpu/drm/i915/display/intel_csr.c
+++ b/drivers/gpu/drm/i915/display/intel_csr.c
@@ -40,48 +40,48 @@
#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
-#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
+#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
#define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
MODULE_FIRMWARE(ADLS_CSR_PATH);
-#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
+#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
#define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
MODULE_FIRMWARE(DG1_CSR_PATH);
-#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
+#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
#define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
MODULE_FIRMWARE(RKL_CSR_PATH);
-#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
+#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
#define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
MODULE_FIRMWARE(TGL_CSR_PATH);
-#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
+#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
#define ICL_CSR_MAX_FW_SIZE 0x6000
MODULE_FIRMWARE(ICL_CSR_PATH);
-#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
+#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(CNL_CSR_PATH);
-#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
+#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
#define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
#define GLK_CSR_MAX_FW_SIZE 0x4000
MODULE_FIRMWARE(GLK_CSR_PATH);
-#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
+#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
#define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
#define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(KBL_CSR_PATH);
-#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
+#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
#define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
#define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(SKL_CSR_PATH);
-#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
+#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
#define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define BXT_CSR_MAX_FW_SIZE 0x3000
MODULE_FIRMWARE(BXT_CSR_PATH);
diff --git a/drivers/gpu/drm/i915/display/intel_csr.h b/drivers/gpu/drm/i915/display/intel_csr.h
index 03c64f8af7ab..fbfdaa3df07e 100644
--- a/drivers/gpu/drm/i915/display/intel_csr.h
+++ b/drivers/gpu/drm/i915/display/intel_csr.h
@@ -8,6 +8,12 @@
struct drm_i915_private;
+#define DMC_PATH(platform, major, minor) \
+ "i915/" \
+ __stringify(platform) "_dmc_ver" \
+ __stringify(major) "_" \
+ __stringify(minor) ".bin"
+
#define CSR_VERSION(major, minor) ((major) << 16 | (minor))
#define CSR_VERSION_MAJOR(version) ((version) >> 16)
#define CSR_VERSION_MINOR(version) ((version) & 0xffff)
--
2.30.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
@ 2021-04-20 19:38 ` Patchwork
2021-04-20 19:53 ` [Intel-gfx] [PATCH] " Souza, Jose
` (6 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-20 19:38 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path.
URL : https://patchwork.freedesktop.org/series/89275/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
2021-04-20 19:38 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
@ 2021-04-20 19:53 ` Souza, Jose
2021-04-20 20:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Souza, Jose @ 2021-04-20 19:53 UTC (permalink / raw)
To: Vivi, Rodrigo, intel-gfx
On Tue, 2021-04-20 at 15:12 -0400, Rodrigo Vivi wrote:
> Although this abstraction removes the convenience of grepping
> for the file name, it:
> - makes addition easier.
> - makes it easier to tweak global path when experiments are needed.
> - get in sync with guc/huc, without getting overly abstracted.
> - allows future junction with CSR_VERSION for simplicity.
> - Enforces dmc file will never change this standard.
>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_csr.c | 20 ++++++++++----------
> drivers/gpu/drm/i915/display/intel_csr.h | 6 ++++++
> 2 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
> index 26a3c6787e9e..ad68bcc611c4 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.c
> +++ b/drivers/gpu/drm/i915/display/intel_csr.c
> @@ -40,48 +40,48 @@
>
>
>
>
> #define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
>
>
>
>
> -#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
> +#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
> #define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
> MODULE_FIRMWARE(ADLS_CSR_PATH);
>
>
>
>
> -#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
> +#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
> #define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(DG1_CSR_PATH);
>
>
>
>
> -#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
> +#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
> #define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(RKL_CSR_PATH);
>
>
>
>
> -#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
> +#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
> #define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
> MODULE_FIRMWARE(TGL_CSR_PATH);
>
>
>
>
> -#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
> +#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_CSR_PATH);
>
>
>
>
> -#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
> +#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(CNL_CSR_PATH);
>
>
>
>
> -#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
> +#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define GLK_CSR_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_CSR_PATH);
>
>
>
>
> -#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
> +#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
> #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_CSR_PATH);
>
>
>
>
> -#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
> +#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
> #define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
> #define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_CSR_PATH);
>
>
>
>
> -#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
> +#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
> #define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define BXT_CSR_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_CSR_PATH);
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.h b/drivers/gpu/drm/i915/display/intel_csr.h
> index 03c64f8af7ab..fbfdaa3df07e 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.h
> +++ b/drivers/gpu/drm/i915/display/intel_csr.h
> @@ -8,6 +8,12 @@
>
>
>
>
> struct drm_i915_private;
>
>
>
>
> +#define DMC_PATH(platform, major, minor) \
> + "i915/" \
> + __stringify(platform) "_dmc_ver" \
> + __stringify(major) "_" \
> + __stringify(minor) ".bin"
> +
> #define CSR_VERSION(major, minor) ((major) << 16 | (minor))
> #define CSR_VERSION_MAJOR(version) ((version) >> 16)
> #define CSR_VERSION_MINOR(version) ((version) & 0xffff)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
2021-04-20 19:38 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-20 19:53 ` [Intel-gfx] [PATCH] " Souza, Jose
@ 2021-04-20 20:02 ` Patchwork
2021-04-20 20:40 ` [Intel-gfx] [PATCH] " Lucas De Marchi
` (4 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-20 20:02 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2495 bytes --]
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path.
URL : https://patchwork.freedesktop.org/series/89275/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9988 -> Patchwork_19957
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/index.html
Known issues
------------
Here are the changes found in Patchwork_19957 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/fi-tgl-y/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][2] -> [INCOMPLETE][3] ([i915#2782])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-icl-u2: [PASS][4] -> [DMESG-WARN][5] ([i915#1226])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/fi-icl-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/fi-icl-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
Participating hosts (41 -> 39)
------------------------------
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9988 -> Patchwork_19957
CI-20190529: 20190529
CI_DRM_9988: 431bd0cbb466ae58900e298116cda861dd7fd860 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6071: d293ad78a035dcf681345ca15e0256e0c3b1e7bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19957: da8ade7b5d5563b73f66dcbec0fec17d26260d8e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
da8ade7b5d55 drm/i915/dmc: Let's abstract the dmc path.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/index.html
[-- Attachment #1.2: Type: text/html, Size: 3153 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
` (2 preceding siblings ...)
2021-04-20 20:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2021-04-20 20:40 ` Lucas De Marchi
2021-04-21 9:44 ` Rodrigo Vivi
2021-04-21 0:13 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
` (3 subsequent siblings)
7 siblings, 1 reply; 13+ messages in thread
From: Lucas De Marchi @ 2021-04-20 20:40 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Intel Graphics
On Tue, Apr 20, 2021 at 12:12 PM Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>
> Although this abstraction removes the convenience of grepping
> for the file name, it:
> - makes addition easier.
> - makes it easier to tweak global path when experiments are needed.
> - get in sync with guc/huc, without getting overly abstracted.
> - allows future junction with CSR_VERSION for simplicity.
> - Enforces dmc file will never change this standard.
>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_csr.c | 20 ++++++++++----------
> drivers/gpu/drm/i915/display/intel_csr.h | 6 ++++++
> 2 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
> index 26a3c6787e9e..ad68bcc611c4 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.c
> +++ b/drivers/gpu/drm/i915/display/intel_csr.c
> @@ -40,48 +40,48 @@
>
> #define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
>
> -#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
> +#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
> #define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
> MODULE_FIRMWARE(ADLS_CSR_PATH);
>
> -#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
> +#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
> #define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(DG1_CSR_PATH);
>
> -#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
> +#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
> #define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(RKL_CSR_PATH);
>
> -#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
> +#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
> #define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
> MODULE_FIRMWARE(TGL_CSR_PATH);
>
> -#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
> +#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_CSR_PATH);
>
> -#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
> +#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(CNL_CSR_PATH);
>
> -#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
> +#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define GLK_CSR_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_CSR_PATH);
>
> -#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
> +#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
> #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_CSR_PATH);
>
> -#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
> +#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
> #define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
> #define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_CSR_PATH);
>
> -#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
> +#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
> #define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define BXT_CSR_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_CSR_PATH);
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.h b/drivers/gpu/drm/i915/display/intel_csr.h
> index 03c64f8af7ab..fbfdaa3df07e 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.h
> +++ b/drivers/gpu/drm/i915/display/intel_csr.h
> @@ -8,6 +8,12 @@
>
> struct drm_i915_private;
>
> +#define DMC_PATH(platform, major, minor) \
> + "i915/" \
> + __stringify(platform) "_dmc_ver" \
> + __stringify(major) "_" \
> + __stringify(minor) ".bin"
contrary to the macros below that are used in other places, I don't
expect DMC_PATH to be ever used outside intel_csr.c.
Why are you adding it to the header?
thanks
Lucas De Marchi
> +
> #define CSR_VERSION(major, minor) ((major) << 16 | (minor))
> #define CSR_VERSION_MAJOR(version) ((version) >> 16)
> #define CSR_VERSION_MINOR(version) ((version) & 0xffff)
> --
> 2.30.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
` (3 preceding siblings ...)
2021-04-20 20:40 ` [Intel-gfx] [PATCH] " Lucas De Marchi
@ 2021-04-21 0:13 ` Patchwork
2021-04-21 13:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path. (rev2) Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-21 0:13 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30265 bytes --]
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path.
URL : https://patchwork.freedesktop.org/series/89275/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9988_full -> Patchwork_19957_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19957_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@prime:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([i915#750])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-tglb1/igt@drm_import_export@prime.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-tglb2/igt@drm_import_export@prime.html
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#180]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed-process.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][7] -> [TIMEOUT][8] ([i915#2369] / [i915#2481] / [i915#3070])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb2/igt@gem_eio@unwedge-stress.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][9] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][10] -> [FAIL][11] ([i915#2842]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-glk7/igt@gem_exec_fair@basic-none-vip@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-glk3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271]) +398 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][18] -> [DMESG-WARN][19] ([i915#118] / [i915#95])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-glk5/igt@gem_exec_whisper@basic-contexts-all.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#2190])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@big-copy-odd:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#307])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl6/igt@gem_mmap_gtt@big-copy-odd.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl9/igt@gem_mmap_gtt@big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#307])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb1/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][25] ([i915#2658])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl2/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3323])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@gem_userptr_blits@dmabuf-sync.html
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3323])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][28] ([i915#2724])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb2/igt@gem_userptr_blits@vma-merge.html
- shard-kbl: NOTRUN -> [FAIL][29] ([i915#3318])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl6/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][30] -> [DMESG-WARN][31] ([i915#1436] / [i915#716])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl8/igt@gen9_exec_parse@allowed-single.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl4/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][32] ([i915#3296])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@gen9_exec_parse@bb-large.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-snb: [PASS][33] -> [INCOMPLETE][34] ([i915#2880])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#454])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl8/igt@i915_pm_dc@dc6-psr.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][37] -> [INCOMPLETE][38] ([i915#2782])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-snb7/igt@i915_selftest@live@hangcheck.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb6/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@fence-restore-untiled:
- shard-skl: [PASS][39] -> [INCOMPLETE][40] ([i915#198])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl7/igt@i915_suspend@fence-restore-untiled.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl8/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#2521])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html
* igt@kms_ccs@pipe-c-bad-aux-stride:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111304]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_ccs@pipe-c-bad-aux-stride.html
* igt@kms_chamelium@hdmi-audio-edid:
- shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +13 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl4/igt@kms_chamelium@hdmi-audio-edid.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +25 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl8/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_color_chamelium@pipe-a-ctm-negative:
- shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +23 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-negative.html
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][48] ([i915#1319]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl2/igt@kms_content_protection@atomic.html
* igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][49] ([fdo#109271]) +130 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109274] / [fdo#109278])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-skl: [PASS][52] -> [INCOMPLETE][53] ([i915#3254])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][54] -> [FAIL][55] ([i915#2346] / [i915#533])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109274])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@kms_flip@2x-flip-vs-suspend-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][58] -> [FAIL][59] ([i915#79]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl4/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][60] -> [FAIL][61] ([i915#2122]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-apl: NOTRUN -> [FAIL][62] ([i915#2641])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2672])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#2672])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271]) +50 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#111825])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: NOTRUN -> [FAIL][67] ([i915#1188]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#533]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [PASS][70] -> [DMESG-WARN][71] ([i915#180])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][74] -> [FAIL][75] ([fdo#108145] / [i915#265])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][76] ([i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
- shard-kbl: NOTRUN -> [FAIL][77] ([i915#265]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][78] ([fdo#108145] / [i915#265])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658]) +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658]) +4 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][84] ([IGT#2])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@kms_sysfs_edid_timing.html
- shard-kbl: NOTRUN -> [FAIL][85] ([IGT#2])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-b-query-idle-hang:
- shard-snb: [PASS][86] -> [SKIP][87] ([fdo#109271])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-snb2/igt@kms_vblank@pipe-b-query-idle-hang.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-snb2/igt@kms_vblank@pipe-b-query-idle-hang.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271]) +254 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2437])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_writeback@writeback-fb-id.html
* igt@perf@unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109289])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@perf@unprivileged-single-ctx-counters.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl1/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +3 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl6/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][93] ([i915#2369] / [i915#3063]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-tglb7/igt@gem_eio@unwedge-stress.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][95] ([i915#2846]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-glk6/igt@gem_exec_fair@basic-deadline.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-glk1/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][97] ([i915#2842]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][99] ([i915#2842]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-tglb8/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-iclb: [FAIL][101] ([i915#2428]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb6/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb5/igt@gem_mmap_gtt@cpuset-basic-small-copy-xy.html
* igt@gem_mmap_gtt@cpuset-medium-copy:
- shard-glk: [FAIL][103] ([i915#307]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-glk2/igt@gem_mmap_gtt@cpuset-medium-copy.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-glk5/igt@gem_mmap_gtt@cpuset-medium-copy.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [DMESG-WARN][105] ([i915#1436] / [i915#716]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl9/igt@gen9_exec_parse@allowed-all.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@gen9_exec_parse@allowed-all.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [DMESG-WARN][107] ([i915#1982]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl6/igt@i915_module_load@reload-with-fault-injection.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl9/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- shard-skl: [FAIL][109] ([i915#54]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][111] ([i915#2346]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [FAIL][113] ([i915#79]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-apl8/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl7/igt@kms_flip@flip-vs-expired-vblank@a-dp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116] +7 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][119] ([fdo#108145] / [i915#265]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][121] ([fdo#109441]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@prime_vgem@coherency-blt:
- shard-skl: [INCOMPLETE][123] -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-skl6/igt@prime_vgem@coherency-blt.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-skl10/igt@prime_vgem@coherency-blt.html
* igt@prime_vgem@sync@rcs0:
- shard-iclb: [INCOMPLETE][125] ([i915#409]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb5/igt@prime_vgem@sync@rcs0.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb4/igt@prime_vgem@sync@rcs0.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][127] ([i915#2842]) -> [SKIP][128] ([fdo#109271])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][129] ([i915#2684]) -> [WARN][130] ([i915#2681] / [i915#2684])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-iclb: [SKIP][131] ([i915#2920]) -> [SKIP][132] ([i915#658]) +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-iclb: [SKIP][133] ([i915#658]) -> [SKIP][134] ([i915#2920]) +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb8/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#1814] / [i915#2505] / [i915#3002]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3002])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl7/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl1/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl7/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl3/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl1/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-kbl6/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl7/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl1/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-kbl3/igt@runner@aborted.html
- shard-iclb: ([FAIL][148], [FAIL][149], [FAIL][150]) ([i915#2426] / [i915#3002] / [i915#409]) -> ([FAIL][151], [FAIL][152]) ([i915#3002])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb5/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb7/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9988/shard-iclb1/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/shard-i
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19957/index.html
[-- Attachment #1.2: Type: text/html, Size: 33898 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-20 20:40 ` [Intel-gfx] [PATCH] " Lucas De Marchi
@ 2021-04-21 9:44 ` Rodrigo Vivi
2021-04-21 12:18 ` Jani Nikula
2021-04-21 14:57 ` Lucas De Marchi
0 siblings, 2 replies; 13+ messages in thread
From: Rodrigo Vivi @ 2021-04-21 9:44 UTC (permalink / raw)
To: intel-gfx
Although this abstraction removes the convenience of grepping
for the file name, it:
- makes addition easier.
- makes it easier to tweak global path when experiments are needed.
- get in sync with guc/huc, without getting overly abstracted.
- allows future junction with CSR_VERSION for simplicity.
- Enforces dmc file will never change this standard.
v2: define DMC_PATH inside .c (Lucas)
Cc: Fei Yang <fei.yang@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com> #v1
---
drivers/gpu/drm/i915/display/intel_csr.c | 26 +++++++++++++++---------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
index 26a3c6787e9e..26a922d34263 100644
--- a/drivers/gpu/drm/i915/display/intel_csr.c
+++ b/drivers/gpu/drm/i915/display/intel_csr.c
@@ -38,50 +38,56 @@
* low-power state and comes back to normal.
*/
+#define DMC_PATH(platform, major, minor) \
+ "i915/" \
+ __stringify(platform) "_dmc_ver" \
+ __stringify(major) "_" \
+ __stringify(minor) ".bin"
+
#define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
-#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
+#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
#define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
MODULE_FIRMWARE(ADLS_CSR_PATH);
-#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
+#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
#define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
MODULE_FIRMWARE(DG1_CSR_PATH);
-#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
+#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
#define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
MODULE_FIRMWARE(RKL_CSR_PATH);
-#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
+#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
#define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
MODULE_FIRMWARE(TGL_CSR_PATH);
-#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
+#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
#define ICL_CSR_MAX_FW_SIZE 0x6000
MODULE_FIRMWARE(ICL_CSR_PATH);
-#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
+#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(CNL_CSR_PATH);
-#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
+#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
#define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
#define GLK_CSR_MAX_FW_SIZE 0x4000
MODULE_FIRMWARE(GLK_CSR_PATH);
-#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
+#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
#define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
#define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(KBL_CSR_PATH);
-#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
+#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
#define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
#define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
MODULE_FIRMWARE(SKL_CSR_PATH);
-#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
+#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
#define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define BXT_CSR_MAX_FW_SIZE 0x3000
MODULE_FIRMWARE(BXT_CSR_PATH);
--
2.30.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-21 9:44 ` Rodrigo Vivi
@ 2021-04-21 12:18 ` Jani Nikula
2021-04-21 14:58 ` Lucas De Marchi
2021-04-21 14:57 ` Lucas De Marchi
1 sibling, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2021-04-21 12:18 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx
On Wed, 21 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> Although this abstraction removes the convenience of grepping
> for the file name, it:
> - makes addition easier.
> - makes it easier to tweak global path when experiments are needed.
> - get in sync with guc/huc, without getting overly abstracted.
> - allows future junction with CSR_VERSION for simplicity.
> - Enforces dmc file will never change this standard.
>
> v2: define DMC_PATH inside .c (Lucas)
>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com> #v1
Nice,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
On a related note, should we finally consider a s/csr/dmc/g rename all
over the place? It's just confusing to keep using two names.
> ---
> drivers/gpu/drm/i915/display/intel_csr.c | 26 +++++++++++++++---------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
> index 26a3c6787e9e..26a922d34263 100644
> --- a/drivers/gpu/drm/i915/display/intel_csr.c
> +++ b/drivers/gpu/drm/i915/display/intel_csr.c
> @@ -38,50 +38,56 @@
> * low-power state and comes back to normal.
> */
>
> +#define DMC_PATH(platform, major, minor) \
> + "i915/" \
> + __stringify(platform) "_dmc_ver" \
> + __stringify(major) "_" \
> + __stringify(minor) ".bin"
> +
> #define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
>
> -#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
> +#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
> #define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
> MODULE_FIRMWARE(ADLS_CSR_PATH);
>
> -#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
> +#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
> #define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(DG1_CSR_PATH);
>
> -#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
> +#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
> #define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(RKL_CSR_PATH);
>
> -#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
> +#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
> #define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
> MODULE_FIRMWARE(TGL_CSR_PATH);
>
> -#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
> +#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_CSR_PATH);
>
> -#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
> +#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(CNL_CSR_PATH);
>
> -#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
> +#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define GLK_CSR_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_CSR_PATH);
>
> -#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
> +#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
> #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_CSR_PATH);
>
> -#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
> +#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
> #define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
> #define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_CSR_PATH);
>
> -#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
> +#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
> #define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define BXT_CSR_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_CSR_PATH);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path. (rev2)
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
` (4 preceding siblings ...)
2021-04-21 0:13 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
@ 2021-04-21 13:25 ` Patchwork
2021-04-21 13:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-21 18:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-21 13:25 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path. (rev2)
URL : https://patchwork.freedesktop.org/series/89275/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Let's abstract the dmc path. (rev2)
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
` (5 preceding siblings ...)
2021-04-21 13:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path. (rev2) Patchwork
@ 2021-04-21 13:49 ` Patchwork
2021-04-21 18:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-21 13:49 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2585 bytes --]
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path. (rev2)
URL : https://patchwork.freedesktop.org/series/89275/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9992 -> Patchwork_19959
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/index.html
Known issues
------------
Here are the changes found in Patchwork_19959 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#2283])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
Participating hosts (41 -> 40)
------------------------------
Additional (1): fi-bdw-5557u
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9992 -> Patchwork_19959
CI-20190529: 20190529
CI_DRM_9992: cd804a7f03a97c3f808e696bcf04d7338f3fc27d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6072: 0a51f49df9f5ca535fc0206a27a6780de6b52320 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19959: b7bbe304556d184a22b83370ae9d2ced6a0b4efc @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b7bbe304556d drm/i915/dmc: Let's abstract the dmc path.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/index.html
[-- Attachment #1.2: Type: text/html, Size: 3342 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-21 9:44 ` Rodrigo Vivi
2021-04-21 12:18 ` Jani Nikula
@ 2021-04-21 14:57 ` Lucas De Marchi
1 sibling, 0 replies; 13+ messages in thread
From: Lucas De Marchi @ 2021-04-21 14:57 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Wed, Apr 21, 2021 at 05:44:06AM -0400, Rodrigo Vivi wrote:
>Although this abstraction removes the convenience of grepping
>for the file name, it:
>- makes addition easier.
>- makes it easier to tweak global path when experiments are needed.
>- get in sync with guc/huc, without getting overly abstracted.
>- allows future junction with CSR_VERSION for simplicity.
>- Enforces dmc file will never change this standard.
>
>v2: define DMC_PATH inside .c (Lucas)
>
>Cc: Fei Yang <fei.yang@intel.com>
>Cc: Jani Nikula <jani.nikula@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>Reviewed-by: José Roberto de Souza <jose.souza@intel.com> #v1
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/display/intel_csr.c | 26 +++++++++++++++---------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
>index 26a3c6787e9e..26a922d34263 100644
>--- a/drivers/gpu/drm/i915/display/intel_csr.c
>+++ b/drivers/gpu/drm/i915/display/intel_csr.c
>@@ -38,50 +38,56 @@
> * low-power state and comes back to normal.
> */
>
>+#define DMC_PATH(platform, major, minor) \
>+ "i915/" \
>+ __stringify(platform) "_dmc_ver" \
>+ __stringify(major) "_" \
>+ __stringify(minor) ".bin"
>+
> #define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
>
>-#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
>+#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
> #define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
> MODULE_FIRMWARE(ADLS_CSR_PATH);
>
>-#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
>+#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
> #define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(DG1_CSR_PATH);
>
>-#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
>+#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
> #define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
> MODULE_FIRMWARE(RKL_CSR_PATH);
>
>-#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
>+#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
> #define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
> MODULE_FIRMWARE(TGL_CSR_PATH);
>
>-#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
>+#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_CSR_PATH);
>
>-#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
>+#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(CNL_CSR_PATH);
>
>-#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
>+#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define GLK_CSR_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_CSR_PATH);
>
>-#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
>+#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
> #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
> #define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_CSR_PATH);
>
>-#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
>+#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
> #define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
> #define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_CSR_PATH);
>
>-#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
>+#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
> #define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define BXT_CSR_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_CSR_PATH);
>--
>2.30.2
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path.
2021-04-21 12:18 ` Jani Nikula
@ 2021-04-21 14:58 ` Lucas De Marchi
0 siblings, 0 replies; 13+ messages in thread
From: Lucas De Marchi @ 2021-04-21 14:58 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Apr 21, 2021 at 03:18:17PM +0300, Jani Nikula wrote:
>On Wed, 21 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> Although this abstraction removes the convenience of grepping
>> for the file name, it:
>> - makes addition easier.
>> - makes it easier to tweak global path when experiments are needed.
>> - get in sync with guc/huc, without getting overly abstracted.
>> - allows future junction with CSR_VERSION for simplicity.
>> - Enforces dmc file will never change this standard.
>>
>> v2: define DMC_PATH inside .c (Lucas)
>>
>> Cc: Fei Yang <fei.yang@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Reviewed-by: José Roberto de Souza <jose.souza@intel.com> #v1
>
>Nice,
>
>Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>On a related note, should we finally consider a s/csr/dmc/g rename all
>over the place? It's just confusing to keep using two names.
+1
But maybe we need a comment about dmc vs csr use, because spec uses
both.
Lucas De Marchi
>
>
>> ---
>> drivers/gpu/drm/i915/display/intel_csr.c | 26 +++++++++++++++---------
>> 1 file changed, 16 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_csr.c b/drivers/gpu/drm/i915/display/intel_csr.c
>> index 26a3c6787e9e..26a922d34263 100644
>> --- a/drivers/gpu/drm/i915/display/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/display/intel_csr.c
>> @@ -38,50 +38,56 @@
>> * low-power state and comes back to normal.
>> */
>>
>> +#define DMC_PATH(platform, major, minor) \
>> + "i915/" \
>> + __stringify(platform) "_dmc_ver" \
>> + __stringify(major) "_" \
>> + __stringify(minor) ".bin"
>> +
>> #define GEN12_CSR_MAX_FW_SIZE ICL_CSR_MAX_FW_SIZE
>>
>> -#define ADLS_CSR_PATH "i915/adls_dmc_ver2_01.bin"
>> +#define ADLS_CSR_PATH DMC_PATH(adls, 2, 01)
>> #define ADLS_CSR_VERSION_REQUIRED CSR_VERSION(2, 1)
>> MODULE_FIRMWARE(ADLS_CSR_PATH);
>>
>> -#define DG1_CSR_PATH "i915/dg1_dmc_ver2_02.bin"
>> +#define DG1_CSR_PATH DMC_PATH(dg1, 2, 02)
>> #define DG1_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
>> MODULE_FIRMWARE(DG1_CSR_PATH);
>>
>> -#define RKL_CSR_PATH "i915/rkl_dmc_ver2_02.bin"
>> +#define RKL_CSR_PATH DMC_PATH(rkl, 2, 02)
>> #define RKL_CSR_VERSION_REQUIRED CSR_VERSION(2, 2)
>> MODULE_FIRMWARE(RKL_CSR_PATH);
>>
>> -#define TGL_CSR_PATH "i915/tgl_dmc_ver2_08.bin"
>> +#define TGL_CSR_PATH DMC_PATH(tgl, 2, 08)
>> #define TGL_CSR_VERSION_REQUIRED CSR_VERSION(2, 8)
>> MODULE_FIRMWARE(TGL_CSR_PATH);
>>
>> -#define ICL_CSR_PATH "i915/icl_dmc_ver1_09.bin"
>> +#define ICL_CSR_PATH DMC_PATH(icl, 1, 09)
>> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 9)
>> #define ICL_CSR_MAX_FW_SIZE 0x6000
>> MODULE_FIRMWARE(ICL_CSR_PATH);
>>
>> -#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
>> +#define CNL_CSR_PATH DMC_PATH(cnl, 1, 07)
>> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
>> #define CNL_CSR_MAX_FW_SIZE GLK_CSR_MAX_FW_SIZE
>> MODULE_FIRMWARE(CNL_CSR_PATH);
>>
>> -#define GLK_CSR_PATH "i915/glk_dmc_ver1_04.bin"
>> +#define GLK_CSR_PATH DMC_PATH(glk, 1, 04)
>> #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
>> #define GLK_CSR_MAX_FW_SIZE 0x4000
>> MODULE_FIRMWARE(GLK_CSR_PATH);
>>
>> -#define KBL_CSR_PATH "i915/kbl_dmc_ver1_04.bin"
>> +#define KBL_CSR_PATH DMC_PATH(kbl, 1, 04)
>> #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
>> #define KBL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
>> MODULE_FIRMWARE(KBL_CSR_PATH);
>>
>> -#define SKL_CSR_PATH "i915/skl_dmc_ver1_27.bin"
>> +#define SKL_CSR_PATH DMC_PATH(skl, 1, 27)
>> #define SKL_CSR_VERSION_REQUIRED CSR_VERSION(1, 27)
>> #define SKL_CSR_MAX_FW_SIZE BXT_CSR_MAX_FW_SIZE
>> MODULE_FIRMWARE(SKL_CSR_PATH);
>>
>> -#define BXT_CSR_PATH "i915/bxt_dmc_ver1_07.bin"
>> +#define BXT_CSR_PATH DMC_PATH(bxt, 1, 07)
>> #define BXT_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
>> #define BXT_CSR_MAX_FW_SIZE 0x3000
>> MODULE_FIRMWARE(BXT_CSR_PATH);
>
>--
>Jani Nikula, Intel Open Source Graphics Center
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: Let's abstract the dmc path. (rev2)
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
` (6 preceding siblings ...)
2021-04-21 13:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-04-21 18:16 ` Patchwork
7 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-04-21 18:16 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30272 bytes --]
== Series Details ==
Series: drm/i915/dmc: Let's abstract the dmc path. (rev2)
URL : https://patchwork.freedesktop.org/series/89275/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9992_full -> Patchwork_19959_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19959_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19959_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19959_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_crc@pipe-d-cursor-64x64-random:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-64x64-random.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-tglb6/igt@kms_cursor_crc@pipe-d-cursor-64x64-random.html
Known issues
------------
Here are the changes found in Patchwork_19959_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_import_export@flink:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([i915#750])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-tglb3/igt@drm_import_export@flink.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-tglb5/igt@drm_import_export@flink.html
* igt@gem_ctx_persistence@smoketest:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-snb7/igt@gem_ctx_persistence@smoketest.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][6] -> [TIMEOUT][7] ([i915#2369] / [i915#2481] / [i915#3070])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb5/igt@gem_eio@unwedge-stress.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl2/igt@gem_exec_fair@basic-none-vip@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl4/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_mmap_gtt@big-copy:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#307])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk4/igt@gem_mmap_gtt@big-copy.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk5/igt@gem_mmap_gtt@big-copy.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][16] ([i915#2658])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-snb5/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][17] ([i915#3002])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl1/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][18] ([i915#3318])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl2/igt@gem_userptr_blits@vma-merge.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: NOTRUN -> [INCOMPLETE][21] ([i915#2782])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-snb5/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +21 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_color_chamelium@pipe-c-ctm-limited-range:
- shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +18 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-snb5/igt@kms_color_chamelium@pipe-c-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +4 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_color_chamelium@pipe-c-gamma.html
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@kms_color_chamelium@pipe-d-ctm-max.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][26] ([i915#1319])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][27] ([i915#2105])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271]) +47 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][29] ([i915#180])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-random:
- shard-glk: NOTRUN -> [SKIP][30] ([fdo#109271]) +26 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@kms_cursor_crc@pipe-d-cursor-256x256-random.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2346])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl10/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#198])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl7/igt@kms_flip@flip-vs-suspend@a-edp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl6/igt@kms_flip@flip-vs-suspend@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1:
- shard-glk: [PASS][37] -> [FAIL][38] ([i915#2122]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk2/igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk8/igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#2122])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2672]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#2642]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][43] ([fdo#109271]) +300 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-snb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-glk: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2672])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl10/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][46] -> [FAIL][47] ([i915#1188])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#533]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#533])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#533])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][51] -> [INCOMPLETE][52] ([i915#155])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][53] ([i915#265])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#658]) +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#658]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#658])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][58] -> [SKIP][59] ([fdo#109441]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][60] ([IGT#2])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271]) +246 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl2/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_writeback@writeback-check-output:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#2437]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl7/igt@kms_writeback@writeback-check-output.html
* igt@perf@blocking:
- shard-skl: [PASS][63] -> [FAIL][64] ([i915#1542])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl6/igt@perf@blocking.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl7/igt@perf@blocking.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2994]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl7/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@sema-10:
- shard-glk: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#2994])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk6/igt@sysfs_clients@sema-10.html
* igt@sysfs_clients@split-50:
- shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2994]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@sysfs_clients@split-50.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [PASS][68] -> [FAIL][69] ([i915#1731]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl9/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@sysfs_heartbeat_interval@mixed@rcs0.html
#### Possible fixes ####
* igt@gem_create@create-clear:
- shard-glk: [FAIL][70] ([i915#1888] / [i915#3160]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk8/igt@gem_create@create-clear.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk8/igt@gem_create@create-clear.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][72] ([i915#2846]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk1/igt@gem_exec_fair@basic-deadline.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][74] ([i915#2842]) -> [PASS][75] +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][76] ([i915#2842]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk6/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][78] ([i915#2849]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-iclb: [FAIL][80] ([i915#2428]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb1/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb3/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][82] ([i915#180]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: [FAIL][84] ([i915#454]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl9/igt@i915_pm_dc@dc6-psr.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl7/igt@i915_pm_dc@dc6-psr.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][86] ([i915#2346]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][88] ([i915#155] / [i915#180] / [i915#636]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][90] ([i915#79]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [DMESG-WARN][92] ([i915#1982]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][94] ([i915#79]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97] +4 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][98] ([i915#2122]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-glk6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a2.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-glk4/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt:
- shard-skl: [FAIL][100] ([i915#49]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][102] ([i915#1188]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl1/igt@kms_hdr@bpc-switch.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl9/igt@kms_hdr@bpc-switch.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][104] ([fdo#108145] / [i915#265]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][106] ([fdo#109441]) -> [PASS][107] +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][108] ([i915#2681] / [i915#2684]) -> [WARN][109] ([i915#1804] / [i915#2684])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][110] ([i915#2920]) -> [SKIP][111] ([i915#658]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][112] ([i915#658]) -> [SKIP][113] ([i915#2920]) +3 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-iclb8/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119]) ([i915#1436] / [i915#180] / [i915#2505] / [i915#3002] / [i915#92]) -> ([FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124]) ([i915#180] / [i915#1814] / [i915#2505] / [i915#3002])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl1/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl6/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl6/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl1/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl1/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-kbl6/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl1/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl6/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl6/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl1/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-kbl1/igt@runner@aborted.html
- shard-apl: ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][130], [FAIL][131]) ([i915#1814] / [i915#3002])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl8/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl8/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl1/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl8/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-apl6/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl6/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-apl3/igt@runner@aborted.html
- shard-skl: ([FAIL][132], [FAIL][133]) ([i915#3002]) -> ([FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1814] / [i915#2029] / [i915#3002])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl10/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9992/shard-skl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl4/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl9/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/shard-skl2/igt@runner@aborted.html
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2428]: https://gitlab.freedesktop.org/drm/intel/issues/2428
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2481]: https://gitlab.freedesktop.org/drm/intel/issues/2481
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2642]: https://gitlab.freedesktop.org/drm/intel/issues/2642
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#31
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19959/index.html
[-- Attachment #1.2: Type: text/html, Size: 37207 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-04-21 18:16 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 19:12 [Intel-gfx] [PATCH] drm/i915/dmc: Let's abstract the dmc path Rodrigo Vivi
2021-04-20 19:38 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-20 19:53 ` [Intel-gfx] [PATCH] " Souza, Jose
2021-04-20 20:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-04-20 20:40 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2021-04-21 9:44 ` Rodrigo Vivi
2021-04-21 12:18 ` Jani Nikula
2021-04-21 14:58 ` Lucas De Marchi
2021-04-21 14:57 ` Lucas De Marchi
2021-04-21 0:13 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-04-21 13:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Let's abstract the dmc path. (rev2) Patchwork
2021-04-21 13:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-21 18:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.