All of lore.kernel.org
 help / color / mirror / Atom feed
From: <dlinkin@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <jiri@nvidia.com>,
	<stephen@networkplumber.org>, <dsahern@gmail.com>,
	<vladbu@nvidia.com>, Dmytro Linkin <dlinkin@nvidia.com>
Subject: [PATCH RESEND-2 RFC net-next 17/18] selftest: netdevsim: Add devlink rate grouping test
Date: Wed, 21 Apr 2021 18:53:04 +0300	[thread overview]
Message-ID: <1619020385-20220-18-git-send-email-dlinkin@nvidia.com> (raw)
In-Reply-To: <1619020385-20220-1-git-send-email-dlinkin@nvidia.com>

From: Dmytro Linkin <dlinkin@nvidia.com>

Test verifies that netdevsim correctly implements devlink ops callbacks
that set node as a parent of devlink leaf or node rate object.

Co-developed-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
 .../selftests/drivers/net/netdevsim/devlink.sh     | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
index 7c6ecf2..0f4b163 100755
--- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
+++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
@@ -563,6 +563,26 @@ rate_attr_tx_rate_check()
 	check_err $? "Unexpected $name attr value $api_value != $rate"
 }
 
+rate_attr_parent_check()
+{
+	local handle=$1
+	local parent=$2
+	local debug_file=$3
+
+	rate_attr_set $handle parent $parent
+	check_err $? "Failed to set parent"
+
+	debug_value=$(cat $debug_file)
+	check_err $? "Failed to get parent debugfs value"
+	[ "$debug_value" == "$parent" ]
+	check_err $? "Unexpected parent debug value $debug_value != $parent"
+
+	api_value=$(rate_attr_get $r_obj parent)
+	check_err $? "Failed to get parent attr value"
+	[ "$api_value" == "$parent" ]
+	check_err $? "Unexpected parent attr value $api_value != $parent"
+}
+
 rate_node_add()
 {
 	local handle=$1
@@ -627,6 +647,28 @@ rate_test()
 	[ $num_nodes == 0 ]
 	check_err $? "Expected 0 rate node but got $num_nodes"
 
+	local node1_name='group1'
+	local node1="$DL_HANDLE/$node1_name"
+	rate_node_add "$node1"
+	check_err $? "Failed to add node $node1"
+
+	rate_attr_parent_check $r_obj $node1_name \
+		$DEBUGFS_DIR/ports/${r_obj##*/}/rate_parent
+
+	local node2_name='group2'
+	local node2="$DL_HANDLE/$node2_name"
+	rate_node_add "$node2"
+	check_err $? "Failed to add node $node2"
+
+	rate_attr_parent_check $node2 $node1_name \
+		$DEBUGFS_DIR/rate_nodes/$node2_name/rate_parent
+	rate_node_del "$node2"
+	check_err $? "Failed to delete node $node2"
+	rate_attr_set "$r_obj" noparent
+	check_err $? "Failed to unset $r_obj parent node"
+	rate_node_del "$node1"
+	check_err $? "Failed to delete node $node1"
+
 	log_test "rate test"
 }
 
-- 
1.8.3.1


  parent reply	other threads:[~2021-04-21 15:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 15:52 [PATCH RESEND-2 RFC net-next 00/18] devlink: rate objects API dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 01/18] netdevsim: Add max_vfs to bus_dev dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 02/18] netdevsim: Disable VFs on nsim_dev_reload_destroy() call dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 03/18] netdevsim: Implement port types and indexing dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 04/18] netdevsim: Implement VFs dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 05/18] netdevsim: Implement legacy/switchdev mode for VFs dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 06/18] devlink: Introduce rate object dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 07/18] netdevsim: Register devlink rate leaf objects per VF dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 08/18] selftest: netdevsim: Add devlink rate test dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 09/18] devlink: Allow setting tx rate for devlink rate leaf objects dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 10/18] netdevsim: Implement devlink rate leafs tx rate support dlinkin
2021-04-22 12:30   ` kernel test robot
2021-04-22 15:18   ` kernel test robot
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 11/18] selftest: netdevsim: Add devlink port shared/max tx rate test dlinkin
2021-04-21 15:52 ` [PATCH RESEND-2 RFC net-next 12/18] devlink: Introduce rate nodes dlinkin
2021-04-21 21:31   ` kernel test robot
2021-04-21 21:32   ` kernel test robot
2021-04-23  9:37   ` Dan Carpenter
2021-04-23  9:37     ` Dan Carpenter
2021-04-23 10:26     ` Dmytro Linkin
2021-04-21 15:53 ` [PATCH RESEND-2 RFC net-next 13/18] netdevsim: Implement support for devlink " dlinkin
2021-04-21 15:53 ` [PATCH RESEND-2 RFC net-next 14/18] selftest: netdevsim: Add devlink rate nodes test dlinkin
2021-04-21 15:53 ` [PATCH RESEND-2 RFC net-next 15/18] devlink: Allow setting parent node of rate objects dlinkin
2021-04-21 15:53 ` [PATCH RESEND-2 RFC net-next 16/18] netdevsim: " dlinkin
2021-04-21 15:53 ` dlinkin [this message]
2021-04-21 15:53 ` [PATCH RESEND-2 RFC net-next 18/18] Documentation: devlink " dlinkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1619020385-20220-18-git-send-email-dlinkin@nvidia.com \
    --to=dlinkin@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vladbu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.