All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: idxd: add engine 'struct device' missing bus type assignment
@ 2021-04-26 23:09 Dave Jiang
  2021-05-10 14:18 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2021-04-26 23:09 UTC (permalink / raw)
  To: vkoul; +Cc: dmaengine

engine 'struct device' setup is missing assigning the bus type. Add it to
dsa_bus_type.

Fixes: 75b911309060 ("dmaengine: idxd: fix engine conf_dev lifetime")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---

Hi Vinod, this line got dropped after all my rebasing when it has always
been there. We should include it with the 5.13 merge window pull request.
Thanks!

 drivers/dma/idxd/init.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 2a926bef87f2..ec7305f86bf7 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -242,6 +242,7 @@ static int idxd_setup_engines(struct idxd_device *idxd)
 		engine->idxd = idxd;
 		device_initialize(&engine->conf_dev);
 		engine->conf_dev.parent = &idxd->conf_dev;
+		engine->conf_dev.bus = &dsa_bus_type;
 		engine->conf_dev.type = &idxd_engine_device_type;
 		rc = dev_set_name(&engine->conf_dev, "engine%d.%d", idxd->id, engine->id);
 		if (rc < 0) {



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: idxd: add engine 'struct device' missing bus type assignment
  2021-04-26 23:09 [PATCH] dmaengine: idxd: add engine 'struct device' missing bus type assignment Dave Jiang
@ 2021-05-10 14:18 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-05-10 14:18 UTC (permalink / raw)
  To: Dave Jiang; +Cc: dmaengine

On 26-04-21, 16:09, Dave Jiang wrote:
> engine 'struct device' setup is missing assigning the bus type. Add it to
> dsa_bus_type.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-10 14:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 23:09 [PATCH] dmaengine: idxd: add engine 'struct device' missing bus type assignment Dave Jiang
2021-05-10 14:18 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.