* [PATCH] net: Remove redundant assignment to err
@ 2021-04-29 1:32 Yang Li
2021-04-29 22:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-04-29 1:32 UTC (permalink / raw)
To: davem
Cc: yoshfuji, dsahern, kuba, nathan, ndesaulniers, netdev,
linux-kernel, clang-built-linux, Yang Li
Variable 'err' is set to -ENOMEM but this value is never read as it is
overwritten with a new value later on, hence the 'If statements' and
assignments are redundantand and can be removed.
Cleans up the following clang-analyzer warning:
net/ipv6/seg6.c:126:4: warning: Value stored to 'err' is never read
[clang-analyzer-deadcode.DeadStores]
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/ipv6/seg6.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c
index d2f8138..e412817 100644
--- a/net/ipv6/seg6.c
+++ b/net/ipv6/seg6.c
@@ -122,9 +122,6 @@ static int seg6_genl_sethmac(struct sk_buff *skb, struct genl_info *info)
hinfo = seg6_hmac_info_lookup(net, hmackeyid);
if (!slen) {
- if (!hinfo)
- err = -ENOENT;
-
err = seg6_hmac_info_del(net, hmackeyid);
goto out_unlock;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: Remove redundant assignment to err
2021-04-29 1:32 [PATCH] net: Remove redundant assignment to err Yang Li
@ 2021-04-29 22:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-29 22:40 UTC (permalink / raw)
To: Yang Li
Cc: davem, yoshfuji, dsahern, kuba, nathan, ndesaulniers, netdev,
linux-kernel, clang-built-linux
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 29 Apr 2021 09:32:36 +0800 you wrote:
> Variable 'err' is set to -ENOMEM but this value is never read as it is
> overwritten with a new value later on, hence the 'If statements' and
> assignments are redundantand and can be removed.
>
> Cleans up the following clang-analyzer warning:
>
> net/ipv6/seg6.c:126:4: warning: Value stored to 'err' is never read
> [clang-analyzer-deadcode.DeadStores]
>
> [...]
Here is the summary with links:
- net: Remove redundant assignment to err
https://git.kernel.org/netdev/net/c/1a70f6597d5f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-29 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 1:32 [PATCH] net: Remove redundant assignment to err Yang Li
2021-04-29 22:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.