Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

[Joonas Lahtinen]

+ intel-gfx mailing list

Quoting Zhenyu Wang (2021-04-30 02:58:28)
> On 2021.04.29 20:14:50 +0200, Andreas Friedrich wrote:
> > Hello Joonas,
> > 
> > with kernel 5.12 suspend to memory is no longer working on my old
> > Toshiba Tecra A10 notebook.
> > 
> > After calling /sbin/pm-suspend the screen is dimmed but the CPU fan is
> > still running, the system is frozen and is not in suspended state. The
> > only way to get the system working again is to hard power off and on.
> > 
> > Kernel 5.11.16 works well.
> > 
> > Bisecting the kernel leads me to your commit, which caused the problem:
> > 
> >   commit c071a6c0fef0fade787d827c7fc0e07481512326 (HEAD, refs/bisect/bad)
> >   Merge: a2dd2ff50cde 02dd2b12a685
> >   Author: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >   Date:   Thu Jan 21 15:10:16 2021 +0200
> > 
> >     Merge tag 'gvt-gt-next-2021-01-18' of https://github.com/intel/gvt-linux into drm-intel-gt-next
> > 
> >     gvt-gt-next-2021-01-18
> > 
> >     - GVT cmd parser enhancement against guest context (Yan)
> > 
> >     Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> >     From: Zhenyu Wang <zhenyuw@linux.intel.com>
> >     Link: https://patchwork.freedesktop.org/patch/msgid/20210118050739.GY15982@zhen-hp.sh.intel.com

That is a merge commit, it doesn't itself change anything as there were no
conflicts. It just indicates that two trees got merged.

Bisecting should end up in a commit that has code changes. Then you should
be able to try to revert the offending commit from the latest mainline kernel.
Most of the time that can be used to confirm that reverting specific commit
fixes issue (unless the commit has a lot of dependencies). This is not
required though, if you are able to bisect to a single code change commit
that'll allow us to provide fix to try.

If you are able to provide a bisect to a one patch, please do report it
as a bug, let's then take it from there.

See:

https://01.org/linuxgraphics/documentation/how-report-bugs

> > Not every suspend results in a frozen system, so I think a race
> > condition is on the way.

This would further tip the scale towards the bisect being a false
positive. I know it can be painful to do dozens of runs per each
bisecting point, but it's really needed to arrive at the right patch.

What kind of rate you have for hitting the issue on 5.12 kernel?

> > Appendix:
> > - Kernel configuration "5.12.config.gz"
> > - My grub kernel boot parameters:
> >   root=/dev/sda5 snd-hda-intel.model=toshiba resume=/dev/sda3 printk.time=1
> > 
> > Please let me know if I could help to fix the problem.
> > 
> 
> Looks gvt is not enabled in config or runtime, so can't think that gvt merge should be related...

Yes, I think the merge commit is a red herring.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

[Andreas Friedrich]

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

On Fri, Apr 30, 2021 at 11:31:47AM +0300, Joonas Lahtinen wrote:

Hello Joonas,

thank you for your quick response.
...
> That is a merge commit, it doesn't itself change anything as there were no
> conflicts. It just indicates that two trees got merged.
...
> If you are able to provide a bisect to a one patch, please do report it
> as a bug, let's then take it from there.

I have bisect the kernel 3 times and it always leads me to the wrong
end. Because not every suspend results in a frozen system, maybe I
have marked a 'bisect good' although it was bad.

What I surely can say is, that kernel 5.11.16 works fine and 5.12-rc1
(v5.12-rc1-dontuse) does not.

However, on the bisecting path I saw the following commits:
  [41a9c75d0acf23f33f012d3f9535de9e9b631051] drm/i915/gem: Move stolen node into GEM object union
  [d82afcf9caaac26ce2642511115bca9dacf30f41] Merge tag 'drm-intel-gt-next-2021-01-21-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
  [885e1938452fc7fc37a3051d76e1ddb7ead099fa] drm/i915/gvt: statically set F_CMD_WRITE_PATCH flag
  [a2dd2ff50cde3cbbeecec72225bb18582b291f14] drm/i915/gt: Skip over completed active execlists, again
  [02dd2b12a685944c4d52c569d05f636372a7b6c7] drm/i915/gvt: unify lri cmd handler and mmio handlers
  [69b4b99842201bc24c98ba66b922d8879e190483] drm/i915/gvt: Add missing forward decl of intel_vgpu for HDRTEST
  [c071a6c0fef0fade787d827c7fc0e07481512326] Merge tag 'gvt-gt-next-2021-01-18' of https://github.com/intel/gvt-linux into drm-intel-gt-next

So I think it's a drm-i915 issue. I have communicated with David
Airlie (airlied@redhat.com) and he also bets on an i915 bug.
...
> https://01.org/linuxgraphics/documentation/how-report-bugs

Following https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
I can give you the following infos:
  - After calling 'echo mem > /sys/power/state' the system gets frozen
    (the screen is dimmed but the CPU fan is still running). The
    system is inaccessible from remote. The only way to get it working
    again is to hard power off and on.
  - One out of 5 suspend tries will cause the issue, mostly the first one.
  - Notebook: Old Toshiba Tecra A10 from 2009.
  - x86_64, 5.12-rc1, Debian GNU/Linux 10 (buster), see dmidecode.txt.gz
    and 5.12.config.gz
  - Because the system is frozen, I cannot read /sys/class/drm/card0/error
    before rebooting.

Please let me know if I can do anyting else to solve the problem.

Best regards
Andreas Friedrich

[-- Attachment #2: dmidecode.txt.gz --]
[-- Type: application/gzip, Size: 3534 bytes --]

[-- Attachment #3: 5.12.config.gz --]
[-- Type: application/gzip, Size: 27176 bytes --]

[-- Attachment #4: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

[Joonas Lahtinen]

Quoting Andreas Friedrich (2021-04-30 13:36:35)
> On Fri, Apr 30, 2021 at 11:31:47AM +0300, Joonas Lahtinen wrote:
> 
> Hello Joonas,
> 
> thank you for your quick response.
> ...
> > That is a merge commit, it doesn't itself change anything as there were no
> > conflicts. It just indicates that two trees got merged.
> ...
> > If you are able to provide a bisect to a one patch, please do report it
> > as a bug, let's then take it from there.
> 
> I have bisect the kernel 3 times and it always leads me to the wrong
> end. Because not every suspend results in a frozen system, maybe I
> have marked a 'bisect good' although it was bad.

This is most likely the problem. You should try each suggested commit
enough times to gain confidence in if it's good or bad build.

> What I surely can say is, that kernel 5.11.16 works fine and 5.12-rc1
> (v5.12-rc1-dontuse) does not.
> 
> However, on the bisecting path I saw the following commits:
>   [41a9c75d0acf23f33f012d3f9535de9e9b631051] drm/i915/gem: Move stolen node into GEM object union
>   [d82afcf9caaac26ce2642511115bca9dacf30f41] Merge tag 'drm-intel-gt-next-2021-01-21-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
>   [885e1938452fc7fc37a3051d76e1ddb7ead099fa] drm/i915/gvt: statically set F_CMD_WRITE_PATCH flag
>   [a2dd2ff50cde3cbbeecec72225bb18582b291f14] drm/i915/gt: Skip over completed active execlists, again
>   [02dd2b12a685944c4d52c569d05f636372a7b6c7] drm/i915/gvt: unify lri cmd handler and mmio handlers
>   [69b4b99842201bc24c98ba66b922d8879e190483] drm/i915/gvt: Add missing forward decl of intel_vgpu for HDRTEST
>   [c071a6c0fef0fade787d827c7fc0e07481512326] Merge tag 'gvt-gt-next-2021-01-18' of https://github.com/intel/gvt-linux into drm-intel-gt-next

As Zhenyu mentioned, you don't even have GVT module enabled, so most of
those are guaranteed to be incorrectly bisected. And there are two merge
commits with no conflicts (== no code change).

Bisect should end so that the previous commit is good, and the new
commit is bad. If there are no code changes in the commit, there's
no way it can be the commit that is really the culprit.

Without a proper bisect, it'll be quite difficult to start the triage
on our side.

> So I think it's a drm-i915 issue. I have communicated with David
> Airlie (airlied@redhat.com) and he also bets on an i915 bug.

It's very possible that it can be i915 bug. What you can try is to
blacklist i915 module and operate the system with SSH and see if the
latest kernel still freezes?

Also, please try drm-tip kernel and see if it fixed there.

> > https://01.org/linuxgraphics/documentation/how-report-bugs
> 
> Following https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
> I can give you the following infos:
>   - After calling 'echo mem > /sys/power/state' the system gets frozen
>     (the screen is dimmed but the CPU fan is still running). The
>     system is inaccessible from remote. The only way to get it working
>     again is to hard power off and on.
>   - One out of 5 suspend tries will cause the issue, mostly the first one.
>   - Notebook: Old Toshiba Tecra A10 from 2009.
>   - x86_64, 5.12-rc1, Debian GNU/Linux 10 (buster), see dmidecode.txt.gz
>     and 5.12.config.gz
>   - Because the system is frozen, I cannot read /sys/class/drm/card0/error
>     before rebooting.
> 
> Please let me know if I can do anyting else to solve the problem.

Please do file a bug on the issue tracker as requested:

https://gitlab.freedesktop.org/drm/intel/issues/

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook

[Andreas Friedrich]

On Mon, May 03, 2021 at 11:13:25AM +0300, Joonas Lahtinen wrote:

Hello Joonas,
...
> It's very possible that it can be i915 bug. What you can try is to
> blacklist i915 module and operate the system with SSH and see if the
> latest kernel still freezes?
This is a good idea. I have disabled i915 in my kernel configuration:
  grep I915 .config
  # CONFIG_DRM_I915 is not set
This time the suspend works fine! So I think it is definitely an i915
DRM bug.
>
> Also, please try drm-tip kernel and see if it fixed there.
I have tried:
  uname -r
  5.12.0-rc8+
but no changes. The system freezes after the first try.
...
> Please do file a bug on the issue tracker as requested:
>
> https://gitlab.freedesktop.org/drm/intel/issues/
Done.

Best regards
Andreas Friedrich
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook - FIXED

[Andreas Friedrich]

On Mon, May 03, 2021 at 02:00:50PM +0200, Andreas Friedrich wrote:

Hello Joonas,
> ...
> > It's very possible that it can be i915 bug. What you can try is to
> > blacklist i915 module and operate the system with SSH and see if the
> > latest kernel still freezes?
> This is a good idea. I have disabled i915 in my kernel configuration:
>   grep I915 .config
>   # CONFIG_DRM_I915 is not set
> This time the suspend works fine! So I think it is definitely an i915
> DRM bug.
> >
> > Also, please try drm-tip kernel and see if it fixed there.
> I have tried:
>   uname -r
>   5.12.0-rc8+
> but no changes. The system freezes after the first try.
> ...
> > Please do file a bug on the issue tracker as requested:
> >
> > https://gitlab.freedesktop.org/drm/intel/issues/
> Done.

Fixed with 5.12.2
  drm/i915: Disable runtime power management during shutdown,
  commit 7962893ecb853aa7c8925ce237ab6c4274cfc1c7 upstream.

Best regards
Andreas Friedrich
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] REGRESSION with 5.12: Suspend not working on Toshiba notebook - NOT FIXED

[Andreas Friedrich]

On Sat, May 08, 2021 at 01:52:54AM +0200, Andreas Friedrich wrote:

Hello Joonas,
...
> Fixed with 5.12.2
>   drm/i915: Disable runtime power management during shutdown,
>   commit 7962893ecb853aa7c8925ce237ab6c4274cfc1c7 upstream.

I was wrong. One of 10 suspend still hangs.

Best regards
Andreas Friedrich
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx