* [Qemu-devel] [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
@ 2019-04-24 10:21 ` Daniel Berrange
2019-04-24 11:20 ` Thomas Huth
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Daniel Berrange @ 2019-04-24 10:21 UTC (permalink / raw)
To: qemu-devel
NB that patch will break Linux based Mingw builds, as they don't include
"mys2" in their output from gcc, so it would need to match both.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Qemu-devel] [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
2019-04-24 10:21 ` [Qemu-devel] [Bug 1826175] " Daniel Berrange
@ 2019-04-24 11:20 ` Thomas Huth
2019-04-24 11:57 ` Daniel Berrange
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2019-04-24 11:20 UTC (permalink / raw)
To: qemu-devel
This change needs to go in via the capstone project. capstone is just an
unmodified "submodule" in QEMU - we do not include any QEMU-only changes
here.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
Invalid
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Qemu-devel] [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
2019-04-24 10:21 ` [Qemu-devel] [Bug 1826175] " Daniel Berrange
2019-04-24 11:20 ` Thomas Huth
@ 2019-04-24 11:57 ` Daniel Berrange
2019-04-24 12:10 ` Gwendolyn Haller
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Daniel Berrange @ 2019-04-24 11:57 UTC (permalink / raw)
To: qemu-devel
Re-opened, since although the fix needs to be done in capstone, QEMU
also needs a commit to actually update the submodule hash to pull in the
fix.
** Changed in: qemu
Status: Invalid => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Qemu-devel] [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
` (2 preceding siblings ...)
2019-04-24 11:57 ` Daniel Berrange
@ 2019-04-24 12:10 ` Gwendolyn Haller
2019-04-24 12:25 ` Peter Maydell
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Gwendolyn Haller @ 2019-04-24 12:10 UTC (permalink / raw)
To: qemu-devel
I did submit a bug already to Capstone proper on their GitHub. Thanks
for the heads-up about it needing to cover both cases for cross-
compilers!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Qemu-devel] [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
` (3 preceding siblings ...)
2019-04-24 12:10 ` Gwendolyn Haller
@ 2019-04-24 12:25 ` Peter Maydell
2019-09-24 10:56 ` Adrian Vladu
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Peter Maydell @ 2019-04-24 12:25 UTC (permalink / raw)
To: qemu-devel
https://github.com/aquynh/capstone/issues/1464 is the upstream bug --
thanks for reporting it there.
** Bug watch added: github.com/aquynh/capstone/issues #1464
https://github.com/aquynh/capstone/issues/1464
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
` (4 preceding siblings ...)
2019-04-24 12:25 ` Peter Maydell
@ 2019-09-24 10:56 ` Adrian Vladu
2020-04-05 2:04 ` Chad Kennedy
2021-04-30 10:06 ` Thomas Huth
7 siblings, 0 replies; 9+ messages in thread
From: Adrian Vladu @ 2019-09-24 10:56 UTC (permalink / raw)
To: qemu-devel
The fix in upstream capstone has been merged:
https://github.com/aquynh/capstone/commit/29893c63e34ee21846744d02c396ae3c801b936b
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
` (5 preceding siblings ...)
2019-09-24 10:56 ` Adrian Vladu
@ 2020-04-05 2:04 ` Chad Kennedy
2021-04-30 10:06 ` Thomas Huth
7 siblings, 0 replies; 9+ messages in thread
From: Chad Kennedy @ 2020-04-05 2:04 UTC (permalink / raw)
To: qemu-devel
I am still running into this issue when compiling QEMU on Windows using
MSYS2. I can manually apply the fix per the Capstone commit above and
compile just fine.
For moving forward, how should this be handled in the codebase to get
the MSYS2 build cleanly working? I imagine wholesale pulling the latest
Capstone may break quite a bit. Is it possible to cherry-pick this one
change into the submodule?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
New
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug 1826175] Re: Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib"
2019-04-24 9:52 [Qemu-devel] [Bug 1826175] [NEW] Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make target capstone.lib" Gwendolyn Haller
` (6 preceding siblings ...)
2020-04-05 2:04 ` Chad Kennedy
@ 2021-04-30 10:06 ` Thomas Huth
7 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2021-04-30 10:06 UTC (permalink / raw)
To: qemu-devel
As far as I can see we're using a capstone version now that contains the
commit with the fix, so I'm closing this bug. If you are still having
problems, please open again or file a new bug ticket.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1826175
Title:
Compilation on MSYS2/MinGW-w64 fails with error: "No rule to make
target capstone.lib"
Status in QEMU:
Fix Released
Bug description:
I submitted this bug to Capstone directly but I figured it'd be useful
to post it here too. The IS_MINGW check in the Makefile for Capstone
fails under MSYS2 MinGW-w64 because cc --version doesn't have mingw in
the output anymore:
$ whereis cc
cc: /mingw64/bin/cc.exe
$ cc --version
cc.exe (Rev2, Built by MSYS2 project) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Really simple patch:
diff --git "a/Makefile" "b/Makefile"
index 063f50db..1d9f042e 100644
--- "a/Makefile"
+++ "b/Makefile"
@@ -288,7 +288,7 @@ CFLAGS := $(CFLAGS:-fPIC=)
# On Windows we need the shared library to be executable
else
# mingw?
-IS_MINGW := $(shell $(CC) --version | grep -i mingw | wc -l)
+IS_MINGW := $(shell $(CC) --version | grep -i msys2 | wc -l)
ifeq ($(IS_MINGW),1)
EXT = dll
AR_EXT = lib
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1826175/+subscriptions
^ permalink raw reply [flat|nested] 9+ messages in thread