compile error in fedora19

compile error in fedora19

[Nulik Nol]

Hi,
I have this error when compiling on Fedora 19. Any package I am missing ?

[niko@localhost dpdk-1.3.1r2]$ make config T=x86_64-default-linuxapp-gcc
Configuration done
[niko@localhost dpdk-1.3.1r2]$ make
== Build scripts
== Build scripts/testhost
  HOSTCC testhost.o
  HOSTLD testhost
  INSTALL-HOSTAPP testhost
== Build lib
== Build lib/librte_eal
== Build lib/librte_eal/common
  SYMLINK-FILE include/rte_atomic.h
  SYMLINK-FILE include/rte_branch_prediction.h
  SYMLINK-FILE include/rte_byteorder.h
  SYMLINK-FILE include/rte_common.h
  SYMLINK-FILE include/rte_cycles.h
  SYMLINK-FILE include/rte_debug.h
  SYMLINK-FILE include/rte_eal.h
  SYMLINK-FILE include/rte_errno.h
  SYMLINK-FILE include/rte_launch.h
  SYMLINK-FILE include/rte_lcore.h
  SYMLINK-FILE include/rte_log.h
  SYMLINK-FILE include/rte_memcpy.h
  SYMLINK-FILE include/rte_memory.h
  SYMLINK-FILE include/rte_memzone.h
  SYMLINK-FILE include/rte_pci.h
  SYMLINK-FILE include/rte_pci_dev_ids.h
  SYMLINK-FILE include/rte_per_lcore.h
  SYMLINK-FILE include/rte_prefetch.h
  SYMLINK-FILE include/rte_random.h
  SYMLINK-FILE include/rte_rwlock.h
  SYMLINK-FILE include/rte_spinlock.h
  SYMLINK-FILE include/rte_tailq.h
  SYMLINK-FILE include/rte_interrupts.h
  SYMLINK-FILE include/rte_alarm.h
  SYMLINK-FILE include/rte_string_fns.h
  SYMLINK-FILE include/rte_cpuflags.h
  SYMLINK-FILE include/rte_version.h
  SYMLINK-FILE include/rte_tailq_elem.h
  SYMLINK-FILE include/rte_eal_memconfig.h
  SYMLINK-FILE include/rte_malloc_heap.h
  SYMLINK-FILE include/arch/rte_atomic.h
== Build lib/librte_eal/linuxapp
== Build lib/librte_eal/linuxapp/igb_uio
  LD      /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/igb_uio/built-in.o
  CC [M]  /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.o
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.mod.o
  LD [M]  /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko
INSTALL-MODULE igb_uio.ko
== Build lib/librte_eal/linuxapp/eal
  CC eal.o
  CC eal_hugepage_info.o
  CC eal_memory.o
  CC eal_thread.o
  CC eal_log.o
  CC eal_pci.o
  CC eal_debug.o
  CC eal_lcore.o
  CC eal_hpet.o
  CC eal_interrupts.o
  CC eal_alarm.o
  CC eal_common_memzone.o
  CC eal_common_log.o
  CC eal_common_launch.o
  CC eal_common_pci.o
  CC eal_common_memory.o
  CC eal_common_tailqs.o
  CC eal_common_errno.o
  CC eal_common_cpuflags.o
  AR librte_eal.a
  SYMLINK-FILE include/exec-env/rte_per_lcore.h
  SYMLINK-FILE include/exec-env/rte_lcore.h
  SYMLINK-FILE include/exec-env/rte_interrupts.h
  SYMLINK-FILE include/exec-env/rte_kni_common.h
  INSTALL-LIB librte_eal.a
== Build lib/librte_eal/linuxapp/kni
  LD      /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/built-in.o
  CC [M]  /volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.o
In file included from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h:41:0,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_type.h:31,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_dcb.h:32,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h:52,
                 from
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:56:
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h:321:0:
error: "vlan_tx_tag_present" redefined [-Werror]
 #define vlan_tx_tag_present(_skb) 0
 ^
In file included from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h:56:0,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h:41,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_type.h:31,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_dcb.h:32,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h:52,
                 from
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:56:
/usr/src/kernels/3.10.7-200.fc19.x86_64/include/linux/if_vlan.h:81:0:
note: this is the location of the previous definition
 #define vlan_tx_tag_present(__skb) ((__skb)->vlan_tci & VLAN_TAG_PRESENT)
 ^
In file included from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h:41:0,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_type.h:31,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_dcb.h:32,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h:52,
                 from
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:56:
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h:322:0:
error: "vlan_tx_tag_get" redefined [-Werror]
 #define vlan_tx_tag_get(_skb) 0
 ^
In file included from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/kcompat.h:56:0,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_osdep.h:41,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_type.h:31,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_dcb.h:32,
                 from
/volume/niko/dpdk-1.3.1r2/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h:52,
                 from
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:56:
/usr/src/kernels/3.10.7-200.fc19.x86_64/include/linux/if_vlan.h:82:0:
note: this is the location of the previous definition
 #define vlan_tx_tag_get(__skb)  ((__skb)->vlan_tci & ~VLAN_TAG_PRESENT)
 ^
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:
In function ‘ixgbe_vlan_mode’:
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:334:25:
error: ‘NETIF_F_HW_VLAN_RX’ undeclared (first use in this function)
  enable = !!(features & NETIF_F_HW_VLAN_RX);
                         ^
/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.c:334:25:
note: each undeclared identifier is reported only once for each
function it appears in
cc1: all warnings being treated as errors
make[8]: *** [/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni/ixgbe_main.o]
Error 1
make[7]: *** [_module_/volume/niko/dpdk-1.3.1r2/build/build/lib/librte_eal/linuxapp/kni]
Error 2
make[6]: *** [sub-make] Error 2
make[5]: *** [rte_kni.ko] Error 2
make[4]: *** [kni] Error 2
make[3]: *** [linuxapp] Error 2
make[2]: *** [librte_eal] Error 2
make[1]: *** [lib] Error 2
make: *** [all] Error 2
[niko@localhost dpdk-1.3.1r2]$
[niko@localhost dpdk-1.3.1r2]$ uname -a
Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
[niko@localhost dpdk-1.3.1r2]$

Re: compile error in fedora19

[David Nyström]

On Fri 23 Aug 2013 12:11:51 PM CEST, Nulik Nol wrote:
> Hi,
> I have this error when compiling on Fedora 19. Any package I am missing ?
>
> [niko@localhost dpdk-1.3.1r2]$ make config T=x86_64-default-linuxapp-gcc
<snip>

> [niko@localhost dpdk-1.3.1r2]$ uname -a
> Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
> 23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

I'm guessing your running the 3.10.7 kernel as default in fedora 19, 
but there should really
be a kernel version check somewhere in there to give the user a warning 
when using
an "untested" kernel version.

Br,
David

Re: compile error in fedora19

[David Nyström]

On Fri 23 Aug 2013 12:21:41 PM CEST, David Nyström wrote:
> On Fri 23 Aug 2013 12:11:51 PM CEST, Nulik Nol wrote:
>> Hi,
>> I have this error when compiling on Fedora 19. Any package I am
>> missing ?
>>
>> [niko@localhost dpdk-1.3.1r2]$ make config T=x86_64-default-linuxapp-gcc
> <snip>
>
>> [niko@localhost dpdk-1.3.1r2]$ uname -a
>> Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
>> 23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
>
> I'm guessing your running the 3.10.7 kernel as default in fedora 19,
> but there should really
> be a kernel version check somewhere in there to give the user a
> warning when using
> an "untested" kernel version.
>

Oh, forgot to say, I see the same errors on linux 3.11-rc6.

Re: compile error in fedora19

[Nulik Nol]

>> [niko@localhost dpdk-1.3.1r2]$ uname -a
>> Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
>> 23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
>
>
> I'm guessing your running the 3.10.7 kernel as default in fedora 19, but
> there should really
> be a kernel version check somewhere in there to give the user a warning when
> using
> an "untested" kernel version.
>
well, I can't find any restrictions on that one in the "getting
started guide", it says kernel >= 2.6.33 is ok.
So how do we fix it ?

Regards

Re: compile error in fedora19

[Thomas Monjalon]

23/08/2013 07:32, Nulik Nol :
> >> [niko@localhost dpdk-1.3.1r2]$ uname -a
> >> Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
> >> 23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
> 
> So how do we fix it ?

I've sent some patches which are still waiting for review.
Anybody (including you) may review them.

-- 
Thomas

Re: compile error in fedora19

[Nulik Nol]

Sorry for my insistence but these patches seem to be of about month
ago  ? What exactly the commit message says for this fix ? is this in
1.3.1r2 ?

Regards

On Fri, Aug 23, 2013 at 3:22 PM, Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:
> 23/08/2013 07:32, Nulik Nol :
>> >> [niko@localhost dpdk-1.3.1r2]$ uname -a
>> >> Linux localhost.localdomain 3.10.7-200.fc19.x86_64 #1 SMP Thu Aug 15
>> >> 23:19:45 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
>>
>> So how do we fix it ?
>
> I've sent some patches which are still waiting for review.
> Anybody (including you) may review them.
>
> --
> Thomas

Re: compile error in fedora19

[Thomas Monjalon]

24/08/2013 05:44, Nulik Nol :
> Thomas Monjalon wrote:
> > I've sent some patches which are still waiting for review.
> > Anybody (including you) may review them.
>
> Sorry for my insistence but these patches seem to be of about month
> ago  ? What exactly the commit message says for this fix ? is this in
> 1.3.1r2 ?

The patches are:
	- kni: fix build with kernel 3.8
	- kni: fix build with kernel 3.9
	- kni: fix build with kernel 3.10
	- app: fix build with gcc 4.8

I've sent them in July. Note that Linux-3.10 has been released in June.
It is not integrated in 1.3.1r2 because it is waiting for review. Any 
volunteer ?

I understand you haven't tested them. Could you test please ?

By the way, a quick workaround is to disable KNI (CONFIG_RTE_LIBRTE_KNI).

PS: please don't top-post.

-- 
Thomas

Re: compile error in fedora19

[David Nyström]

On Sat 24 Aug 2013 03:58:59 PM CEST, Thomas Monjalon wrote:
> 24/08/2013 05:44, Nulik Nol :
>> Thomas Monjalon wrote:
>>> I've sent some patches which are still waiting for review.
>>> Anybody (including you) may review them.
>>

<snip>

> I understand you haven't tested them. Could you test please ?

Built cleanly on Ubuntu 13.10, 3.11.0-2-generic, which is 3.11-rc5.

As for a review, I can reply to the original patch, however,
check your GCC 4.8 build fix patch, you are only comparing the first 
character of
buf and string_elt_strs[i].result.
Is this the intended result ?

Br,
David

Re: compile error in fedora19

[David Nyström]

On 08/26/2013 10:36 AM, David Nyström wrote:
> On Sat 24 Aug 2013 03:58:59 PM CEST, Thomas Monjalon wrote:
>> 24/08/2013 05:44, Nulik Nol :
>>> Thomas Monjalon wrote:
>>>> I've sent some patches which are still waiting for review.
>>>> Anybody (including you) may review them.
>>>
>
> <snip>
>
>> I understand you haven't tested them. Could you test please ?
>
> Built cleanly on Ubuntu 13.10, 3.11.0-2-generic, which is 3.11-rc5.
>
> As for a review, I can reply to the original patch, however,
> check your GCC 4.8 build fix patch, you are only comparing the first
> character of
> buf and string_elt_strs[i].result.
> Is this the intended result ?
>

Arrgh,

Never mind this, missed a parathesis. its OK.

Br,
David