* scsi: ufs-mediatek: fix ufs power down specs violation
@ 2021-05-12 9:41 peter.wang
2021-05-12 9:41 ` [PATCH v3 1/1] " peter.wang
0 siblings, 1 reply; 4+ messages in thread
From: peter.wang @ 2021-05-12 9:41 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao
As per specs, e.g, JESD220E chapter 7.2, while powering off
the ufs device, RST_N signal should be between VSS(Ground)
and VCCQ/VCCQ2. The power down sequence after fixing as below:
Power down:
1. Assert RST_N low
2. Turn-off VCC
3. Turn-off VCCQ/VCCQ2
drivers/scsi/ufs/ufs-mediatek.c | 4 ++++
1 file changed, 4 insertions(+)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/1] scsi: ufs-mediatek: fix ufs power down specs violation
2021-05-12 9:41 scsi: ufs-mediatek: fix ufs power down specs violation peter.wang
@ 2021-05-12 9:41 ` peter.wang
0 siblings, 0 replies; 4+ messages in thread
From: peter.wang @ 2021-05-12 9:41 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao
From: Peter Wang <peter.wang@mediatek.com>
As per specs, e.g, JESD220E chapter 7.2, while powering off
the ufs device, RST_N signal should be between VSS(Ground)
and VCCQ/VCCQ2. The power down sequence after fixing as below:
Power down:
1. Assert RST_N low
2. Turn-off VCC
3. Turn-off VCCQ/VCCQ2
Change-Id: Ib35768d47026d111e1cdd3c4023f2e131b5e65e8
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index c55202b..47f47ab 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -922,6 +922,7 @@ static void ufs_mtk_vreg_set_lpm(struct ufs_hba *hba, bool lpm)
static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
{
int err;
+ struct arm_smccc_res res;
if (ufshcd_is_link_hibern8(hba)) {
err = ufs_mtk_link_set_lpm(hba);
@@ -941,6 +942,9 @@ static int ufs_mtk_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
goto fail;
}
+ if (ufshcd_is_shutdown_pm(pm_op))
+ ufs_mtk_device_reset_ctrl(0, res);
+
return 0;
fail:
/*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* scsi: ufs-mediatek: fix ufs power down specs violation
@ 2021-05-12 9:15 peter.wang
0 siblings, 0 replies; 4+ messages in thread
From: peter.wang @ 2021-05-12 9:15 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao
As per specs, e.g, JESD220E chapter 7.2, while powering off
the ufs device, RST_N signal should be between VSS(Ground)
and VCCQ/VCCQ2. The power down sequence after fixing as below:
Power down:
1. Assert RST_N low
2. Turn-off VCC
3. Turn-off VCCQ/VCCQ2
drivers/scsi/ufs/ufs-mediatek.c | 4 ++++
1 file changed, 4 insertions(+)
^ permalink raw reply [flat|nested] 4+ messages in thread
* scsi: ufs-mediatek: fix ufs power down specs violation
@ 2021-05-12 8:39 peter.wang
0 siblings, 0 replies; 4+ messages in thread
From: peter.wang @ 2021-05-12 8:39 UTC (permalink / raw)
To: stanley.chu, linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: wsd_upstream, peter.wang, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao
As per specs, e.g, JESD220E chapter 7.2, while powering off
the ufs device, RST_N signal should be between VSS(Ground)
and VCCQ/VCCQ2. The power down sequence after fixing as below:
Power down:
1. Assert RST_N low
2. Turn-off VCC
3. Turn-off VCCQ/VCCQ2
drivers/scsi/ufs/ufs-mediatek.c | 4 ++++
1 file changed, 4 insertions(+)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-12 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 9:41 scsi: ufs-mediatek: fix ufs power down specs violation peter.wang
2021-05-12 9:41 ` [PATCH v3 1/1] " peter.wang
-- strict thread matches above, loose matches on Subject: below --
2021-05-12 9:15 peter.wang
2021-05-12 8:39 peter.wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.