All of lore.kernel.org
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 2/2] net/mlx5: fix mem leak when a device configured repeatedly
@ 2021-05-12 13:18 wangyunjian
  0 siblings, 0 replies; only message in thread
From: wangyunjian @ 2021-05-12 13:18 UTC (permalink / raw)
  To: dev; +Cc: matan, shahafs, viacheslavo, dingxiaoxiong, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
	rte_eth_dev_configure
	rte_eth_rx_queue_setup
	rte_eth_tx_queue_setup
	rte_eth_dev_start
	rte_eth_dev_stop
done

Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/mlx5/mlx5.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 35f91e965e..916744f141 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1455,6 +1455,8 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
 	struct mlx5_proc_priv *ppriv;
 	size_t ppriv_size;
 
+	mlx5_proc_priv_uninit(dev);
+
 	/*
 	 * UAR register table follows the process private structure. BlueFlame
 	 * registers for Tx queues are stored in the table.
-- 
2.23.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-12 13:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 13:18 [dpdk-dev] [PATCH 2/2] net/mlx5: fix mem leak when a device configured repeatedly wangyunjian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.