[PATCH] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag

[PATCH] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag

[Tian Tao]

request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
can be replaced by request_irq() with IRQF_NO_AUTOEN flag.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/pci/controller/dwc/pcie-tegra194.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index bafd2c6..7349926 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -2021,14 +2021,13 @@ static int tegra_pcie_config_ep(struct tegra_pcie_dw *pcie,
 		return -ENOMEM;
 	}
 
-	irq_set_status_flags(pcie->pex_rst_irq, IRQ_NOAUTOEN);
-
 	pcie->ep_state = EP_STATE_DISABLED;
 
 	ret = devm_request_threaded_irq(dev, pcie->pex_rst_irq, NULL,
 					tegra_pcie_ep_pex_rst_irq,
 					IRQF_TRIGGER_RISING |
-					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+					IRQF_TRIGGER_FALLING |
+					IRQF_ONESHOT | IRQF_NO_AUTOEN
 					name, (void *)pcie);
 	if (ret < 0) {
 		dev_err(dev, "Failed to request IRQ for PERST: %d\n", ret);
-- 
2.7.4

Re: [PATCH] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag

[Krzysztof Wilczyński]

Hi Tian,

Thank you for sending the patch over!

> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.

A few comments.

The commit message is a bit terse and the subject could be improved
a little.  Does this change fixes an issue with the driver?  Why is this
flag needed?  The commit message could explain better why this change is
needed, etc.

Krzysztof