* [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 11:06 ` Heiko Stuebner
2021-05-15 10:53 ` [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
` (32 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Heiko Stuebner
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/arc/emac_rockchip.c:18: warning: expecting prototype for emac(). Prototype was for DRV_NAME() instead
Cc: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/arc/emac_rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
index 48ecdf1..1c9ca3b 100644
--- a/drivers/net/ethernet/arc/emac_rockchip.c
+++ b/drivers/net/ethernet/arc/emac_rockchip.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* emac-rockchip.c - Rockchip EMAC specific glue layer
*
* Copyright (C) 2014 Romain Perier <romain.perier@gmail.com>
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers
2021-05-15 10:53 ` [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 11:06 ` Heiko Stuebner
0 siblings, 0 replies; 47+ messages in thread
From: Heiko Stuebner @ 2021-05-15 11:06 UTC (permalink / raw)
To: davem, kuba, Yang Shen; +Cc: netdev, linux-kernel, Yang Shen
Am Samstag, 15. Mai 2021, 12:53:26 CEST schrieb Yang Shen:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/arc/emac_rockchip.c:18: warning: expecting prototype for emac(). Prototype was for DRV_NAME() instead
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/net/ethernet/arc/emac_rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c
> index 48ecdf1..1c9ca3b 100644
> --- a/drivers/net/ethernet/arc/emac_rockchip.c
> +++ b/drivers/net/ethernet/arc/emac_rockchip.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> -/**
> +/*
> * emac-rockchip.c - Rockchip EMAC specific glue layer
> *
> * Copyright (C) 2014 Romain Perier <romain.perier@gmail.com>
>
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
2021-05-15 10:53 ` [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 14:21 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 03/34] net: atheros: atl1e: " Yang Shen
` (31 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:442: warning: expecting prototype for atl1c_set_mac(). Prototype was for atl1c_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:969: warning: expecting prototype for atl1c_setup_mem_resources(). Prototype was for atl1c_setup_ring_resources() instead
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1375: warning: expecting prototype for atl1c_configure(). Prototype was for atl1c_configure_mac() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 740127a..77da1c5 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -432,7 +432,7 @@ static void atl1c_restore_vlan(struct atl1c_adapter *adapter)
}
/**
- * atl1c_set_mac - Change the Ethernet Address of the NIC
+ * atl1c_set_mac_addr - Change the Ethernet Address of the NIC
* @netdev: network interface device structure
* @p: pointer to an address structure
*
@@ -960,7 +960,7 @@ static void atl1c_free_ring_resources(struct atl1c_adapter *adapter)
}
/**
- * atl1c_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1c_setup_ring_resources - allocate Tx / RX descriptor resources
* @adapter: board private structure
*
* Return 0 on success, negative on failure
@@ -1366,7 +1366,7 @@ static void atl1c_set_aspm(struct atl1c_hw *hw, u16 link_speed)
}
/**
- * atl1c_configure - Configure Transmit&Receive Unit after Reset
+ * atl1c_configure_mac - Configure Transmit&Receive Unit after Reset
* @adapter: board private structure
*
* Configure the Tx /Rx unit of the MAC after a reset.
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments
2021-05-15 10:53 ` [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
@ 2021-05-15 14:21 ` Andrew Lunn
0 siblings, 0 replies; 47+ messages in thread
From: Andrew Lunn @ 2021-05-15 14:21 UTC (permalink / raw)
To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel, Chris Snook
On Sat, May 15, 2021 at 06:53:27PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:442: warning: expecting prototype for atl1c_set_mac(). Prototype was for atl1c_set_mac_addr() instead
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:969: warning: expecting prototype for atl1c_setup_mem_resources(). Prototype was for atl1c_setup_ring_resources() instead
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1375: warning: expecting prototype for atl1c_configure(). Prototype was for atl1c_configure_mac() instead
>
> Cc: Chris Snook <chris.snook@gmail.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 03/34] net: atheros: atl1e: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
2021-05-15 10:53 ` [PATCH 01/34] net: arc: Demote non-compliant kernel-doc headers Yang Shen
2021-05-15 10:53 ` [PATCH 02/34] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 14:23 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 04/34] net: atheros: atl1x: " Yang Shen
` (30 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:367: warning: expecting prototype for atl1e_set_mac(). Prototype was for atl1e_set_mac_addr() instead
drivers/net/ethernet/atheros/atl1e/atl1e_main.c:796: warning: expecting prototype for atl1e_setup_mem_resources(). Prototype was for atl1e_setup_ring_resources() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
index ff9f96d..2eb0a2a 100644
--- a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
@@ -357,7 +357,7 @@ static void atl1e_restore_vlan(struct atl1e_adapter *adapter)
}
/**
- * atl1e_set_mac - Change the Ethernet Address of the NIC
+ * atl1e_set_mac_addr - Change the Ethernet Address of the NIC
* @netdev: network interface device structure
* @p: pointer to an address structure
*
@@ -787,7 +787,7 @@ static void atl1e_free_ring_resources(struct atl1e_adapter *adapter)
}
/**
- * atl1e_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1e_setup_ring_resources - allocate Tx / RX descriptor resources
* @adapter: board private structure
*
* Return 0 on success, negative on failure
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 03/34] net: atheros: atl1e: Fix wrong function name in comments
2021-05-15 10:53 ` [PATCH 03/34] net: atheros: atl1e: " Yang Shen
@ 2021-05-15 14:23 ` Andrew Lunn
0 siblings, 0 replies; 47+ messages in thread
From: Andrew Lunn @ 2021-05-15 14:23 UTC (permalink / raw)
To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel, Chris Snook
On Sat, May 15, 2021 at 06:53:28PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/atheros/atl1e/atl1e_main.c:367: warning: expecting prototype for atl1e_set_mac(). Prototype was for atl1e_set_mac_addr() instead
> drivers/net/ethernet/atheros/atl1e/atl1e_main.c:796: warning: expecting prototype for atl1e_setup_mem_resources(). Prototype was for atl1e_setup_ring_resources() instead
>
> Cc: Chris Snook <chris.snook@gmail.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 04/34] net: atheros: atl1x: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (2 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 03/34] net: atheros: atl1e: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 14:25 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 05/34] net: broadcom: bnx2x: " Yang Shen
` (29 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Chris Snook
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/atheros/atlx/atl1.c:1020: warning: expecting prototype for atl1_setup_mem_resources(). Prototype was for atl1_setup_ring_resources() instead
Cc: Chris Snook <chris.snook@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/atheros/atlx/atl1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c
index eaf96d0..c67201a 100644
--- a/drivers/net/ethernet/atheros/atlx/atl1.c
+++ b/drivers/net/ethernet/atheros/atlx/atl1.c
@@ -1011,7 +1011,7 @@ static int atl1_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
}
/**
- * atl1_setup_mem_resources - allocate Tx / RX descriptor resources
+ * atl1_setup_ring_resources - allocate Tx / RX descriptor resources
* @adapter: board private structure
*
* Return 0 on success, negative on failure
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 04/34] net: atheros: atl1x: Fix wrong function name in comments
2021-05-15 10:53 ` [PATCH 04/34] net: atheros: atl1x: " Yang Shen
@ 2021-05-15 14:25 ` Andrew Lunn
0 siblings, 0 replies; 47+ messages in thread
From: Andrew Lunn @ 2021-05-15 14:25 UTC (permalink / raw)
To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel, Chris Snook
On Sat, May 15, 2021 at 06:53:29PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/atheros/atlx/atl1.c:1020: warning: expecting prototype for atl1_setup_mem_resources(). Prototype was for atl1_setup_ring_resources() instead
>
> Cc: Chris Snook <chris.snook@gmail.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 05/34] net: broadcom: bnx2x: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (3 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 04/34] net: atheros: atl1x: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 06/34] net: brocade: bna: " Yang Shen
` (28 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Ariel Elior, Sudarsana Kalluru,
GR-everest-linux-l2
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13595: warning: expecting prototype for bnx2x_get_num_none_def_sbs(). Prototype was for bnx2x_get_num_non_def_sbs() instead
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4165: warning: expecting prototype for atomic_add_ifless(). Prototype was for __atomic_add_ifless() instead
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4193: warning: expecting prototype for atomic_dec_ifmoe(). Prototype was for __atomic_dec_ifmoe() instead
Cc: Ariel Elior <aelior@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: GR-everest-linux-l2@marvell.com
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 281b1c2..2acbc73 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -13586,7 +13586,7 @@ static int bnx2x_set_qm_cid_count(struct bnx2x *bp)
}
/**
- * bnx2x_get_num_none_def_sbs - return the number of none default SBs
+ * bnx2x_get_num_non_def_sbs - return the number of none default SBs
* @pdev: pci device
* @cnic_cnt: count
*
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 6cd1523..542c698 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -4152,7 +4152,7 @@ void bnx2x_init_mcast_obj(struct bnx2x *bp,
/*************************** Credit handling **********************************/
/**
- * atomic_add_ifless - add if the result is less than a given value.
+ * __atomic_add_ifless - add if the result is less than a given value.
*
* @v: pointer of type atomic_t
* @a: the amount to add to v...
@@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v, int a, int u)
}
/**
- * atomic_dec_ifmoe - dec if the result is more or equal than a given value.
+ * __atomic_dec_ifmoe - dec if the result is more or equal than a given value.
*
* @v: pointer of type atomic_t
* @a: the amount to dec from v...
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 06/34] net: brocade: bna: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (4 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 05/34] net: broadcom: bnx2x: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers Yang Shen
` (27 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Rasesh Mody, Sudarsana Kalluru,
GR-Linux-NIC-Dev
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/brocade/bna/bfa_cee.c:91: warning: expecting prototype for bfa_cee_get_attr_isr(). Prototype was for bfa_cee_get_stats_isr() instead
Cc: Rasesh Mody <rmody@marvell.com>
Cc: Sudarsana Kalluru <skalluru@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/brocade/bna/bfa_cee.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_cee.c b/drivers/net/ethernet/brocade/bna/bfa_cee.c
index 06f221c..eeb05e3 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_cee.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_cee.c
@@ -82,7 +82,7 @@ bfa_cee_get_attr_isr(struct bfa_cee *cee, enum bfa_status status)
}
/**
- * bfa_cee_get_attr_isr - CEE ISR for get-stats responses from f/w
+ * bfa_cee_get_stats_isr - CEE ISR for get-stats responses from f/w
*
* @cee: Pointer to the CEE module
* @status: Return status from the f/w
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (5 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 06/34] net: brocade: bna: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 12:46 ` Nicolas.Ferre
2021-05-15 10:53 ` [PATCH 08/34] net: calxeda: Fix wrong function name in comments Yang Shen
` (26 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Nicolas Ferre, Claudiu Beznea
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
index 283918a..5c368a9 100644
--- a/drivers/net/ethernet/cadence/macb_ptp.c
+++ b/drivers/net/ethernet/cadence/macb_ptp.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
* 1588 PTP support for Cadence GEM device.
*
* Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers
2021-05-15 10:53 ` [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 12:46 ` Nicolas.Ferre
2021-05-17 1:48 ` Yang Shen
0 siblings, 1 reply; 47+ messages in thread
From: Nicolas.Ferre @ 2021-05-15 12:46 UTC (permalink / raw)
To: shenyang39, davem, kuba; +Cc: netdev, linux-kernel, Claudiu.Beznea
On 15/05/2021 at 12:53, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Ok, if it raises a warning.
But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
with same change to a combined patch.
Regards,
Nicolas
> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
> drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 283918a..5c368a9 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
> * 1588 PTP support for Cadence GEM device.
> *
> * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
> --
> 2.7.4
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 47+ messages in thread
* Re: [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers
2021-05-15 12:46 ` Nicolas.Ferre
@ 2021-05-17 1:48 ` Yang Shen
0 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-17 1:48 UTC (permalink / raw)
To: Nicolas.Ferre, davem, kuba; +Cc: netdev, linux-kernel, Claudiu.Beznea
On 2021/5/15 20:46, Nicolas.Ferre@microchip.com wrote:
> On 15/05/2021 at 12:53, Yang Shen wrote:
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/net/ethernet/cadence/macb_ptp.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>>
>> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Ok, if it raises a warning.
>
> But I would prefer that you add drivers/net/ethernet/cadence/macb_pci.c
> with same change to a combined patch.
>
> Regards,
> Nicolas
>
OK，The compiler missed this warning at
drivers/net/ethernet/cadence/macb_pci.c.
I'll fix this in the next version.
Thanks,
Yang
>
>> Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
>> Signed-off-by: Yang Shen <shenyang39@huawei.com>
>> ---
>> drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
>> index 283918a..5c368a9 100644
>> --- a/drivers/net/ethernet/cadence/macb_ptp.c
>> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
>> @@ -1,5 +1,5 @@
>> // SPDX-License-Identifier: GPL-2.0-only
>> -/**
>> +/*
>> * 1588 PTP support for Cadence GEM device.
>> *
>> * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
>> --
>> 2.7.4
>>
>
>
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 08/34] net: calxeda: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (6 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 07/34] net: cadence: macb_ptp: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 09/34] net: chelsio: cxgb3: " Yang Shen
` (25 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/calxeda/xgmac.c:720: warning: expecting prototype for init_xgmac_dma_desc_rings(). Prototype was for xgmac_dma_desc_rings_init() instead
drivers/net/ethernet/calxeda/xgmac.c:867: warning: expecting prototype for xgmac_tx(). Prototype was for xgmac_tx_complete() instead
drivers/net/ethernet/calxeda/xgmac.c:1049: warning: expecting prototype for xgmac_release(). Prototype was for xgmac_stop() instead
drivers/net/ethernet/calxeda/xgmac.c:1822: warning: expecting prototype for xgmac_dvr_remove(). Prototype was for xgmac_remove() instead
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/calxeda/xgmac.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index bbb453c..b6a0664 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -711,7 +711,7 @@ static void xgmac_rx_refill(struct xgmac_priv *priv)
}
/**
- * init_xgmac_dma_desc_rings - init the RX/TX descriptor rings
+ * xgmac_dma_desc_rings_init - init the RX/TX descriptor rings
* @dev: net device structure
* Description: this function initializes the DMA RX/TX descriptors
* and allocates the socket buffers.
@@ -859,7 +859,7 @@ static void xgmac_free_dma_desc_rings(struct xgmac_priv *priv)
}
/**
- * xgmac_tx:
+ * xgmac_tx_complete:
* @priv: private driver structure
* Description: it reclaims resources after transmission completes.
*/
@@ -1040,7 +1040,7 @@ static int xgmac_open(struct net_device *dev)
}
/**
- * xgmac_release - close entry point of the driver
+ * xgmac_stop - close entry point of the driver
* @dev : device pointer.
* Description:
* This is the stop entry point of the driver.
@@ -1812,7 +1812,7 @@ static int xgmac_probe(struct platform_device *pdev)
}
/**
- * xgmac_dvr_remove
+ * xgmac_remove
* @pdev: platform device pointer
* Description: this function resets the TX/RX processes, disables the MAC RX/TX
* changes the link status, releases the DMA descriptor rings,
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 09/34] net: chelsio: cxgb3: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (7 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 08/34] net: calxeda: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 10/34] net: chelsio: cxgb4: " Yang Shen
` (24 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/chelsio/cxgb3/sge.c:677: warning: expecting prototype for free_qset(). Prototype was for t3_free_qset() instead
drivers/net/ethernet/chelsio/cxgb3/sge.c:1266: warning: expecting prototype for eth_xmit(). Prototype was for t3_eth_xmit() instead
Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index 1cc3c51..cec7308 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -665,7 +665,7 @@ static void t3_reset_qset(struct sge_qset *q)
/**
- * free_qset - free the resources of an SGE queue set
+ * t3_free_qset - free the resources of an SGE queue set
* @adapter: the adapter owning the queue set
* @q: the queue set
*
@@ -1256,7 +1256,7 @@ static inline void t3_stop_tx_queue(struct netdev_queue *txq,
}
/**
- * eth_xmit - add a packet to the Ethernet Tx queue
+ * t3_eth_xmit - add a packet to the Ethernet Tx queue
* @skb: the packet
* @dev: the egress net device
*
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 10/34] net: chelsio: cxgb4: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (8 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 09/34] net: chelsio: cxgb3: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 11/34] net: chelsio: cxgb4vf: " Yang Shen
` (23 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/chelsio/cxgb3/sge.c:677: warning: expecting prototype for free_qset(). Prototype was for t3_free_qset() instead
drivers/net/ethernet/chelsio/cxgb3/sge.c:1266: warning: expecting prototype for eth_xmit(). Prototype was for t3_eth_xmit() instead
Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
index 70dbee8..5bf117d 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c
@@ -446,7 +446,7 @@ void cxgb4_ptp_init(struct adapter *adapter)
}
/**
- * cxgb4_ptp_remove - disable PTP device and stop the overflow check
+ * cxgb4_ptp_stop - disable PTP device and stop the overflow check
* @adapter: board private structure
*
* Stop the PTP support.
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index 9428ef1..ae3ad99 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
@@ -6983,7 +6983,7 @@ int t4_fw_bye(struct adapter *adap, unsigned int mbox)
}
/**
- * t4_init_cmd - ask FW to initialize the device
+ * t4_early_init - ask FW to initialize the device
* @adap: the adapter
* @mbox: mailbox to use for the FW command
*
@@ -10224,7 +10224,7 @@ int t4_load_cfg(struct adapter *adap, const u8 *cfg_data, unsigned int size)
}
/**
- * t4_set_vf_mac - Set MAC address for the specified VF
+ * t4_set_vf_mac_acl - Set MAC address for the specified VF
* @adapter: The adapter
* @vf: one of the VFs instantiated by the specified PF
* @naddr: the number of MAC addresses
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 11/34] net: chelsio: cxgb4vf: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (9 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 10/34] net: chelsio: cxgb4: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 12/34] net: huawei: hinic: " Yang Shen
` (22 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Raju Rangoju
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/chelsio/cxgb4vf/sge.c:966: warning: expecting prototype for check_ring_tx_db(). Prototype was for ring_tx_db() instead
Cc: Raju Rangoju <rajur@chelsio.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
index 95657da..7bc80ee 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/sge.c
@@ -954,7 +954,7 @@ static void write_sgl(const struct sk_buff *skb, struct sge_txq *tq,
}
/**
- * check_ring_tx_db - check and potentially ring a TX queue's doorbell
+ * ring_tx_db - check and potentially ring a TX queue's doorbell
* @adapter: the adapter
* @tq: the TX queue
* @n: number of new descriptors to give to HW
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 12/34] net: huawei: hinic: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (10 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 11/34] net: chelsio: cxgb4vf: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 13/34] net: micrel: " Yang Shen
` (21 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Bin Luo
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:604: warning: expecting prototype for cmdq_arm_ceq_handler(). Prototype was for cmdq_sync_cmd_handler() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:59: warning: expecting prototype for get_capability(). Prototype was for parse_capability() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:101: warning: expecting prototype for get_cap_from_fw(). Prototype was for get_capability() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:355: warning: expecting prototype for clear_io_resource(). Prototype was for clear_io_resources() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:1100: warning: expecting prototype for hinic_hwdev_get_sq(). Prototype was for hinic_hwdev_get_rq() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_if.c:341: warning: expecting prototype for dma_attr_table_init(). Prototype was for dma_attr_init() instead
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c:904: warning: expecting prototype for hinic_put_wqe(). Prototype was for hinic_rq_put_wqe() instead
drivers/net/ethernet/huawei/hinic/hinic_main.c:241: warning: expecting prototype for create_txqs(). Prototype was for create_rxqs() instead
drivers/net/ethernet/huawei/hinic/hinic_main.c:295: warning: expecting prototype for free_txqs(). Prototype was for free_rxqs() instead
drivers/net/ethernet/huawei/hinic/hinic_tx.c:667: warning: expecting prototype for free_all_rx_skbs(). Prototype was for free_all_tx_skbs() instead
Cc: Bin Luo <luobin9@huawei.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 8 ++++----
drivers/net/ethernet/huawei/hinic/hinic_hw_if.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c | 2 +-
drivers/net/ethernet/huawei/hinic/hinic_main.c | 4 ++--
drivers/net/ethernet/huawei/hinic/hinic_tx.c | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
index 577cb2cf..307a6d4 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
@@ -594,7 +594,7 @@ static void cmdq_update_errcode(struct hinic_cmdq *cmdq, u16 prod_idx,
}
/**
- * cmdq_arm_ceq_handler - cmdq completion event handler for sync command
+ * cmdq_sync_cmd_handler - cmdq completion event handler for sync command
* @cmdq: the cmdq of the command
* @cons_idx: the consumer index to update the error code for
* @errcode: the error code
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
index 19a91c0..428108e 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
@@ -48,7 +48,7 @@ enum io_status {
};
/**
- * get_capability - convert device capabilities to NIC capabilities
+ * parse_capability - convert device capabilities to NIC capabilities
* @hwdev: the HW device to set and convert device capabilities for
* @dev_cap: device capabilities from FW
*
@@ -92,7 +92,7 @@ static int parse_capability(struct hinic_hwdev *hwdev,
}
/**
- * get_cap_from_fw - get device capabilities from FW
+ * get_capability - get device capabilities from FW
* @pfhwdev: the PF HW device to get capabilities for
*
* Return 0 - Success, negative - Failure
@@ -346,7 +346,7 @@ static int wait_for_db_state(struct hinic_hwdev *hwdev)
}
/**
- * clear_io_resource - set the IO resources as not active in the NIC
+ * clear_io_resources - set the IO resources as not active in the NIC
* @hwdev: the NIC HW device
*
* Return 0 - Success, negative - Failure
@@ -1090,7 +1090,7 @@ struct hinic_sq *hinic_hwdev_get_sq(struct hinic_hwdev *hwdev, int i)
}
/**
- * hinic_hwdev_get_sq - get RQ
+ * hinic_hwdev_get_rq - get RQ
* @hwdev: the NIC HW device
* @i: the position of the RQ
*
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
index 55b327e..0428faa 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
@@ -334,7 +334,7 @@ static void set_dma_attr(struct hinic_hwif *hwif, u32 entry_idx,
}
/**
- * dma_attr_table_init - initialize the default dma attributes
+ * dma_attr_init - initialize the default dma attributes
* @hwif: the HW interface of a pci function device
**/
static void dma_attr_init(struct hinic_hwif *hwif)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
index dcba4d0..336248a 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
@@ -894,7 +894,7 @@ struct hinic_rq_wqe *hinic_rq_read_next_wqe(struct hinic_rq *rq,
}
/**
- * hinic_put_wqe - release the ci for new wqes
+ * hinic_rq_put_wqe - release the ci for new wqes
* @rq: recv queue
* @cons_idx: consumer index of the wqe
* @wqe_size: the size of the wqe
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
index 1da5997..405ee4d 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_main.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c
@@ -232,7 +232,7 @@ static void free_txqs(struct hinic_dev *nic_dev)
}
/**
- * create_txqs - Create the Logical Rx Queues of specific NIC device
+ * create_rxqs - Create the Logical Rx Queues of specific NIC device
* @nic_dev: the specific NIC device
*
* Return 0 - Success, negative - Failure
@@ -288,7 +288,7 @@ static int create_rxqs(struct hinic_dev *nic_dev)
}
/**
- * free_txqs - Free the Logical Rx Queues of specific NIC device
+ * free_rxqs - Free the Logical Rx Queues of specific NIC device
* @nic_dev: the specific NIC device
**/
static void free_rxqs(struct hinic_dev *nic_dev)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
index 7bd414a..c5bdb0d 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
@@ -660,7 +660,7 @@ static void tx_free_skb(struct hinic_dev *nic_dev, struct sk_buff *skb,
}
/**
- * free_all_rx_skbs - free all skbs in tx queue
+ * free_all_tx_skbs - free all skbs in tx queue
* @txq: tx queue
**/
static void free_all_tx_skbs(struct hinic_txq *txq)
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 13/34] net: micrel: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (11 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 12/34] net: huawei: hinic: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 14/34] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
` (20 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Tristram Ha
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/micrel/ksz884x.c:2163: warning: expecting prototype for sw_get_board_storm(). Prototype was for sw_get_broad_storm() instead
drivers/net/ethernet/micrel/ksz884x.c:2985: warning: expecting prototype for port_w_phy(). Prototype was for hw_w_phy() instead
drivers/net/ethernet/micrel/ksz884x.c:4792: warning: expecting prototype for transmit_done(). Prototype was for tx_done() instead
Cc: Tristram Ha <Tristram.Ha@micrel.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/micrel/ksz884x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 9ed264e..3532bfe 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -2153,7 +2153,7 @@ static void sw_cfg_broad_storm(struct ksz_hw *hw, u8 percent)
}
/**
- * sw_get_board_storm - get broadcast storm threshold
+ * sw_get_broad_storm - get broadcast storm threshold
* @hw: The hardware instance.
* @percent: Buffer to store the broadcast storm threshold percentage.
*
@@ -2973,7 +2973,7 @@ static void hw_r_phy(struct ksz_hw *hw, int port, u16 reg, u16 *val)
}
/**
- * port_w_phy - write data to PHY register
+ * hw_w_phy - write data to PHY register
* @hw: The hardware instance.
* @port: Port to write.
* @reg: PHY register to write.
@@ -4782,7 +4782,7 @@ static void transmit_cleanup(struct dev_info *hw_priv, int normal)
}
/**
- * transmit_done - transmit done processing
+ * tx_done - transmit done processing
* @hw_priv: Network device.
*
* This routine is called when the transmit interrupt is triggered, indicating
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 14/34] net: microchip: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (12 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 13/34] net: micrel: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 15/34] net: neterion: Fix wrong function name in comments Yang Shen
` (19 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Ringle
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/microchip/encx24j600.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Jon Ringle <jringle@gridpoint.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/microchip/encx24j600.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index 3658c4ae..ee921a9 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* Microchip ENCX24J600 ethernet driver
*
* Copyright (C) 2015 Gridpoint
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 15/34] net: neterion: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (13 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 14/34] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 16/34] net: neterion: vxge: " Yang Shen
` (18 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Mason
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/neterion/s2io.c:2759: warning: expecting prototype for s2io_poll(). Prototype was for s2io_poll_msix() instead
drivers/net/ethernet/neterion/s2io.c:5304: warning: expecting prototype for s2io_ethtol_get_link_ksettings(). Prototype was for s2io_ethtool_get_link_ksettings() instead
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/neterion/s2io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c
index 9cfcd55..27a65ab3 100644
--- a/drivers/net/ethernet/neterion/s2io.c
+++ b/drivers/net/ethernet/neterion/s2io.c
@@ -2743,7 +2743,7 @@ static int s2io_chk_rx_buffers(struct s2io_nic *nic, struct ring_info *ring)
}
/**
- * s2io_poll - Rx interrupt handler for NAPI support
+ * s2io_poll_msix - Rx interrupt handler for NAPI support
* @napi : pointer to the napi structure.
* @budget : The number of packets that were budgeted to be processed
* during one pass through the 'Poll" function.
@@ -5288,7 +5288,7 @@ s2io_ethtool_set_link_ksettings(struct net_device *dev,
}
/**
- * s2io_ethtol_get_link_ksettings - Return link specific information.
+ * s2io_ethtool_get_link_ksettings - Return link specific information.
* @dev: pointer to netdev
* @cmd : pointer to the structure with parameters given by ethtool
* to return link information.
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 16/34] net: neterion: vxge: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (14 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 15/34] net: neterion: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 17/34] net: netronome: nfp: " Yang Shen
` (17 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Jon Mason
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/neterion/vxge/vxge-config.c:4895: warning: expecting prototype for vxge_hw_vpath_rx_doorbell_post(). Prototype was for vxge_hw_vpath_rx_doorbell_init() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:1814: warning: expecting prototype for vxge_poll(). Prototype was for vxge_poll_msix() instead
drivers/net/ethernet/neterion/vxge/vxge-main.c:4761: warning: expecting prototype for vxge_rem_nic(). Prototype was for vxge_remove() instead
Cc: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
index 5162b93..38a273c 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
@@ -4884,7 +4884,7 @@ vxge_hw_vpath_open(struct __vxge_hw_device *hldev,
}
/**
- * vxge_hw_vpath_rx_doorbell_post - Close the handle got from previous vpath
+ * vxge_hw_vpath_rx_doorbell_init - Close the handle got from previous vpath
* (vpath) open
* @vp: Handle got from previous vpath open
*
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index 87892bd..b113c15 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -1799,7 +1799,7 @@ static void vxge_reset(struct work_struct *work)
}
/**
- * vxge_poll - Receive handler when Receive Polling is used.
+ * vxge_poll_msix - Receive handler when Receive Polling is used.
* @napi: pointer to the napi structure.
* @budget: Number of packets budgeted to be processed in this iteration.
*
@@ -4752,7 +4752,7 @@ vxge_probe(struct pci_dev *pdev, const struct pci_device_id *pre)
}
/**
- * vxge_rem_nic - Free the PCI device
+ * vxge_remove - Free the PCI device
* @pdev: structure containing the PCI related information of the device.
* Description: This function is called by the Pci subsystem to release a
* PCI device and free up all resource held up by the device.
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 17/34] net: netronome: nfp: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (15 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 16/34] net: neterion: vxge: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-17 9:45 ` Simon Horman
2021-05-15 10:53 ` [PATCH 18/34] net: calxeda: " Yang Shen
` (16 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Simon Horman
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead
Cc: Simon Horman <simon.horman@netronome.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/netronome/nfp/ccm_mbox.c | 2 +-
drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 +-
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/ccm_mbox.c b/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
index f0783aa..4247bca 100644
--- a/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
+++ b/drivers/net/ethernet/netronome/nfp/ccm_mbox.c
@@ -36,7 +36,7 @@ enum nfp_net_mbox_cmsg_state {
};
/**
- * struct nfp_ccm_mbox_skb_cb - CCM mailbox specific info
+ * struct nfp_ccm_mbox_cmsg_cb - CCM mailbox specific info
* @state: processing state (/stage) of the message
* @err: error encountered during processing if any
* @max_len: max(request_len, reply_len)
diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
index d19c02e..ab70179 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c
@@ -21,7 +21,7 @@
#define NFP_TUN_PRE_TUN_IPV6_BIT BIT(7)
/**
- * struct nfp_tun_pre_run_rule - rule matched before decap
+ * struct nfp_tun_pre_tun_rule - rule matched before decap
* @flags: options for the rule offset
* @port_idx: index of destination MAC address for the rule
* @vlan_tci: VLAN info associated with MAC
diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
index d4e0254..e2e5fd0 100644
--- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
+++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c
@@ -24,7 +24,7 @@
#define NFFW_FWID_ALL 255
-/**
+/*
* NFFW_INFO_VERSION history:
* 0: This was never actually used (before versioning), but it refers to
* the previous struct which had FWINFO_CNT = MEINFO_CNT = 120 that later
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 17/34] net: netronome: nfp: Fix wrong function name in comments
2021-05-15 10:53 ` [PATCH 17/34] net: netronome: nfp: " Yang Shen
@ 2021-05-17 9:45 ` Simon Horman
0 siblings, 0 replies; 47+ messages in thread
From: Simon Horman @ 2021-05-17 9:45 UTC (permalink / raw)
To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel
On Sat, May 15, 2021 at 06:53:42PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/netronome/nfp/ccm_mbox.c:52: warning: expecting prototype for struct nfp_ccm_mbox_skb_cb. Prototype was for struct nfp_ccm_mbox_cmsg_cb instead
> drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:35: warning: expecting prototype for struct nfp_tun_pre_run_rule. Prototype was for struct nfp_tun_pre_tun_rule instead
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c:38: warning: expecting prototype for NFFW_INFO_VERSION history(). Prototype was for NFFW_INFO_VERSION_CURRENT() instead
>
> Cc: Simon Horman <simon.horman@netronome.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Thanks,
looks good to me.
Signed-off-by: Simon Horman <simon.horman@netronome.com>
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 18/34] net: calxeda: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (16 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 17/34] net: netronome: nfp: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 19/34] net: samsung: sxgbe: " Yang Shen
` (15 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Shahed Shaikh, Manish Chopra
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c:761: warning: expecting prototype for qlcnic_83xx_idc_cold_state(). Prototype was for qlcnic_83xx_idc_cold_state_handler() instead
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c:192: warning: expecting prototype for qlcnic_83xx_vnic_opmode(). Prototype was for qlcnic_83xx_config_vnic_opmode() instead
Cc: Shahed Shaikh <shshaikh@marvell.com>
Cc: Manish Chopra <manishc@marvell.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index d2c1907..0a2f34f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -746,7 +746,7 @@ static int qlcnic_83xx_idc_unknown_state(struct qlcnic_adapter *adapter)
}
/**
- * qlcnic_83xx_idc_cold_state
+ * qlcnic_83xx_idc_cold_state_handler
*
* @adapter: adapter structure
*
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
index c4297ae..7116095 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_vnic.c
@@ -180,7 +180,7 @@ static int qlcnic_83xx_init_non_privileged_vnic(struct qlcnic_adapter *adapter)
}
/**
- * qlcnic_83xx_vnic_opmode
+ * qlcnic_83xx_config_vnic_opmode
*
* @adapter: adapter structure
* Identify virtual NIC operational modes.
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 19/34] net: samsung: sxgbe: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (17 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 18/34] net: calxeda: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
` (14 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Byungho An
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:797: warning: expecting prototype for sxgbe_tx_clean(). Prototype was for sxgbe_tx_all_clean() instead
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1026: warning: expecting prototype for sxgbe_init_tx_coalesce(). Prototype was for sxgbe_tx_init_coalesce() instead
Cc: Byungho An <bh74.an@samsung.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
index 971f1e5..090bcd2 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
@@ -789,7 +789,7 @@ static void sxgbe_tx_queue_clean(struct sxgbe_tx_queue *tqueue)
}
/**
- * sxgbe_tx_clean:
+ * sxgbe_tx_all_clean:
* @priv: driver private structure
* Description: it reclaims resources after transmission completes.
*/
@@ -1015,7 +1015,7 @@ static void sxgbe_tx_timer(struct timer_list *t)
}
/**
- * sxgbe_init_tx_coalesce: init tx mitigation options.
+ * sxgbe_tx_init_coalesce: init tx mitigation options.
* @priv: driver private structure
* Description:
* This inits the transmit coalesce parameters: i.e. timer rate,
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (18 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 19/34] net: samsung: sxgbe: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-17 2:17 ` Kunihiko Hayashi
2021-05-15 10:53 ` [PATCH 21/34] net: ti: Fix wrong struct name in comments Yang Shen
` (13 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Kunihiko Hayashi
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/socionext/sni_ave.c:28: warning: expecting prototype for sni_ave.c(). Prototype was for AVE_IDR() instead
Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/socionext/sni_ave.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index fcbb4bb..5eb6bb4 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* sni_ave.c - Socionext UniPhier AVE ethernet driver
* Copyright 2014 Panasonic Corporation
* Copyright 2015-2017 Socionext Inc.
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers
2021-05-15 10:53 ` [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-17 2:17 ` Kunihiko Hayashi
0 siblings, 0 replies; 47+ messages in thread
From: Kunihiko Hayashi @ 2021-05-17 2:17 UTC (permalink / raw)
To: Yang Shen; +Cc: davem, kuba, netdev, linux-kernel
Hi Yang,
On 2021/05/15 19:53, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/socionext/sni_ave.c:28: warning: expecting prototype for sni_ave.c(). Prototype was for AVE_IDR() instead
>
> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
I confirmed the fix of the warning.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 21/34] net: ti: Fix wrong struct name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (19 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 20/34] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 22/34] net: via: Fix wrong function " Yang Shen
` (12 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Cyril Chemparathy, Grygorii Strashko
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/ti/cpsw_ale.c:88: warning: expecting prototype for struct ale_dev_id. Prototype was for struct cpsw_ale_dev_id instead
Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/ti/cpsw_ale.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
index d828f85..0c75e05 100644
--- a/drivers/net/ethernet/ti/cpsw_ale.c
+++ b/drivers/net/ethernet/ti/cpsw_ale.c
@@ -70,7 +70,7 @@ enum {
};
/**
- * struct ale_dev_id - The ALE version/SoC specific configuration
+ * struct cpsw_ale_dev_id - The ALE version/SoC specific configuration
* @dev_id: ALE version/SoC id
* @features: features supported by ALE
* @tbl_entries: number of ALE entries
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 22/34] net: via: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (20 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 21/34] net: ti: Fix wrong struct name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers Yang Shen
` (11 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Francois Romieu
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/via/via-velocity.c:1908: warning: expecting prototype for tx_srv(). Prototype was for velocity_tx_srv() instead
drivers/net/ethernet/via/via-velocity.c:2466: warning: expecting prototype for velocity_get_status(). Prototype was for velocity_get_stats() instead
drivers/net/ethernet/via/via-velocity.c:3734: warning: expecting prototype for velocity_cleanup(). Prototype was for velocity_cleanup_module() instead
Cc: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/ethernet/via/via-velocity.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c
index fecc4d7..88426b5 100644
--- a/drivers/net/ethernet/via/via-velocity.c
+++ b/drivers/net/ethernet/via/via-velocity.c
@@ -1897,7 +1897,7 @@ static void velocity_error(struct velocity_info *vptr, int status)
}
/**
- * tx_srv - transmit interrupt service
+ * velocity_tx_srv - transmit interrupt service
* @vptr: Velocity
*
* Scan the queues looking for transmitted packets that
@@ -2453,7 +2453,7 @@ static int velocity_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
}
/**
- * velocity_get_status - statistics callback
+ * velocity_get_stats - statistics callback
* @dev: network device
*
* Callback from the network layer to allow driver statistics
@@ -3723,7 +3723,7 @@ static int __init velocity_init_module(void)
}
/**
- * velocity_cleanup - module unload
+ * velocity_cleanup_module - module unload
*
* When the velocity hardware is unloaded this function is called.
* It will clean up the notifiers and the unregister the PCI
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (21 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 22/34] net: via: Fix wrong function " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 14:17 ` Andrew Lunn
2021-05-15 10:53 ` [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments Yang Shen
` (10 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Andrew Lunn, Heiner Kallweit,
Russell King
Fixes the following W=1 kernel build warning(s):
drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/phy/adin.c | 2 +-
drivers/net/phy/rockchip.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 55a0b91..5ce6da6 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
-/**
+/*
* Driver for Analog Devices Industrial Ethernet PHYs
*
* Copyright 2019 Analog Devices Inc.
diff --git a/drivers/net/phy/rockchip.c b/drivers/net/phy/rockchip.c
index 52f1f65..bb13e75 100644
--- a/drivers/net/phy/rockchip.c
+++ b/drivers/net/phy/rockchip.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0+
-/**
+/*
* drivers/net/phy/rockchip.c
*
* Driver for ROCKCHIP Ethernet PHYs
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers
2021-05-15 10:53 ` [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 14:17 ` Andrew Lunn
0 siblings, 0 replies; 47+ messages in thread
From: Andrew Lunn @ 2021-05-15 14:17 UTC (permalink / raw)
To: Yang Shen
Cc: davem, kuba, netdev, linux-kernel, Heiner Kallweit, Russell King
On Sat, May 15, 2021 at 06:53:48PM +0800, Yang Shen wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/phy/adin.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> drivers/net/phy/rockchip.c:3: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (22 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 23/34] net: phy: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 11:36 ` Kalle Valo
2021-05-15 10:53 ` [PATCH 25/34] net: ath: " Yang Shen
` (9 subsequent siblings)
33 siblings, 1 reply; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Jiri Slaby, Nick Kossifidis,
Luis Chamberlain, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting prototype for at5k_hw_stop_rx_pcu(). Prototype was for ath5k_hw_stop_rx_pcu() instead
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index f2db7cf..3f4ce4e 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -855,7 +855,7 @@ ath5k_hw_start_rx_pcu(struct ath5k_hw *ah)
}
/**
- * at5k_hw_stop_rx_pcu() - Stop RX engine
+ * ath5k_hw_stop_rx_pcu() - Stop RX engine
* @ah: The &struct ath5k_hw
*
* Stops RX engine on PCU
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* Re: [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments
2021-05-15 10:53 ` [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments Yang Shen
@ 2021-05-15 11:36 ` Kalle Valo
2021-05-15 11:37 ` Kalle Valo
0 siblings, 1 reply; 47+ messages in thread
From: Kalle Valo @ 2021-05-15 11:36 UTC (permalink / raw)
To: Yang Shen
Cc: davem, kuba, netdev, linux-kernel, Jiri Slaby, Nick Kossifidis,
Luis Chamberlain
Yang Shen <shenyang39@huawei.com> writes:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting prototype for at5k_hw_stop_rx_pcu(). Prototype was for ath5k_hw_stop_rx_pcu() instead
>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Nick Kossifidis <mickflemm@gmail.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> ---
> drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
Patches for drivers/net/wireless should be sent to linux-wireless, I
recommend submitting those patches separately from rest of the series.
(Patches 24, 25, 29, 30 and 34)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 47+ messages in thread
* Re: [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments
2021-05-15 11:36 ` Kalle Valo
@ 2021-05-15 11:37 ` Kalle Valo
2021-05-17 1:51 ` Yang Shen
0 siblings, 1 reply; 47+ messages in thread
From: Kalle Valo @ 2021-05-15 11:37 UTC (permalink / raw)
To: Yang Shen
Cc: davem, kuba, netdev, linux-kernel, Jiri Slaby, Nick Kossifidis,
Luis Chamberlain
Kalle Valo <kvalo@codeaurora.org> writes:
> Yang Shen <shenyang39@huawei.com> writes:
>
>> Fixes the following W=1 kernel build warning(s):
>>
>> drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting
>> prototype for at5k_hw_stop_rx_pcu(). Prototype was for
>> ath5k_hw_stop_rx_pcu() instead
>>
>> Cc: Jiri Slaby <jirislaby@kernel.org>
>> Cc: Nick Kossifidis <mickflemm@gmail.com>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Kalle Valo <kvalo@codeaurora.org>
>> Signed-off-by: Yang Shen <shenyang39@huawei.com>
>> ---
>> drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
>
> Patches for drivers/net/wireless should be sent to linux-wireless, I
> recommend submitting those patches separately from rest of the series.
> (Patches 24, 25, 29, 30 and 34)
Oh, and patch 33 should be also sent to linux-wireless.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 47+ messages in thread
* Re: [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments
2021-05-15 11:37 ` Kalle Valo
@ 2021-05-17 1:51 ` Yang Shen
0 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-17 1:51 UTC (permalink / raw)
To: Kalle Valo
Cc: davem, kuba, netdev, linux-kernel, Jiri Slaby, Nick Kossifidis,
Luis Chamberlain
On 2021/5/15 19:37, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Yang Shen <shenyang39@huawei.com> writes:
>>
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>> drivers/net/wireless/ath/ath5k/pcu.c:865: warning: expecting
>>> prototype for at5k_hw_stop_rx_pcu(). Prototype was for
>>> ath5k_hw_stop_rx_pcu() instead
>>>
>>> Cc: Jiri Slaby <jirislaby@kernel.org>
>>> Cc: Nick Kossifidis <mickflemm@gmail.com>
>>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>>> Cc: Kalle Valo <kvalo@codeaurora.org>
>>> Signed-off-by: Yang Shen <shenyang39@huawei.com>
>>> ---
>>> drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
>>
>> Patches for drivers/net/wireless should be sent to linux-wireless, I
>> recommend submitting those patches separately from rest of the series.
>> (Patches 24, 25, 29, 30 and 34)
>
> Oh, and patch 33 should be also sent to linux-wireless.
>
Thanks! I'll fix this in the next version.
Regards,
Yang
^ permalink raw reply [flat|nested] 47+ messages in thread
* [PATCH 25/34] net: ath: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (23 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 24/34] net: ath: ath5k: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 26/34] net: ath: wil6210: " Yang Shen
` (8 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/hw.c:119: warning: expecting prototype for ath_hw_set_bssid_mask(). Prototype was for ath_hw_setbssidmask() instead
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/hw.c b/drivers/net/wireless/ath/hw.c
index eae9abf..b53ebb3 100644
--- a/drivers/net/wireless/ath/hw.c
+++ b/drivers/net/wireless/ath/hw.c
@@ -24,7 +24,7 @@
#define REG_WRITE(_ah, _reg, _val) (common->ops->write)(_ah, _val, _reg)
/**
- * ath_hw_set_bssid_mask - filter out bssids we listen
+ * ath_hw_setbssidmask - filter out bssids we listen
*
* @common: the ath_common struct for the device.
*
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 26/34] net: ath: wil6210: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (24 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 25/34] net: ath: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 27/34] net: broadcom: brcmfmac: Demote non-compliant kernel-doc headers Yang Shen
` (7 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Maya Erez
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/wil6210/interrupt.c:28: warning: expecting prototype for Theory of operation(). Prototype was for WIL6210_IRQ_DISABLE() instead
drivers/net/wireless/ath/wil6210/wmi.c:227: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ath/wil6210/wmi.c:245: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ath/wil6210/wmi.c:263: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Maya Erez <merez@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ath/wil6210/interrupt.c | 2 +-
drivers/net/wireless/ath/wil6210/wmi.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/interrupt.c b/drivers/net/wireless/ath/wil6210/interrupt.c
index d13d081..6717238 100644
--- a/drivers/net/wireless/ath/wil6210/interrupt.c
+++ b/drivers/net/wireless/ath/wil6210/interrupt.c
@@ -9,7 +9,7 @@
#include "wil6210.h"
#include "trace.h"
-/**
+/*
* Theory of operation:
*
* There is ISR pseudo-cause register,
diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index 02ad449..2dc8406 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -224,7 +224,7 @@ struct auth_no_hdr {
u8 led_polarity = LED_POLARITY_LOW_ACTIVE;
/**
- * return AHB address for given firmware internal (linker) address
+ * wmi_addr_remap - return AHB address for given firmware internal (linker) address
* @x: internal address
* If address have no valid AHB mapping, return 0
*/
@@ -242,7 +242,7 @@ static u32 wmi_addr_remap(u32 x)
}
/**
- * find fw_mapping entry by section name
+ * wil_find_fw_mapping - find fw_mapping entry by section name
* @section: section name
*
* Return pointer to section or NULL if not found
@@ -260,7 +260,7 @@ struct fw_map *wil_find_fw_mapping(const char *section)
}
/**
- * Check address validity for WMI buffer; remap if needed
+ * wmi_buffer_block - Check address validity for WMI buffer; remap if needed
* @wil: driver data
* @ptr_: internal (linker) fw/ucode address
* @size: if non zero, validate the block does not
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 27/34] net: broadcom: brcmfmac: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (25 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 26/34] net: ath: wil6210: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 28/34] net: intel: ipw2x00: Fix wrong function name in comments Yang Shen
` (6 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Franky Lin, Hante Meuleman
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2040: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:1295: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
index 34cd8a7..9ac0d8c 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
@@ -2037,7 +2037,7 @@ static void brcmf_p2p_get_current_chanspec(struct brcmf_p2p_info *p2p,
}
/**
- * Change a P2P Role.
+ * brcmf_p2p_ifchange - Change a P2P Role.
* @cfg: driver private data for cfg80211 interface.
* @if_type: interface type.
* Returns 0 if success.
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 16ed325..d1dda85 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -1291,7 +1291,7 @@ static void brcmf_sdio_free_glom(struct brcmf_sdio *bus)
}
}
-/**
+/*
* brcmfmac sdio bus specific header
* This is the lowest layer header wrapped on the packets transmitted between
* host and WiFi dongle which contains information needed for SDIO core and
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 28/34] net: intel: ipw2x00: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (26 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 27/34] net: broadcom: brcmfmac: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 29/34] net: intel: iwlwifi: Demote non-compliant kernel-doc headers Yang Shen
` (5 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Stanislav Yakovlev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/ipw2x00/ipw2100.c:5359: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/ipw2x00/ipw2100.c:6533: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/ipw2x00/ipw2100.c:6565: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index 23fbddd..a1c7b04 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
@@ -5356,7 +5356,7 @@ struct ipw2100_wep_key {
#define WEP_STR_128(x) x[0],x[1],x[2],x[3],x[4],x[5],x[6],x[7],x[8],x[9],x[10]
/**
- * Set a the wep key
+ * ipw2100_set_key - Set a the wep key
*
* @priv: struct to work on
* @idx: index of the key we want to set
@@ -6530,7 +6530,7 @@ static struct pci_driver ipw2100_pci_driver = {
};
/**
- * Initialize the ipw2100 driver/module
+ * ipw2100_init - Initialize the ipw2100 driver/module
*
* @returns 0 if ok, < 0 errno node con error.
*
@@ -6562,7 +6562,7 @@ static int __init ipw2100_init(void)
}
/**
- * Cleanup ipw2100 driver registration
+ * ipw2100_exit - Cleanup ipw2100 driver registration
*/
static void __exit ipw2100_exit(void)
{
@@ -7197,7 +7197,7 @@ static int ipw2100_wx_set_txpow(struct net_device *dev,
{
struct ipw2100_priv *priv = libipw_priv(dev);
int err = 0, value;
-
+
if (ipw_radio_kill_sw(priv, wrqu->txpower.disabled))
return -EINPROGRESS;
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 29/34] net: intel: iwlwifi: Demote non-compliant kernel-doc headers
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (27 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 28/34] net: intel: ipw2x00: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 30/34] net: marvell: libertas_tf: Fix wrong function name in comments Yang Shen
` (4 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Stanislav Yakovlev, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:11: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 0b81806..f1ed73c 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -7,11 +7,11 @@
#include "fw/api/commands.h"
#include "fw/api/phy-ctxt.h"
-/**
+/*
* DDR needs frequency in units of 16.666MHz, so provide FW with the
* frequency values in the adjusted format.
*/
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
/* LPDDR4 */
/* frequency 3733MHz */
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 30/34] net: marvell: libertas_tf: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (28 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 29/34] net: intel: iwlwifi: Demote non-compliant kernel-doc headers Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 31/34] net: realtek: rtlwifi: " Yang Shen
` (3 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/marvell/libertas_tf/if_usb.c:56: warning: expecting prototype for if_usb_wrike_bulk_callback(). Prototype was for if_usb_write_bulk_callback() instead
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
index a92916d..fe0a69e 100644
--- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c
@@ -48,7 +48,7 @@ static int if_usb_submit_rx_urb(struct if_usb_card *cardp);
static int if_usb_reset_device(struct lbtf_private *priv);
/**
- * if_usb_wrike_bulk_callback - call back to handle URB status
+ * if_usb_write_bulk_callback - call back to handle URB status
*
* @urb: pointer to urb structure
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 31/34] net: realtek: rtlwifi: Fix wrong function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (29 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 30/34] net: marvell: libertas_tf: Fix wrong function name in comments Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 32/34] net: rsi: Fix missing " Yang Shen
` (2 subsequent siblings)
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Ping-Ke Shih
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: expecting prototype for writeLLT(). Prototype was for rtl92c_llt_write() instead
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:154: warning: expecting prototype for rtl92c_init_LLT_table(). Prototype was for rtl92c_init_llt_table() instead
Cc: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index 8d2c6d8..4ff0d41 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
@@ -112,7 +112,7 @@ void rtl92c_read_chip_version(struct ieee80211_hw *hw)
}
/**
- * writeLLT - LLT table write access
+ * rtl92c_llt_write - LLT table write access
* @hw: Pointer to the ieee80211_hw structure.
* @address: LLT logical address.
* @data: LLT data content
@@ -144,7 +144,7 @@ bool rtl92c_llt_write(struct ieee80211_hw *hw, u32 address, u32 data)
}
/**
- * rtl92c_init_LLT_table - Init LLT table
+ * rtl92c_init_llt_table - Init LLT table
* @hw: Pointer to the ieee80211_hw structure.
* @boundary: Page boundary.
*
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 32/34] net: rsi: Fix missing function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (30 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 31/34] net: realtek: rtlwifi: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 33/34] net: ti: wl1251: " Yang Shen
2021-05-15 10:53 ` [PATCH 34/34] net: ti: wlcore: " Yang Shen
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba
Cc: netdev, linux-kernel, Yang Shen, Amitkumar Karwar, Siva Rebbagondla
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/rsi/rsi_91x_mgmt.c:1550: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 33c76d3..dffe1d6 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -1547,8 +1547,8 @@ static int rsi_eeprom_read(struct rsi_common *common)
}
/**
- * This function sends a frame to block/unblock
- * data queues in the firmware
+ * rsi_send_block_unblock_frame() - This function sends a frame to block/unblock
+ * data queues in the firmware
*
* @common: Pointer to the driver private structure.
* @block_event: Event block if true, unblock if false
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 33/34] net: ti: wl1251: Fix missing function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (31 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 32/34] net: rsi: Fix missing " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
2021-05-15 10:53 ` [PATCH 34/34] net: ti: wlcore: " Yang Shen
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wl1251/cmd.c:15: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:103: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wl1251/cmd.c:141: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Kalle Valo <kvalo@adurom.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ti/wl1251/cmd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ti/wl1251/cmd.c b/drivers/net/wireless/ti/wl1251/cmd.c
index 498c8db..eb92dde 100644
--- a/drivers/net/wireless/ti/wl1251/cmd.c
+++ b/drivers/net/wireless/ti/wl1251/cmd.c
@@ -12,7 +12,7 @@
#include "acx.h"
/**
- * send command to firmware
+ * wl1251_cmd_send - Send command to firmware
*
* @wl: wl struct
* @id: command id
@@ -59,7 +59,7 @@ int wl1251_cmd_send(struct wl1251 *wl, u16 id, void *buf, size_t len)
}
/**
- * send test command to firmware
+ * wl1251_cmd_test - Send test command to firmware
*
* @wl: wl struct
* @buf: buffer containing the command, with all headers, must work with dma
@@ -100,7 +100,7 @@ int wl1251_cmd_test(struct wl1251 *wl, void *buf, size_t buf_len, u8 answer)
}
/**
- * read acx from firmware
+ * wl1251_cmd_interrogate - Read acx from firmware
*
* @wl: wl struct
* @id: acx id
@@ -138,7 +138,7 @@ int wl1251_cmd_interrogate(struct wl1251 *wl, u16 id, void *buf, size_t len)
}
/**
- * write acx value to firmware
+ * wl1251_cmd_configure - Write acx value to firmware
*
* @wl: wl struct
* @id: acx id
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread* [PATCH 34/34] net: ti: wlcore: Fix missing function name in comments
2021-05-15 10:53 [PATCH 00/34] Rid W=1 warnings in net Yang Shen
` (32 preceding siblings ...)
2021-05-15 10:53 ` [PATCH 33/34] net: ti: wl1251: " Yang Shen
@ 2021-05-15 10:53 ` Yang Shen
33 siblings, 0 replies; 47+ messages in thread
From: Yang Shen @ 2021-05-15 10:53 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yang Shen, Kalle Valo
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wlcore/cmd.c:824: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wlcore/cmd.c:853: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
drivers/net/wireless/ti/wlcore/cmd.c:882: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
drivers/net/wireless/ti/wlcore/cmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/cmd.c b/drivers/net/wireless/ti/wlcore/cmd.c
index 32a2e27..8b798b5 100644
--- a/drivers/net/wireless/ti/wlcore/cmd.c
+++ b/drivers/net/wireless/ti/wlcore/cmd.c
@@ -821,7 +821,7 @@ int wl12xx_cmd_role_start_ibss(struct wl1271 *wl, struct wl12xx_vif *wlvif)
/**
- * send test command to firmware
+ * wl1271_cmd_test - send test command to firmware
*
* @wl: wl struct
* @buf: buffer containing the command, with all headers, must work with dma
@@ -850,7 +850,7 @@ int wl1271_cmd_test(struct wl1271 *wl, void *buf, size_t buf_len, u8 answer)
EXPORT_SYMBOL_GPL(wl1271_cmd_test);
/**
- * read acx from firmware
+ * wl1271_cmd_interrogate - read acx from firmware
*
* @wl: wl struct
* @id: acx id
@@ -879,7 +879,7 @@ int wl1271_cmd_interrogate(struct wl1271 *wl, u16 id, void *buf,
}
/**
- * write acx value to firmware
+ * wlcore_cmd_configure_failsafe - write acx value to firmware
*
* @wl: wl struct
* @id: acx id
--
2.7.4
^ permalink raw reply related [flat|nested] 47+ messages in thread