All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Amit Kumar Mahapatra <akumarma@xilinx.com>,
	Rob Herring <robh+dt@kernel.org>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>,
	linux-mtd@lists.infradead.org,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Michal Simek <monstr@monstr.eu>,
	Richard Weinberger <richard@nod.at>,
	Srinivas Goud <sgoud@xilinx.com>,
	Siva Durga Prasad Paladugu <sivadur@xilinx.com>,
	devicetree@vger.kernel.org,
	Helmut Grohne <helmut.grohne@intenta.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v20 18/19] dt-bindings: mtd: pl353-nand: Describe this hardware controller
Date: Wed, 19 May 2021 19:18:10 -0500	[thread overview]
Message-ID: <1621469890.766281.3946396.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210519182636.1110080-19-miquel.raynal@bootlin.com>

On Wed, 19 May 2021 20:26:35 +0200, Miquel Raynal wrote:
> Add a yaml description of this NAND controller which is described as a
> subnode of the SMC bus.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dts:21.11-33: Warning (reg_format): /example-0/nand-controller@0,0:reg: property has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: example-0: nand-controller@0,0:reg:0: [0, 0, 16777216] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml

See https://patchwork.ozlabs.org/patch/1481118

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Amit Kumar Mahapatra <akumarma@xilinx.com>,
	Rob Herring <robh+dt@kernel.org>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>,
	linux-mtd@lists.infradead.org,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Michal Simek <monstr@monstr.eu>,
	Richard Weinberger <richard@nod.at>,
	Srinivas Goud <sgoud@xilinx.com>,
	Siva Durga Prasad Paladugu <sivadur@xilinx.com>,
	devicetree@vger.kernel.org,
	Helmut Grohne <helmut.grohne@intenta.de>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v20 18/19] dt-bindings: mtd: pl353-nand: Describe this hardware controller
Date: Wed, 19 May 2021 19:18:10 -0500	[thread overview]
Message-ID: <1621469890.766281.3946396.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210519182636.1110080-19-miquel.raynal@bootlin.com>

On Wed, 19 May 2021 20:26:35 +0200, Miquel Raynal wrote:
> Add a yaml description of this NAND controller which is described as a
> subnode of the SMC bus.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../bindings/mtd/arm,pl353-nand-r2p1.yaml     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dts:21.11-33: Warning (reg_format): /example-0/nand-controller@0,0:reg: property has invalid length (12 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.example.dt.yaml: example-0: nand-controller@0,0:reg:0: [0, 0, 16777216] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml

See https://patchwork.ozlabs.org/patch/1481118

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-05-20  0:18 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 18:26 [PATCH v20 00/19] ARM Primecell PL35x support Miquel Raynal
2021-05-19 18:26 ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 01/19] dt-binding: memory: pl353-smc: Rephrase the binding Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:51   ` Rob Herring
2021-05-21  1:51     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 02/19] dt-binding: memory: pl353-smc: Document the range property Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:57   ` Rob Herring
2021-05-21  1:57     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 03/19] dt-binding: memory: pl353-smc: Drop the partitioning section Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:57   ` Rob Herring
2021-05-21  1:57     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 04/19] dt-binding: memory: pl353-smc: Describe the child reg property Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:58   ` Rob Herring
2021-05-21  1:58     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 05/19] dt-binding: memory: pl353-smc: Fix the example syntax and style Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:58   ` Rob Herring
2021-05-21  1:58     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 06/19] dt-binding: memory: pl353-smc: Drop unsupported nodes from the example Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:58   ` Rob Herring
2021-05-21  1:58     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 07/19] dt-binding: memory: pl353-smc: Fix the NAND controller node in " Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:58   ` Rob Herring
2021-05-21  1:58     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 08/19] dt-binding: memory: pl353-smc: Fix the reg property " Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:55   ` Rob Herring
2021-05-21  1:55     ` Rob Herring
2021-05-27 10:26     ` Miquel Raynal
2021-05-27 10:26       ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 09/19] dt-binding: memory: pl353-smc: Detail the main reg property content Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-21  1:57   ` Rob Herring
2021-05-21  1:57     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 10/19] dt-binding: memory: pl353-smc: Convert to yaml Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-20  0:18   ` Rob Herring
2021-05-20  0:18     ` Rob Herring
2021-05-20 11:09   ` Michael Walle
2021-05-20 11:09     ` Michael Walle
2021-05-20 11:31     ` Miquel Raynal
2021-05-20 11:31       ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 11/19] memory: pl353-smc: Fix style Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 12/19] memory: pl353-smc: Rename goto labels Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 13/19] memory: pl353-smc: Let lower level controller drivers handle inits Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 14/19] memory: pl353-smc: Avoid useless acronyms in descriptions Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 15/19] memory: pl353-smc: Declare variables following a reverse christmas tree order Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 16/19] MAINTAINERS: Add PL353 SMC entry Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 17/19] MAINTAINERS: Add PL353 NAND controller entry Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-19 18:26 ` [PATCH v20 18/19] dt-bindings: mtd: pl353-nand: Describe this hardware controller Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal
2021-05-20  0:18   ` Rob Herring [this message]
2021-05-20  0:18     ` Rob Herring
2021-05-20 20:56   ` Rob Herring
2021-05-20 20:56     ` Rob Herring
2021-05-19 18:26 ` [PATCH v20 19/19] mtd: rawnand: pl353: Add support for the ARM PL353 SMC NAND controller Miquel Raynal
2021-05-19 18:26   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621469890.766281.3946396.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=akumarma@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=helmut.grohne@intenta.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=monstr@monstr.eu \
    --cc=nagasure@xilinx.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=sgoud@xilinx.com \
    --cc=sivadur@xilinx.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.