[PATCH] docs: lockdep-design: improve readability of the block matrix

[PATCH] docs: lockdep-design: improve readability of the block matrix

[Xiongwei Song]

From: Xiongwei Song <sxwjean@gmail.com>

The block condition matrix is using 'E' as the writer notation, however,
the writer reminder below the matrix is using 'W', to make them consistent
and make the matrix more readable, we'd better to use 'W' to represent
writer.

Suggested-by: Waiman Long <llong@redhat.com>
Suggested-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
 Documentation/locking/lockdep-design.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
index 9f3cfca..82f36ca 100644
--- a/Documentation/locking/lockdep-design.rst
+++ b/Documentation/locking/lockdep-design.rst
@@ -453,9 +453,9 @@ There are simply four block conditions:
 Block condition matrix, Y means the row blocks the column, and N means otherwise.
 
 	+---+---+---+---+
-	|   | E | r | R |
+	|   | W | r | R |
 	+---+---+---+---+
-	| E | Y | Y | Y |
+	| W | Y | Y | Y |
 	+---+---+---+---+
 	| r | Y | Y | N |
 	+---+---+---+---+
-- 
2.7.4

Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

[Boqun Feng]

On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
> 
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
> 
> Suggested-by: Waiman Long <llong@redhat.com>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>

Reviewed-by: Boqun Feng <boqun.feng@gmail.com>

Regards,
Boqun

> ---
>  Documentation/locking/lockdep-design.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
>  Block condition matrix, Y means the row blocks the column, and N means otherwise.
>  
>  	+---+---+---+---+
> -	|   | E | r | R |
> +	|   | W | r | R |
>  	+---+---+---+---+
> -	| E | Y | Y | Y |
> +	| W | Y | Y | Y |
>  	+---+---+---+---+
>  	| r | Y | Y | N |
>  	+---+---+---+---+
> -- 
> 2.7.4
> 

Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

[Peter Zijlstra]

On Thu, May 27, 2021 at 11:30:14AM +0800, Boqun Feng wrote:
> On Mon, May 24, 2021 at 11:05:45PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> > 
> > The block condition matrix is using 'E' as the writer notation, however,
> > the writer reminder below the matrix is using 'W', to make them consistent
> > and make the matrix more readable, we'd better to use 'W' to represent
> > writer.
> > 
> > Suggested-by: Waiman Long <llong@redhat.com>
> > Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> 
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>

Thanks!

Re: [PATCH] docs: lockdep-design: improve readability of the block matrix

[Waiman Long]

On 5/24/21 11:05 AM, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> The block condition matrix is using 'E' as the writer notation, however,
> the writer reminder below the matrix is using 'W', to make them consistent
> and make the matrix more readable, we'd better to use 'W' to represent
> writer.
>
> Suggested-by: Waiman Long <llong@redhat.com>
> Suggested-by: Boqun Feng <boqun.feng@gmail.com>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> ---
>   Documentation/locking/lockdep-design.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
> index 9f3cfca..82f36ca 100644
> --- a/Documentation/locking/lockdep-design.rst
> +++ b/Documentation/locking/lockdep-design.rst
> @@ -453,9 +453,9 @@ There are simply four block conditions:
>   Block condition matrix, Y means the row blocks the column, and N means otherwise.
>   
>   	+---+---+---+---+
> -	|   | E | r | R |
> +	|   | W | r | R |
>   	+---+---+---+---+
> -	| E | Y | Y | Y |
> +	| W | Y | Y | Y |
>   	+---+---+---+---+
>   	| r | Y | Y | N |
>   	+---+---+---+---+

Acked-by: Waiman Long <longman@redhat.com>

[tip: locking/core] locking/lockdep,doc: Improve readability of the block matrix

[tip-bot2 for Xiongwei Song]

The following commit has been merged into the locking/core branch of tip:

Commit-ID:     fab6216fafdd74cd84de929ffe7b787976d32cff
Gitweb:        https://git.kernel.org/tip/fab6216fafdd74cd84de929ffe7b787976d32cff
Author:        Xiongwei Song <sxwjean@gmail.com>
AuthorDate:    Mon, 24 May 2021 23:05:45 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 31 May 2021 10:14:54 +02:00

locking/lockdep,doc: Improve readability of the block matrix

The block condition matrix is using 'E' as the writer notation,
however, the writer reminder below the matrix is using 'W', to make
them consistent and make the matrix more readable, we'd better to use
'W' to represent writer.

Suggested-by: Waiman Long <llong@redhat.com>
Suggested-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lkml.kernel.org/r/1621868745-23311-1-git-send-email-sxwjean@me.com
---
 Documentation/locking/lockdep-design.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/locking/lockdep-design.rst b/Documentation/locking/lockdep-design.rst
index 9f3cfca..82f36ca 100644
--- a/Documentation/locking/lockdep-design.rst
+++ b/Documentation/locking/lockdep-design.rst
@@ -453,9 +453,9 @@ There are simply four block conditions:
 Block condition matrix, Y means the row blocks the column, and N means otherwise.
 
 	+---+---+---+---+
-	|   | E | r | R |
+	|   | W | r | R |
 	+---+---+---+---+
-	| E | Y | Y | Y |
+	| W | Y | Y | Y |
 	+---+---+---+---+
 	| r | Y | Y | N |
 	+---+---+---+---+