* [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
@ 2021-05-28 4:24 Vidya Srinivas
2021-05-28 12:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-06-04 18:46 ` [igt-dev] " Mark Yacoub
0 siblings, 2 replies; 6+ messages in thread
From: Vidya Srinivas @ 2021-05-28 4:24 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin
Some Intel Gen11 systems are not able to do a RTC wake.
Instead change the default SUSPEND_TEST_NONE to
SUSPEND_TEST_PLATFORM.
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_flip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 8f736652be90..8afac88c9b15 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -835,7 +835,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
if (o->flags & TEST_SUSPEND)
igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
- SUSPEND_TEST_NONE);
+ is_i915_device(drm_fd)?
+ SUSPEND_TEST_PLATFORM:SUSPEND_TEST_NONE);
if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
igt_assert(do_wait_for_vblank(o, o->pipe, target_seq, &vbl_reply)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_flip.c: Fix subtests flip-vs-suspend
2021-05-28 4:24 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend Vidya Srinivas
@ 2021-05-28 12:58 ` Patchwork
2021-06-04 18:46 ` [igt-dev] " Mark Yacoub
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2021-05-28 12:58 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5335 bytes --]
== Series Details ==
Series: tests/kms_flip.c: Fix subtests flip-vs-suspend
URL : https://patchwork.freedesktop.org/series/90715/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10146 -> IGTPW_5859
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5859 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5859, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5859:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_lrc:
- fi-tgl-u2: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-tgl-u2/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in IGTPW_5859 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][3] -> [DMESG-FAIL][4] ([i915#165])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@basic:
- fi-tgl-u2: [PASS][5] -> [FAIL][6] ([i915#2416])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-tgl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][7] ([i915#3303]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [DMESG-FAIL][9] ([i915#3462]) -> [INCOMPLETE][10] ([i915#3462])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
- fi-bsw-nick: [DMESG-FAIL][11] ([i915#3462]) -> [INCOMPLETE][12] ([i915#2782] / [i915#2940] / [i915#3462])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-bsw-nick/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-cfl-8109u: [FAIL][13] ([i915#2426] / [i915#3363]) -> [FAIL][14] ([i915#3363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-cfl-8109u/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-cfl-8109u/igt@runner@aborted.html
- fi-glk-dsi: [FAIL][15] ([i915#3363] / [k.org#202321]) -> [FAIL][16] ([i915#2426] / [i915#3363] / [k.org#202321])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-glk-dsi/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/fi-glk-dsi/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#2416]: https://gitlab.freedesktop.org/drm/intel/issues/2416
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (44 -> 39)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6095 -> IGTPW_5859
CI-20190529: 20190529
CI_DRM_10146: eca2bdf0b1ad4250df25fda7ae2a5848c314264d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5859: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/index.html
IGT_6095: 5c7b7a8e441577a00cc4e71ec0ae57af640eb92a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5859/index.html
[-- Attachment #1.2: Type: text/html, Size: 6436 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
2021-05-28 4:24 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend Vidya Srinivas
@ 2021-06-04 18:46 ` Mark Yacoub
2021-06-04 18:46 ` [igt-dev] " Mark Yacoub
1 sibling, 0 replies; 6+ messages in thread
From: Mark Yacoub @ 2021-06-04 18:46 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev, intel-gfx, charlton.lin
Tested it on ChromeOS and it runs well. But I think we should fix the
root cause instead.
On Fri, May 28, 2021 at 12:33 AM Vidya Srinivas
<vidya.srinivas@intel.com> wrote:
>
> Some Intel Gen11 systems are not able to do a RTC wake.
> Instead change the default SUSPEND_TEST_NONE to
> SUSPEND_TEST_PLATFORM.
>
Tested on ChromeOS on TGL (Delbin) and JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_flip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 8f736652be90..8afac88c9b15 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -835,7 +835,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
>
> if (o->flags & TEST_SUSPEND)
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> - SUSPEND_TEST_NONE);
> + is_i915_device(drm_fd)?
> + SUSPEND_TEST_PLATFORM:SUSPEND_TEST_NONE);
>
> if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
> igt_assert(do_wait_for_vblank(o, o->pipe, target_seq, &vbl_reply)
> --
> 2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
@ 2021-06-04 18:46 ` Mark Yacoub
0 siblings, 0 replies; 6+ messages in thread
From: Mark Yacoub @ 2021-06-04 18:46 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev, intel-gfx, charlton.lin
Tested it on ChromeOS and it runs well. But I think we should fix the
root cause instead.
On Fri, May 28, 2021 at 12:33 AM Vidya Srinivas
<vidya.srinivas@intel.com> wrote:
>
> Some Intel Gen11 systems are not able to do a RTC wake.
> Instead change the default SUSPEND_TEST_NONE to
> SUSPEND_TEST_PLATFORM.
>
Tested on ChromeOS on TGL (Delbin) and JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_flip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 8f736652be90..8afac88c9b15 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -835,7 +835,8 @@ static bool run_test_step(struct test_output *o, unsigned int *events)
>
> if (o->flags & TEST_SUSPEND)
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> - SUSPEND_TEST_NONE);
> + is_i915_device(drm_fd)?
> + SUSPEND_TEST_PLATFORM:SUSPEND_TEST_NONE);
>
> if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
> igt_assert(do_wait_for_vblank(o, o->pipe, target_seq, &vbl_reply)
> --
> 2.7.4
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
2021-06-04 18:46 ` [igt-dev] " Mark Yacoub
@ 2021-06-05 5:39 ` Srinivas, Vidya
-1 siblings, 0 replies; 6+ messages in thread
From: Srinivas, Vidya @ 2021-06-05 5:39 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev, intel-gfx, Lin, Charlton
Thank you so much Mark. This patch is not required. I have abandoned it.
We needed to stop tlsdate daemon which was holding the RTC lock (initctl stop tlsdated).
Apologies for the same.
Regards
Vidya
-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Saturday, June 5, 2021 12:17 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
Tested it on ChromeOS and it runs well. But I think we should fix the root cause instead.
On Fri, May 28, 2021 at 12:33 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Some Intel Gen11 systems are not able to do a RTC wake.
> Instead change the default SUSPEND_TEST_NONE to SUSPEND_TEST_PLATFORM.
>
Tested on ChromeOS on TGL (Delbin) and JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_flip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c index
> 8f736652be90..8afac88c9b15 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -835,7 +835,8 @@ static bool run_test_step(struct test_output *o,
> unsigned int *events)
>
> if (o->flags & TEST_SUSPEND)
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> - SUSPEND_TEST_NONE);
> + is_i915_device(drm_fd)?
> +
> + SUSPEND_TEST_PLATFORM:SUSPEND_TEST_NONE);
>
> if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
> igt_assert(do_wait_for_vblank(o, o->pipe, target_seq,
> &vbl_reply)
> --
> 2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
@ 2021-06-05 5:39 ` Srinivas, Vidya
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas, Vidya @ 2021-06-05 5:39 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev, intel-gfx, Lin, Charlton
Thank you so much Mark. This patch is not required. I have abandoned it.
We needed to stop tlsdate daemon which was holding the RTC lock (initctl stop tlsdated).
Apologies for the same.
Regards
Vidya
-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Saturday, June 5, 2021 12:17 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Almahallawy, Khaled <khaled.almahallawy@intel.com>; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend
Tested it on ChromeOS and it runs well. But I think we should fix the root cause instead.
On Fri, May 28, 2021 at 12:33 AM Vidya Srinivas <vidya.srinivas@intel.com> wrote:
>
> Some Intel Gen11 systems are not able to do a RTC wake.
> Instead change the default SUSPEND_TEST_NONE to SUSPEND_TEST_PLATFORM.
>
Tested on ChromeOS on TGL (Delbin) and JSL (Drawlat)
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_flip.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c index
> 8f736652be90..8afac88c9b15 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -835,7 +835,8 @@ static bool run_test_step(struct test_output *o,
> unsigned int *events)
>
> if (o->flags & TEST_SUSPEND)
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> - SUSPEND_TEST_NONE);
> + is_i915_device(drm_fd)?
> +
> + SUSPEND_TEST_PLATFORM:SUSPEND_TEST_NONE);
>
> if (do_vblank && (o->flags & TEST_EINVAL) && o->vblank_state.count > 0)
> igt_assert(do_wait_for_vblank(o, o->pipe, target_seq,
> &vbl_reply)
> --
> 2.7.4
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-05 5:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 4:24 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_flip.c: Fix subtests flip-vs-suspend Vidya Srinivas
2021-05-28 12:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2021-06-04 18:46 ` [Intel-gfx] [PATCH i-g-t] [RFC] " Mark Yacoub
2021-06-04 18:46 ` [igt-dev] " Mark Yacoub
2021-06-05 5:39 ` [Intel-gfx] " Srinivas, Vidya
2021-06-05 5:39 ` [igt-dev] " Srinivas, Vidya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.