All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-pci@vger.kernel.org, daniel.vetter@ffwll.ch,
	Harry.Wentland@amd.com
Cc: Alexander.Deucher@amd.com, gregkh@linuxfoundation.org,
	ppaalanen@gmail.com, helgaas@kernel.org, Felix.Kuehling@amd.com
Subject: Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released
Date: Wed, 19 May 2021 13:46:47 +0200	[thread overview]
Message-ID: <1622338a-d95a-fe13-e4a4-c99cb4a31f6c@amd.com> (raw)
In-Reply-To: <4a9af53a-564d-62ae-25e1-06ca4129857f@amd.com>

Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky:
>
>
> On 2021-05-19 6:57 a.m., Christian König wrote:
>> Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky:
>>> [SNIP]
>>>>>
>>>>> Would this be the right way to do it ?
>>>>
>>>> Yes, it is at least a start. Question is if we can wait blocking 
>>>> here or not.
>>>>
>>>> We install a callback a bit lower to avoid blocking, so I'm pretty 
>>>> sure that won't work as expected.
>>>>
>>>> Christian.
>>>
>>> I can't see why this would create problems, as long as the dependencies
>>> complete or force competed if they are from same device (extracted) but
>>> on a different ring then looks to me it should work. I will give it
>>> a try.
>>
>> Ok, but please also test the case for a killed process.
>>
>> Christian.
>
> You mean something like run glxgears and then simply
> terminate it ? Because I done that. Or something more ?

Well glxgears is a bit to lightweight for that.

You need at least some test which is limited by the rendering pipeline.

Christian.

>
> Andrey
>
>
>>
>>>
>>> Andrey
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Candrey.grodzovsky%40amd.com%7Cce1252e55fae4338710d08d91ab4de01%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637570186393107071%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=vGqxY5sxpEIiQGFBNn2PWkKqVjviM29r34Yjv0wujf4%3D&amp;reserved=0 
>>


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-pci@vger.kernel.org, daniel.vetter@ffwll.ch,
	Harry.Wentland@amd.com
Cc: Alexander.Deucher@amd.com, gregkh@linuxfoundation.org,
	helgaas@kernel.org, Felix.Kuehling@amd.com
Subject: Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released
Date: Wed, 19 May 2021 13:46:47 +0200	[thread overview]
Message-ID: <1622338a-d95a-fe13-e4a4-c99cb4a31f6c@amd.com> (raw)
In-Reply-To: <4a9af53a-564d-62ae-25e1-06ca4129857f@amd.com>

Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky:
>
>
> On 2021-05-19 6:57 a.m., Christian König wrote:
>> Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky:
>>> [SNIP]
>>>>>
>>>>> Would this be the right way to do it ?
>>>>
>>>> Yes, it is at least a start. Question is if we can wait blocking 
>>>> here or not.
>>>>
>>>> We install a callback a bit lower to avoid blocking, so I'm pretty 
>>>> sure that won't work as expected.
>>>>
>>>> Christian.
>>>
>>> I can't see why this would create problems, as long as the dependencies
>>> complete or force competed if they are from same device (extracted) but
>>> on a different ring then looks to me it should work. I will give it
>>> a try.
>>
>> Ok, but please also test the case for a killed process.
>>
>> Christian.
>
> You mean something like run glxgears and then simply
> terminate it ? Because I done that. Or something more ?

Well glxgears is a bit to lightweight for that.

You need at least some test which is limited by the rendering pipeline.

Christian.

>
> Andrey
>
>
>>
>>>
>>> Andrey
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Candrey.grodzovsky%40amd.com%7Cce1252e55fae4338710d08d91ab4de01%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637570186393107071%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=vGqxY5sxpEIiQGFBNn2PWkKqVjviM29r34Yjv0wujf4%3D&amp;reserved=0 
>>


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Christian König" <ckoenig.leichtzumerken@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-pci@vger.kernel.org, daniel.vetter@ffwll.ch,
	Harry.Wentland@amd.com
Cc: Alexander.Deucher@amd.com, gregkh@linuxfoundation.org,
	ppaalanen@gmail.com, helgaas@kernel.org, Felix.Kuehling@amd.com
Subject: Re: [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released
Date: Wed, 19 May 2021 13:46:47 +0200	[thread overview]
Message-ID: <1622338a-d95a-fe13-e4a4-c99cb4a31f6c@amd.com> (raw)
In-Reply-To: <4a9af53a-564d-62ae-25e1-06ca4129857f@amd.com>

Am 19.05.21 um 13:03 schrieb Andrey Grodzovsky:
>
>
> On 2021-05-19 6:57 a.m., Christian König wrote:
>> Am 18.05.21 um 20:48 schrieb Andrey Grodzovsky:
>>> [SNIP]
>>>>>
>>>>> Would this be the right way to do it ?
>>>>
>>>> Yes, it is at least a start. Question is if we can wait blocking 
>>>> here or not.
>>>>
>>>> We install a callback a bit lower to avoid blocking, so I'm pretty 
>>>> sure that won't work as expected.
>>>>
>>>> Christian.
>>>
>>> I can't see why this would create problems, as long as the dependencies
>>> complete or force competed if they are from same device (extracted) but
>>> on a different ring then looks to me it should work. I will give it
>>> a try.
>>
>> Ok, but please also test the case for a killed process.
>>
>> Christian.
>
> You mean something like run glxgears and then simply
> terminate it ? Because I done that. Or something more ?

Well glxgears is a bit to lightweight for that.

You need at least some test which is limited by the rendering pipeline.

Christian.

>
> Andrey
>
>
>>
>>>
>>> Andrey
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Candrey.grodzovsky%40amd.com%7Cce1252e55fae4338710d08d91ab4de01%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637570186393107071%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=vGqxY5sxpEIiQGFBNn2PWkKqVjviM29r34Yjv0wujf4%3D&amp;reserved=0 
>>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-05-19 11:46 UTC|newest]

Thread overview: 193+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 14:26 [PATCH v7 00/16] RFC Support hot device unplug in amdgpu Andrey Grodzovsky
2021-05-12 14:26 ` Andrey Grodzovsky
2021-05-12 14:26 ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 01/16] drm/ttm: Remap all page faults to per process dummy page Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 02/16] drm/amdgpu: Split amdgpu_device_fini into early and late Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 03/16] drm/amdkfd: Split kfd suspend from device exit Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 20:33   ` Felix Kuehling
2021-05-12 20:33     ` Felix Kuehling
2021-05-12 20:33     ` Felix Kuehling
2021-05-12 20:38     ` Andrey Grodzovsky
2021-05-12 20:38       ` Andrey Grodzovsky
2021-05-12 20:38       ` Andrey Grodzovsky
2021-05-20  3:20     ` [PATCH] drm/amdgpu: Add early fini callback Andrey Grodzovsky
2021-05-20  3:20       ` Andrey Grodzovsky
2021-05-20  3:20       ` Andrey Grodzovsky
2021-05-20  3:29       ` Felix Kuehling
2021-05-20  3:29         ` Felix Kuehling
2021-05-20  3:29         ` Felix Kuehling
2021-05-20  3:58         ` Andrey Grodzovsky
2021-05-20  3:58           ` Andrey Grodzovsky
2021-05-20  3:58           ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 04/16] " Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 05/16] drm/amdgpu: Handle IOMMU enabled case Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-14 14:41   ` Andrey Grodzovsky
2021-05-14 14:41     ` Andrey Grodzovsky
2021-05-14 14:41     ` Andrey Grodzovsky
2021-05-14 16:25     ` Felix Kuehling
2021-05-14 16:25       ` Felix Kuehling
2021-05-14 16:26       ` Andrey Grodzovsky
2021-05-14 16:26         ` Andrey Grodzovsky
2021-05-14 16:26         ` Andrey Grodzovsky
2021-05-17 14:38       ` [PATCH] " Andrey Grodzovsky
2021-05-17 14:38         ` Andrey Grodzovsky
2021-05-17 14:38         ` Andrey Grodzovsky
2021-05-17 14:48         ` Felix Kuehling
2021-05-17 14:48           ` Felix Kuehling
2021-05-17 14:48           ` Felix Kuehling
2021-05-12 14:26 ` [PATCH v7 06/16] drm/amdgpu: Remap all page faults to per process dummy page Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 07/16] PCI: Add support for dev_groups to struct pci_driver Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 08/16] drm/amdgpu: Convert driver sysfs attributes to static attributes Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 09/16] drm/amdgpu: Guard against write accesses after device removal Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 20:17   ` Alex Deucher
2021-05-12 20:17     ` Alex Deucher
2021-05-12 20:17     ` Alex Deucher
2021-05-12 20:30     ` Andrey Grodzovsky
2021-05-12 20:30       ` Andrey Grodzovsky
2021-05-12 20:30       ` Andrey Grodzovsky
2021-05-12 20:50       ` Alex Deucher
2021-05-12 20:50         ` Alex Deucher
2021-05-12 20:50         ` Alex Deucher
2021-05-13 14:47         ` Andrey Grodzovsky
2021-05-13 14:47           ` Andrey Grodzovsky
2021-05-13 14:47           ` Andrey Grodzovsky
2021-05-13 14:54           ` Alex Deucher
2021-05-13 14:54             ` Alex Deucher
2021-05-13 14:54             ` Alex Deucher
2021-05-12 14:26 ` [PATCH v7 10/16] drm/sched: Make timeout timer rearm conditional Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 11/16] drm/amdgpu: Prevent any job recoveries after device is unplugged Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 12/16] drm/amdgpu: Fix hang on device removal Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-14 14:42   ` Andrey Grodzovsky
2021-05-14 14:42     ` Andrey Grodzovsky
2021-05-14 14:42     ` Andrey Grodzovsky
2021-05-17 14:40     ` Andrey Grodzovsky
2021-05-17 14:40       ` Andrey Grodzovsky
2021-05-17 14:40       ` Andrey Grodzovsky
2021-05-17 17:39       ` Alex Deucher
2021-05-17 17:39         ` Alex Deucher
2021-05-17 17:39         ` Alex Deucher
2021-05-17 19:39       ` Christian König
2021-05-17 19:39         ` Christian König
2021-05-17 19:39         ` Christian König
2021-05-17 19:46         ` Andrey Grodzovsky
2021-05-17 19:46           ` Andrey Grodzovsky
2021-05-17 19:46           ` Andrey Grodzovsky
2021-05-17 19:54           ` Christian König
2021-05-17 19:54             ` Christian König
2021-05-17 19:54             ` Christian König
2021-05-12 14:26 ` [PATCH v7 13/16] drm/scheduler: Fix hang when sched_entity released Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-18 14:07   ` Christian König
2021-05-18 14:07     ` Christian König
2021-05-18 14:07     ` Christian König
2021-05-18 15:03     ` Andrey Grodzovsky
2021-05-18 15:03       ` Andrey Grodzovsky
2021-05-18 15:03       ` Andrey Grodzovsky
2021-05-18 15:15       ` Christian König
2021-05-18 15:15         ` Christian König
2021-05-18 15:15         ` Christian König
2021-05-18 16:17         ` Andrey Grodzovsky
2021-05-18 16:17           ` Andrey Grodzovsky
2021-05-18 16:17           ` Andrey Grodzovsky
2021-05-18 16:33           ` Christian König
2021-05-18 16:33             ` Christian König
2021-05-18 16:33             ` Christian König
2021-05-18 17:43             ` Andrey Grodzovsky
2021-05-18 17:43               ` Andrey Grodzovsky
2021-05-18 17:43               ` Andrey Grodzovsky
2021-05-18 18:02               ` Christian König
2021-05-18 18:02                 ` Christian König
2021-05-18 18:02                 ` Christian König
2021-05-18 18:09                 ` Andrey Grodzovsky
2021-05-18 18:09                   ` Andrey Grodzovsky
2021-05-18 18:09                   ` Andrey Grodzovsky
2021-05-18 18:13                   ` Christian König
2021-05-18 18:13                     ` Christian König
2021-05-18 18:13                     ` Christian König
2021-05-18 18:48                     ` Andrey Grodzovsky
2021-05-18 18:48                       ` Andrey Grodzovsky
2021-05-18 18:48                       ` Andrey Grodzovsky
2021-05-18 20:56                       ` Andrey Grodzovsky
2021-05-18 20:56                         ` Andrey Grodzovsky
2021-05-18 20:56                         ` Andrey Grodzovsky
2021-05-19 10:57                       ` Christian König
2021-05-19 10:57                         ` Christian König
2021-05-19 10:57                         ` Christian König
2021-05-19 11:03                         ` Andrey Grodzovsky
2021-05-19 11:03                           ` Andrey Grodzovsky
2021-05-19 11:03                           ` Andrey Grodzovsky
2021-05-19 11:46                           ` Christian König [this message]
2021-05-19 11:46                             ` Christian König
2021-05-19 11:46                             ` Christian König
2021-05-19 11:51                             ` Andrey Grodzovsky
2021-05-19 11:51                               ` Andrey Grodzovsky
2021-05-19 11:51                               ` Andrey Grodzovsky
2021-05-19 11:56                               ` Christian König
2021-05-19 11:56                                 ` Christian König
2021-05-19 11:56                                 ` Christian König
2021-05-19 14:14                                 ` [PATCH] drm/sched: Avoid data corruptions Andrey Grodzovsky
2021-05-19 14:14                                   ` Andrey Grodzovsky
2021-05-19 14:14                                   ` Andrey Grodzovsky
2021-05-19 14:15                                   ` Christian König
2021-05-19 14:15                                     ` Christian König
2021-05-19 14:15                                     ` Christian König
2021-05-12 14:26 ` [PATCH v7 14/16] drm/amd/display: Remove superfluous drm_mode_config_cleanup Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 15/16] drm/amdgpu: Verify DMA opearations from device are done Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26 ` [PATCH v7 16/16] drm/amdgpu: Unmap all MMIO mappings Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-12 14:26   ` Andrey Grodzovsky
2021-05-14 14:42   ` Andrey Grodzovsky
2021-05-14 14:42     ` Andrey Grodzovsky
2021-05-14 14:42     ` Andrey Grodzovsky
2021-05-17 14:41     ` Andrey Grodzovsky
2021-05-17 14:41       ` Andrey Grodzovsky
2021-05-17 14:41       ` Andrey Grodzovsky
2021-05-17 17:43   ` Alex Deucher
2021-05-17 17:43     ` Alex Deucher
2021-05-17 17:43     ` Alex Deucher
2021-05-17 18:46     ` Andrey Grodzovsky
2021-05-17 18:46       ` Andrey Grodzovsky
2021-05-17 18:46       ` Andrey Grodzovsky
2021-05-17 18:56       ` Alex Deucher
2021-05-17 18:56         ` Alex Deucher
2021-05-17 18:56         ` Alex Deucher
2021-05-17 19:22         ` Andrey Grodzovsky
2021-05-17 19:22           ` Andrey Grodzovsky
2021-05-17 19:22           ` Andrey Grodzovsky
2021-05-17 19:31     ` [PATCH] " Andrey Grodzovsky
2021-05-17 19:31       ` Andrey Grodzovsky
2021-05-17 19:31       ` Andrey Grodzovsky
2021-05-18 14:01       ` Andrey Grodzovsky
2021-05-18 14:01         ` Andrey Grodzovsky
2021-05-18 14:01         ` Andrey Grodzovsky
2021-05-18 14:02         ` Deucher, Alexander
2021-05-18 14:02           ` Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1622338a-d95a-fe13-e4a4-c99cb4a31f6c@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ppaalanen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.