[PATCH] target: fix warning on realtime kernels

[PATCH] target: fix warning on realtime kernels

[Maurizio Lombardi]

On realtime kernels, spin_lock_irq*(spinlock_t) do not
disable the interrupts, a call to irqs_disabled()
will return false thus firing a warning in __transport_wait_for_tasks()

This patch removes the warning and also replaces assert_spin_locked
with lockdep_assert_held()

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 drivers/target/target_core_transport.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 8fbfe75c5744..09526e6bc0bb 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -3121,9 +3121,7 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
 	__releases(&cmd->t_state_lock)
 	__acquires(&cmd->t_state_lock)
 {
-
-	assert_spin_locked(&cmd->t_state_lock);
-	WARN_ON_ONCE(!irqs_disabled());
+	lockdep_assert_held(&cmd->t_state_lock);
 
 	if (fabric_stop)
 		cmd->transport_state |= CMD_T_FABRIC_STOP;
-- 
2.31.1

Re: [PATCH] target: fix warning on realtime kernels

[Bart Van Assche]

On 5/31/21 5:13 AM, Maurizio Lombardi wrote:
> On realtime kernels, spin_lock_irq*(spinlock_t) do not
> disable the interrupts, a call to irqs_disabled()
> will return false thus firing a warning in __transport_wait_for_tasks()
> 
> This patch removes the warning and also replaces assert_spin_locked
> with lockdep_assert_held()

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH] target: fix warning on realtime kernels

[Martin K. Petersen]

On Mon, 31 May 2021 14:13:26 +0200, Maurizio Lombardi wrote:

> On realtime kernels, spin_lock_irq*(spinlock_t) do not
> disable the interrupts, a call to irqs_disabled()
> will return false thus firing a warning in __transport_wait_for_tasks()
> 
> This patch removes the warning and also replaces assert_spin_locked
> with lockdep_assert_held()

Applied to 5.13/scsi-fixes, thanks!

[1/1] target: fix warning on realtime kernels
      https://git.kernel.org/mkp/scsi/c/515da6f4295c

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] target: fix warning on realtime kernels

[Chaitanya Kulkarni]

On 5/31/21 05:13, Maurizio Lombardi wrote:
> On realtime kernels, spin_lock_irq*(spinlock_t) do not
> disable the interrupts, a call to irqs_disabled()
> will return false thus firing a warning in __transport_wait_for_tasks()
>
> This patch removes the warning and also replaces assert_spin_locked
> with lockdep_assert_held()
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>