* [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h
@ 2021-06-03 2:59 Wan Jiabing
2021-06-03 15:32 ` Ranjani Sridharan
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-06-03 2:59 UTC (permalink / raw)
To: Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan,
Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Guennadi Liakhovetski, Bard Liao, Wan Jiabing,
sound-open-firmware, alsa-devel, linux-kernel
shim.h is included twice.
As shim.h is not related to later header file,
keep one which has comment and remove the former one.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
sound/soc/sof/intel/pci-tng.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-tng.c
index 4ee1da3..4bded66 100644
--- a/sound/soc/sof/intel/pci-tng.c
+++ b/sound/soc/sof/intel/pci-tng.c
@@ -15,7 +15,6 @@
#include <sound/sof.h>
#include "../ops.h"
#include "atom.h"
-#include "shim.h"
#include "../sof-pci-dev.h"
#include "../sof-audio.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h
2021-06-03 2:59 [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h Wan Jiabing
@ 2021-06-03 15:32 ` Ranjani Sridharan
0 siblings, 0 replies; 3+ messages in thread
From: Ranjani Sridharan @ 2021-06-03 15:32 UTC (permalink / raw)
To: Wan Jiabing, Pierre-Louis Bossart, Liam Girdwood, Kai Vehmanen,
Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Guennadi Liakhovetski, Bard Liao, sound-open-firmware,
alsa-devel, linux-kernel
On Thu, 2021-06-03 at 10:59 +0800, Wan Jiabing wrote:
> shim.h is included twice.
> As shim.h is not related to later header file,
> keep one which has comment and remove the former one.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> sound/soc/sof/intel/pci-tng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-
> tng.c
> index 4ee1da3..4bded66 100644
> --- a/sound/soc/sof/intel/pci-tng.c
> +++ b/sound/soc/sof/intel/pci-tng.c
> @@ -15,7 +15,6 @@
> #include <sound/sof.h>
> #include "../ops.h"
> #include "atom.h"
> -#include "shim.h"
> #include "../sof-pci-dev.h"
> #include "../sof-audio.h"
>
Thanks for the patch.
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h
@ 2021-06-03 15:32 ` Ranjani Sridharan
0 siblings, 0 replies; 3+ messages in thread
From: Ranjani Sridharan @ 2021-06-03 15:32 UTC (permalink / raw)
To: Wan Jiabing, Pierre-Louis Bossart, Liam Girdwood, Kai Vehmanen,
Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Guennadi Liakhovetski, Bard Liao, sound-open-firmware,
alsa-devel, linux-kernel
On Thu, 2021-06-03 at 10:59 +0800, Wan Jiabing wrote:
> shim.h is included twice.
> As shim.h is not related to later header file,
> keep one which has comment and remove the former one.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> sound/soc/sof/intel/pci-tng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-
> tng.c
> index 4ee1da3..4bded66 100644
> --- a/sound/soc/sof/intel/pci-tng.c
> +++ b/sound/soc/sof/intel/pci-tng.c
> @@ -15,7 +15,6 @@
> #include <sound/sof.h>
> #include "../ops.h"
> #include "atom.h"
> -#include "shim.h"
> #include "../sof-pci-dev.h"
> #include "../sof-audio.h"
>
Thanks for the patch.
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-03 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 2:59 [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h Wan Jiabing
2021-06-03 15:32 ` Ranjani Sridharan
2021-06-03 15:32 ` Ranjani Sridharan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.