All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues
@ 2021-06-02 11:01 Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 1/6] net: hdlc_cisco: remove redundant blank lines Guangbin Huang
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patchset clean up some code style issues.

Peng Li (6):
  net: hdlc_cisco: remove redundant blank lines
  net: hdlc_cisco: fix the code style issue about "foo* bar"
  net: hdlc_cisco: add some required spaces
  net: hdlc_cisco: remove unnecessary out of memory message
  net: hdlc_cisco: add blank line after declaration
  net: hdlc_cisco: remove redundant space

 drivers/net/wan/hdlc_cisco.c | 49 +++++++++++++-------------------------------
 1 file changed, 14 insertions(+), 35 deletions(-)

-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 1/6] net: hdlc_cisco: remove redundant blank lines
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 2/6] net: hdlc_cisco: fix the code style issue about "foo* bar" Guangbin Huang
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patch removes some redundant blank lines.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index cb5898f..5fc0f8d 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -28,14 +28,12 @@
 #define CISCO_ADDR_REPLY	1	/* Cisco address reply */
 #define CISCO_KEEPALIVE_REQ	2	/* Cisco keepalive request */
 
-
 struct hdlc_header {
 	u8 address;
 	u8 control;
 	__be16 protocol;
 }__packed;
 
-
 struct cisco_packet {
 	__be32 type;		/* code */
 	__be32 par1;
@@ -46,7 +44,6 @@ struct cisco_packet {
 #define	CISCO_PACKET_LEN	18
 #define	CISCO_BIG_PACKET_LEN	20
 
-
 struct cisco_state {
 	cisco_proto settings;
 
@@ -59,16 +56,13 @@ struct cisco_state {
 	u32 rxseq; /* RX sequence number */
 };
 
-
 static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr);
 
-
 static inline struct cisco_state* state(hdlc_device *hdlc)
 {
 	return (struct cisco_state *)hdlc->state;
 }
 
-
 static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
 			     u16 type, const void *daddr, const void *saddr,
 			     unsigned int len)
@@ -90,8 +84,6 @@ static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
 	return sizeof(struct hdlc_header);
 }
 
-
-
 static void cisco_keepalive_send(struct net_device *dev, u32 type,
 				 __be32 par1, __be32 par2)
 {
@@ -124,8 +116,6 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
 	dev_queue_xmit(skb);
 }
 
-
-
 static __be16 cisco_type_trans(struct sk_buff *skb, struct net_device *dev)
 {
 	struct hdlc_header *data = (struct hdlc_header*)skb->data;
@@ -148,7 +138,6 @@ static __be16 cisco_type_trans(struct sk_buff *skb, struct net_device *dev)
 	}
 }
 
-
 static int cisco_rx(struct sk_buff *skb)
 {
 	struct net_device *dev = skb->dev;
@@ -253,8 +242,6 @@ static int cisco_rx(struct sk_buff *skb)
 	return NET_RX_DROP;
 }
 
-
-
 static void cisco_timer(struct timer_list *t)
 {
 	struct cisco_state *st = from_timer(st, t, timer);
@@ -276,8 +263,6 @@ static void cisco_timer(struct timer_list *t)
 	add_timer(&st->timer);
 }
 
-
-
 static void cisco_start(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -294,8 +279,6 @@ static void cisco_start(struct net_device *dev)
 	add_timer(&st->timer);
 }
 
-
-
 static void cisco_stop(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
@@ -310,7 +293,6 @@ static void cisco_stop(struct net_device *dev)
 	spin_unlock_irqrestore(&st->lock, flags);
 }
 
-
 static struct hdlc_proto proto = {
 	.start		= cisco_start,
 	.stop		= cisco_stop,
@@ -381,21 +363,17 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr)
 	return -EINVAL;
 }
 
-
 static int __init mod_init(void)
 {
 	register_hdlc_protocol(&proto);
 	return 0;
 }
 
-
-
 static void __exit mod_exit(void)
 {
 	unregister_hdlc_protocol(&proto);
 }
 
-
 module_init(mod_init);
 module_exit(mod_exit);
 
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 2/6] net: hdlc_cisco: fix the code style issue about "foo* bar"
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 1/6] net: hdlc_cisco: remove redundant blank lines Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 3/6] net: hdlc_cisco: add some required spaces Guangbin Huang
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Fix the checkpatch error as "foo* bar" and should be "foo *bar",
and "(foo*)" should be "(foo *)".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index 5fc0f8d..227939d 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -58,7 +58,7 @@ struct cisco_state {
 
 static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr);
 
-static inline struct cisco_state* state(hdlc_device *hdlc)
+static inline struct cisco_state *state(hdlc_device *hdlc)
 {
 	return (struct cisco_state *)hdlc->state;
 }
@@ -73,7 +73,7 @@ static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev,
 #endif
 
 	skb_push(skb, sizeof(struct hdlc_header));
-	data = (struct hdlc_header*)skb->data;
+	data = (struct hdlc_header *)skb->data;
 	if (type == CISCO_KEEPALIVE)
 		data->address = CISCO_MULTICAST;
 	else
@@ -98,7 +98,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
 	}
 	skb_reserve(skb, 4);
 	cisco_hard_header(skb, dev, CISCO_KEEPALIVE, NULL, NULL, 0);
-	data = (struct cisco_packet*)(skb->data + 4);
+	data = (struct cisco_packet *)(skb->data + 4);
 
 	data->type = htonl(type);
 	data->par1 = par1;
@@ -118,7 +118,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
 
 static __be16 cisco_type_trans(struct sk_buff *skb, struct net_device *dev)
 {
-	struct hdlc_header *data = (struct hdlc_header*)skb->data;
+	struct hdlc_header *data = (struct hdlc_header *)skb->data;
 
 	if (skb->len < sizeof(struct hdlc_header))
 		return cpu_to_be16(ETH_P_HDLC);
@@ -143,7 +143,7 @@ static int cisco_rx(struct sk_buff *skb)
 	struct net_device *dev = skb->dev;
 	hdlc_device *hdlc = dev_to_hdlc(dev);
 	struct cisco_state *st = state(hdlc);
-	struct hdlc_header *data = (struct hdlc_header*)skb->data;
+	struct hdlc_header *data = (struct hdlc_header *)skb->data;
 	struct cisco_packet *cisco_data;
 	struct in_device *in_dev;
 	__be32 addr, mask;
@@ -172,7 +172,7 @@ static int cisco_rx(struct sk_buff *skb)
 			goto rx_error;
 		}
 
-		cisco_data = (struct cisco_packet*)(skb->data + sizeof
+		cisco_data = (struct cisco_packet *)(skb->data + sizeof
 						    (struct hdlc_header));
 
 		switch (ntohl (cisco_data->type)) {
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 3/6] net: hdlc_cisco: add some required spaces
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 1/6] net: hdlc_cisco: remove redundant blank lines Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 2/6] net: hdlc_cisco: fix the code style issue about "foo* bar" Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 4/6] net: hdlc_cisco: remove unnecessary out of memory message Guangbin Huang
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Add spaces required after the close parenthesis '}'.
Add spaces required after that ','.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index 227939d..3f6a51a 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -32,7 +32,7 @@ struct hdlc_header {
 	u8 address;
 	u8 control;
 	__be16 protocol;
-}__packed;
+} __packed;
 
 struct cisco_packet {
 	__be32 type;		/* code */
@@ -40,7 +40,7 @@ struct cisco_packet {
 	__be32 par2;
 	__be16 rel;		/* reliability */
 	__be32 time;
-}__packed;
+} __packed;
 #define	CISCO_PACKET_LEN	18
 #define	CISCO_BIG_PACKET_LEN	20
 
@@ -341,7 +341,8 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr)
 		    new_settings.timeout < 2)
 			return -EINVAL;
 
-		result = hdlc->attach(dev, ENCODING_NRZ,PARITY_CRC16_PR1_CCITT);
+		result = hdlc->attach(dev, ENCODING_NRZ,
+				      PARITY_CRC16_PR1_CCITT);
 		if (result)
 			return result;
 
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 4/6] net: hdlc_cisco: remove unnecessary out of memory message
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
                   ` (2 preceding siblings ...)
  2021-06-02 11:01 ` [PATCH net-next 3/6] net: hdlc_cisco: add some required spaces Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 5/6] net: hdlc_cisco: add blank line after declaration Guangbin Huang
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index 3f6a51a..0d29a2c 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -92,10 +92,9 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type,
 
 	skb = dev_alloc_skb(sizeof(struct hdlc_header) +
 			    sizeof(struct cisco_packet));
-	if (!skb) {
-		netdev_warn(dev, "Memory squeeze on %s()\n", __func__);
+	if (!skb)
 		return;
-	}
+
 	skb_reserve(skb, 4);
 	cisco_hard_header(skb, dev, CISCO_KEEPALIVE, NULL, NULL, 0);
 	data = (struct cisco_packet *)(skb->data + 4);
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 5/6] net: hdlc_cisco: add blank line after declaration
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
                   ` (3 preceding siblings ...)
  2021-06-02 11:01 ` [PATCH net-next 4/6] net: hdlc_cisco: remove unnecessary out of memory message Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-02 11:01 ` [PATCH net-next 6/6] net: hdlc_cisco: remove redundant space Guangbin Huang
  2021-06-03 20:30 ` [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

This patch fixes the checkpatch error about missing a blank line
after declarations.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index 0d29a2c..d337711 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -214,6 +214,7 @@ static int cisco_rx(struct sk_buff *skb)
 				st->last_poll = jiffies;
 				if (!st->up) {
 					u32 sec, min, hrs, days;
+
 					sec = ntohl(cisco_data->time) / 1000;
 					min = sec / 60; sec -= min * 60;
 					hrs = min / 60; min -= hrs * 60;
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH net-next 6/6] net: hdlc_cisco: remove redundant space
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
                   ` (4 preceding siblings ...)
  2021-06-02 11:01 ` [PATCH net-next 5/6] net: hdlc_cisco: add blank line after declaration Guangbin Huang
@ 2021-06-02 11:01 ` Guangbin Huang
  2021-06-03 20:30 ` [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: Guangbin Huang @ 2021-06-02 11:01 UTC (permalink / raw)
  To: davem, kuba, xie.he.0141, ms, willemb
  Cc: netdev, linux-kernel, lipeng321, tanhuazhong, huangguangbin2

From: Peng Li <lipeng321@huawei.com>

Space prohibited between function name and open parenthesis '('.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/wan/hdlc_cisco.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index d337711..349ca18 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -174,7 +174,7 @@ static int cisco_rx(struct sk_buff *skb)
 		cisco_data = (struct cisco_packet *)(skb->data + sizeof
 						    (struct hdlc_header));
 
-		switch (ntohl (cisco_data->type)) {
+		switch (ntohl(cisco_data->type)) {
 		case CISCO_ADDR_REQ: /* Stolen from syncppp.c :-) */
 			rcu_read_lock();
 			in_dev = __in_dev_get_rcu(dev);
-- 
2.8.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues
  2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
                   ` (5 preceding siblings ...)
  2021-06-02 11:01 ` [PATCH net-next 6/6] net: hdlc_cisco: remove redundant space Guangbin Huang
@ 2021-06-03 20:30 ` patchwork-bot+netdevbpf
  6 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-03 20:30 UTC (permalink / raw)
  To: huangguangbin
  Cc: davem, kuba, xie.he.0141, ms, willemb, netdev, linux-kernel,
	lipeng321, tanhuazhong

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Wed, 2 Jun 2021 19:01:10 +0800 you wrote:
> From: Peng Li <lipeng321@huawei.com>
> 
> This patchset clean up some code style issues.
> 
> Peng Li (6):
>   net: hdlc_cisco: remove redundant blank lines
>   net: hdlc_cisco: fix the code style issue about "foo* bar"
>   net: hdlc_cisco: add some required spaces
>   net: hdlc_cisco: remove unnecessary out of memory message
>   net: hdlc_cisco: add blank line after declaration
>   net: hdlc_cisco: remove redundant space
> 
> [...]

Here is the summary with links:
  - [net-next,1/6] net: hdlc_cisco: remove redundant blank lines
    https://git.kernel.org/netdev/net-next/c/5abaf211c4a5
  - [net-next,2/6] net: hdlc_cisco: fix the code style issue about "foo* bar"
    https://git.kernel.org/netdev/net-next/c/001aa274300d
  - [net-next,3/6] net: hdlc_cisco: add some required spaces
    https://git.kernel.org/netdev/net-next/c/c1300f37ea99
  - [net-next,4/6] net: hdlc_cisco: remove unnecessary out of memory message
    https://git.kernel.org/netdev/net-next/c/05ff5525aa82
  - [net-next,5/6] net: hdlc_cisco: add blank line after declaration
    https://git.kernel.org/netdev/net-next/c/4e38d514788c
  - [net-next,6/6] net: hdlc_cisco: remove redundant space
    https://git.kernel.org/netdev/net-next/c/4a20f8ecbf61

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-03 20:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 11:01 [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 1/6] net: hdlc_cisco: remove redundant blank lines Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 2/6] net: hdlc_cisco: fix the code style issue about "foo* bar" Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 3/6] net: hdlc_cisco: add some required spaces Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 4/6] net: hdlc_cisco: remove unnecessary out of memory message Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 5/6] net: hdlc_cisco: add blank line after declaration Guangbin Huang
2021-06-02 11:01 ` [PATCH net-next 6/6] net: hdlc_cisco: remove redundant space Guangbin Huang
2021-06-03 20:30 ` [PATCH net-next 0/6] net: hdlc_cisci: clean up some code style issues patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.