* [PATCH] spi: stm32-qspi: Fix W=1 build warning
@ 2021-06-04 7:50 ` patrice.chotard
0 siblings, 0 replies; 6+ messages in thread
From: patrice.chotard @ 2021-06-04 7:50 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello, patrice.chotard
From: Patrice Chotard <patrice.chotard@foss.st.com>
Fix the following compilation warning using W=1 build:
arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f4481fe48bf0..e71a4c514f7b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -806,6 +806,7 @@ config SPI_STM32_QSPI
tristate "STMicroelectronics STM32 QUAD SPI controller"
depends on ARCH_STM32 || COMPILE_TEST
depends on OF
+ depends on SPI_MEM
help
This enables support for the Quad SPI controller in master mode.
This driver does not support generic SPI. The implementation only
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] spi: stm32-qspi: Fix W=1 build warning
@ 2021-06-04 7:50 ` patrice.chotard
0 siblings, 0 replies; 6+ messages in thread
From: patrice.chotard @ 2021-06-04 7:50 UTC (permalink / raw)
To: Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello, patrice.chotard
From: Patrice Chotard <patrice.chotard@foss.st.com>
Fix the following compilation warning using W=1 build:
arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
drivers/spi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index f4481fe48bf0..e71a4c514f7b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -806,6 +806,7 @@ config SPI_STM32_QSPI
tristate "STMicroelectronics STM32 QUAD SPI controller"
depends on ARCH_STM32 || COMPILE_TEST
depends on OF
+ depends on SPI_MEM
help
This enables support for the Quad SPI controller in master mode.
This driver does not support generic SPI. The implementation only
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning
2021-06-04 7:50 ` patrice.chotard
@ 2021-06-04 15:27 ` Randy Dunlap
-1 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-06-04 15:27 UTC (permalink / raw)
To: patrice.chotard, Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello
On 6/4/21 12:50 AM, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
This is a build error, not a warning. The complete message is:
ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
> ---
> drivers/spi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
> tristate "STMicroelectronics STM32 QUAD SPI controller"
> depends on ARCH_STM32 || COMPILE_TEST
> depends on OF
> + depends on SPI_MEM
> help
> This enables support for the Quad SPI controller in master mode.
> This driver does not support generic SPI. The implementation only
>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning
@ 2021-06-04 15:27 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-06-04 15:27 UTC (permalink / raw)
To: patrice.chotard, Mark Brown, Alexandre Torgue
Cc: linux-spi, linux-stm32, linux-arm-kernel, linux-kernel,
christophe.kerello
On 6/4/21 12:50 AM, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
This is a build error, not a warning. The complete message is:
ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
> ---
> drivers/spi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
> tristate "STMicroelectronics STM32 QUAD SPI controller"
> depends on ARCH_STM32 || COMPILE_TEST
> depends on OF
> + depends on SPI_MEM
> help
> This enables support for the Quad SPI controller in master mode.
> This driver does not support generic SPI. The implementation only
>
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning
2021-06-04 7:50 ` patrice.chotard
@ 2021-06-04 16:32 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-06-04 16:32 UTC (permalink / raw)
To: Alexandre Torgue, patrice.chotard
Cc: Mark Brown, linux-spi, christophe.kerello, linux-stm32,
linux-kernel, linux-arm-kernel
On Fri, 4 Jun 2021 09:50:09 +0200, patrice.chotard@foss.st.com wrote:
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: stm32-qspi: Fix W=1 build warning
commit: 6829222b408f5aa5222c18ea3f492cac19fa9405
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning
@ 2021-06-04 16:32 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-06-04 16:32 UTC (permalink / raw)
To: Alexandre Torgue, patrice.chotard
Cc: Mark Brown, linux-spi, christophe.kerello, linux-stm32,
linux-kernel, linux-arm-kernel
On Fri, 4 Jun 2021 09:50:09 +0200, patrice.chotard@foss.st.com wrote:
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: stm32-qspi: Fix W=1 build warning
commit: 6829222b408f5aa5222c18ea3f492cac19fa9405
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-04 16:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 7:50 [PATCH] spi: stm32-qspi: Fix W=1 build warning patrice.chotard
2021-06-04 7:50 ` patrice.chotard
2021-06-04 15:27 ` Randy Dunlap
2021-06-04 15:27 ` Randy Dunlap
2021-06-04 16:32 ` Mark Brown
2021-06-04 16:32 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.