[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Renaud AUBIN]

The http-parser repository has been transfered from joyent to nodejs.
Bump version to 2.6.0.

Signed-off-by: Renaud AUBIN <root@renaud.io>
---
 ...1-Use-f-option-when-calling-ln-at-install-time.patch | 17 +++++++++--------
 package/libhttpparser/Config.in                         |  2 +-
 package/libhttpparser/libhttpparser.mk                  |  4 ++--
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
index 29fe04d..df16656 100644
--- a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
+++ b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
@@ -1,4 +1,4 @@
-From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001
+From 384917321c45e492b0ca7aaa94d4b15324aef95d Mon Sep 17 00:00:00 2001
 From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Date: Fri, 28 Aug 2015 19:02:11 +0200
 Subject: [PATCH] Use -f option when calling ln at install time
@@ -6,29 +6,30 @@ Subject: [PATCH] Use -f option when calling ln at install time
 This allows "make install; make install" to work properly.
 
 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+Signed-off-by: Renaud AUBIN <root@renaud.io>
 ---
  Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/Makefile b/Makefile
-index 373709c..6206b09 100644
+index 33c8ba0..b36d95a 100644
 --- a/Makefile
 +++ b/Makefile
-@@ -113,12 +113,12 @@ tags: http_parser.c http_parser.h test.c
+@@ -125,12 +125,12 @@ tags: http_parser.c http_parser.h test.c
  install: library
  	$(INSTALL) -D  http_parser.h $(INCLUDEDIR)/http_parser.h
  	$(INSTALL) -D $(SONAME) $(LIBDIR)/$(SONAME)
--	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
-+	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
+-	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
++	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
  
  install-strip: library
  	$(INSTALL) -D  http_parser.h $(INCLUDEDIR)/http_parser.h
  	$(INSTALL) -D -s $(SONAME) $(LIBDIR)/$(SONAME)
--	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
-+	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
+-	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
++	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
  
  uninstall:
  	rm $(INCLUDEDIR)/http_parser.h
 -- 
-2.5.0
+2.6.2
 
diff --git a/package/libhttpparser/Config.in b/package/libhttpparser/Config.in
index 31b8b9b..4356304 100644
--- a/package/libhttpparser/Config.in
+++ b/package/libhttpparser/Config.in
@@ -11,7 +11,7 @@ config BR2_PACKAGE_LIBHTTPPARSER
 	  40 bytes of data per message stream (in a web server
 	  that is per connection).
 
-	  https://github.com/joyent/http-parser
+	  https://github.com/nodejs/http-parser
 
 comment "libhttpparser needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
diff --git a/package/libhttpparser/libhttpparser.mk b/package/libhttpparser/libhttpparser.mk
index d6ec236..015efc0 100644
--- a/package/libhttpparser/libhttpparser.mk
+++ b/package/libhttpparser/libhttpparser.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-LIBHTTPPARSER_VERSION = v2.5.0
-LIBHTTPPARSER_SITE = $(call github,joyent,http-parser,$(LIBHTTPPARSER_VERSION))
+LIBHTTPPARSER_VERSION = v2.6.0
+LIBHTTPPARSER_SITE = $(call github,nodejs,http-parser,$(LIBHTTPPARSER_VERSION))
 LIBHTTPPARSER_INSTALL_STAGING = YES
 LIBHTTPPARSER_LICENSE = MIT
 LIBHTTPPARSER_LICENSE_FILES = LICENSE-MIT
-- 
2.6.2

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Thomas Petazzoni]

Renaud,

On Tue, 01 Dec 2015 13:15:19 +0100, Renaud AUBIN wrote:
> The http-parser repository has been transfered from joyent to nodejs.
> Bump version to 2.6.0.
> 
> Signed-off-by: Renaud AUBIN <root@renaud.io>

The commit title for packages should always look like:

	<package>: <description>

So in the case of this commit, it should be:

	libhttpparser: bump to version 2.6.0

Also, when you send a new version of a patch, it should be titled
[PATCHv2] and include a changelog of what has changed since the
previous iteration of the patch. See the Buildroot manual for details
about this, and "git help format-patch" for details on how to do it.

> diff --git a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> index 29fe04d..df16656 100644
> --- a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> +++ b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> @@ -1,4 +1,4 @@
> -From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001
> +From 384917321c45e492b0ca7aaa94d4b15324aef95d Mon Sep 17 00:00:00 2001
>  From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>  Date: Fri, 28 Aug 2015 19:02:11 +0200
>  Subject: [PATCH] Use -f option when calling ln at install time
> @@ -6,29 +6,30 @@ Subject: [PATCH] Use -f option when calling ln at install time
>  This allows "make install; make install" to work properly.

Since you're using libhttpparser, could you submit this patch to the
upstream project, so that we can hopefully get rid of it in the future ?

Finally, if you have some time, could you submit a patch to add a hash
file to this package, since it's fetched from github ?

I've fixed the commit title, and applied to the next branch (soon to be
merged into master).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Renaud AUBIN]

Thomas,

Le 2015-12-01 17:50, Thomas Petazzoni a ?crit?:
> Renaud,
> 
> On Tue, 01 Dec 2015 13:15:19 +0100, Renaud AUBIN wrote:
>> The http-parser repository has been transfered from joyent to nodejs.
>> Bump version to 2.6.0.
>> 
>> Signed-off-by: Renaud AUBIN <root@renaud.io>
> 
> The commit title for packages should always look like:
> 
> 	<package>: <description>
> 
> So in the case of this commit, it should be:
> 
> 	libhttpparser: bump to version 2.6.0
> 
> Also, when you send a new version of a patch, it should be titled
> [PATCHv2] and include a changelog of what has changed since the
> previous iteration of the patch. See the Buildroot manual for details
> about this, and "git help format-patch" for details on how to do it.
> 

OK, no excuse on that since the manual is complete on that.
Sorry (^^)

>> diff --git 
>> a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch 
>> b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
>> index 29fe04d..df16656 100644
>> --- 
>> a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
>> +++ 
>> b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
>> @@ -1,4 +1,4 @@
>> -From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 
>> 2001
>> +From 384917321c45e492b0ca7aaa94d4b15324aef95d Mon Sep 17 00:00:00 
>> 2001
>>  From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>  Date: Fri, 28 Aug 2015 19:02:11 +0200
>>  Subject: [PATCH] Use -f option when calling ln at install time
>> @@ -6,29 +6,30 @@ Subject: [PATCH] Use -f option when calling ln at 
>> install time
>>  This allows "make install; make install" to work properly.
> 
> Since you're using libhttpparser, could you submit this patch to the
> upstream project, so that we can hopefully get rid of it in the future 
> ?
> 

Existing upstream PR on this:
https://github.com/nodejs/http-parser/pull/243
https://github.com/nodejs/http-parser/pull/272

+ an issue / proposal on CMake usage instead of the existing plain old 
Makefile (but with no PR, I wouldn't count on this one).
So... Wait and see...

> Finally, if you have some time, could you submit a patch to add a hash
> file to this package, since it's fetched from github ?
> 
> I've fixed the commit title, and applied to the next branch (soon to be
> merged into master).
> 

No problem, I'll monitor master.

> Thanks,
> 
> Thomas

Thanks for your thoroughful explanation (obv. + the great work on 
buildroot!)

Renaud

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Arnout Vandecappelle]

On 01-12-15 21:20, J?rg Krause wrote:
> On Di, 2015-12-01 at 13:21 +0100, Renaud AUBIN wrote:
>> I have resubmitted by figuring out by myself the ad hoc git am
>> processing? 
>> Maybe the Contributing chapter could be slightly improved by a
>> section on packages' patching policies?
>>
>> Thank you for your review.
>>
> 
> We have a section about patch policy in the Buildroot manual:
> http://nightly.buildroot.org/#patch-policy

 But it doesn't say anything about what you have to do when you update a patch.
I'll try to cook something up.

 Regards,
 Arnout

> 
> Best regards
> J?rg Krause
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Jörg Krause]

On Di, 2015-12-01 at 13:21 +0100, Renaud AUBIN wrote:
> I have resubmitted by figuring out by myself the ad hoc git am
> processing? 
> Maybe the Contributing chapter could be slightly improved by a
> section on packages' patching policies?
> 
> Thank you for your review.
> 

We have a section about patch policy in the Buildroot manual:
http://nightly.buildroot.org/#patch-policy

Best regards
J?rg Krause

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Renaud AUBIN]

I have resubmitted by figuring out by myself the ad hoc git am processing? 
Maybe the Contributing chapter could be slightly improved by a section on packages' patching policies?

Thank you for your review.

Le?1 d?c. 2015 11:10 AM, Baruch Siach <baruch@tkos.co.il> a ?crit?:
>
> Hi Renaud AUBIN, 
>
> On Tue, Dec 01, 2015 at 09:35:04AM +0100, Renaud AUBIN wrote: 
> > The http-parser repository has been transfered from joyent to nodejs. 
> > Bump version to 2.6.0. 
> > 
> > Signed-off-by: Renaud AUBIN <root@renaud.io> 
>
> [...] 
>
> > -From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001 
> > -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 
> > -Date: Fri, 28 Aug 2015 19:02:11 +0200 
> > +From fb2d2803bdad4847b3116a325a9ae0a56f906a08 Mon Sep 17 00:00:00 2001 
> > +From: Renaud AUBIN <root@renaud.io> 
> > +Date: Tue, 1 Dec 2015 09:24:41 +0100 
>
> Please do not change the patch authorship. 
>
> >? Subject: [PATCH] Use -f option when calling ln at install time 
> >? 
> >? This allows "make install; make install" to work properly. 
> > - 
> > -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 
>
> Also, please don't remove existing sign-off. You may add your sign-off here 
> when you update the patch. 
>
> baruch 
>
> -- 
> ???? http://baruch.siach.name/blog/????????????????? ~. .~?? Tk Open Systems 
> =}------------------------------------------------ooO--U--Ooo------------{= 
> ?? - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - 
> _______________________________________________ 
> buildroot mailing list 
> buildroot at busybox.net 
> http://lists.busybox.net/mailman/listinfo/buildroot 

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Baruch Siach]

Hi Renaud AUBIN,

On Tue, Dec 01, 2015 at 09:35:04AM +0100, Renaud AUBIN wrote:
> The http-parser repository has been transfered from joyent to nodejs.
> Bump version to 2.6.0.
> 
> Signed-off-by: Renaud AUBIN <root@renaud.io>

[...]

> -From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001
> -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -Date: Fri, 28 Aug 2015 19:02:11 +0200
> +From fb2d2803bdad4847b3116a325a9ae0a56f906a08 Mon Sep 17 00:00:00 2001
> +From: Renaud AUBIN <root@renaud.io>
> +Date: Tue, 1 Dec 2015 09:24:41 +0100

Please do not change the patch authorship.

>  Subject: [PATCH] Use -f option when calling ln at install time
>  
>  This allows "make install; make install" to work properly.
> -
> -Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Also, please don't remove existing sign-off. You may add your sign-off here 
when you update the patch.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] Update the libhttpparser package

[Renaud AUBIN]

The http-parser repository has been transfered from joyent to nodejs.
Bump version to 2.6.0.

Signed-off-by: Renaud AUBIN <root@renaud.io>
---
 ...-f-option-when-calling-ln-at-install-time.patch | 22 ++++++++++------------
 package/libhttpparser/Config.in                    |  2 +-
 package/libhttpparser/libhttpparser.mk             |  4 ++--
 3 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
index 29fe04d..336a9e0 100644
--- a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
+++ b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
@@ -1,34 +1,32 @@
-From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Fri, 28 Aug 2015 19:02:11 +0200
+From fb2d2803bdad4847b3116a325a9ae0a56f906a08 Mon Sep 17 00:00:00 2001
+From: Renaud AUBIN <root@renaud.io>
+Date: Tue, 1 Dec 2015 09:24:41 +0100
 Subject: [PATCH] Use -f option when calling ln at install time
 
 This allows "make install; make install" to work properly.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 ---
  Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/Makefile b/Makefile
-index 373709c..6206b09 100644
+index 33c8ba0..b36d95a 100644
 --- a/Makefile
 +++ b/Makefile
-@@ -113,12 +113,12 @@ tags: http_parser.c http_parser.h test.c
+@@ -125,12 +125,12 @@ tags: http_parser.c http_parser.h test.c
  install: library
  	$(INSTALL) -D  http_parser.h $(INCLUDEDIR)/http_parser.h
  	$(INSTALL) -D $(SONAME) $(LIBDIR)/$(SONAME)
--	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
-+	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
+-	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
++	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
  
  install-strip: library
  	$(INSTALL) -D  http_parser.h $(INCLUDEDIR)/http_parser.h
  	$(INSTALL) -D -s $(SONAME) $(LIBDIR)/$(SONAME)
--	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
-+	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.so
+-	ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
++	ln -sf $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT)
  
  uninstall:
  	rm $(INCLUDEDIR)/http_parser.h
 -- 
-2.5.0
+2.6.2
 
diff --git a/package/libhttpparser/Config.in b/package/libhttpparser/Config.in
index 31b8b9b..4356304 100644
--- a/package/libhttpparser/Config.in
+++ b/package/libhttpparser/Config.in
@@ -11,7 +11,7 @@ config BR2_PACKAGE_LIBHTTPPARSER
 	  40 bytes of data per message stream (in a web server
 	  that is per connection).
 
-	  https://github.com/joyent/http-parser
+	  https://github.com/nodejs/http-parser
 
 comment "libhttpparser needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
diff --git a/package/libhttpparser/libhttpparser.mk b/package/libhttpparser/libhttpparser.mk
index d6ec236..015efc0 100644
--- a/package/libhttpparser/libhttpparser.mk
+++ b/package/libhttpparser/libhttpparser.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-LIBHTTPPARSER_VERSION = v2.5.0
-LIBHTTPPARSER_SITE = $(call github,joyent,http-parser,$(LIBHTTPPARSER_VERSION))
+LIBHTTPPARSER_VERSION = v2.6.0
+LIBHTTPPARSER_SITE = $(call github,nodejs,http-parser,$(LIBHTTPPARSER_VERSION))
 LIBHTTPPARSER_INSTALL_STAGING = YES
 LIBHTTPPARSER_LICENSE = MIT
 LIBHTTPPARSER_LICENSE_FILES = LICENSE-MIT
-- 
2.6.2