* [PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static
@ 2021-06-16 5:55 ` Jiapeng Chong
0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Chong @ 2021-06-16 5:55 UTC (permalink / raw)
To: lgirdwood; +Cc: broonie, perex, tiwai, alsa-devel, linux-kernel, Jiapeng Chong
This symbol is not used outside of hdmi-codec.c, so marks it static.
Fix the following sparse warning:
sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol
'hdmi_codec_controls' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/soc/codecs/hdmi-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index e0460a9..b61f980 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -747,7 +747,7 @@ static int hdmi_codec_mute(struct snd_soc_dai *dai, int mute, int direction)
SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\
SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)
-struct snd_kcontrol_new hdmi_codec_controls[] = {
+static struct snd_kcontrol_new hdmi_codec_controls[] = {
{
.access = SNDRV_CTL_ELEM_ACCESS_READ,
.iface = SNDRV_CTL_ELEM_IFACE_PCM,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static
@ 2021-06-16 5:55 ` Jiapeng Chong
0 siblings, 0 replies; 4+ messages in thread
From: Jiapeng Chong @ 2021-06-16 5:55 UTC (permalink / raw)
To: lgirdwood; +Cc: Jiapeng Chong, alsa-devel, linux-kernel, tiwai, broonie
This symbol is not used outside of hdmi-codec.c, so marks it static.
Fix the following sparse warning:
sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol
'hdmi_codec_controls' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/soc/codecs/hdmi-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index e0460a9..b61f980 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -747,7 +747,7 @@ static int hdmi_codec_mute(struct snd_soc_dai *dai, int mute, int direction)
SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\
SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE)
-struct snd_kcontrol_new hdmi_codec_controls[] = {
+static struct snd_kcontrol_new hdmi_codec_controls[] = {
{
.access = SNDRV_CTL_ELEM_ACCESS_READ,
.iface = SNDRV_CTL_ELEM_IFACE_PCM,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static
2021-06-16 5:55 ` Jiapeng Chong
@ 2021-06-16 16:41 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-06-16 16:41 UTC (permalink / raw)
To: lgirdwood, Jiapeng Chong
Cc: Mark Brown, alsa-devel, linux-kernel, perex, tiwai
On Wed, 16 Jun 2021 13:55:41 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of hdmi-codec.c, so marks it static.
>
> Fix the following sparse warning:
>
> sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol
> 'hdmi_codec_controls' was not declared. Should it be static?
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: hdmi-codec: make hdmi_codec_controls static
commit: e99d7c69fd4c18e7319f8aab8e252b12130796bf
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static
@ 2021-06-16 16:41 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2021-06-16 16:41 UTC (permalink / raw)
To: lgirdwood, Jiapeng Chong; +Cc: alsa-devel, Mark Brown, tiwai, linux-kernel
On Wed, 16 Jun 2021 13:55:41 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of hdmi-codec.c, so marks it static.
>
> Fix the following sparse warning:
>
> sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol
> 'hdmi_codec_controls' was not declared. Should it be static?
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: hdmi-codec: make hdmi_codec_controls static
commit: e99d7c69fd4c18e7319f8aab8e252b12130796bf
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-16 16:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 5:55 [PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static Jiapeng Chong
2021-06-16 5:55 ` Jiapeng Chong
2021-06-16 16:41 ` Mark Brown
2021-06-16 16:41 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.