All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper
@ 2021-06-23 15:16 Xianting Tian
  2021-06-23 16:14   ` Stefano Garzarella
  2021-06-23 21:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Xianting Tian @ 2021-06-23 15:16 UTC (permalink / raw)
  To: mst, jasowang, davem, kuba
  Cc: virtualization, netdev, linux-kernel, Xianting Tian

virtio_find_vqs_ctx() is defined but never be called currently,
it is the right place to use it.

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 drivers/net/virtio_net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 78a01c7..9061c55 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2830,8 +2830,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
 			ctx[rxq2vq(i)] = true;
 	}
 
-	ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks,
-					 names, ctx, NULL);
+	ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks,
+				  names, ctx, NULL);
 	if (ret)
 		goto err_find;
 
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper
  2021-06-23 15:16 [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper Xianting Tian
@ 2021-06-23 16:14   ` Stefano Garzarella
  2021-06-23 21:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2021-06-23 16:14 UTC (permalink / raw)
  To: Xianting Tian
  Cc: mst, jasowang, davem, kuba, virtualization, netdev, linux-kernel,
	Xianting Tian

On Wed, Jun 23, 2021 at 11:16:22AM -0400, Xianting Tian wrote:
>virtio_find_vqs_ctx() is defined but never be called currently,
>it is the right place to use it.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>index 78a01c7..9061c55 100644
>--- a/drivers/net/virtio_net.c
>+++ b/drivers/net/virtio_net.c
>@@ -2830,8 +2830,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
> 			ctx[rxq2vq(i)] = true;
> 	}
>
>-	ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks,
>-					 names, ctx, NULL);
>+	ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks,
>+				  names, ctx, NULL);
> 	if (ret)
> 		goto err_find;
>
>-- 
>1.8.3.1
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper
@ 2021-06-23 16:14   ` Stefano Garzarella
  0 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2021-06-23 16:14 UTC (permalink / raw)
  To: Xianting Tian
  Cc: mst, Xianting Tian, netdev, linux-kernel, virtualization, kuba, davem

On Wed, Jun 23, 2021 at 11:16:22AM -0400, Xianting Tian wrote:
>virtio_find_vqs_ctx() is defined but never be called currently,
>it is the right place to use it.
>
>Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
>---
> drivers/net/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>index 78a01c7..9061c55 100644
>--- a/drivers/net/virtio_net.c
>+++ b/drivers/net/virtio_net.c
>@@ -2830,8 +2830,8 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
> 			ctx[rxq2vq(i)] = true;
> 	}
>
>-	ret = vi->vdev->config->find_vqs(vi->vdev, total_vqs, vqs, callbacks,
>-					 names, ctx, NULL);
>+	ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks,
>+				  names, ctx, NULL);
> 	if (ret)
> 		goto err_find;
>
>-- 
>1.8.3.1
>

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper
  2021-06-23 15:16 [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper Xianting Tian
  2021-06-23 16:14   ` Stefano Garzarella
@ 2021-06-23 21:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-23 21:00 UTC (permalink / raw)
  To: Xianting Tian
  Cc: mst, jasowang, davem, kuba, virtualization, netdev, linux-kernel,
	xianting.tian

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 23 Jun 2021 11:16:22 -0400 you wrote:
> virtio_find_vqs_ctx() is defined but never be called currently,
> it is the right place to use it.
> 
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - virtio_net: Use virtio_find_vqs_ctx() helper
    https://git.kernel.org/netdev/net-next/c/a2f7dc00ea51

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-23 21:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 15:16 [PATCH] virtio_net: Use virtio_find_vqs_ctx() helper Xianting Tian
2021-06-23 16:14 ` Stefano Garzarella
2021-06-23 16:14   ` Stefano Garzarella
2021-06-23 21:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.