* [PATCH] flow_offload: action should not be NULL when it is referenced
@ 2021-06-26 11:56 13145886936
2021-06-28 21:30 ` patchwork-bot+netdevbpf
2021-08-18 11:58 ` Ido Schimmel
0 siblings, 2 replies; 5+ messages in thread
From: 13145886936 @ 2021-06-26 11:56 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, gushengxian, gushengxian
From: gushengxian <gushengxian@yulong.com>
"action" should not be NULL when it is referenced.
Signed-off-by: gushengxian <13145886936@163.com>
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
include/net/flow_offload.h | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
index dc5c1e69cd9f..69c9eabf8325 100644
--- a/include/net/flow_offload.h
+++ b/include/net/flow_offload.h
@@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
if (flow_offload_has_one_action(action))
return true;
- flow_action_for_each(i, action_entry, action) {
- if (i && action_entry->hw_stats != last_hw_stats) {
- NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
- return false;
+ if (action) {
+ flow_action_for_each(i, action_entry, action) {
+ if (i && action_entry->hw_stats != last_hw_stats) {
+ NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
+ return false;
+ }
+ last_hw_stats = action_entry->hw_stats;
}
- last_hw_stats = action_entry->hw_stats;
}
return true;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] flow_offload: action should not be NULL when it is referenced
2021-06-26 11:56 [PATCH] flow_offload: action should not be NULL when it is referenced 13145886936
@ 2021-06-28 21:30 ` patchwork-bot+netdevbpf
2021-08-18 11:58 ` Ido Schimmel
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-28 21:30 UTC (permalink / raw)
To: None; +Cc: davem, kuba, netdev, linux-kernel, gushengxian
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 26 Jun 2021 04:56:06 -0700 you wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> "action" should not be NULL when it is referenced.
>
> Signed-off-by: gushengxian <13145886936@163.com>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
>
> [...]
Here is the summary with links:
- flow_offload: action should not be NULL when it is referenced
https://git.kernel.org/netdev/net/c/9ea3e52c5bc8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] flow_offload: action should not be NULL when it is referenced
2021-06-26 11:56 [PATCH] flow_offload: action should not be NULL when it is referenced 13145886936
2021-06-28 21:30 ` patchwork-bot+netdevbpf
@ 2021-08-18 11:58 ` Ido Schimmel
2021-08-18 12:36 ` Jamal Hadi Salim
1 sibling, 1 reply; 5+ messages in thread
From: Ido Schimmel @ 2021-08-18 11:58 UTC (permalink / raw)
To: 13145886936; +Cc: davem, kuba, netdev, linux-kernel, gushengxian
On Sat, Jun 26, 2021 at 04:56:06AM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> "action" should not be NULL when it is referenced.
>
> Signed-off-by: gushengxian <13145886936@163.com>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> include/net/flow_offload.h | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index dc5c1e69cd9f..69c9eabf8325 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
> if (flow_offload_has_one_action(action))
> return true;
>
> - flow_action_for_each(i, action_entry, action) {
> - if (i && action_entry->hw_stats != last_hw_stats) {
> - NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
> - return false;
> + if (action) {
This patch generates a smatch warning:
include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn: variable dereferenced before check 'action' (see line 319)
Why the patch is needed? 'action' is already dereferenced in
flow_offload_has_one_action()
> + flow_action_for_each(i, action_entry, action) {
> + if (i && action_entry->hw_stats != last_hw_stats) {
> + NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
> + return false;
> + }
> + last_hw_stats = action_entry->hw_stats;
> }
> - last_hw_stats = action_entry->hw_stats;
> }
> return true;
> }
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] flow_offload: action should not be NULL when it is referenced
2021-08-18 11:58 ` Ido Schimmel
@ 2021-08-18 12:36 ` Jamal Hadi Salim
2021-08-18 13:39 ` Ido Schimmel
0 siblings, 1 reply; 5+ messages in thread
From: Jamal Hadi Salim @ 2021-08-18 12:36 UTC (permalink / raw)
To: Ido Schimmel, 13145886936
Cc: davem, kuba, netdev, linux-kernel, gushengxian, Cong Wang, Jiri Pirko
On 2021-08-18 7:58 a.m., Ido Schimmel wrote:
> On Sat, Jun 26, 2021 at 04:56:06AM -0700, 13145886936@163.com wrote:
>> From: gushengxian <gushengxian@yulong.com>
>>
>> "action" should not be NULL when it is referenced.
>>
>> Signed-off-by: gushengxian <13145886936@163.com>
>> Signed-off-by: gushengxian <gushengxian@yulong.com>
>> ---
>> include/net/flow_offload.h | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>> index dc5c1e69cd9f..69c9eabf8325 100644
>> --- a/include/net/flow_offload.h
>> +++ b/include/net/flow_offload.h
>> @@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
>> if (flow_offload_has_one_action(action))
>> return true;
>>
>> - flow_action_for_each(i, action_entry, action) {
>> - if (i && action_entry->hw_stats != last_hw_stats) {
>> - NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
>> - return false;
>> + if (action) {
>
> This patch generates a smatch warning:
>
> include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn: variable dereferenced before check 'action' (see line 319)
>
> Why the patch is needed? 'action' is already dereferenced in
> flow_offload_has_one_action()
>
Yep, doesnt make sense at all.
cheers,
jamal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] flow_offload: action should not be NULL when it is referenced
2021-08-18 12:36 ` Jamal Hadi Salim
@ 2021-08-18 13:39 ` Ido Schimmel
0 siblings, 0 replies; 5+ messages in thread
From: Ido Schimmel @ 2021-08-18 13:39 UTC (permalink / raw)
To: Jamal Hadi Salim
Cc: 13145886936, davem, kuba, netdev, linux-kernel, gushengxian,
Cong Wang, Jiri Pirko
On Wed, Aug 18, 2021 at 08:36:55AM -0400, Jamal Hadi Salim wrote:
> On 2021-08-18 7:58 a.m., Ido Schimmel wrote:
> > On Sat, Jun 26, 2021 at 04:56:06AM -0700, 13145886936@163.com wrote:
> > > From: gushengxian <gushengxian@yulong.com>
> > >
> > > "action" should not be NULL when it is referenced.
> > >
> > > Signed-off-by: gushengxian <13145886936@163.com>
> > > Signed-off-by: gushengxian <gushengxian@yulong.com>
> > > ---
> > > include/net/flow_offload.h | 12 +++++++-----
> > > 1 file changed, 7 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> > > index dc5c1e69cd9f..69c9eabf8325 100644
> > > --- a/include/net/flow_offload.h
> > > +++ b/include/net/flow_offload.h
> > > @@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
> > > if (flow_offload_has_one_action(action))
> > > return true;
> > > - flow_action_for_each(i, action_entry, action) {
> > > - if (i && action_entry->hw_stats != last_hw_stats) {
> > > - NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
> > > - return false;
> > > + if (action) {
> >
> > This patch generates a smatch warning:
> >
> > include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn: variable dereferenced before check 'action' (see line 319)
> >
> > Why the patch is needed? 'action' is already dereferenced in
> > flow_offload_has_one_action()
> >
>
> Yep, doesnt make sense at all.
Will send a revert
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-18 13:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 11:56 [PATCH] flow_offload: action should not be NULL when it is referenced 13145886936
2021-06-28 21:30 ` patchwork-bot+netdevbpf
2021-08-18 11:58 ` Ido Schimmel
2021-08-18 12:36 ` Jamal Hadi Salim
2021-08-18 13:39 ` Ido Schimmel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.