All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] tests/kms_addfb_basic: Test addfb2 with DRM_FORMAT_C8 only if supported.
@ 2021-07-07 20:03 Mark Yacoub
  2021-07-07 20:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 15+ messages in thread
From: Mark Yacoub @ 2021-07-07 20:03 UTC (permalink / raw)
  To: igt-dev; +Cc: seanpaul, petri.latvala, Mark Yacoub

From: Mark Yacoub <markyacoub@google.com>

[Why]
Some devices such as Trogdor do not support DRM_FORMAT_C8 pixel format.
Skip any addfb2 test on such devices that is expected to succeed such as
subtest size-max.

[How]
Only run the check on devices with DRM_FORMAT_C8 support

Tested on Trogdor.

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
 tests/kms_addfb_basic.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 91fb6ac9..20597b69 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -411,6 +411,7 @@ static void size_tests(int fd)
 	struct drm_mode_fb_cmd2 f_8 = {};
 	struct drm_mode_fb_cmd2 *framebuffers[] = {&f, &f_16, &f_8};
 	int i;
+	bool is_c8_format_supported = !is_msm_device(fd);
 
 	f.width = 1024;
 	f.height = 1024;
@@ -440,17 +441,19 @@ static void size_tests(int fd)
 	f_16.handles[0] = gem_bo;
 	f_8.handles[0] = gem_bo;
 
-	igt_describe("Check if addfb2 call works with max size of  buffer object");
+	igt_describe("Check if addfb2 call works with max size of buffer object");
 	igt_subtest("size-max") {
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
 		f.fb_id = 0;
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == 0);
 		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f_16.fb_id) == 0);
-		f.fb_id = 0;
-		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == 0);
-		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f_8.fb_id) == 0);
-		f.fb_id = 0;
+		f_16.fb_id = 0;
+		if (is_c8_format_supported) {
+			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == 0);
+			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f_8.fb_id) == 0);
+			f_8.fb_id = 0;
+		}
 	}
 
 	f.width++;
-- 
2.32.0.93.g670b81a890-goog

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-09-01 14:22 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 20:03 [igt-dev] [PATCH] tests/kms_addfb_basic: Test addfb2 with DRM_FORMAT_C8 only if supported Mark Yacoub
2021-07-07 20:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-08  0:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-07-08 19:09 ` [igt-dev] [PATCH] " Ville Syrjälä
2021-07-08 19:53   ` Mark Yacoub
2021-07-08 19:51 ` Mark Yacoub
2021-07-08 21:17 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Test addfb2 with DRM_FORMAT_C8 only if supported. (rev2) Patchwork
2021-07-09  9:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-09 15:05 ` [igt-dev] [PATCH v2] tests/kms_addfb_basic: Test addfb2 with DRM_FORMAT_C8 only if supported Mark Yacoub
2021-09-01 14:25   ` Petri Latvala
2021-07-09 15:42 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Test addfb2 with DRM_FORMAT_C8 only if supported. (rev3) Patchwork
2021-07-10  8:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-20 15:34   ` Mark Yacoub
2021-07-20 16:11     ` Vudum, Lakshminarayana
2021-07-20 15:56 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.