FAILED: patch "[PATCH] fuse: reject internal errno" failed to apply to 4.19-stable tree

FAILED: patch "[PATCH] fuse: reject internal errno" failed to apply to 4.19-stable tree

[gregkh]

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 49221cf86d18bb66fe95d3338cb33bd4b9880ca5 Mon Sep 17 00:00:00 2001
From: Miklos Szeredi <mszeredi@redhat.com>
Date: Tue, 22 Jun 2021 09:15:35 +0200
Subject: [PATCH] fuse: reject internal errno

Don't allow userspace to report errors that could be kernel-internal.

Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Fixes: 334f485df85a ("[PATCH] FUSE - device functions")
Cc: <stable@vger.kernel.org> # v2.6.14
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 6e63bcba2a40..b8d58aa08206 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1867,7 +1867,7 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud,
 	}
 
 	err = -EINVAL;
-	if (oh.error <= -1000 || oh.error > 0)
+	if (oh.error <= -512 || oh.error > 0)
 		goto copy_finish;
 
 	spin_lock(&fpq->lock);

Re: FAILED: patch "[PATCH] fuse: reject internal errno" failed to apply to 4.19-stable tree

[Miklos Szeredi]

Hi Greg,

Please apply with --fuzz=3 (though I don't really see why this is
needed, since there's just a single line of difference in the
context).

Should work for backports to all previous versions.

Thanks,
Miklos

On Sun, Jul 11, 2021 at 3:20 PM <gregkh@linuxfoundation.org> wrote:
>
>
> The patch below does not apply to the 4.19-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> From 49221cf86d18bb66fe95d3338cb33bd4b9880ca5 Mon Sep 17 00:00:00 2001
> From: Miklos Szeredi <mszeredi@redhat.com>
> Date: Tue, 22 Jun 2021 09:15:35 +0200
> Subject: [PATCH] fuse: reject internal errno
>
> Don't allow userspace to report errors that could be kernel-internal.
>
> Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
> Fixes: 334f485df85a ("[PATCH] FUSE - device functions")
> Cc: <stable@vger.kernel.org> # v2.6.14
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 6e63bcba2a40..b8d58aa08206 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -1867,7 +1867,7 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud,
>         }
>
>         err = -EINVAL;
> -       if (oh.error <= -1000 || oh.error > 0)
> +       if (oh.error <= -512 || oh.error > 0)
>                 goto copy_finish;
>
>         spin_lock(&fpq->lock);
>

Re: FAILED: patch "[PATCH] fuse: reject internal errno" failed to apply to 4.19-stable tree

[Greg Kroah-Hartman]

On Mon, Jul 12, 2021 at 09:17:00AM +0200, Miklos Szeredi wrote:
> Hi Greg,
> 
> Please apply with --fuzz=3 (though I don't really see why this is
> needed, since there's just a single line of difference in the
> context).
> 
> Should work for backports to all previous versions.

Ok, that worked better, the context did not allow it to apply cleanly
as-is.

thanks,

greg k-h