* [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
@ 2021-07-13 13:59 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2021-07-13 13:59 UTC (permalink / raw)
To: DRI Development
Cc: David Airlie, Daniel Vetter, Intel Graphics Development,
Maxime Ripard, Chris Wilson, Thomas Zimmermann, Daniel Vetter
Some vague evidences suggests this can go wrong. Try to prevent it by
holding the right mutex and clearing ->deferred_setup to make sure we
later on don't accidentally try to re-register the fbdev when the
driver thought it had it all cleaned up already.
v2: I realized that this is fundamentally butchered, and CI complained
about lockdep splats. So limit the critical section again and just add
a few notes what the proper fix is.
References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 9d82fda274eb..8f11e5abb222 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
* A wrapper around unregister_framebuffer, to release the fb_info
* framebuffer device. This must be called before releasing all resources for
* @fb_helper by calling drm_fb_helper_fini().
+ *
+ * Note that this is fundamentally racy on hotunload because it doen't handle
+ * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
*/
void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
{
@@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
* @fb_helper: driver-allocated fbdev helper, can be NULL
*
* This cleans up all remaining resources associated with @fb_helper.
+ *
+ * Note that this is fundamentally racy on hotunload because it doen't handle
+ * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
*/
void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
{
@@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
{
struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+ mutex_lock(&fb_helper->lock);
+ fb_helper->deferred_setup = false;
+ mutex_unlock(&fb_helper->lock);
+
if (fb_helper->fbdev)
/* drm_fbdev_fb_destroy() takes care of cleanup */
drm_fb_helper_unregister_fbi(fb_helper);
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
(?)
@ 2021-07-13 16:43 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-07-13 16:43 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/fb-helper: Try to protect cleanup against delayed setup
URL : https://patchwork.freedesktop.org/series/92478/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b0ba74e0d5e3 drm/fb-helper: Try to protect cleanup against delayed setup
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
-:62: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Daniel Vetter <daniel.vetter@ffwll.ch>' != 'Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>'
total: 0 errors, 2 warnings, 0 checks, 28 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
(?)
(?)
@ 2021-07-13 17:09 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-07-13 17:09 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2803 bytes --]
== Series Details ==
Series: drm/fb-helper: Try to protect cleanup against delayed setup
URL : https://patchwork.freedesktop.org/series/92478/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10341 -> Patchwork_20587
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/index.html
Known issues
------------
Here are the changes found in Patchwork_20587 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/fi-tgl-y/igt@amdgpu/amd_prime@amd-to-i915.html
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [PASS][2] -> [DMESG-WARN][3] ([i915#203]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][4] ([i915#1602] / [i915#2029])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/fi-bdw-5557u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (39 -> 35)
------------------------------
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10341 -> Patchwork_20587
CI-20190529: 20190529
CI_DRM_10341: 72a4e94d9585ff89a8c85bd1436fb05b60dad2f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6137: 2fee489255f7a8cd6a584373c30e3d44a07a78ea @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20587: b0ba74e0d5e3af9a36ca12804924a802b41617de @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b0ba74e0d5e3 drm/fb-helper: Try to protect cleanup against delayed setup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/index.html
[-- Attachment #1.2: Type: text/html, Size: 3262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
@ 2021-07-13 20:21 ` Sam Ravnborg
-1 siblings, 0 replies; 13+ messages in thread
From: Sam Ravnborg @ 2021-07-13 20:21 UTC (permalink / raw)
To: Daniel Vetter
Cc: David Airlie, Intel Graphics Development, DRI Development,
Chris Wilson, Thomas Zimmermann, Daniel Vetter
Hi Daniel,
On Tue, Jul 13, 2021 at 03:59:22PM +0200, Daniel Vetter wrote:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
s/doen't/doesn't/
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
s/doen't/doesn't/
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
I could not find any better spot to clear deferred_setup - so I think
this is OK.
With the two spellign issues fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
No r-b as I an not too fluent in these code paths and all the locking.
Sam
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
@ 2021-07-13 20:21 ` Sam Ravnborg
0 siblings, 0 replies; 13+ messages in thread
From: Sam Ravnborg @ 2021-07-13 20:21 UTC (permalink / raw)
To: Daniel Vetter
Cc: David Airlie, Intel Graphics Development, DRI Development,
Chris Wilson, Thomas Zimmermann, Daniel Vetter
Hi Daniel,
On Tue, Jul 13, 2021 at 03:59:22PM +0200, Daniel Vetter wrote:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
s/doen't/doesn't/
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
s/doen't/doesn't/
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
I could not find any better spot to clear deferred_setup - so I think
this is OK.
With the two spellign issues fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
No r-b as I an not too fluent in these code paths and all the locking.
Sam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
` (3 preceding siblings ...)
(?)
@ 2021-07-13 23:25 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2021-07-13 23:25 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30278 bytes --]
== Series Details ==
Series: drm/fb-helper: Try to protect cleanup against delayed setup
URL : https://patchwork.freedesktop.org/series/92478/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10341_full -> Patchwork_20587_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20587_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20587_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20587_full:
### IGT changes ###
#### Possible regressions ####
* igt@dumb_buffer@map-invalid-size:
- shard-iclb: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@dumb_buffer@map-invalid-size.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][2] ([i915#3063]) -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-1/igt@gem_eio@unwedge-stress.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_suspend@basic-s4-devices:
- {shard-rkl}: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-1/igt@gem_exec_suspend@basic-s4-devices.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-5/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_ccs:
- {shard-rkl}: [FAIL][6] ([i915#3678]) -> [SKIP][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_ccs.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_ccs.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- {shard-rkl}: NOTRUN -> [SKIP][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-1/igt@kms_dither@fb-8bpc-vs-panel-6bpc.html
* igt@runner@aborted:
- {shard-rkl}: ([FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12]) ([i915#2029] / [i915#3002] / [i915#3728]) -> ([FAIL][13], [FAIL][14], [FAIL][15]) ([i915#3002])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-6/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-1/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-5/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-5/igt@runner@aborted.html
* igt@sysfs_timeslice_duration@timeout@rcs0:
- {shard-rkl}: [PASS][16] -> [FAIL][17] +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-1/igt@sysfs_timeslice_duration@timeout@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-2/igt@sysfs_timeslice_duration@timeout@rcs0.html
Known issues
------------
Here are the changes found in Patchwork_20587_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][18] ([i915#3002])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb5/igt@gem_create@create-massive.html
- shard-kbl: NOTRUN -> [DMESG-WARN][19] ([i915#3002])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl1/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#1099]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb5/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][21] -> [TIMEOUT][22] ([i915#2369] / [i915#2481] / [i915#3070])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb7/igt@gem_eio@unwedge-stress.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#2846])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-glk6/igt@gem_exec_fair@basic-deadline.html
- shard-apl: NOTRUN -> [FAIL][25] ([i915#2846])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#2842])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][28] -> [FAIL][29] ([i915#2842]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-kbl7/igt@gem_exec_fair@basic-none@vcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][30] -> [FAIL][31] ([i915#2842])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-glk3/igt@gem_exec_fair@basic-throttle@rcs0.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-glk1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][32] ([i915#3633]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb6/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][33] ([i915#3633])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb1/igt@gem_exec_reloc@basic-wide-active@vcs1.html
* igt@gem_exec_suspend@basic-s3-devices:
- shard-tglb: [PASS][34] -> [DMESG-WARN][35] ([i915#402])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-tglb3/igt@gem_exec_suspend@basic-s3-devices.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-tglb1/igt@gem_exec_suspend@basic-s3-devices.html
* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [PASS][36] -> [DMESG-WARN][37] ([i915#118] / [i915#95])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-glk1/igt@gem_exec_whisper@basic-fds-priority-all.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-glk2/igt@gem_exec_whisper@basic-fds-priority-all.html
* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#2190])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@coherency:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109292])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@gem_mmap_gtt@coherency.html
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [PASS][40] -> [FAIL][41] ([i915#307])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][42] ([i915#2658])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][43] ([i915#3002])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@gem_userptr_blits@input-checking.html
* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: [PASS][44] -> [INCOMPLETE][45] ([i915#198])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl7/igt@i915_pm_backlight@fade_with_suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl5/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_selftest@mock@dmabuf:
- shard-iclb: NOTRUN -> [DMESG-WARN][46] ([i915#3746]) +17 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@i915_selftest@mock@dmabuf.html
* igt@i915_suspend@forcewake:
- shard-snb: [PASS][47] -> [DMESG-WARN][48] ([i915#3305])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-snb2/igt@i915_suspend@forcewake.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb2/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3777]) +4 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271]) +59 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl6/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_joiner@2x-modeset:
- shard-iclb: NOTRUN -> [SKIP][51] ([i915#2705])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][52] ([i915#3689])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-tglb1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109284] / [fdo#111827]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +8 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +18 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb5/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +29 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][57] ([i915#1319])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][58] ([i915#1319]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-skl: [PASS][59] -> [FAIL][60] ([i915#3444])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl3/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278] / [fdo#109279])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][62] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109278]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][65] -> [FAIL][66] ([i915#79])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][67] -> [DMESG-WARN][68] ([i915#180]) +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2672])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][70] ([fdo#109271]) +378 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-snb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render:
- shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271]) +14 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-skl: [PASS][72] -> [FAIL][73] ([i915#49])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109280]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#111825]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][76] -> [FAIL][77] ([fdo#108145] / [i915#265])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][78] ([i915#265]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][79] ([fdo#108145] / [i915#265]) +4 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658]) +4 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb2/igt@kms_psr@psr2_suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271]) +337 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl3/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#533])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2437]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl8/igt@kms_writeback@writeback-fb-id.html
* igt@perf@polling:
- shard-skl: [PASS][87] -> [FAIL][88] ([i915#1542])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl2/igt@perf@polling.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl6/igt@perf@polling.html
* igt@prime_vgem@fence-flip-hang:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109295])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@prime_vgem@fence-flip-hang.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2994]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-apl1/igt@sysfs_clients@create.html
* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@fbdev@write:
- {shard-rkl}: [SKIP][92] ([i915#2582]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@fbdev@write.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@fbdev@write.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: [FAIL][94] ([i915#2842]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-glk4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-glk5/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][96] ([i915#2842]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-2/igt@gem_exec_fair@basic-throttle@rcs0.html
- shard-iclb: [FAIL][98] ([i915#2849]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_suspend@basic-s3-devices:
- shard-iclb: [DMESG-WARN][100] ([i915#1226]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb5/igt@gem_exec_suspend@basic-s3-devices.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb2/igt@gem_exec_suspend@basic-s3-devices.html
* igt@i915_pm_backlight@basic-brightness:
- {shard-rkl}: [SKIP][102] ([i915#3012]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@i915_pm_backlight@basic-brightness.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [INCOMPLETE][104] ([i915#3698]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb2/igt@i915_pm_dc@dc5-psr.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb5/igt@i915_pm_dc@dc5-psr.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [DMESG-WARN][106] ([i915#180]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-kbl4/igt@i915_suspend@sysfs-reader.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- {shard-rkl}: [SKIP][108] ([i915#3638]) -> [PASS][109] +3 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180:
- {shard-rkl}: [SKIP][110] ([i915#3721]) -> [PASS][111] +6 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [FAIL][112] ([i915#3678]) -> [PASS][113] +4 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-b-ctm-0-25:
- {shard-rkl}: [SKIP][114] ([i915#1149] / [i915#1849]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_color@pipe-b-ctm-0-25.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_color@pipe-b-ctm-0-25.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement:
- {shard-rkl}: [SKIP][116] ([fdo#112022]) -> [PASS][117] +10 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [FAIL][118] ([i915#2346]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- {shard-rkl}: [SKIP][120] ([fdo#111825]) -> [PASS][121] +4 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a:
- shard-iclb: [SKIP][122] -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb2/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb3/igt@kms_dither@fb-8bpc-vs-panel-8bpc@edp-1-pipe-a.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- {shard-rkl}: [SKIP][124] ([fdo#111314]) -> [PASS][125] +6 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
* igt@kms_flip@absolute-wf_vblank@a-edp1:
- shard-skl: [DMESG-WARN][126] ([i915#1982]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl5/igt@kms_flip@absolute-wf_vblank@a-edp1.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl3/igt@kms_flip@absolute-wf_vblank@a-edp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][128] ([i915#2122]) -> [PASS][129] +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl10/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][130] ([i915#180] / [i915#1982]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- {shard-rkl}: [SKIP][132] ([i915#1849]) -> [PASS][133] +33 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- {shard-rkl}: [SKIP][134] ([i915#1849] / [i915#3558]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][136] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb6/igt@kms_psr2_su@page_flip.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@cursor_render:
- {shard-rkl}: [SKIP][138] ([i915#1072]) -> [PASS][139] +2 similar issues
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_psr@cursor_render.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_psr@cursor_render.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][140] ([fdo#109441]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_sequence@get-forked:
- {shard-rkl}: [SKIP][142] ([i915#1845]) -> [PASS][143] +17 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-5/igt@kms_sequence@get-forked.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-rkl-6/igt@kms_sequence@get-forked.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][144] ([i915#1982] / [i915#262]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-skl6/igt@perf_pmu@module-unload.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/shard-skl8/igt@perf_pmu@module-unload.html
* igt@sysfs_preempt_timeout@timeout@rcs0:
- {shard-rkl}: [FAIL][146] -> [PASS][147] +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10341/shard-rkl-2/igt@sysfs_preempt_timeout@timeout@rcs0.html
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20587/index.html
[-- Attachment #1.2: Type: text/html, Size: 33370 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
@ 2021-07-15 14:18 ` Thomas Zimmermann
-1 siblings, 0 replies; 13+ messages in thread
From: Thomas Zimmermann @ 2021-07-15 14:18 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: David Airlie, Daniel Vetter, Intel Graphics Development, Chris Wilson
[-- Attachment #1.1: Type: text/plain, Size: 3016 bytes --]
Am 13.07.21 um 15:59 schrieb Daniel Vetter:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
@ 2021-07-15 14:18 ` Thomas Zimmermann
0 siblings, 0 replies; 13+ messages in thread
From: Thomas Zimmermann @ 2021-07-15 14:18 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: David Airlie, Daniel Vetter, Intel Graphics Development, Chris Wilson
[-- Attachment #1.1.1: Type: text/plain, Size: 3016 bytes --]
Am 13.07.21 um 15:59 schrieb Daniel Vetter:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
2021-07-13 13:59 ` [Intel-gfx] " Daniel Vetter
@ 2022-11-15 9:30 ` Andrzej Hajda
-1 siblings, 0 replies; 13+ messages in thread
From: Andrzej Hajda @ 2022-11-15 9:30 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: David Airlie, Intel Graphics Development, Chris Wilson,
Thomas Zimmermann, Daniel Vetter
On 13.07.2021 15:59, Daniel Vetter wrote:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
@ 2022-11-15 9:30 ` Andrzej Hajda
0 siblings, 0 replies; 13+ messages in thread
From: Andrzej Hajda @ 2022-11-15 9:30 UTC (permalink / raw)
To: Daniel Vetter, DRI Development
Cc: David Airlie, Intel Graphics Development, Maxime Ripard,
Chris Wilson, Thomas Zimmermann, Daniel Vetter
On 13.07.2021 15:59, Daniel Vetter wrote:
> Some vague evidences suggests this can go wrong. Try to prevent it by
> holding the right mutex and clearing ->deferred_setup to make sure we
> later on don't accidentally try to re-register the fbdev when the
> driver thought it had it all cleaned up already.
>
> v2: I realized that this is fundamentally butchered, and CI complained
> about lockdep splats. So limit the critical section again and just add
> a few notes what the proper fix is.
>
> References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> ---
> drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 9d82fda274eb..8f11e5abb222 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> * A wrapper around unregister_framebuffer, to release the fb_info
> * framebuffer device. This must be called before releasing all resources for
> * @fb_helper by calling drm_fb_helper_fini().
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> {
> @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> * @fb_helper: driver-allocated fbdev helper, can be NULL
> *
> * This cleans up all remaining resources associated with @fb_helper.
> + *
> + * Note that this is fundamentally racy on hotunload because it doen't handle
> + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> */
> void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> {
> @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> {
> struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
> + mutex_lock(&fb_helper->lock);
> + fb_helper->deferred_setup = false;
> + mutex_unlock(&fb_helper->lock);
> +
> if (fb_helper->fbdev)
> /* drm_fbdev_fb_destroy() takes care of cleanup */
> drm_fb_helper_unregister_fbi(fb_helper);
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
2022-11-15 9:30 ` Andrzej Hajda
@ 2022-11-16 9:31 ` Daniel Vetter
-1 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2022-11-16 9:31 UTC (permalink / raw)
To: Andrzej Hajda
Cc: David Airlie, Daniel Vetter, Intel Graphics Development,
Chris Wilson, DRI Development, Thomas Zimmermann, Daniel Vetter
On Tue, Nov 15, 2022 at 10:30:01AM +0100, Andrzej Hajda wrote:
> On 13.07.2021 15:59, Daniel Vetter wrote:
> > Some vague evidences suggests this can go wrong. Try to prevent it by
> > holding the right mutex and clearing ->deferred_setup to make sure we
> > later on don't accidentally try to re-register the fbdev when the
> > driver thought it had it all cleaned up already.
> >
> > v2: I realized that this is fundamentally butchered, and CI complained
> > about lockdep splats. So limit the critical section again and just add
> > a few notes what the proper fix is.
> >
> > References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
I just dropped this one from my patch pile a while ago, because there were
conflicts. If you like it, feel free to resurrect&rebase and then merge it
(but maybe cc intel-gfx so the CI there can test it).
-Daniel
>
> Regards
> Andrzej
>
> > ---
> > drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> > index 9d82fda274eb..8f11e5abb222 100644
> > --- a/drivers/gpu/drm/drm_fb_helper.c
> > +++ b/drivers/gpu/drm/drm_fb_helper.c
> > @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> > * A wrapper around unregister_framebuffer, to release the fb_info
> > * framebuffer device. This must be called before releasing all resources for
> > * @fb_helper by calling drm_fb_helper_fini().
> > + *
> > + * Note that this is fundamentally racy on hotunload because it doen't handle
> > + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> > */
> > void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> > {
> > @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> > * @fb_helper: driver-allocated fbdev helper, can be NULL
> > *
> > * This cleans up all remaining resources associated with @fb_helper.
> > + *
> > + * Note that this is fundamentally racy on hotunload because it doen't handle
> > + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> > */
> > void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> > {
> > @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> > {
> > struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> > + mutex_lock(&fb_helper->lock);
> > + fb_helper->deferred_setup = false;
> > + mutex_unlock(&fb_helper->lock);
> > +
> > if (fb_helper->fbdev)
> > /* drm_fbdev_fb_destroy() takes care of cleanup */
> > drm_fb_helper_unregister_fbi(fb_helper);
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup
@ 2022-11-16 9:31 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2022-11-16 9:31 UTC (permalink / raw)
To: Andrzej Hajda
Cc: David Airlie, Daniel Vetter, Intel Graphics Development,
Maxime Ripard, Chris Wilson, DRI Development, Thomas Zimmermann,
Daniel Vetter
On Tue, Nov 15, 2022 at 10:30:01AM +0100, Andrzej Hajda wrote:
> On 13.07.2021 15:59, Daniel Vetter wrote:
> > Some vague evidences suggests this can go wrong. Try to prevent it by
> > holding the right mutex and clearing ->deferred_setup to make sure we
> > later on don't accidentally try to re-register the fbdev when the
> > driver thought it had it all cleaned up already.
> >
> > v2: I realized that this is fundamentally butchered, and CI complained
> > about lockdep splats. So limit the critical section again and just add
> > a few notes what the proper fix is.
> >
> > References: https://intel-gfx-ci.01.org/tree/linux-next/next-20201215/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
I just dropped this one from my patch pile a while ago, because there were
conflicts. If you like it, feel free to resurrect&rebase and then merge it
(but maybe cc intel-gfx so the CI there can test it).
-Daniel
>
> Regards
> Andrzej
>
> > ---
> > drivers/gpu/drm/drm_fb_helper.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> > index 9d82fda274eb..8f11e5abb222 100644
> > --- a/drivers/gpu/drm/drm_fb_helper.c
> > +++ b/drivers/gpu/drm/drm_fb_helper.c
> > @@ -598,6 +598,9 @@ EXPORT_SYMBOL(drm_fb_helper_alloc_fbi);
> > * A wrapper around unregister_framebuffer, to release the fb_info
> > * framebuffer device. This must be called before releasing all resources for
> > * @fb_helper by calling drm_fb_helper_fini().
> > + *
> > + * Note that this is fundamentally racy on hotunload because it doen't handle
> > + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> > */
> > void drm_fb_helper_unregister_fbi(struct drm_fb_helper *fb_helper)
> > {
> > @@ -611,6 +614,9 @@ EXPORT_SYMBOL(drm_fb_helper_unregister_fbi);
> > * @fb_helper: driver-allocated fbdev helper, can be NULL
> > *
> > * This cleans up all remaining resources associated with @fb_helper.
> > + *
> > + * Note that this is fundamentally racy on hotunload because it doen't handle
> > + * open fbdev file descriptors at all. Use drm_fbdev_generic_setup() instead.
> > */
> > void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
> > {
> > @@ -2382,6 +2388,10 @@ static void drm_fbdev_client_unregister(struct drm_client_dev *client)
> > {
> > struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> > + mutex_lock(&fb_helper->lock);
> > + fb_helper->deferred_setup = false;
> > + mutex_unlock(&fb_helper->lock);
> > +
> > if (fb_helper->fbdev)
> > /* drm_fbdev_fb_destroy() takes care of cleanup */
> > drm_fb_helper_unregister_fbi(fb_helper);
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 13+ messages in thread