All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Jason Gunthorpe" <jgg@nvidia.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Provide core infrastructure for managing open/release (rev2)
Date: Fri, 16 Jul 2021 16:49:26 -0000	[thread overview]
Message-ID: <162645416614.12777.9888825247711123044@emeril.freedesktop.org> (raw)
In-Reply-To: <0-v1-eaf3ccbba33c+1add0-vfio_reflck_jgg@nvidia.com>

== Series Details ==

Series: Provide core infrastructure for managing open/release (rev2)
URL   : https://patchwork.freedesktop.org/series/92556/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
55369372f9a3 vfio/samples: Remove module get/put
-:55: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 31 lines checked
177714a2be7f vfio: Introduce a vfio_uninit_group_dev() API call
a8ad279bbf60 vfio: Provide better generic support for open/release vfio_device_ops
-:107: CHECK:BRACES: braces {} should be used on all arms of this statement
#107: FILE: drivers/vfio/vfio.c:114:
+	if (alloc_dev_set) {
[...]
+	} else
[...]

-:118: CHECK:BRACES: Unbalanced braces around else statement
#118: FILE: drivers/vfio/vfio.c:125:
+	} else

-:236: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#236: FILE: drivers/vfio/vfio.c:1478:
+	fdno = ret = get_unused_fd_flags(O_CLOEXEC);

-:334: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#334: FILE: include/linux/vfio.h:25:
+	struct mutex lock;

-:376: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 4 checks, 302 lines checked
ec95ddcfb48f vfio/samples: Delete useless open/close
-:96: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 66 lines checked
851ba57de6e7 vfio/fsl: Move to the device set infrastructure
-:295: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 254 lines checked
fceda419b48c vfio/platform: Use open_device() instead of open coding a refcnt scheme
-:48: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#48: FILE: drivers/vfio/platform/vfio_platform_common.c:230:
+		dev_warn(

-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/vfio/platform/vfio_platform_common.c:261:
+		dev_warn(

-:146: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 2 checks, 120 lines checked
168446e606ea vfio/pci: Move to the device set infrastructure
622d1a17107e vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set
-:130: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#130: FILE: drivers/vfio/pci/vfio_pci.c:2225:
+	if (vfio_pci_for_each_slot_or_bus(

-:236: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 1 checks, 193 lines checked
b2f54bb6af80 vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
-:230: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#230: FILE: drivers/vfio/pci/vfio_pci.c:2103:
+	if (vfio_pci_for_each_slot_or_bus(

-:299: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 1 checks, 267 lines checked
76aced5ab6ba vfio/mbochs: Fix close when multiple device FDs are open
-:35: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
242842506d4f vfio/ap, ccw: Fix open/close when multiple device FDs are open
-:83: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 52 lines checked
4593947ca67f vfio/gvt: Fix open/close when multiple device FDs are open
-:50: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
a2014e2a4820 vfio: Remove struct vfio_device_ops open/release
-:142: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Jason Gunthorpe <jgg@ziepe.ca>' != 'Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>'

total: 0 errors, 1 warnings, 0 checks, 107 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-07-16 16:49 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  0:20 [PATCH 00/13] Provide core infrastructure for managing open/release Jason Gunthorpe
2021-07-15  0:20 ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20 ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 01/13] vfio/samples: Remove module get/put Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-19 11:42   ` Cornelia Huck
2021-07-19 11:42     ` [Intel-gfx] " Cornelia Huck
2021-07-19 11:42     ` Cornelia Huck
2021-07-15  0:20 ` [PATCH 02/13] vfio: Introduce a vfio_uninit_group_dev() API call Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15  3:49   ` Leon Romanovsky
2021-07-15  3:49     ` [Intel-gfx] " Leon Romanovsky
2021-07-15  3:49     ` Leon Romanovsky
2021-07-15 12:45     ` Jason Gunthorpe
2021-07-15 12:45       ` [Intel-gfx] " Jason Gunthorpe
2021-07-15 12:45       ` Jason Gunthorpe
2021-07-19 12:11   ` Cornelia Huck
2021-07-19 12:11     ` [Intel-gfx] " Cornelia Huck
2021-07-19 12:11     ` Cornelia Huck
2021-07-19 12:17     ` Jason Gunthorpe
2021-07-19 12:17       ` [Intel-gfx] " Jason Gunthorpe
2021-07-19 12:17       ` Jason Gunthorpe
2021-07-19 12:43       ` Cornelia Huck
2021-07-19 12:43         ` [Intel-gfx] " Cornelia Huck
2021-07-19 12:43         ` Cornelia Huck
2021-07-15  0:20 ` [PATCH 03/13] vfio: Provide better generic support for open/release vfio_device_ops Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-19 12:58   ` Cornelia Huck
2021-07-19 12:58     ` [Intel-gfx] " Cornelia Huck
2021-07-19 12:58     ` Cornelia Huck
2021-07-19 13:01     ` Jason Gunthorpe
2021-07-19 13:01       ` [Intel-gfx] " Jason Gunthorpe
2021-07-19 13:01       ` Jason Gunthorpe
2021-07-19 13:03       ` Jason Gunthorpe
2021-07-19 13:03         ` [Intel-gfx] " Jason Gunthorpe
2021-07-19 13:03         ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 04/13] vfio/samples: Delete useless open/close Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-19 13:01   ` Cornelia Huck
2021-07-19 13:01     ` [Intel-gfx] " Cornelia Huck
2021-07-19 13:01     ` Cornelia Huck
2021-07-15  0:20 ` [PATCH 05/13] vfio/fsl: Move to the device set infrastructure Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-20 16:12   ` Diana Craciun OSS
2021-07-20 16:12     ` [Intel-gfx] " Diana Craciun OSS
2021-07-20 16:12     ` Diana Craciun OSS
2021-07-20 16:17     ` Jason Gunthorpe
2021-07-20 16:17       ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 16:17       ` Jason Gunthorpe
2021-07-20 16:23       ` Diana Craciun OSS
2021-07-20 16:23         ` [Intel-gfx] " Diana Craciun OSS
2021-07-20 16:23         ` Diana Craciun OSS
2021-07-20 16:25         ` Jason Gunthorpe
2021-07-20 16:25           ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 16:25           ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 06/13] vfio/platform: Use open_device() instead of open coding a refcnt scheme Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 07/13] vfio/pci: Move to the device set infrastructure Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 08/13] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15  0:20 ` [PATCH 09/13] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15 21:00   ` Alex Williamson
2021-07-15 21:00     ` [Intel-gfx] " Alex Williamson
2021-07-15 21:00     ` Alex Williamson
2021-07-15 22:11     ` Jason Gunthorpe
2021-07-15 22:11       ` [Intel-gfx] " Jason Gunthorpe
2021-07-15 22:11       ` Jason Gunthorpe
2021-07-15 22:27       ` Alex Williamson
2021-07-15 22:27         ` [Intel-gfx] " Alex Williamson
2021-07-15 22:27         ` Alex Williamson
2021-07-15  0:20 ` [PATCH 10/13] vfio/mbochs: Fix close when multiple device FDs are open Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-19 14:45   ` Cornelia Huck
2021-07-19 14:45     ` [Intel-gfx] " Cornelia Huck
2021-07-19 14:45     ` Cornelia Huck
2021-07-15  0:20 ` [PATCH 11/13] vfio/ap,ccw: Fix open/close " Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] [PATCH 11/13] vfio/ap, ccw: " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-19 14:40   ` [PATCH 11/13] vfio/ap,ccw: " Cornelia Huck
2021-07-19 14:40     ` [Intel-gfx] [PATCH 11/13] vfio/ap, ccw: " Cornelia Huck
2021-07-19 14:40     ` [PATCH 11/13] vfio/ap,ccw: " Cornelia Huck
2021-07-15  0:20 ` [PATCH 12/13] vfio/gvt: " Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-16  6:50   ` Zhenyu Wang
2021-07-16  6:50     ` [Intel-gfx] " Zhenyu Wang
2021-07-16  6:50     ` Zhenyu Wang
2021-07-19 14:47   ` Cornelia Huck
2021-07-19 14:47     ` [Intel-gfx] " Cornelia Huck
2021-07-19 14:47     ` Cornelia Huck
2021-07-15  0:20 ` [PATCH 13/13] vfio: Remove struct vfio_device_ops open/release Jason Gunthorpe
2021-07-15  0:20   ` [Intel-gfx] " Jason Gunthorpe
2021-07-15  0:20   ` Jason Gunthorpe
2021-07-15 13:28 ` [PATCH 00/13] Provide core infrastructure for managing open/release Kirti Wankhede
2021-07-15 13:28   ` [Intel-gfx] " Kirti Wankhede
2021-07-15 13:28   ` Kirti Wankhede
2021-07-15 14:55   ` Jason Gunthorpe
2021-07-15 14:55     ` [Intel-gfx] " Jason Gunthorpe
2021-07-15 14:55     ` Jason Gunthorpe
2021-07-16 16:49 ` Patchwork [this message]
2021-07-16 17:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Provide core infrastructure for managing open/release (rev2) Patchwork
2021-07-16 22:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-20 17:19 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162645416614.12777.9888825247711123044@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jgg@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.